)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8240cedca652ba441dbb252f18345d18a15d4c06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"80b5afd7_14c18e4f","updated":"2022-05-17 16:03:43.000000000","message":"Early WIP","commit_id":"defe6d921cf9a7def23114a4e52f6975e74f2436"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1c35bdf885276721812e7012ac0bd9dcee6b69e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cbc6cefc_03607154","updated":"2022-05-23 13:33:27.000000000","message":"It is mostly ready for testing... @James, feel free to update","commit_id":"c1c17c9239b87044032f4b6c6d3f17ad6b1ac850"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"469a91b02c4470ff0ee8fee908ad49fc14e2cdeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"02002298_e6e9311b","updated":"2022-05-25 02:55:01.000000000","message":"I pushed an update that made the changes I suggested. I\u0027ve got the containers starting now, although they are all using the default configs for now.","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4e52a7ec_be5dacd9","updated":"2022-05-25 14:02:33.000000000","message":"thank you James, well done! a few questions please","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f5a84ffe2024d53e1dfecfdd08f5b7328a9a22d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"90d571f7_95760a72","updated":"2022-05-27 15:13:15.000000000","message":"by the way if we are doing thsi can we take this opertunity to remvoe nova from the role name\n\nit shoudl jsut be tripleo_libvirt not tripleo_nova_libvirt since libvirt is not part of nova.\n","commit_id":"4ece73197dc894783484d7b833cd8599f47ae030"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fdc46011e107a3c26614b6c15262567ec27a74b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"eb718ba2_927cbc21","in_reply_to":"90d571f7_95760a72","updated":"2022-05-31 11:41:48.000000000","message":"that\u0027s not easy to implement given that I use a custom script to maintain naming parity for t-h-t params vs ansible vars. If I rename, it starts complaining about missing or redundant vars. I\u0027d say le\u0027s keep the naming until we no longer need to do backports of ansible vars to tht params","commit_id":"4ece73197dc894783484d7b833cd8599f47ae030"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"6f5ada18a57cb70829887de8bd65f6d175418604","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"f79a0e08_f6b43375","updated":"2022-06-10 11:27:49.000000000","message":"@James, please do not rename variable, it\u0027s hard to keep them in sync with tht params otherwise (see the recent change where I\u0027ve added a 3 missed vars). Now I have to dedup those added recently and keep my naming scheme","commit_id":"01b55e8ceaa8b1eaaab637214c12581798e4a5ee"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"369e84d0805e15b040d95bcafab1a8716a41903a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"0cb41514_0cec4239","in_reply_to":"f79a0e08_f6b43375","updated":"2022-06-10 13:57:35.000000000","message":"which variables? only ones renamed in PS17 are not from tht.","commit_id":"01b55e8ceaa8b1eaaab637214c12581798e4a5ee"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"7dbaa18bef6886604d9158d21dc2be7009d61cef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"89bda0b8_76369c14","updated":"2022-07-29 21:17:15.000000000","message":"I see that tripleo_nova_compute [1] uses .yml and tripleo_nova_libvirt [2] uses .yaml\nI had to do a silly workaround [3] to get them working when I followed the etherpad [4]\nCan these be made consistent?\n\n[1] https://review.opendev.org/c/openstack/tripleo-ansible/+/843659\n[2] https://review.opendev.org/c/openstack/tripleo-ansible/+/842152\n\n[3] silly workaround\nfunction yml_yaml {\n    # symlink .yml files to .yaml files\n    echo \"yml_yaml: $1\"\n    pushd $1\n    for F1 in $(ls *.yml); do\n        F2\u003d$(echo $F1 | sed -e s/yml/yaml/g)\n        sudo ln -vsf $F1 $F2\n    done\n    popd\n}\nfunction yaml_yml {\n    # symlink .yaml files to .yml files\n    echo \"yaml_yml: $1\"\n    pushd $1\n    for F1 in $(ls *.yaml); do\n        F2\u003d$(echo $F1 | sed -e s/yaml/yml/g)\n        sudo ln -vsf $F1 $F2\n    done\n    popd\n}\nyml_yaml /home/stack/tripleo-ansible/tripleo_ansible/roles/tripleo_nova_compute/tasks\nyaml_yml /home/stack/tripleo-ansible/tripleo_ansible/roles/tripleo_nova_libvirt/tasks\n\n[4] https://etherpad.opendev.org/p/tripleo-standalone-roles\n","commit_id":"696b42b3790651c583b0212f3021b571c709ef1a"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"efebdf84f31fced0e8865bffb468639f8378748a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"772b2b21_9384b18e","updated":"2022-07-29 16:10:01.000000000","message":"I\u0027m wondering why is not executing the molecule job.","commit_id":"696b42b3790651c583b0212f3021b571c709ef1a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"698ce9f753f6d66e655755bb3d777b0fd6033d9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"d9e2b372_b735fced","in_reply_to":"2e52ab26_97dd56fe","updated":"2022-08-03 11:52:20.000000000","message":"done","commit_id":"696b42b3790651c583b0212f3021b571c709ef1a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"54b2685274d07c7c43af13d4139f29858d94dad3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"34925b63_15e06f35","in_reply_to":"3918b36a_c4d17428","updated":"2022-08-04 11:59:37.000000000","message":"added a molecule execution patch on top","commit_id":"696b42b3790651c583b0212f3021b571c709ef1a"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"ca9e004d87ea1f7de4ae4f69e4b316635573efc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"c08dd8e6_008670b4","in_reply_to":"772b2b21_9384b18e","updated":"2022-07-29 16:12:49.000000000","message":"https://github.com/openstack/tripleo-ansible/blob/master/zuul.d/molecule.yaml#L50\n\nNo tripleo_nova_libvirt job.....","commit_id":"696b42b3790651c583b0212f3021b571c709ef1a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a854117c43767237dc521c0c3be86a1fe9cf8af6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"2e52ab26_97dd56fe","in_reply_to":"89bda0b8_76369c14","updated":"2022-08-03 11:50:34.000000000","message":"good point, I\u0027ll fix that","commit_id":"696b42b3790651c583b0212f3021b571c709ef1a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a854117c43767237dc521c0c3be86a1fe9cf8af6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"3918b36a_c4d17428","in_reply_to":"c08dd8e6_008670b4","updated":"2022-08-03 11:50:34.000000000","message":"right, there is no molecule coverage yet. That is something to be done. Also it would become even more useful as we wire-in all the role vars into real config management (many of them do nothing at the moment, but only provide mappings to corresponding t-h-t params and hiera mappings to be processes/implemented or reworked later","commit_id":"696b42b3790651c583b0212f3021b571c709ef1a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"54b2685274d07c7c43af13d4139f29858d94dad3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"d195f567_64e73aea","updated":"2022-08-04 11:59:37.000000000","message":"failed to Set facts for Ceph multiconfig keyring paths\n\nhttps://b58b3ae0e86f6370c47c-4aa13c6b5893117c84c953dbfc32d7df.ssl.cf1.rackcdn.com/852026/4/check/tripleo-ansible-centos-stream-molecule-tripleo_nova_libvirt/5f47cdc/ansible-execution.log","commit_id":"7d32eda6915cc77eba06d8d52870e3fb077eb3b9"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"599932eabb034f8550eedd3070320edb97a189d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"9790d12a_42b3c2d5","updated":"2022-08-09 14:26:06.000000000","message":"Now I\u0027ll try to create some meaningful molecule tests","commit_id":"d78d62ccb74b9a7e05a9227d3e3944e5cb1d5123"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"04dc40ff3955af99007706c4205284d84b99011a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"fb98ddd0_80748881","updated":"2022-08-10 16:19:12.000000000","message":"WIP meaningful molecule scenarios","commit_id":"567229a2da5d59f0148ba41576843ab7a0fc7c5a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"75978e6f73b290ef6d9d4e7efdff25a10967b0d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"6f7cf0b4_14e5f5f9","updated":"2022-08-29 14:14:12.000000000","message":"let\u0027s merge this, then adjust as required?\nWith the testing framework improved, there was proposed extra molecule coverage on top.","commit_id":"dee14343772a33a4b3ea7deb1d2d1f7c6c3ad32b"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c71e7bd7448434b7885ae7d817a7e7b61ec9eadf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"1cabfe19_28fb8f33","updated":"2022-09-06 13:18:32.000000000","message":"am not sure why it fails, on my env deployed with zuul reproducer, the command\n\npytest ../../../tests/test_molecule.py --scenario configure\n\nfinishes w/o such errors reported...","commit_id":"fd56cf46c1490e2360549a38ef6c325dea34ebd7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"15782ab0b7969a68fd3fd9b7b7b5c648743587ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"1164b74b_b811a468","updated":"2022-09-06 12:53:30.000000000","message":"molecule configure scenario failed for real reason\n\n2022-09-02 14:09:42.399608 | centos-9-stream |   stderr: \u0027grep: /etc/libvirt/virtqemud.conf: No such file or directory\u0027","commit_id":"fd56cf46c1490e2360549a38ef6c325dea34ebd7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"337c6863bd4617104e385cdf5e26c1373212b09e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"0ef35d7f_400bfdfc","updated":"2022-09-06 12:48:21.000000000","message":"recheck content-provider","commit_id":"fd56cf46c1490e2360549a38ef6c325dea34ebd7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3a454ef3b5201c1f8bd00925bac191cd30d4417e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"497bc2a9_f075a3ae","updated":"2022-09-09 12:48:56.000000000","message":"there are problems in verify tasks, it should check containers\u0027 config, and hosts\u0027 ones, depending on a case.","commit_id":"fd56cf46c1490e2360549a38ef6c325dea34ebd7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4f16bf7a3e5fbf826cc601a890abb58f8ab88ac3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"8032a1e8_4ef08317","updated":"2022-09-12 12:24:59.000000000","message":"blocked by unrelated /etc/pki/rpm-gpg/RPM-GPG-KEY-redhat-beta: no such file or directory in tripleo common","commit_id":"2a6c83d807465da8173469f4cb01065b1913495a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d54e827e75d385be05891d2d99e0e5cbd54927e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"f9ea4c84_c2657f50","updated":"2022-09-13 15:39:28.000000000","message":"PTAL, another +2 is needed :)","commit_id":"af69195a8afbd852010b1ef6537656537d8126ea"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"685c6046ef9ad533c19ea4d5f10f93251f266103","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"8c300b9b_b1592ecf","updated":"2022-09-13 12:06:28.000000000","message":"can we merge this please","commit_id":"af69195a8afbd852010b1ef6537656537d8126ea"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"94db75b29da3b67b7617a36abd459cc1c61e3a90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"8446d478_b15da768","updated":"2022-09-13 15:51:13.000000000","message":"good to merge this.","commit_id":"af69195a8afbd852010b1ef6537656537d8126ea"}],"tripleo_ansible/roles/tripleo_nova_libvirt/defaults/main.yml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":true,"context_lines":[{"line_number":66,"context_line":"tripleo_nova_libvirt_rbd_disk_cachemodes: \"{{ tripleo_rbd_disk_cachemodes | default([\u0027network\u003dwriteback\u0027], true) }}\""},{"line_number":67,"context_line":"tripleo_nova_libvirt_network: internal_api"},{"line_number":68,"context_line":"tripleo_nova_libvirt_idm_realm: \"{{ tripleo_idm_realm | default(lookup(\u0027ini\u0027, \u0027realm default\u003dDEFAULT section\u003dglobal file\u003d/etc/ipa/default.conf\u0027)) }}\""},{"line_number":69,"context_line":"tripleo_nova_libvirt_need_libvirt_secret: false"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"tripleo_nova_libvirt_config_volume: /var/lib/config-data/ansible-generated/nova_libvirt"},{"line_number":72,"context_line":"tripleo_nova_libvirt_common_volumes:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"0a5bcc97_061cbc9e","line":69,"updated":"2022-05-25 14:02:33.000000000","message":"these are defined as facts in main.yml\n\nwouldn\u0027t that work like that?\n\nor we can move them all here...","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"895d0a5c662a79daab0c9fd32ea6bd0cff4bd12e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"tripleo_nova_libvirt_rbd_disk_cachemodes: \"{{ tripleo_rbd_disk_cachemodes | default([\u0027network\u003dwriteback\u0027], true) }}\""},{"line_number":67,"context_line":"tripleo_nova_libvirt_network: internal_api"},{"line_number":68,"context_line":"tripleo_nova_libvirt_idm_realm: \"{{ tripleo_idm_realm | default(lookup(\u0027ini\u0027, \u0027realm default\u003dDEFAULT section\u003dglobal file\u003d/etc/ipa/default.conf\u0027)) }}\""},{"line_number":69,"context_line":"tripleo_nova_libvirt_need_libvirt_secret: false"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"tripleo_nova_libvirt_config_volume: /var/lib/config-data/ansible-generated/nova_libvirt"},{"line_number":72,"context_line":"tripleo_nova_libvirt_common_volumes:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"b9c9eea6_f1e0691b","line":69,"in_reply_to":"0a5bcc97_061cbc9e","updated":"2022-05-25 15:26:12.000000000","message":"Ack","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"369e84d0805e15b040d95bcafab1a8716a41903a","unresolved":true,"context_lines":[{"line_number":130,"context_line":"  - \"{{ tripleo_nova_libvirt_config_volume ~"},{"line_number":131,"context_line":"        \u0027:/var/lib/kolla/config_files/src:ro\u0027 }}\""},{"line_number":132,"context_line":"  - \"{{ tripleo_nova_libvirt_ceph_config_path ~"},{"line_number":133,"context_line":"        \u0027:/var/lib/kolla/config_files/src-ceph:ro\u0027 }}\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"tripleo_nova_libvirt_internal_tls_volumes: \"{{"},{"line_number":136,"context_line":"  tripleo_nova_libvirt_enable_internal_tls |"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5444b093_241b3e34","line":133,"updated":"2022-06-10 13:57:35.000000000","message":"looks like this is already added with tripleo_nova_libvirt_ceph_volumes, so it can be dropped. I\u0027ll take care of it.","commit_id":"7a96ee6bc260eb6eb6e9eef302ffd7bdcafafa5c"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"cd06ad8ad1ab70233467114f7a26d74ba2b5f077","unresolved":false,"context_lines":[{"line_number":130,"context_line":"  - \"{{ tripleo_nova_libvirt_config_volume ~"},{"line_number":131,"context_line":"        \u0027:/var/lib/kolla/config_files/src:ro\u0027 }}\""},{"line_number":132,"context_line":"  - \"{{ tripleo_nova_libvirt_ceph_config_path ~"},{"line_number":133,"context_line":"        \u0027:/var/lib/kolla/config_files/src-ceph:ro\u0027 }}\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"tripleo_nova_libvirt_internal_tls_volumes: \"{{"},{"line_number":136,"context_line":"  tripleo_nova_libvirt_enable_internal_tls |"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"00ffa3b9_031ae42a","line":133,"in_reply_to":"5444b093_241b3e34","updated":"2022-06-10 13:57:53.000000000","message":"Done","commit_id":"7a96ee6bc260eb6eb6e9eef302ffd7bdcafafa5c"}],"tripleo_ansible/roles/tripleo_nova_libvirt/files/nova_virtlogd.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    dest: \"/etc/ceph/\""},{"line_number":9,"context_line":"    merge: true"},{"line_number":10,"context_line":"    preserve_properties: true"},{"line_number":11,"context_line":"permissions: []"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5cd9bc76_de4caa55","line":11,"updated":"2022-05-25 14:02:33.000000000","message":"are you sure we should use empty list?\nthis tripleo_nova_libvirt_ceph_multiconfig is quite important","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"895d0a5c662a79daab0c9fd32ea6bd0cff4bd12e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    dest: \"/etc/ceph/\""},{"line_number":9,"context_line":"    merge: true"},{"line_number":10,"context_line":"    preserve_properties: true"},{"line_number":11,"context_line":"permissions: []"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"639c63a9_c2e31514","line":11,"in_reply_to":"5cd9bc76_de4caa55","updated":"2022-05-25 15:26:12.000000000","message":"Ack","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"}],"tripleo_ansible/roles/tripleo_nova_libvirt/files/nova_virtnodedevd.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    dest: \"/etc/ceph/\""},{"line_number":9,"context_line":"    merge: true"},{"line_number":10,"context_line":"    preserve_properties: true"},{"line_number":11,"context_line":"permissions: []"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"32d8169b_3e008420","line":11,"updated":"2022-05-25 14:02:33.000000000","message":"ditto","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"895d0a5c662a79daab0c9fd32ea6bd0cff4bd12e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    dest: \"/etc/ceph/\""},{"line_number":9,"context_line":"    merge: true"},{"line_number":10,"context_line":"    preserve_properties: true"},{"line_number":11,"context_line":"permissions: []"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9d13e2e4_c7e294ec","line":11,"in_reply_to":"32d8169b_3e008420","updated":"2022-05-25 15:26:12.000000000","message":"Ack","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"}],"tripleo_ansible/roles/tripleo_nova_libvirt/files/nova_virtproxyd.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    dest: \"/etc/ceph/\""},{"line_number":9,"context_line":"    merge: true"},{"line_number":10,"context_line":"    preserve_properties: true"},{"line_number":11,"context_line":"permissions: []"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"e30bafc4_0bb7d741","line":11,"updated":"2022-05-25 14:02:33.000000000","message":"ditto","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"895d0a5c662a79daab0c9fd32ea6bd0cff4bd12e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    dest: \"/etc/ceph/\""},{"line_number":9,"context_line":"    merge: true"},{"line_number":10,"context_line":"    preserve_properties: true"},{"line_number":11,"context_line":"permissions: []"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1088fa00_da7a0014","line":11,"in_reply_to":"e30bafc4_0bb7d741","updated":"2022-05-25 15:26:12.000000000","message":"Ack","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"}],"tripleo_ansible/roles/tripleo_nova_libvirt/files/nova_virtqemud.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    dest: \"/etc/ceph/\""},{"line_number":9,"context_line":"    merge: true"},{"line_number":10,"context_line":"    preserve_properties: true"},{"line_number":11,"context_line":"permissions: []"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ef62db84_d39305c4","line":11,"updated":"2022-05-25 14:02:33.000000000","message":"ditto","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"895d0a5c662a79daab0c9fd32ea6bd0cff4bd12e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    dest: \"/etc/ceph/\""},{"line_number":9,"context_line":"    merge: true"},{"line_number":10,"context_line":"    preserve_properties: true"},{"line_number":11,"context_line":"permissions: []"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"83c62e85_b6f67666","line":11,"in_reply_to":"ef62db84_d39305c4","updated":"2022-05-25 15:26:12.000000000","message":"Ack","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"}],"tripleo_ansible/roles/tripleo_nova_libvirt/files/nova_virtsecretd.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    dest: \"/etc/ceph/\""},{"line_number":9,"context_line":"    merge: true"},{"line_number":10,"context_line":"    preserve_properties: true"},{"line_number":11,"context_line":"permissions: []"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"58618444_c35380ab","line":11,"updated":"2022-05-25 14:02:33.000000000","message":"ditto","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"895d0a5c662a79daab0c9fd32ea6bd0cff4bd12e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    dest: \"/etc/ceph/\""},{"line_number":9,"context_line":"    merge: true"},{"line_number":10,"context_line":"    preserve_properties: true"},{"line_number":11,"context_line":"permissions: []"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"2b71679c_b391cfed","line":11,"in_reply_to":"58618444_c35380ab","updated":"2022-05-25 15:26:12.000000000","message":"Ack","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"}],"tripleo_ansible/roles/tripleo_nova_libvirt/files/nova_virtstoraged.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    dest: \"/etc/ceph/\""},{"line_number":9,"context_line":"    merge: true"},{"line_number":10,"context_line":"    preserve_properties: true"},{"line_number":11,"context_line":"permissions: []"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"e0993f11_e83c63fe","line":11,"updated":"2022-05-25 14:02:33.000000000","message":"ditto","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"895d0a5c662a79daab0c9fd32ea6bd0cff4bd12e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    dest: \"/etc/ceph/\""},{"line_number":9,"context_line":"    merge: true"},{"line_number":10,"context_line":"    preserve_properties: true"},{"line_number":11,"context_line":"permissions: []"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"08a559a5_ae770854","line":11,"in_reply_to":"e0993f11_e83c63fe","updated":"2022-05-25 15:26:12.000000000","message":"Ack","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"}],"tripleo_ansible/roles/tripleo_nova_libvirt/meta/main.yml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"ce66f7c5a84e017054f993c4db9da252de8fb2f1","unresolved":true,"context_lines":[{"line_number":41,"context_line":"# List your role dependencies here, one per line. Be sure to remove the \u0027[]\u0027 above,"},{"line_number":42,"context_line":"# if you add dependencies to this list."},{"line_number":43,"context_line":"dependencies:"},{"line_number":44,"context_line":"  - standalone_roles_common"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"d6a6cc27_e5a33546","line":44,"updated":"2022-05-25 02:54:15.000000000","message":"i think we can drop this until we have an actual need for a common role dependency.","commit_id":"1e176ce96a112c63455cbd440c5d65708160dd9e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# List your role dependencies here, one per line. Be sure to remove the \u0027[]\u0027 above,"},{"line_number":42,"context_line":"# if you add dependencies to this list."},{"line_number":43,"context_line":"dependencies:"},{"line_number":44,"context_line":"  - standalone_roles_common"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e53b8088_0ce7dae8","line":44,"in_reply_to":"d6a6cc27_e5a33546","updated":"2022-05-25 14:02:33.000000000","message":"Ack","commit_id":"1e176ce96a112c63455cbd440c5d65708160dd9e"}],"tripleo_ansible/roles/tripleo_nova_libvirt/tasks/configure.yml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"783d89de26f84c8194c4481fce1da7ef8ce22c66","unresolved":true,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    - name: Configure nova_libvirt log_filters config values"},{"line_number":160,"context_line":"      ini_file:"},{"line_number":161,"context_line":"        path: \"{{ tripleo_nova_libvirt_config_dir }}/etc/libvirt/{{ item.1 ~ \u0027.conf\u0027 }}\""},{"line_number":162,"context_line":"        section: null"},{"line_number":163,"context_line":"        option: log_filters"},{"line_number":164,"context_line":"        value: \"{{ lookup(\u0027vars\u0027, \u0027tripleo_nova_libvirt_\u0027 ~ item ~ \u0027_log_filters\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"ced18e1a_664e462b","line":161,"updated":"2022-08-19 15:35:55.000000000","message":"this should just use item and not item.1 since the loop is the list of service names.","commit_id":"01d46c9579d1d1d820a77dc432b94c32a81bfe82"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7f9aa625d4cdbae06941558603ca5f0f50ad98bd","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    - name: Configure nova_libvirt log_filters config values"},{"line_number":160,"context_line":"      ini_file:"},{"line_number":161,"context_line":"        path: \"{{ tripleo_nova_libvirt_config_dir }}/etc/libvirt/{{ item.1 ~ \u0027.conf\u0027 }}\""},{"line_number":162,"context_line":"        section: null"},{"line_number":163,"context_line":"        option: log_filters"},{"line_number":164,"context_line":"        value: \"{{ lookup(\u0027vars\u0027, \u0027tripleo_nova_libvirt_\u0027 ~ item ~ \u0027_log_filters\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"e68d7171_18a403c9","line":161,"in_reply_to":"ced18e1a_664e462b","updated":"2022-08-19 16:01:23.000000000","message":"thanks! done in https://review.opendev.org/c/openstack/tripleo-ansible/+/853810","commit_id":"01d46c9579d1d1d820a77dc432b94c32a81bfe82"}],"tripleo_ansible/roles/tripleo_nova_libvirt/tasks/install.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    seuser: system_u"},{"line_number":58,"context_line":"- name: ensure ceph configurations exist"},{"line_number":59,"context_line":"  file:"},{"line_number":60,"context_line":"    path: \"{{ tripleo_nova_libvirt_ceph_config_path }}\""},{"line_number":61,"context_line":"    state: directory"},{"line_number":62,"context_line":"- name: check if libvirt is installed"},{"line_number":63,"context_line":"  command: /usr/bin/rpm -q libvirt-daemon"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7606057f_e3ffc179","line":60,"updated":"2022-05-25 14:02:33.000000000","message":"nice catch!","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"}],"tripleo_ansible/roles/tripleo_nova_libvirt/tasks/install.yml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a5285ecdb6271d5bee2a4254e6aa0d25d6f20601","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    recurse: \"{{ item.recurse | default(omit) }}\""},{"line_number":24,"context_line":"    mode: \"{{ item.mode | default(omit) }}\""},{"line_number":25,"context_line":"  with_items:"},{"line_number":26,"context_line":"    - { \u0027path\u0027: /etc/puppet, \u0027setype\u0027: container_file_t }"},{"line_number":27,"context_line":"    - { \u0027path\u0027: /etc/libvirt, \u0027setype\u0027: container_file_t }"},{"line_number":28,"context_line":"    - { \u0027path\u0027: /etc/libvirt/secrets, \u0027setype\u0027: container_file_t }"},{"line_number":29,"context_line":"    - { \u0027path\u0027: /etc/libvirt/qemu, \u0027setype\u0027: container_file_t }"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"65911dcc_f647864a","line":26,"updated":"2022-08-16 14:49:00.000000000","message":"note that that legacy path is required as long as we have that host-path added by containers manager for /var/lib/tripleo-config/container-startup-config/nova_libvirt/*.json","commit_id":"f0ff4c5bcb1a7561d24a1e715702644233b6f5a4"}],"tripleo_ansible/roles/tripleo_nova_libvirt/tasks/main.yml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":true,"context_lines":[{"line_number":82,"context_line":"      nova_virtlogd{% if tripleo_nova_libvirt_enable_virtlogd_container_wrapper %}_wrapper{% endif %}"},{"line_number":83,"context_line":"  set_fact:"},{"line_number":84,"context_line":"    tripleo_nova_libvirt_containers:"},{"line_number":85,"context_line":"      - create_virtlogd_wrapper"},{"line_number":86,"context_line":"      - \"{{ tripleo_nova_libvirt_virtlogd_wrapper_name }}\""},{"line_number":87,"context_line":"      - nova_virtsecretd"},{"line_number":88,"context_line":"      - nova_virtnodedevd"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5938412e_b4c84c6f","line":85,"updated":"2022-05-25 14:02:33.000000000","message":"did you miss this one James?","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"895d0a5c662a79daab0c9fd32ea6bd0cff4bd12e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"      nova_virtlogd{% if tripleo_nova_libvirt_enable_virtlogd_container_wrapper %}_wrapper{% endif %}"},{"line_number":83,"context_line":"  set_fact:"},{"line_number":84,"context_line":"    tripleo_nova_libvirt_containers:"},{"line_number":85,"context_line":"      - create_virtlogd_wrapper"},{"line_number":86,"context_line":"      - \"{{ tripleo_nova_libvirt_virtlogd_wrapper_name }}\""},{"line_number":87,"context_line":"      - nova_virtsecretd"},{"line_number":88,"context_line":"      - nova_virtnodedevd"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"699e5a85_526f72a2","line":85,"in_reply_to":"5938412e_b4c84c6f","updated":"2022-05-25 15:26:12.000000000","message":"Ack","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d6ebc9df3ea3b7779412cbcc68f68d451b1f9da4","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    tripleo_nova_libvirt_ceph_multiconfig_keyrings: \u003e"},{"line_number":78,"context_line":"      {% set ceph_info \u003d [tripleo_nova_libvirt_ceph_cluster_name ~ \u0027.client.\u0027 ~ tripleo_nova_libvirt_ceph_client_user_name ~ \u0027.keyring\u0027] %}"},{"line_number":79,"context_line":"      {% for c in tripleo_nova_libvirt_cinder_rbd_multi_config | dict2items %}"},{"line_number":80,"context_line":"      {% set ceph_info +\u003d [c.value[\u0027CephClusterName\u0027] | default(tripleo_nova_libvirt_ceph_cluster_name ~ \u0027.client.\u0027 ~ c.value[\u0027CephClientUserName\u0027] | default(tripleo_nova_libvirt_ceph_client_user_name) ~ \u0027.keyring\u0027] %}"},{"line_number":81,"context_line":"      {% endfor %}"},{"line_number":82,"context_line":"      {{ ceph_info }}"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"dad9cab8_ae22fe17","line":80,"range":{"start_line":80,"start_character":23,"end_line":80,"end_character":25},"updated":"2022-08-04 15:42:36.000000000","message":"it seems the issue is here:\nhttps://b58b3ae0e86f6370c47c-4aa13c6b5893117c84c953dbfc32d7df.ssl.cf1.rackcdn.com/852026/4/check/tripleo-ansible-centos-stream-molecule-tripleo_nova_libvirt/5f47cdc/job-output.txt\n\n```\nmsg: |-\n2022-08-03 14:48:40.050468 | centos-9-stream |     template error while templating string: expected token \u0027end of statement block\u0027, got \u0027+\u0027. String: {% set ceph_info \u003d [tripleo_nova_libvirt_ceph_cluster_name ~ \u0027.client.\u0027 ~ tripleo_nova_libvirt_ceph_client_user_name ~ \u0027.keyring\u0027] %} {% for c in tripleo_nova_libvirt_cinder_rbd_multi_config | dict2items %} {% set ceph_info +\u003d [c.value[\u0027CephClusterName\u0027] | default(tripleo_nova_libvirt_ceph_cluster_name ~ \u0027.client.\u0027 ~ c.value[\u0027CephClientUserName\u0027] | default(tripleo_nova_libvirt_ceph_client_user_name) ~ \u0027.keyring\u0027] %} {% endfor %} {{ ceph_info }}\n```\n\nIf we paste this template here also https://cryptic-cliffs-32040.herokuapp.com, I can see the same error.\n\nRegarding IRC question, all the molecule commands are here:\nhttps://opendev.org/openstack/tripleo-ansible/src/branch/master/tests/test_molecule.py#L35\n\nIt might help to test the stuff locally.","commit_id":"7d32eda6915cc77eba06d8d52870e3fb077eb3b9"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"86227b7dfec93e674d4d55324c857653f4de11b3","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    tripleo_nova_libvirt_ceph_multiconfig_keyrings: \u003e"},{"line_number":78,"context_line":"      {% set ceph_info \u003d [tripleo_nova_libvirt_ceph_cluster_name ~ \u0027.client.\u0027 ~ tripleo_nova_libvirt_ceph_client_user_name ~ \u0027.keyring\u0027] %}"},{"line_number":79,"context_line":"      {% for c in tripleo_nova_libvirt_cinder_rbd_multi_config | dict2items %}"},{"line_number":80,"context_line":"      {% set ceph_info +\u003d [c.value[\u0027CephClusterName\u0027] | default(tripleo_nova_libvirt_ceph_cluster_name ~ \u0027.client.\u0027 ~ c.value[\u0027CephClientUserName\u0027] | default(tripleo_nova_libvirt_ceph_client_user_name) ~ \u0027.keyring\u0027] %}"},{"line_number":81,"context_line":"      {% endfor %}"},{"line_number":82,"context_line":"      {{ ceph_info }}"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"ed97a7a2_a9652f65","line":80,"range":{"start_line":80,"start_character":23,"end_line":80,"end_character":25},"in_reply_to":"dad9cab8_ae22fe17","updated":"2022-08-08 16:05:41.000000000","message":"yes, thank you. I have this job deployed in my zuul reproducer","commit_id":"7d32eda6915cc77eba06d8d52870e3fb077eb3b9"}],"tripleo_ansible/roles/tripleo_nova_libvirt/tasks/nova_libvirt_configure.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"ce66f7c5a84e017054f993c4db9da252de8fb2f1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a6eba443_8752c9a7","updated":"2022-05-25 02:54:15.000000000","message":"can we name this just configure.yaml?\nI\u0027d like to not prefix the configure/install/update/upgrade tasks files with the role name. I think that makes for a cleaner interface and is more inline with ansible patterns (main.yaml, etc).\n\nI know I didn\u0027t do this in some of my roles, but I plan to go back and fix.","commit_id":"1e176ce96a112c63455cbd440c5d65708160dd9e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"caacbda4_18691602","in_reply_to":"a6eba443_8752c9a7","updated":"2022-05-25 14:02:33.000000000","message":"Ack","commit_id":"1e176ce96a112c63455cbd440c5d65708160dd9e"}],"tripleo_ansible/roles/tripleo_nova_libvirt/tasks/nova_libvirt_install.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"ce66f7c5a84e017054f993c4db9da252de8fb2f1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cbcb6774_dd7d3f2b","updated":"2022-05-25 02:54:15.000000000","message":"can we name it install.yaml?","commit_id":"1e176ce96a112c63455cbd440c5d65708160dd9e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0a3bd6b6_91aef09b","in_reply_to":"cbcb6774_dd7d3f2b","updated":"2022-05-25 14:02:33.000000000","message":"Ack","commit_id":"1e176ce96a112c63455cbd440c5d65708160dd9e"}],"tripleo_ansible/roles/tripleo_nova_libvirt/tasks/nova_libvirt_update.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"ce66f7c5a84e017054f993c4db9da252de8fb2f1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"073d318d_1f342a9e","updated":"2022-05-25 02:54:15.000000000","message":"update.yaml?","commit_id":"1e176ce96a112c63455cbd440c5d65708160dd9e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"354a9070_d36c046e","in_reply_to":"073d318d_1f342a9e","updated":"2022-05-25 14:02:33.000000000","message":"Ack","commit_id":"1e176ce96a112c63455cbd440c5d65708160dd9e"}],"tripleo_ansible/roles/tripleo_nova_libvirt/tasks/nova_libvirt_upgrade.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"ce66f7c5a84e017054f993c4db9da252de8fb2f1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"75c7a94f_db212405","updated":"2022-05-25 02:54:15.000000000","message":"upgrade.yaml?","commit_id":"1e176ce96a112c63455cbd440c5d65708160dd9e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"60f7608a_14f219d5","in_reply_to":"75c7a94f_db212405","updated":"2022-05-25 14:02:33.000000000","message":"Ack","commit_id":"1e176ce96a112c63455cbd440c5d65708160dd9e"}],"tripleo_ansible/roles/tripleo_nova_libvirt/tasks/run.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    name: tripleo_container_standalone"},{"line_number":31,"context_line":"  vars:"},{"line_number":32,"context_line":"    tripleo_container_standalone_service: nova_libvirt"},{"line_number":33,"context_line":"    tripleo_container_standalone_container_defs:"},{"line_number":34,"context_line":"      nova_virtlogd: \"{{ lookup(\u0027template\u0027, \u0027nova_virtlogd.yaml.j2\u0027) | from_yaml }}\""},{"line_number":35,"context_line":"      nova_virtnodedevd: \"{{ lookup(\u0027template\u0027, \u0027nova_virtnodedevd.yaml.j2\u0027) | from_yaml }}\""},{"line_number":36,"context_line":"      nova_virtproxyd: \"{{ lookup(\u0027template\u0027, \u0027nova_virtproxyd.yaml.j2\u0027) | from_yaml }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"8a59486c_7adad6f5","line":33,"updated":"2022-05-25 14:02:33.000000000","message":"did you miss create_virtlogd_wrapper?","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"895d0a5c662a79daab0c9fd32ea6bd0cff4bd12e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    name: tripleo_container_standalone"},{"line_number":31,"context_line":"  vars:"},{"line_number":32,"context_line":"    tripleo_container_standalone_service: nova_libvirt"},{"line_number":33,"context_line":"    tripleo_container_standalone_container_defs:"},{"line_number":34,"context_line":"      nova_virtlogd: \"{{ lookup(\u0027template\u0027, \u0027nova_virtlogd.yaml.j2\u0027) | from_yaml }}\""},{"line_number":35,"context_line":"      nova_virtnodedevd: \"{{ lookup(\u0027template\u0027, \u0027nova_virtnodedevd.yaml.j2\u0027) | from_yaml }}\""},{"line_number":36,"context_line":"      nova_virtproxyd: \"{{ lookup(\u0027template\u0027, \u0027nova_virtproxyd.yaml.j2\u0027) | from_yaml }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3b6eb172_a6fd4dff","line":33,"in_reply_to":"8a59486c_7adad6f5","updated":"2022-05-25 15:26:12.000000000","message":"Ack","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  vars:"},{"line_number":32,"context_line":"    tripleo_container_standalone_service: nova_libvirt"},{"line_number":33,"context_line":"    tripleo_container_standalone_container_defs:"},{"line_number":34,"context_line":"      nova_virtlogd: \"{{ lookup(\u0027template\u0027, \u0027nova_virtlogd.yaml.j2\u0027) | from_yaml }}\""},{"line_number":35,"context_line":"      nova_virtnodedevd: \"{{ lookup(\u0027template\u0027, \u0027nova_virtnodedevd.yaml.j2\u0027) | from_yaml }}\""},{"line_number":36,"context_line":"      nova_virtproxyd: \"{{ lookup(\u0027template\u0027, \u0027nova_virtproxyd.yaml.j2\u0027) | from_yaml }}\""},{"line_number":37,"context_line":"      nova_virtqemud: \"{{ lookup(\u0027template\u0027, \u0027nova_virtqemud.yaml.j2\u0027) | from_yaml }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"49cdfeaa_dee04ac9","line":34,"updated":"2022-05-25 14:02:33.000000000","message":"there is also _wrapper handling conditions, but we can run it w/o wrapper in this poc","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"}],"tripleo_ansible/roles/tripleo_nova_libvirt/templates/nova_virtlogd.yaml.j2":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  - label\u003ddisable"},{"line_number":10,"context_line":"cap_add: SYS_ADMIN"},{"line_number":11,"context_line":"restart: always"},{"line_number":12,"context_line":"depends_on: {% if tripleo_nova_libvirt_enable_virtlogd_container_wrapper%}tripleo_nova_virtlogd_wrapper.service{% else %}tripleo_nova_virtlogd.service{% endif %}"},{"line_number":13,"context_line":"volumes:"},{"line_number":14,"context_line":"  {% set nova_libvirt_volumes \u003d [] %}"},{"line_number":15,"context_line":"  {%- set nova_libvirt_volumes +\u003d"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"fd0e9e80_c99d5b0c","line":12,"updated":"2022-05-25 14:02:33.000000000","message":"well spotted","commit_id":"1e176ce96a112c63455cbd440c5d65708160dd9e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":true,"context_lines":[{"line_number":19,"context_line":"        tripleo_nova_libvirt_opt_volumes +"},{"line_number":20,"context_line":"        tripleo_nova_libvirt_internal_tls_volumes +"},{"line_number":21,"context_line":"        tripleo_nova_libvirt_ceph_volumes +"},{"line_number":22,"context_line":"        [\u0027/etc/libvirt/qemu:/etc/libvirt/qemu:ro\u0027,"},{"line_number":23,"context_line":"        \u0027/var/lib/kolla/config_files/nova_virtlogd.json:/var/lib/kolla/config_files/config.json:ro\u0027,"},{"line_number":24,"context_line":"        \u0027/var/lib/container-config-scripts/virtlogd_wrapper:/usr/local/bin/virtlogd_wrapper:ro\u0027] -%}"},{"line_number":25,"context_line":"  {{ tripleo_nova_libvirt_common_volumes + nova_libvirt_volumes }}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"fb29ad94_f8a88a5c","line":22,"updated":"2022-05-25 14:02:33.000000000","message":"why did you drop it?","commit_id":"1e176ce96a112c63455cbd440c5d65708160dd9e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"895d0a5c662a79daab0c9fd32ea6bd0cff4bd12e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        tripleo_nova_libvirt_opt_volumes +"},{"line_number":20,"context_line":"        tripleo_nova_libvirt_internal_tls_volumes +"},{"line_number":21,"context_line":"        tripleo_nova_libvirt_ceph_volumes +"},{"line_number":22,"context_line":"        [\u0027/etc/libvirt/qemu:/etc/libvirt/qemu:ro\u0027,"},{"line_number":23,"context_line":"        \u0027/var/lib/kolla/config_files/nova_virtlogd.json:/var/lib/kolla/config_files/config.json:ro\u0027,"},{"line_number":24,"context_line":"        \u0027/var/lib/container-config-scripts/virtlogd_wrapper:/usr/local/bin/virtlogd_wrapper:ro\u0027] -%}"},{"line_number":25,"context_line":"  {{ tripleo_nova_libvirt_common_volumes + nova_libvirt_volumes }}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"626a2af0_d1f0d882","line":22,"in_reply_to":"fb29ad94_f8a88a5c","updated":"2022-05-25 15:26:12.000000000","message":"nvm, there is a top level /etc/libvirt share that covers this one","commit_id":"1e176ce96a112c63455cbd440c5d65708160dd9e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":true,"context_lines":[{"line_number":21,"context_line":"        tripleo_nova_libvirt_ceph_volumes +"},{"line_number":22,"context_line":"        [\u0027/etc/libvirt/qemu:/etc/libvirt/qemu:ro\u0027,"},{"line_number":23,"context_line":"        \u0027/var/lib/kolla/config_files/nova_virtlogd.json:/var/lib/kolla/config_files/config.json:ro\u0027,"},{"line_number":24,"context_line":"        \u0027/var/lib/container-config-scripts/virtlogd_wrapper:/usr/local/bin/virtlogd_wrapper:ro\u0027] -%}"},{"line_number":25,"context_line":"  {{ tripleo_nova_libvirt_common_volumes + nova_libvirt_volumes }}"},{"line_number":26,"context_line":"environment:"},{"line_number":27,"context_line":"  KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"01b5b1ab_fac4fc9b","line":24,"updated":"2022-05-25 14:02:33.000000000","message":"why did you drop it?","commit_id":"1e176ce96a112c63455cbd440c5d65708160dd9e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"895d0a5c662a79daab0c9fd32ea6bd0cff4bd12e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        tripleo_nova_libvirt_ceph_volumes +"},{"line_number":22,"context_line":"        [\u0027/etc/libvirt/qemu:/etc/libvirt/qemu:ro\u0027,"},{"line_number":23,"context_line":"        \u0027/var/lib/kolla/config_files/nova_virtlogd.json:/var/lib/kolla/config_files/config.json:ro\u0027,"},{"line_number":24,"context_line":"        \u0027/var/lib/container-config-scripts/virtlogd_wrapper:/usr/local/bin/virtlogd_wrapper:ro\u0027] -%}"},{"line_number":25,"context_line":"  {{ tripleo_nova_libvirt_common_volumes + nova_libvirt_volumes }}"},{"line_number":26,"context_line":"environment:"},{"line_number":27,"context_line":"  KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"a5827cb2_1e40e452","line":24,"in_reply_to":"01b5b1ab_fac4fc9b","updated":"2022-05-25 15:26:12.000000000","message":"may be it\u0027s fine for this PoC, and the added TODO will cover that","commit_id":"1e176ce96a112c63455cbd440c5d65708160dd9e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f591a8f8538ddfc1a6b74f4de37e7406a5c97789","unresolved":false,"context_lines":[{"line_number":10,"context_line":"cap_add: SYS_ADMIN"},{"line_number":11,"context_line":"restart: always"},{"line_number":12,"context_line":"volumes:"},{"line_number":13,"context_line":"  {{ tripleo_container_standalone_volumes | default([]) + tripleo_nova_libvirt_volumes +"},{"line_number":14,"context_line":"     [\u0027/var/lib/kolla/config_files/nova_virtlogd.json:/var/lib/kolla/config_files/config.json:ro\u0027] }}"},{"line_number":15,"context_line":"environment:"},{"line_number":16,"context_line":"  KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"0ba018be_5983c1b9","line":13,"updated":"2022-05-25 14:02:33.000000000","message":"please note that it should not use extra volumes, see https://review.opendev.org/c/openstack/tripleo-heat-templates/+/839762\n\nbut we can keep it like that for now","commit_id":"9cd0e1ca4919c055677d8a387918249506a2a8f8"}]}