)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"df3b5bb096a9fc57d08de02303ef61fe6f406d9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"c0dd54b1_298ef0a4","updated":"2022-07-19 08:57:40.000000000","message":"See Alan Bishops\u0027s comments.","commit_id":"79f0188b5932c0abde6df97c00f0f866c7f604d7"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"17b304ac6f9fa3d7860d17377980a23cdd94bed0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"d8ab76ad_e6f59386","updated":"2022-10-12 20:53:58.000000000","message":"recheck","commit_id":"9578ee292bb38e06be407725feccec6d8f5740f5"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"6ba00e01fd25eb127cf121fe942b6617bd6a8bd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"1ac26cd4_7c710b5b","updated":"2022-10-21 07:28:01.000000000","message":"Allowing other cores to vote/have a say.","commit_id":"ab8604d06ab7fbb36b9be603cd7d3ef8c13b4300"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f8c6b0881f801695de7776d1bbdba23e00aed910","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"28f836c6_df63c036","updated":"2022-10-24 13:37:39.000000000","message":"Looks like there have been plenty of eyes on this, so let\u0027s move forward.","commit_id":"ab8604d06ab7fbb36b9be603cd7d3ef8c13b4300"}],"tripleo_ansible/roles/tripleo_iscsid/defaults/main.yml":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"b674e65d15e6935100268c09e210503e6e74c7cc","unresolved":true,"context_lines":[{"line_number":29,"context_line":"  - /dev:/dev"},{"line_number":30,"context_line":"  - /run:/run"},{"line_number":31,"context_line":"  - /sys:/sys"},{"line_number":32,"context_line":"  - /lib/modules:/lib/modules:ro"},{"line_number":33,"context_line":"  - \"{{ tripleo_iscsid_config_dir }}:/var/lib/kolla/config_files/src-iscsid:ro\""},{"line_number":34,"context_line":"  - /etc/target:/etc/target:z"},{"line_number":35,"context_line":"  - /var/lib/iscsi:/var/lib/iscsi:z"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"94acf8d0_a14fd572","line":32,"updated":"2022-09-13 12:39:17.000000000","message":"While testing this series with standalone\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_a56/843836/27/check/tripleo-ci-centos-9-singlenode-external-compute-standalone/a5690dd/logs/undercloud/home/zuul/standalone_deploy.log\n\n```\nWARNING | ERROR: Can\u0027t run container iscsid\nstderr: time\u003d\"2022-09-13T12:01:06Z\" level\u003dinfo msg\u003d\"podman filtering at log level info\"\ntime\u003d\"2022-09-13T12:01:06Z\" level\u003dinfo msg\u003d\"Not using native diff for overlay, this may cause degraded performance for building images: kernel has CONFIG_OVERLAY_FS_REDIRECT_DIR enabled\"\ntime\u003d\"2022-09-13T12:01:06Z\" level\u003dinfo msg\u003d\"Setting parallel job count to 25\"\ntime\u003d\"2022-09-13T12:01:06Z\" level\u003dinfo msg\u003d\"Sysctl net.ipv4.ping_group_range\u003d0 0 ignored in containers.conf, since Network Namespace set to host\"\nError: statfs /var/lib/config-data/ansible-generated/iscsid: no such file or directory\n2022-09-13 12:01:06.516391 | fa163ea7-89fa-0ed0-2496-000000002c4c |      FATAL | Create containers managed by Podman for /var/lib/tripleo-config/container-startup-config/iscsid | standalone | error\u003d{\"changed\": false, \"msg\": \"Failed containers: iscsid\"}\n```","commit_id":"2ec00052879665a90b9c677eace04c21a8f36b1d"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"341224a1856f0df47b4cd6112dccd75904dcc28b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  - /dev:/dev"},{"line_number":30,"context_line":"  - /run:/run"},{"line_number":31,"context_line":"  - /sys:/sys"},{"line_number":32,"context_line":"  - /lib/modules:/lib/modules:ro"},{"line_number":33,"context_line":"  - \"{{ tripleo_iscsid_config_dir }}:/var/lib/kolla/config_files/src-iscsid:ro\""},{"line_number":34,"context_line":"  - /etc/target:/etc/target:z"},{"line_number":35,"context_line":"  - /var/lib/iscsi:/var/lib/iscsi:z"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"41cfeb87_53f8abc3","line":32,"in_reply_to":"94acf8d0_a14fd572","updated":"2022-09-30 20:38:15.000000000","message":"should be fixed now if using the playbooks. if using t-h-t, this should take care of it:\nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/859999","commit_id":"2ec00052879665a90b9c677eace04c21a8f36b1d"}],"tripleo_ansible/roles/tripleo_iscsid/tasks/configure.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"06d3e63bb649ca74d21140db8549597e5d506e68","unresolved":true,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Ensure /var/lib/config-data/ansible-generated/iscsid/etc/iscsi exists"},{"line_number":18,"context_line":"  file:"},{"line_number":19,"context_line":"    path: /var/lib/config-data/ansible-generated/iscsid/etc/iscsi"},{"line_number":20,"context_line":"    state: directory"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"aa7b6520_fca2cd84","line":17,"range":{"start_line":17,"start_character":15,"end_line":17,"end_character":60},"updated":"2022-06-27 19:45:05.000000000","message":"This (and L19) should reference the tripleo_iscsid_config_dir variable.","commit_id":"f4e591a669ee9db95854116e3e81f6b144339022"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e48e1d7bb50c9571cb3c0b5bce5bb14aac37e6a4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Ensure /var/lib/config-data/ansible-generated/iscsid/etc/iscsi exists"},{"line_number":18,"context_line":"  file:"},{"line_number":19,"context_line":"    path: /var/lib/config-data/ansible-generated/iscsid/etc/iscsi"},{"line_number":20,"context_line":"    state: directory"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"6d4d25d6_acb23653","line":17,"range":{"start_line":17,"start_character":15,"end_line":17,"end_character":60},"in_reply_to":"aa7b6520_fca2cd84","updated":"2022-10-20 12:29:42.000000000","message":"Done","commit_id":"f4e591a669ee9db95854116e3e81f6b144339022"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"06d3e63bb649ca74d21140db8549597e5d506e68","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7177dbd4_8afc4cb1","line":22,"updated":"2022-06-27 19:45:05.000000000","message":"The THT for iscsid, and the initial tripleo_iscsid role both assume puppet will do the configuration. Is the intention to have this file do what puppet has been doing? Maybe this is just a stub (it creates a directory but doesn\u0027t configure things yet)?","commit_id":"f4e591a669ee9db95854116e3e81f6b144339022"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"b1c3db9aa161a2f920f135467b2fa964148247bc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a3f0e7b8_7794feb7","line":22,"in_reply_to":"17fe2f6a_3398f93a","updated":"2022-10-20 20:06:58.000000000","message":"yes, alan and I had discussed this on IRC, but it wasn\u0027t captured here.\n\nEventually, yes, this role will do a configuration as well. There is a patch from Brendan to start on this:\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/860611","commit_id":"f4e591a669ee9db95854116e3e81f6b144339022"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e48e1d7bb50c9571cb3c0b5bce5bb14aac37e6a4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"17fe2f6a_3398f93a","line":22,"in_reply_to":"7177dbd4_8afc4cb1","updated":"2022-10-20 12:29:42.000000000","message":"James could you please address this?","commit_id":"f4e591a669ee9db95854116e3e81f6b144339022"}],"tripleo_ansible/roles/tripleo_iscsid/tasks/configure.yml":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ad154b9302031902d8e2a0443ecb07c99fba02be","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2022 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"98f5dade_ac645103","line":1,"updated":"2022-09-15 08:18:14.000000000","message":"Can we move the content of this file in run.yaml, it will fix this bug https://launchpad.net/bugs/1989482 ?","commit_id":"2ec00052879665a90b9c677eace04c21a8f36b1d"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"aca28f868e04943a39775c57d7e14d52254c5a41","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2022 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"37fff8e1_6a266528","line":1,"in_reply_to":"41418ed3_a308e26b","updated":"2022-09-30 15:38:24.000000000","message":"on a 3rd look...\nI think this patch will fix it:\nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/859999\n\nThen we can move forward with this patch as-is.","commit_id":"2ec00052879665a90b9c677eace04c21a8f36b1d"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"1dad85b00a5bf23a42b3b5f76489f4c20c2e6a04","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2022 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"a5a583e8_e4403a19","line":1,"in_reply_to":"98f5dade_ac645103","updated":"2022-09-29 10:40:54.000000000","message":"I agree, it can be good to change the name here.","commit_id":"2ec00052879665a90b9c677eace04c21a8f36b1d"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"cbc0e174fafee0c70825486a48c4041055e0e65a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2022 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ae17879e_d73d2684","line":1,"in_reply_to":"a5a583e8_e4403a19","updated":"2022-09-30 15:08:56.000000000","message":"moving this to run.yml isn\u0027t the right fix. we need to make sure that configure.yml is getting called by whatever needs it. likely the t-h-t patch.","commit_id":"2ec00052879665a90b9c677eace04c21a8f36b1d"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"168a4603268f92e7fe7aa7de25afdb967ff4eacf","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2022 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"41418ed3_a308e26b","line":1,"in_reply_to":"ae17879e_d73d2684","updated":"2022-09-30 15:15:31.000000000","message":"ok, i guess we can\u0027t do this in a backwards compatibility way so that the patches can merge in the needed order, so i\u0027ll update run.yml to import_tasks from configure.yml as a temporary workaround.","commit_id":"2ec00052879665a90b9c677eace04c21a8f36b1d"}],"tripleo_ansible/roles/tripleo_iscsid/tasks/iscsid_install.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"28ee3ef4c4e677b900f105cce0a33295e129738f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"install.yml"}],"source_content_type":"x-git/symlink","patch_set":16,"id":"3c654528_7d04990c","line":1,"updated":"2022-09-05 01:50:25.000000000","message":"Should we name this file iscsid-install.yaml instead ?","commit_id":"2ec00052879665a90b9c677eace04c21a8f36b1d"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"14cd33223b670915d3703aec44174d09f11741e6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"install.yml"}],"source_content_type":"x-git/symlink","patch_set":16,"id":"e1bf999f_6c1fd61c","line":1,"in_reply_to":"3c654528_7d04990c","updated":"2022-09-30 15:13:10.000000000","message":"no. iscsid_install.yml is the name used by tripleo-heat-templates, so we need this symlink for backwards compat (temporarily).","commit_id":"2ec00052879665a90b9c677eace04c21a8f36b1d"}],"tripleo_ansible/roles/tripleo_nova_migration_target/tasks/install.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5534f8ab131fe8919e39adc869c72a6cbba68845","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2022 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"8f543ebc_b6bc7d48","line":1,"updated":"2022-10-07 14:54:47.000000000","message":"was this file change intentional?","commit_id":"c6cd749ff914d8f9146148ea6d934ccc3d02943f"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"5191383bdcda51a0ff269ab53c63d744aaf9de0e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2022 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"e5b68aed_6c45cc14","line":1,"in_reply_to":"8f543ebc_b6bc7d48","updated":"2022-10-10 11:42:57.000000000","message":"Actually it\u0027s a good question.","commit_id":"c6cd749ff914d8f9146148ea6d934ccc3d02943f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"60894eb1c9e7d7b7b6ed466fc94119b2d9d01e0f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2022 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"09698cf4_ff975fc5","line":1,"in_reply_to":"d9c459ad_70815be9","updated":"2022-10-14 14:10:34.000000000","message":"the diff is no longer shown if comparing the the base revision, so LGTM","commit_id":"c6cd749ff914d8f9146148ea6d934ccc3d02943f"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"85e6e39551b38b94be53db4c3bfb24d1a674f504","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2022 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"d9c459ad_70815be9","line":1,"in_reply_to":"e5b68aed_6c45cc14","updated":"2022-10-11 21:10:03.000000000","message":"weird, and it has no changes. I wonder how it got included in the commit. Locally, I don\u0027t see it as part of the commit.","commit_id":"c6cd749ff914d8f9146148ea6d934ccc3d02943f"}]}