)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"94e60f3c27e6776f0fecda79ce9fb02c27ac14c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"86c1cebf_1757e497","updated":"2022-05-25 16:51:15.000000000","message":"check-rdo","commit_id":"c39748cbb37a9b854f9e9d36bf5af1cdd3158616"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"f124bd3dba36526d93983b8c2aa8a0a5231bb21d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ffc65a97_36408e69","updated":"2022-05-26 13:05:55.000000000","message":"How this change behaves when run on deployed-ceph standalone scenarios 001/004/010 can be seen in the following:\n\n https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/834352\n\nIt works. The 004 failure is a result not of this patch but of another issue to be solved separately before 834352 is merged.\n\nDetails:\nFor green standalone scenario 001:\n- The initial ceph.conf [1] for this job set the public_network and cluster_network .\n- As per ansible log [2], we see these two parameters were picked up while ms_bind paramters were not [3]\n- In the same log [2] we see the these two parameters were not set but that the ms_bind paramters were [4]\n\nFor green standalone scenario 010: \n- The same behavior is observed [5] as in 001.\n\nFor red standalone scenario 004: \n- The same behavior is observed [6] as in 001.\n- Tempest tests for RGW test_swift_acl_anonymous_download TestObjectStorageBasicOps then fail [7] but they failed the same way even when 834352 does not depend on 834352.\n\n[1] https://e46c7dcaeeba5cd3d545-b2970e7b6495d9446301ff14a6e09bc6.ssl.cf5.rackcdn.com/834352/75/check/tripleo-ci-centos-9-scenario001-standalone/3376d51/logs/undercloud/home/zuul/initial_ceph.conf\n\n[2] https://e46c7dcaeeba5cd3d545-b2970e7b6495d9446301ff14a6e09bc6.ssl.cf5.rackcdn.com/834352/75/check/tripleo-ci-centos-9-scenario001-standalone/3376d51/logs/undercloud/home/zuul/ansible.log\n\n[3]\n2022-05-25 21:03:53,675 p\u003d25689 u\u003droot n\u003dansible | 2022-05-25 21:03:53.675465 | bc764e10-1602-cb30-7c06-00000000029c |       TASK | Build list of underscored keys found in initial ceph conf file\n2022-05-25 21:03:53,760 p\u003d25689 u\u003droot n\u003dansible | 2022-05-25 21:03:53.758851 | bc764e10-1602-cb30-7c06-00000000029c |         OK | Build list of underscored keys found in initial ceph conf file | standalone.localdomain | item\u003dpublic_network\n2022-05-25 21:03:53,774 p\u003d25689 u\u003droot n\u003dansible | 2022-05-25 21:03:53.773710 | bc764e10-1602-cb30-7c06-00000000029c |         OK | Build list of underscored keys found in initial ceph conf file | standalone.localdomain | item\u003dcluster_network\n2022-05-25 21:03:53,786 p\u003d25689 u\u003droot n\u003dansible | 2022-05-25 21:03:53.785527 | bc764e10-1602-cb30-7c06-00000000029c |    SKIPPED | Build list of underscored keys found in initial ceph conf file | standalone.localdomain | item\u003dms_bind_ipv4\n2022-05-25 21:03:53,797 p\u003d25689 u\u003droot n\u003dansible | 2022-05-25 21:03:53.797097 | bc764e10-1602-cb30-7c06-00000000029c |    SKIPPED | Build list of underscored keys found in initial ceph conf file | standalone.localdomain | item\u003dms_bind_ipv6\n\n[4]\n2022-05-25 21:03:53,953 p\u003d25689 u\u003droot n\u003dansible | 2022-05-25 21:03:53.952013 | bc764e10-1602-cb30-7c06-00000000029e |    SKIPPED | Set public/cluster network and v4/v6 ms_bind unless already in ceph.conf | standalone.localdomain | item\u003d{\u0027key\u0027: \u0027public_network\u0027, \u0027value\u0027: \u0027192.168.42.0/24\u0027}\n2022-05-25 21:03:53,961 p\u003d25689 u\u003droot n\u003dansible | 2022-05-25 21:03:53.960339 | bc764e10-1602-cb30-7c06-00000000029e |    SKIPPED | Set public/cluster network and v4/v6 ms_bind unless already in ceph.conf | standalone.localdomain | item\u003d{\u0027key\u0027: \u0027cluster_network\u0027, \u0027value\u0027: \u0027192.168.42.0/24\u0027}\n2022-05-25 21:03:55,246 p\u003d25689 u\u003droot n\u003dansible | 2022-05-25 21:03:55.245459 | bc764e10-1602-cb30-7c06-00000000029e |         OK | Set public/cluster network and v4/v6 ms_bind unless already in ceph.conf | standalone.localdomain | item\u003d{\u0027key\u0027: \u0027ms_bind_ipv4\u0027, \u0027value\u0027: \u0027True\u0027}\n2022-05-25 21:03:56,536 p\u003d25689 u\u003droot n\u003dansible | 2022-05-25 21:03:56.536130 | bc764e10-1602-cb30-7c06-00000000029e |         OK | Set public/cluster network and v4/v6 ms_bind unless already in ceph.conf | standalone.localdomain | item\u003d{\u0027key\u0027: \u0027ms_bind_ipv6\u0027, \u0027value\u0027: \u0027False\u0027}\n\n[5] https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b4d/834352/75/check/tripleo-ci-centos-9-scenario010-standalone/b4d29ce/logs/undercloud/home/zuul/ansible.log\n\n[6] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_916/834352/75/check/tripleo-ci-centos-9-scenario004-standalone/9162458/logs/undercloud/home/zuul/ansible.log\n\n[7] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_916/834352/75/check/tripleo-ci-centos-9-scenario004-standalone/9162458/logs/undercloud/var/log/tempest/tempest_results.xml\n\n\n","commit_id":"f34d35124ae665318d069d8ef8a44df73940ec77"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"f6cf82f9abc1ccea0ddf8ac177b945733a2d8c27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"77573bf9_967d7cc7","updated":"2022-05-27 10:01:01.000000000","message":"+1 as I still have to check the related changes","commit_id":"1c84f6a5ff90cf9789c42d77488c4d9deb35c90d"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"9d3470390c254f0c1e094345e40c581581c502a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"63341b67_317870c9","updated":"2022-05-27 10:00:35.000000000","message":"I found \"network_config_set.yaml\" a bit harder to follow, but I also liked the trick of checking the keys in ceph.conf and setting them if not there.","commit_id":"1c84f6a5ff90cf9789c42d77488c4d9deb35c90d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"026f5defb80e4a4356e6204dd76fa96e212dcd7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4ca082fc_3b9777b4","updated":"2022-05-26 20:14:34.000000000","message":"Testing non-deployed ceph scenario with:\n\n https://review.opendev.org/c/openstack/tripleo-heat-templates/+/843544\n\nTesting deployed ceph scenario with:\n\n https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/834352\n","commit_id":"1c84f6a5ff90cf9789c42d77488c4d9deb35c90d"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"56a29f11c5b34712e34709975448b27933b65f89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8689f306_e18636ff","updated":"2022-05-27 11:44:34.000000000","message":"interesting use case","commit_id":"1c84f6a5ff90cf9789c42d77488c4d9deb35c90d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"b3dfa0696c06067e43f7420417692c5e40a73baf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"10d5fa22_fedcee6d","updated":"2022-05-27 11:00:14.000000000","message":"thanks for the review","commit_id":"1c84f6a5ff90cf9789c42d77488c4d9deb35c90d"}],"tripleo_ansible/roles/tripleo_cephadm/tasks/apply_spec.yaml":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"9d3470390c254f0c1e094345e40c581581c502a6","unresolved":true,"context_lines":[{"line_number":44,"context_line":"  when:"},{"line_number":45,"context_line":"    - not (ceph_orch_status.stdout | from_json).available"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Run ceph config set for parameters before applying the spec"},{"line_number":48,"context_line":"  include_tasks: cephadm_config_set.yaml"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- name: Apply spec"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"434926ce_75973aea","line":47,"range":{"start_line":47,"start_character":2,"end_line":47,"end_character":6},"updated":"2022-05-27 10:00:35.000000000","message":"Makes sense, now that set of tasks are not just image settings but also a bunch of other config-keys","commit_id":"1c84f6a5ff90cf9789c42d77488c4d9deb35c90d"}],"tripleo_ansible/roles/tripleo_cephadm/tasks/cephadm_config_set.yaml":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"9d3470390c254f0c1e094345e40c581581c502a6","unresolved":true,"context_lines":[{"line_number":21,"context_line":"  become: true"},{"line_number":22,"context_line":"  when: tripleo_cephadm_debug | bool"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: ceph config set public/private network and ms_bind ipv4/v6"},{"line_number":25,"context_line":"  include_tasks: network_config_set.yaml"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: set default container image in ceph configuration"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b512e553_5bbdc4f3","line":24,"range":{"start_line":24,"start_character":2,"end_line":24,"end_character":6},"updated":"2022-05-27 10:00:35.000000000","message":"Thanks, that\u0027s the right way to maintain modularity","commit_id":"1c84f6a5ff90cf9789c42d77488c4d9deb35c90d"}],"tripleo_ansible/roles/tripleo_cephadm/tasks/network_config_set.yaml":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"9d3470390c254f0c1e094345e40c581581c502a6","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Expand list of keys to include versions of themselves with spaces"},{"line_number":12,"context_line":"  set_fact:"},{"line_number":13,"context_line":"    ceph_network_keys: \"{{ ceph_network_keys + [ key | regex_replace(\u0027_\u0027, \u0027 \u0027) ] }}\""},{"line_number":14,"context_line":"  loop: \"{{ ceph_network_keys }} \""},{"line_number":15,"context_line":"  loop_control:"},{"line_number":16,"context_line":"    loop_var: key"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"65ec57a8_01d9bb90","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":22},"updated":"2022-05-27 10:00:35.000000000","message":"so here network keys become:\n\n\u0027public network\u0027, \u0027cluster network\u0027, \u0027ms bind ipv4\u0027, \u0027ms bind ipv6\u0027","commit_id":"1c84f6a5ff90cf9789c42d77488c4d9deb35c90d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"e74a3379a6aadd205f47b058059730baa9d8a040","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    loop_var: key"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Build list of underscored keys found in initial ceph conf file"},{"line_number":19,"context_line":"  ignore_errors: true"},{"line_number":20,"context_line":"  delegate_to: localhost"},{"line_number":21,"context_line":"  set_fact:"},{"line_number":22,"context_line":"    keys_in_ceph_conf: \"{{ keys_in_ceph_conf + [ key | regex_replace(\u0027 \u0027, \u0027_\u0027) ] }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2d7d5752_38a8679d","line":19,"range":{"start_line":19,"start_character":2,"end_line":19,"end_character":21},"updated":"2022-05-26 20:05:29.000000000","message":"If you only pass the HCI paramters for your assimilation ceph.conf like below then there won\u0027t be global. Don\u0027t fail just for that though.\n\n  [osd]\n  osd_memory_target_autotune \u003d true\n  osd_numa_auto_affinity \u003d true\n  [mgr]\n  mgr/cephadm/autotune_memory_target_ratio \u003d 0.2","commit_id":"1c84f6a5ff90cf9789c42d77488c4d9deb35c90d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"e74a3379a6aadd205f47b058059730baa9d8a040","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Build list of underscored keys found in initial ceph conf file"},{"line_number":19,"context_line":"  ignore_errors: true"},{"line_number":20,"context_line":"  delegate_to: localhost"},{"line_number":21,"context_line":"  set_fact:"},{"line_number":22,"context_line":"    keys_in_ceph_conf: \"{{ keys_in_ceph_conf + [ key | regex_replace(\u0027 \u0027, \u0027_\u0027) ] }}\""},{"line_number":23,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"eae75761_b6e223f7","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":24},"updated":"2022-05-26 20:05:29.000000000","message":"Tested in a multinode environment and wanted to ensure it would lookup the file on the ansible host.","commit_id":"1c84f6a5ff90cf9789c42d77488c4d9deb35c90d"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"9d3470390c254f0c1e094345e40c581581c502a6","unresolved":true,"context_lines":[{"line_number":23,"context_line":"  vars:"},{"line_number":24,"context_line":"    conf: \"{{ tripleo_cephadm_bootstrap_conf }}\""},{"line_number":25,"context_line":"    value: \"{{ lookup(\u0027ini\u0027,"},{"line_number":26,"context_line":"                       key ~ \u0027 section\u003dglobal default\u003d file\u003d\u0027 ~ conf) }}\""},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - tripleo_cephadm_bootstrap_conf | default(\u0027\u0027) | length \u003e 0"},{"line_number":29,"context_line":"    - value | default(\u0027\u0027) | string | length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2b5f9ad0_41890e25","line":26,"updated":"2022-05-27 10:00:35.000000000","message":"So, iiuc you iterate over the network keys defined on L5 and if a value exists in ceph.conf you add the key in keys_in_ceph_conf array (fixing the format through regex_replace).","commit_id":"1c84f6a5ff90cf9789c42d77488c4d9deb35c90d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"e74a3379a6aadd205f47b058059730baa9d8a040","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    value: \"{{ lookup(\u0027ini\u0027,"},{"line_number":26,"context_line":"                       key ~ \u0027 section\u003dglobal default\u003d file\u003d\u0027 ~ conf) }}\""},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - tripleo_cephadm_bootstrap_conf | default(\u0027\u0027) | length \u003e 0"},{"line_number":29,"context_line":"    - value | default(\u0027\u0027) | string | length \u003e 0"},{"line_number":30,"context_line":"  loop: \"{{ ceph_network_keys }}\""},{"line_number":31,"context_line":"  loop_control:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f96ace51_e2b868fe","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":36},"updated":"2022-05-26 20:05:29.000000000","message":"Only do this if the user passed their own tripleo_cephadm_bootstrap_conf.\n\nOtherwise we know that the template based conf won\u0027t have the network parameters and we\u0027ll just stick with the default empty list for keys_in_ceph_conf defined on line 4.\n\nhttps://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_cephadm/tasks/pre.yaml#L106-L142","commit_id":"1c84f6a5ff90cf9789c42d77488c4d9deb35c90d"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"9d3470390c254f0c1e094345e40c581581c502a6","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    loop_var: key"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Set public/cluster network and v4/v6 ms_bind unless already in ceph.conf"},{"line_number":35,"context_line":"  command: |"},{"line_number":36,"context_line":"    {{ tripleo_cephadm_ceph_cli }} config set global {{ item.key }} {{ item.value }}"},{"line_number":37,"context_line":"  loop: \"{{ net_data | dict2items }}\""},{"line_number":38,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0b0fd164_3155123d","line":35,"updated":"2022-05-27 10:00:35.000000000","message":"if the key provided by net_data is not present in ceph.conf, you set the key in the ceph cluster.\nSo, correct me if I\u0027m wrong, you\u0027re trying to collect the network keys that are not defined in ceph.conf and set them in the cluster with the value passed in net_data.","commit_id":"1c84f6a5ff90cf9789c42d77488c4d9deb35c90d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"b3dfa0696c06067e43f7420417692c5e40a73baf","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    loop_var: key"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Set public/cluster network and v4/v6 ms_bind unless already in ceph.conf"},{"line_number":35,"context_line":"  command: |"},{"line_number":36,"context_line":"    {{ tripleo_cephadm_ceph_cli }} config set global {{ item.key }} {{ item.value }}"},{"line_number":37,"context_line":"  loop: \"{{ net_data | dict2items }}\""},{"line_number":38,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"26ace052_0c28215c","line":35,"in_reply_to":"0b0fd164_3155123d","updated":"2022-05-27 11:00:14.000000000","message":"yes, exactly","commit_id":"1c84f6a5ff90cf9789c42d77488c4d9deb35c90d"}]}