)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"91fa8afd356272111ecf22ed84087107d395fb09","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tripleo_nova_compute: add for standalone roles"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"TBD: group \"flat tasks\" by virtual steps to match the expected"},{"line_number":10,"context_line":"tripleo stepX filters. So that when there is no step data inputs"},{"line_number":11,"context_line":"(i.e. it is being deployed outside of t-h-t), the tasks file use"},{"line_number":12,"context_line":"a flat execution model. And if it has steps data passed in via role"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"f3568f8a_004eec57","line":9,"updated":"2022-07-15 12:21:34.000000000","message":"this have been rethought, so I split the legacy stepX logic required for tripleo off additional validate.yml task. This way we can call the needed tasks based on steps in tripleo, w/o bringing it here","commit_id":"17c63751e99475f89b92888f2f7bcc6d3116c4b9"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7b97c7c4a01a246c9a187bef7fa44b0c50fde96f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tripleo_nova_compute: add for standalone roles"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"TBD: group \"flat tasks\" by virtual steps to match the expected"},{"line_number":10,"context_line":"tripleo stepX filters. So that when there is no step data inputs"},{"line_number":11,"context_line":"(i.e. it is being deployed outside of t-h-t), the tasks file use"},{"line_number":12,"context_line":"a flat execution model. And if it has steps data passed in via role"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"a86e1c24_1355dbed","line":9,"in_reply_to":"f3568f8a_004eec57","updated":"2022-08-03 11:57:52.000000000","message":"Done","commit_id":"17c63751e99475f89b92888f2f7bcc6d3116c4b9"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f522a6265d1e5ceb547ca102cedb27c377a584fb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tripleo_nova_compute: add for standalone roles"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"TBD: group \"flat tasks\" by virtual steps to match the expected"},{"line_number":10,"context_line":"tripleo stepX filters. So that when there is no step data inputs"},{"line_number":11,"context_line":"(i.e. it is being deployed outside of t-h-t), the tasks file use"},{"line_number":12,"context_line":"a flat execution model. And if it has steps data passed in via role"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"ac7daae5_ff303266","line":9,"updated":"2022-08-11 12:24:16.000000000","message":"not sure what I was saying here... no longer relevant as I discovered a way to manage \"virtual steps\" outside of the role","commit_id":"6559fa028a5acd153bcede8b51d4bc5ec763ce39"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"351e567c5508e5a911b9a52a9afd91fd90c262f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e4f0316_6f0eddb8","updated":"2022-05-27 17:09:14.000000000","message":"early WIP","commit_id":"b01887e7bf0ae94ebc277a324f584b1a4f5fe59f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"af944675cd69e9fd699971c965a8de01005c531a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f9bc42f7_2809f8ac","updated":"2022-06-01 11:52:31.000000000","message":"this looks interesting.\nill try and see if i can make time to deploy it but looking at the molecule role im not sure how the podman container image is beign specified.\n\nill also try if i find tiume to invoke this role on a c9s vm\n\ndo you have any exmaple of how to combine these roles yet to deploy a full compute node.","commit_id":"d6ee5d5885441b065107e70798781372c5e97c04"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4babaedbceb2d664b152d81925191537b5d8237f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1d70f4c6_9e670632","in_reply_to":"f9bc42f7_2809f8ac","updated":"2022-06-01 13:11:45.000000000","message":"that\u0027s TBD, still in WIP...","commit_id":"d6ee5d5885441b065107e70798781372c5e97c04"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"40887cfab69eddda5bfbce26a6b08175ee87dac3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"78c5dc60_45fc5db7","updated":"2022-06-02 01:06:53.000000000","message":"i\u0027ve got the container trying to start now, but it\u0027s presently failing on:\n\nINFO:__main__:Loading config file at /var/lib/kolla/config_files/config.json\nINFO:__main__:Validating config file\nINFO:__main__:Kolla config strategy set to: COPY_ALWAYS\nINFO:__main__:Copying service configuration files\nERROR:__main__:MissingRequiredSource: /var/lib/kolla/config_files/src/etc/nova_compute/fernet-keys file is not found\n\n\ni will look at that next.","commit_id":"050dd10e263c1abfd4d64f81f9dfff54c33e1e2d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e9047610db8f844eddea9d80ab2cdb4c3baab671","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5a38e66a_5e5e5fff","in_reply_to":"4551d050_0d052702","updated":"2022-06-02 14:42:29.000000000","message":"right, sorry, I just have not removed all of the copy-pasta (from keystone) leftovers :)","commit_id":"050dd10e263c1abfd4d64f81f9dfff54c33e1e2d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"135c717a0f8c285e4a0a0e8678736e76d371710b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2ff20fa5_68c1c322","in_reply_to":"5a38e66a_5e5e5fff","updated":"2022-06-02 16:57:49.000000000","message":"Done","commit_id":"050dd10e263c1abfd4d64f81f9dfff54c33e1e2d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"17a9a424e87f7ac2805dfb5145229f3ae8e32bc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8f6c5e87_a7f03a6a","in_reply_to":"78c5dc60_45fc5db7","updated":"2022-06-02 13:43:21.000000000","message":"why woudl nova compute need fernet keys?\n\nfernet tokens are used by keystoned instead of uuid based tokens.\n\nnova has no concept of using fernet-keys for anything","commit_id":"050dd10e263c1abfd4d64f81f9dfff54c33e1e2d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5071ca9975388bde09a7119dca52dba1163c0742","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4551d050_0d052702","in_reply_to":"8f6c5e87_a7f03a6a","updated":"2022-06-02 13:43:40.000000000","message":"sorry shoudl not have marked that resovled","commit_id":"050dd10e263c1abfd4d64f81f9dfff54c33e1e2d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"42f711be49b8f40893efe740b15e382ad45756f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c2cb5129_1d6f3509","updated":"2022-06-02 16:57:03.000000000","message":"it is ready for testing","commit_id":"d7055139e28da7502197baffb3de38139c0bca83"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9af174c566337e9ace23dde316abd72151d6ed99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"243e0482_bc405fac","updated":"2022-06-03 13:07:01.000000000","message":"thank you James, well done","commit_id":"51b84e02ff84034604768f6c399d9e028dd01c68"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3e5a30c7840533332f8e434ceae8fa37e49586a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"752c6d1e_594c8cd3","updated":"2022-06-10 10:54:22.000000000","message":"restored rewritten changes...","commit_id":"e3611146ba41b6952c29642e28cf7f755f32200a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bb2416df645a90cd922dc71b3c62a1d750c5d7d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"6c38e68c_9a4a8449","updated":"2022-06-13 16:47:56.000000000","message":"Remaining hiera mappings and t-h-t wire in for global vars:\n\nhttps://paste.opendev.org/show/b96uI0gKShLgZ8Md0VN3/\n\nThe validation script:\nhttps://gist.github.com/bogdando/ab2118f4c6fbb88c1c127fd6eb82b756","commit_id":"7687c9758b3e57a4756f66a215028f666b61df9e"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"65c0c6dc13cdc0c1ca1efc12264759844581ca58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"d89e3a47_2e19954b","updated":"2022-07-29 21:17:01.000000000","message":"I see that tripleo_nova_compute [1] uses .yml and tripleo_nova_libvirt [2] uses .yaml\nI had to do a silly workaround [3] to get them working when I followed the etherpad [4]\nCan these be made consistent?\n\n[1] https://review.opendev.org/c/openstack/tripleo-ansible/+/843659\n[2] https://review.opendev.org/c/openstack/tripleo-ansible/+/842152\n\n[3] silly workaround\nfunction yml_yaml {\n    # symlink .yml files to .yaml files\n    echo \"yml_yaml: $1\"\n    pushd $1\n    for F1 in $(ls *.yml); do\n        F2\u003d$(echo $F1 | sed -e s/yml/yaml/g)\n        sudo ln -vsf $F1 $F2\n    done\n    popd\n}\nfunction yaml_yml {\n    # symlink .yaml files to .yml files\n    echo \"yaml_yml: $1\"\n    pushd $1\n    for F1 in $(ls *.yaml); do\n        F2\u003d$(echo $F1 | sed -e s/yaml/yml/g)\n        sudo ln -vsf $F1 $F2\n    done\n    popd\n}\nyml_yaml /home/stack/tripleo-ansible/tripleo_ansible/roles/tripleo_nova_compute/tasks\nyaml_yml /home/stack/tripleo-ansible/tripleo_ansible/roles/tripleo_nova_libvirt/tasks\n\n[4] https://etherpad.opendev.org/p/tripleo-standalone-roles\n","commit_id":"17c63751e99475f89b92888f2f7bcc6d3116c4b9"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"33be6c618dddea78965027ed257317b42f664c51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"41ce881b_ef4ce333","updated":"2022-08-04 11:56:26.000000000","message":"recheck content provider","commit_id":"2811f3901f19149a8b6ac41ded2181b845ef379a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4d5f5e3b6cf8b52b58193d12a04c6249a2835150","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"95826a56_9acc0e02","updated":"2022-08-11 12:07:20.000000000","message":"\\o/ the partial integration patch in tripleo worked (but unrelated fips job failed)\nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/847030","commit_id":"6559fa028a5acd153bcede8b51d4bc5ec763ce39"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"620bc18a41d53beed89a792dee92d6c6a6778227","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"b4028e21_c37be867","updated":"2022-08-16 17:19:51.000000000","message":"note that this needs to be in the same tree and a child of the tripleo_nova_libvirt patch since they both modify zuul.d/molecule.yaml around the same line #. Otherwise, we get conflicts when we try and cherry pick them together.","commit_id":"8332c2ef3fb5b6506bb89302f7d3c1d48ced9a9b"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"c1a2045a1e0808e4ac6066ad9b8f7610003d459d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"b9b49a93_07b06115","updated":"2022-08-25 13:52:58.000000000","message":"i\u0027ve added some comments about some reasonable defaults for some of the vars. these should be able to make use of the latest sample inventory from https://review.opendev.org/c/openstack/tripleo-ansible/+/840509\n\ni\u0027m still testing, and will report back.","commit_id":"4604b6f788259d8396fd44edf80ee3ecfadcdeb1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"211e1c1f6ddce74b2c83728361f1b220dc0a887f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"629e5ac2_ca6398d6","updated":"2022-08-26 12:44:18.000000000","message":"thank you for suggestions, James. Looking forward for new defaults in inventory","commit_id":"c7f93f4ee4a07c09eb8a78ee11e4f12863305528"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e33f1cbb4e815252f97c246dc6106de51fc9782b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"5a3a5673_4aa9d05b","updated":"2022-08-29 14:13:43.000000000","message":"let\u0027s merge this, then adjust as required?\nWith the testing framework improved, we can also compose molecule tests, like it was proposed for libvirt role.","commit_id":"31d003e180e8c67aa7801853436e600dedeef0f9"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"18fd4412b01f7ad769cf65e38c35c67cee799c93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"542623fa_de2c6d50","updated":"2022-09-12 12:35:46.000000000","message":"PTAL, James","commit_id":"bf7b885600c7e42e3c45541aff914c4eee49099c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b29667c174e17c4fab2042580bec0648d929a701","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"c27423c5_b7a0790e","updated":"2022-09-19 14:39:26.000000000","message":"PTAL again","commit_id":"01e154b47ef70022bab4bc33830742c5f1eb0251"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e3484c52d8da7382e8b8f66a00f4bb83305a7e05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"33ddc9b3_946dc115","updated":"2022-09-22 14:41:34.000000000","message":"at some point we\u0027ve lost \"tripleo_nova_compute_config_overrides\", I wonder at which one...","commit_id":"01e154b47ef70022bab4bc33830742c5f1eb0251"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b53acfb82f37bc9e0c025cc74611a314ad8c2d02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"bf770fde_f1b52e4e","updated":"2022-09-22 14:41:48.000000000","message":"see https://835274c181a104f9c971-96bca91b8ac8416a48bc1ab248a7deaf.ssl.cf1.rackcdn.com/847030/9/check/tripleo-ci-centos-9-standalone/fb6da62/logs/undercloud/home/zuul/standalone_deploy.log","commit_id":"01e154b47ef70022bab4bc33830742c5f1eb0251"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4a9870b379211a81234db6b49b754e5e8dc5114f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"380c59b6_267ad5ad","updated":"2022-09-15 12:25:59.000000000","message":"well spotted, thanks","commit_id":"01e154b47ef70022bab4bc33830742c5f1eb0251"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"52c84b48b2c7b374a051042bde58b410773665db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"29b67e90_a6397074","updated":"2022-10-06 18:31:01.000000000","message":"recheck","commit_id":"1917e9e192f4205587f6f60c28483f8a8c29819a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3ea1ff3bc7a8bac78c0ebdf3eb9e2ccf1ff8e473","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"aa462c23_81116adf","updated":"2022-10-07 14:32:51.000000000","message":"recheck","commit_id":"1917e9e192f4205587f6f60c28483f8a8c29819a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1e603d0d87e7919f71bc7eb0ac11d892d36f2617","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"b56aa320_fc4e68a1","updated":"2022-10-10 13:32:59.000000000","message":"recheck","commit_id":"1917e9e192f4205587f6f60c28483f8a8c29819a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"885ac54fc4b245a9c0f1895a689107d85ee40043","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"bb930ad2_20b07faf","updated":"2022-10-11 15:05:36.000000000","message":"recheck","commit_id":"1917e9e192f4205587f6f60c28483f8a8c29819a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"947e448af8b7900b22453b69e09a0ca38a88eae8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"bdf2721c_ee15487c","updated":"2022-10-13 12:44:33.000000000","message":"recheck","commit_id":"1917e9e192f4205587f6f60c28483f8a8c29819a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"354a89730b6cccabbeb3437a1f19cf3529585d6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"d11c97ed_ef6f8e39","updated":"2022-10-12 13:17:16.000000000","message":"recheck","commit_id":"1917e9e192f4205587f6f60c28483f8a8c29819a"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"5dbc61b4d95b0872e859d9a64f8658b7ede5c866","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"f4c1d5ca_1bbbdb57","updated":"2022-10-12 20:54:16.000000000","message":"recheck","commit_id":"1917e9e192f4205587f6f60c28483f8a8c29819a"}],"tripleo_ansible/roles/tripleo_nova_compute/defaults/main.yml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"75f14e80e4a7c1df90aebe3b40559f7cd296f86d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"tripleo_nova_compute_deploy_identifier: \"{{ tripleo_deploy_identifier | default(\u0027\u0027) }}\""},{"line_number":23,"context_line":"tripleo_nova_compute_hide_sensitive_logs: true"},{"line_number":24,"context_line":"tripleo_nova_compute_container_image: \"quay.io/tripleomastercentos9/openstack-nova-compute:current-tripleo\"  # role specific"},{"line_number":25,"context_line":"tripleo_nova_compute_container_nova_libvirt_config_image: \"{{ tripleo_nova_libvirt_container_config_image | default(tripleo_nova_compute_container_image) }}\""},{"line_number":26,"context_line":"tripleo_nova_compute_docker_ulimit: [\u0027nofile\u003d131072\u0027, \u0027memlock\u003d67108864\u0027]"},{"line_number":27,"context_line":"tripleo_nova_compute_logging_source:"},{"line_number":28,"context_line":"  tag: openstack.nova.compute"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6ae13bcc_81c876bf","line":25,"updated":"2022-06-02 15:28:38.000000000","message":"@James, I restored the change you\u0027ve overwritten. Let\u0027s please keep the naming for now. We can adjust it later.","commit_id":"61b309aae500f7202619d3ddb56d9c2098a17414"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"43a4c1771f1a56630b22b11ca8bb36c5f12f8857","unresolved":true,"context_lines":[{"line_number":165,"context_line":"tripleo_nova_compute_DEFAULT_ram_allocation_ratio: \u00271.0\u0027"},{"line_number":166,"context_line":"tripleo_nova_compute_DEFAULT_report_interval: \u002710\u0027"},{"line_number":167,"context_line":"tripleo_nova_compute_DEFAULT_reserved_host_memory_mb: \u00274096\u0027"},{"line_number":168,"context_line":"tripleo_nova_compute_DEFAULT_resume_guests_state_on_host_boot: \u0027False\u0027"},{"line_number":169,"context_line":"tripleo_nova_compute_DEFAULT_rootwrap_config: /etc/nova/rootwrap.conf"},{"line_number":170,"context_line":"tripleo_nova_compute_DEFAULT_rpc_response_timeout: \u002760\u0027"},{"line_number":171,"context_line":"tripleo_nova_compute_DEFAULT_service_down_time: \u002760\u0027"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"2d82c082_e42a0b94","line":168,"updated":"2022-06-13 16:49:43.000000000","message":"@James, if you need bools to end up as strings in config providers, please use ternary(\u0027True\u0027, \u0027False\u0027). But let\u0027s please keep data inputs clean - bools and not strings with bool\u0027ish values...","commit_id":"e3611146ba41b6952c29642e28cf7f755f32200a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7b97c7c4a01a246c9a187bef7fa44b0c50fde96f","unresolved":false,"context_lines":[{"line_number":165,"context_line":"tripleo_nova_compute_DEFAULT_ram_allocation_ratio: \u00271.0\u0027"},{"line_number":166,"context_line":"tripleo_nova_compute_DEFAULT_report_interval: \u002710\u0027"},{"line_number":167,"context_line":"tripleo_nova_compute_DEFAULT_reserved_host_memory_mb: \u00274096\u0027"},{"line_number":168,"context_line":"tripleo_nova_compute_DEFAULT_resume_guests_state_on_host_boot: \u0027False\u0027"},{"line_number":169,"context_line":"tripleo_nova_compute_DEFAULT_rootwrap_config: /etc/nova/rootwrap.conf"},{"line_number":170,"context_line":"tripleo_nova_compute_DEFAULT_rpc_response_timeout: \u002760\u0027"},{"line_number":171,"context_line":"tripleo_nova_compute_DEFAULT_service_down_time: \u002760\u0027"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fdb54d1_ef087319","line":168,"in_reply_to":"2d82c082_e42a0b94","updated":"2022-08-03 11:57:52.000000000","message":"Done","commit_id":"e3611146ba41b6952c29642e28cf7f755f32200a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9a729066a7552c0d02bc15e05a49c1acb6541a03","unresolved":true,"context_lines":[{"line_number":235,"context_line":"tripleo_nova_compute_neutron_timeout: \u002730\u0027"},{"line_number":236,"context_line":"tripleo_nova_compute_neutron_user_domain_name: Default"},{"line_number":237,"context_line":"tripleo_nova_compute_neutron_username: neutron"},{"line_number":238,"context_line":"tripleo_nova_compute_neutron_valid_interfaces: internal"},{"line_number":239,"context_line":"tripleo_nova_compute_notifications_notification_format: unversioned"},{"line_number":240,"context_line":"tripleo_nova_compute_notifications_notify_on_state_change: vm_and_task_state"},{"line_number":241,"context_line":"tripleo_nova_compute_oslo_concurrency_lock_path: /var/lib/nova/tmp"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"8281eea9_33aaae4f","line":238,"updated":"2022-06-10 12:30:07.000000000","message":"I\u0027m also working on validating hiera data to match these defaults.\nCurrent version removes this one as redundant, while proposes a missing var for it named:\n\ntripleo_nova_compute_nova_network_neutron_valid_interfaces\n\nI think we should strictly follow hiera interfaces even tho that ends up with long names. That would be easier to maintain. And backport/sync changes among versions that still use tht and this new roles. However, I can make the name validator less strict ofc...","commit_id":"e3611146ba41b6952c29642e28cf7f755f32200a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"285148e3e9864e61fc83455ecbb43c9735c9565c","unresolved":true,"context_lines":[{"line_number":235,"context_line":"tripleo_nova_compute_neutron_timeout: \u002730\u0027"},{"line_number":236,"context_line":"tripleo_nova_compute_neutron_user_domain_name: Default"},{"line_number":237,"context_line":"tripleo_nova_compute_neutron_username: neutron"},{"line_number":238,"context_line":"tripleo_nova_compute_neutron_valid_interfaces: internal"},{"line_number":239,"context_line":"tripleo_nova_compute_notifications_notification_format: unversioned"},{"line_number":240,"context_line":"tripleo_nova_compute_notifications_notify_on_state_change: vm_and_task_state"},{"line_number":241,"context_line":"tripleo_nova_compute_oslo_concurrency_lock_path: /var/lib/nova/tmp"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9ecd36ff_4c08d074","line":238,"in_reply_to":"23bfd27c_2b108cbb","updated":"2022-06-13 14:09:38.000000000","message":"actully on the True vs False the rules for that are complex\n\nreally if we care we shoudl have ansible lint enforce it.\n\nbut for things like become for exampel they recommend using yes not true.\n\nhttps://chronicler.tech/red-hat-ansible-yes-no-and/\n\nFor Ansible scenarios, use only yes or no as a Boolean value.\n\nIf you prefer classic True/False, use them capitalized and do not put any quotes.\n\nquoting boolean values is stongly discuraged so i agree that we shoudl not quote the as \u0027True\u0027  or \u0027False\u0027\n\nthe breifly mention the issue with string and bools in \nhttps://docs.ansible.com/ansible/latest/reference_appendices/YAMLSyntax.html#gotchas\nat the very end\n\nthese are not dictonary values so\n\n\"\"\"Use lowercase ‘true’ or ‘false’ for boolean values in dictionaries if you want to be compatible with default yamllint options.\"\"\"\n\ndoes not actully apply to them but if yamllint compatiblity is desireable then yes they shoudl be lower case.\n\nhere we shoudl be use unquoted bool values yes/no or True/False","commit_id":"e3611146ba41b6952c29642e28cf7f755f32200a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bb56951a139b1d03edd60a53c9abedc77c4d0b40","unresolved":true,"context_lines":[{"line_number":235,"context_line":"tripleo_nova_compute_neutron_timeout: \u002730\u0027"},{"line_number":236,"context_line":"tripleo_nova_compute_neutron_user_domain_name: Default"},{"line_number":237,"context_line":"tripleo_nova_compute_neutron_username: neutron"},{"line_number":238,"context_line":"tripleo_nova_compute_neutron_valid_interfaces: internal"},{"line_number":239,"context_line":"tripleo_nova_compute_notifications_notification_format: unversioned"},{"line_number":240,"context_line":"tripleo_nova_compute_notifications_notify_on_state_change: vm_and_task_state"},{"line_number":241,"context_line":"tripleo_nova_compute_oslo_concurrency_lock_path: /var/lib/nova/tmp"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"23bfd27c_2b108cbb","line":238,"in_reply_to":"2a59abcf_e44c2d89","updated":"2022-06-13 13:41:01.000000000","message":"As a primaty maintainer of nova compute modules, I insise on preserving original naming rules until we fully retire puppet.\n\nWith my today tool which will help me backporting and syncing changes from t-h-t params and hiera keys (e.g. removing depreceted ones) to ansible vars, and wice versa, I wouldn\u0027t be able to easily track changes in bindings like\n\n\"tripleo_nova_compute_neutron_valid_interfaces\" to \"neutron_api_endpoint_type\" (ansible)\n\nvs nova::network::neutron::valid_interfaces (tht)\n\nThis is why I need such names.\n\nSo please just kindly accept my request as a maintainer.\n\nAlso, please let\u0027s not use \u0027True\u0027 and \u0027False\u0027 instead of native ansible true, false. That\u0027s a hard anti-pattern. I\u0027ll fix these back to natural values and restore the naming rules.","commit_id":"e3611146ba41b6952c29642e28cf7f755f32200a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"969fcd0ae3b7fd7e808f54cac98a53827be918d8","unresolved":true,"context_lines":[{"line_number":235,"context_line":"tripleo_nova_compute_neutron_timeout: \u002730\u0027"},{"line_number":236,"context_line":"tripleo_nova_compute_neutron_user_domain_name: Default"},{"line_number":237,"context_line":"tripleo_nova_compute_neutron_username: neutron"},{"line_number":238,"context_line":"tripleo_nova_compute_neutron_valid_interfaces: internal"},{"line_number":239,"context_line":"tripleo_nova_compute_notifications_notification_format: unversioned"},{"line_number":240,"context_line":"tripleo_nova_compute_notifications_notify_on_state_change: vm_and_task_state"},{"line_number":241,"context_line":"tripleo_nova_compute_oslo_concurrency_lock_path: /var/lib/nova/tmp"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"b54e961b_d179dd3e","line":238,"in_reply_to":"8281eea9_33aaae4f","updated":"2022-06-10 14:10:07.000000000","message":"The \"static data analyzer\" script is mostly done 😊\n\nHere is an example of a missing hiera mapping\n\nWe can ignore a missing warning that the script logs:\n\nVar for policy_policies hiera key looks missing, use name tripleo_nova_compute_nova_policy_policies\n\nas we use tripleo_nova_compute_oslo_policy_policy_file to specify policy_file directly in new direct ansible config interface,\n\nwhile in t-h-t it is https://opendev.org/openstack/puppet-nova/src/branch/master/manifests/policy.pp#L72 from hiera nova::policy::policies\n\nHowever, what about policy_purge_config missing mapping from hiera to ansible?\n\nVar for policy_purge_config hiera key looks missing, use name tripleo_nova_compute_nova_policy_purge_config ?\n\n^^ this looks like a valid finding.\n\nand so on, and so forth.\nI\u0027ll update the data vars by the script recommendaions.","commit_id":"e3611146ba41b6952c29642e28cf7f755f32200a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"560670177f79a4718476007a4fb0cd70c316cbf2","unresolved":true,"context_lines":[{"line_number":235,"context_line":"tripleo_nova_compute_neutron_timeout: \u002730\u0027"},{"line_number":236,"context_line":"tripleo_nova_compute_neutron_user_domain_name: Default"},{"line_number":237,"context_line":"tripleo_nova_compute_neutron_username: neutron"},{"line_number":238,"context_line":"tripleo_nova_compute_neutron_valid_interfaces: internal"},{"line_number":239,"context_line":"tripleo_nova_compute_notifications_notification_format: unversioned"},{"line_number":240,"context_line":"tripleo_nova_compute_notifications_notify_on_state_change: vm_and_task_state"},{"line_number":241,"context_line":"tripleo_nova_compute_oslo_concurrency_lock_path: /var/lib/nova/tmp"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9f612d45_faff6eed","line":238,"in_reply_to":"9ecd36ff_4c08d074","updated":"2022-07-04 14:16:27.000000000","message":"no, let\u0027s use normal false and true values please","commit_id":"e3611146ba41b6952c29642e28cf7f755f32200a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7b97c7c4a01a246c9a187bef7fa44b0c50fde96f","unresolved":false,"context_lines":[{"line_number":235,"context_line":"tripleo_nova_compute_neutron_timeout: \u002730\u0027"},{"line_number":236,"context_line":"tripleo_nova_compute_neutron_user_domain_name: Default"},{"line_number":237,"context_line":"tripleo_nova_compute_neutron_username: neutron"},{"line_number":238,"context_line":"tripleo_nova_compute_neutron_valid_interfaces: internal"},{"line_number":239,"context_line":"tripleo_nova_compute_notifications_notification_format: unversioned"},{"line_number":240,"context_line":"tripleo_nova_compute_notifications_notify_on_state_change: vm_and_task_state"},{"line_number":241,"context_line":"tripleo_nova_compute_oslo_concurrency_lock_path: /var/lib/nova/tmp"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"55ebd0d1_98d57342","line":238,"in_reply_to":"9f612d45_faff6eed","updated":"2022-08-03 11:57:52.000000000","message":"Done","commit_id":"e3611146ba41b6952c29642e28cf7f755f32200a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6b1ca223a0371f9b0dd9403fcce183cde4e14860","unresolved":true,"context_lines":[{"line_number":235,"context_line":"tripleo_nova_compute_neutron_timeout: \u002730\u0027"},{"line_number":236,"context_line":"tripleo_nova_compute_neutron_user_domain_name: Default"},{"line_number":237,"context_line":"tripleo_nova_compute_neutron_username: neutron"},{"line_number":238,"context_line":"tripleo_nova_compute_neutron_valid_interfaces: internal"},{"line_number":239,"context_line":"tripleo_nova_compute_notifications_notification_format: unversioned"},{"line_number":240,"context_line":"tripleo_nova_compute_notifications_notify_on_state_change: vm_and_task_state"},{"line_number":241,"context_line":"tripleo_nova_compute_oslo_concurrency_lock_path: /var/lib/nova/tmp"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"e3ba83ed_544e4169","line":238,"in_reply_to":"b54e961b_d179dd3e","updated":"2022-06-10 14:20:34.000000000","message":"I tend to avoid following the actual parameter name instead of parameter/class structure in puppet. It can be changed as part of refactoring in puppet side and following the actual parameter structure in nova.conf would be much easier to understand.\n\nRegarding some parameters missing, ideally we need to pick up parameters passed to the nova_config resource because we only care generation of nova.conf and the parameters not mapped to actual config file (eg. manage_service, package_ensure ) are irrelevant for that matter.","commit_id":"e3611146ba41b6952c29642e28cf7f755f32200a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5bc5c834f1c4e237484e54d0ee5798eb1b8fbfbe","unresolved":true,"context_lines":[{"line_number":235,"context_line":"tripleo_nova_compute_neutron_timeout: \u002730\u0027"},{"line_number":236,"context_line":"tripleo_nova_compute_neutron_user_domain_name: Default"},{"line_number":237,"context_line":"tripleo_nova_compute_neutron_username: neutron"},{"line_number":238,"context_line":"tripleo_nova_compute_neutron_valid_interfaces: internal"},{"line_number":239,"context_line":"tripleo_nova_compute_notifications_notification_format: unversioned"},{"line_number":240,"context_line":"tripleo_nova_compute_notifications_notify_on_state_change: vm_and_task_state"},{"line_number":241,"context_line":"tripleo_nova_compute_oslo_concurrency_lock_path: /var/lib/nova/tmp"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"2a59abcf_e44c2d89","line":238,"in_reply_to":"e3ba83ed_544e4169","updated":"2022-06-10 14:36:14.000000000","message":"given w eintend to fully remvoe puppet and heria data interface in the short ot medium term  most of thse parmaters will be removed or replaced in the future\n\n\"tripleo_nova_compute_neutron_valid_interfaces\" really shoudl be someting like \"neutron_api_endpoint_type\"\n\nat the end of the day we dont want to be bound to the current heira/puppet stucture long term so i expect after we have tansiation everything to standalone roles we will refactor this significnatly to clean ups the interface and imimise the number of parmaters that are defined on the role in favor of  config overrieds.","commit_id":"e3611146ba41b6952c29642e28cf7f755f32200a"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"c1a2045a1e0808e4ac6066ad9b8f7610003d459d","unresolved":true,"context_lines":[{"line_number":155,"context_line":"tripleo_nova_compute_DEFAULT_compute_driver: libvirt.LibvirtDriver"},{"line_number":156,"context_line":"tripleo_nova_compute_DEFAULT_dhcp_domain: \u0027\u0027"},{"line_number":157,"context_line":"tripleo_nova_compute_DEFAULT_force_config_drive: true"},{"line_number":158,"context_line":"tripleo_nova_compute_DEFAULT_host: \u0027\u0027"},{"line_number":159,"context_line":"tripleo_nova_compute_DEFAULT_log_dir: /var/log/nova"},{"line_number":160,"context_line":"tripleo_nova_compute_DEFAULT_my_ip: \u0027\u0027"},{"line_number":161,"context_line":"tripleo_nova_compute_DEFAULT_preallocate_images: none"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"34525d9c_7d25c3b3","line":158,"updated":"2022-08-25 13:52:58.000000000","message":"this should default to an ansible fact. likely just the short hostname?","commit_id":"4604b6f788259d8396fd44edf80ee3ecfadcdeb1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c1d2df0fb6fdc323dd7d5b39582a153bc5e20683","unresolved":false,"context_lines":[{"line_number":155,"context_line":"tripleo_nova_compute_DEFAULT_compute_driver: libvirt.LibvirtDriver"},{"line_number":156,"context_line":"tripleo_nova_compute_DEFAULT_dhcp_domain: \u0027\u0027"},{"line_number":157,"context_line":"tripleo_nova_compute_DEFAULT_force_config_drive: true"},{"line_number":158,"context_line":"tripleo_nova_compute_DEFAULT_host: \u0027\u0027"},{"line_number":159,"context_line":"tripleo_nova_compute_DEFAULT_log_dir: /var/log/nova"},{"line_number":160,"context_line":"tripleo_nova_compute_DEFAULT_my_ip: \u0027\u0027"},{"line_number":161,"context_line":"tripleo_nova_compute_DEFAULT_preallocate_images: none"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"a1da3b13_25b73ea7","line":158,"in_reply_to":"041df180_53855f53","updated":"2022-09-12 12:17:41.000000000","message":"Done","commit_id":"4604b6f788259d8396fd44edf80ee3ecfadcdeb1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9752490b8fe879d623516f465f4724d5244cb010","unresolved":true,"context_lines":[{"line_number":155,"context_line":"tripleo_nova_compute_DEFAULT_compute_driver: libvirt.LibvirtDriver"},{"line_number":156,"context_line":"tripleo_nova_compute_DEFAULT_dhcp_domain: \u0027\u0027"},{"line_number":157,"context_line":"tripleo_nova_compute_DEFAULT_force_config_drive: true"},{"line_number":158,"context_line":"tripleo_nova_compute_DEFAULT_host: \u0027\u0027"},{"line_number":159,"context_line":"tripleo_nova_compute_DEFAULT_log_dir: /var/log/nova"},{"line_number":160,"context_line":"tripleo_nova_compute_DEFAULT_my_ip: \u0027\u0027"},{"line_number":161,"context_line":"tripleo_nova_compute_DEFAULT_preallocate_images: none"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"041df180_53855f53","line":158,"in_reply_to":"34525d9c_7d25c3b3","updated":"2022-08-29 14:47:25.000000000","message":"oops, restoring the lost changes back...","commit_id":"4604b6f788259d8396fd44edf80ee3ecfadcdeb1"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"c1a2045a1e0808e4ac6066ad9b8f7610003d459d","unresolved":true,"context_lines":[{"line_number":157,"context_line":"tripleo_nova_compute_DEFAULT_force_config_drive: true"},{"line_number":158,"context_line":"tripleo_nova_compute_DEFAULT_host: \u0027\u0027"},{"line_number":159,"context_line":"tripleo_nova_compute_DEFAULT_log_dir: /var/log/nova"},{"line_number":160,"context_line":"tripleo_nova_compute_DEFAULT_my_ip: \u0027\u0027"},{"line_number":161,"context_line":"tripleo_nova_compute_DEFAULT_preallocate_images: none"},{"line_number":162,"context_line":"tripleo_nova_compute_DEFAULT_report_interval: 10"},{"line_number":163,"context_line":"tripleo_nova_compute_DEFAULT_rootwrap_config: /etc/nova/rootwrap.conf"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"de5fd86c_533ab8e0","line":160,"updated":"2022-08-25 13:52:58.000000000","message":"this should probably default to a variable provided by the inventory. In the inventory, I think we will need the equivalent of net_ip_map from config-download. So, each compute node would have vars for:\n\nctlplane_ip\ninternal_api_ip\nstorage_ip\netc.\n\nThen we\u0027ll also need the equivalent of service_net_map in the inventory.\n\nThen here you could default this to\n{{ service_net_map[\u0027nova_api\u0027] ~ \u0027_ip\u0027 }}\n\nAlternatively, we could have more explicit vars in the inventory:\n\n{{ nova_api_network_ip }}\n\nHowever, that seems like more of a challenge given custom networks, so I prefer using service_net_map I think.\n\nI\u0027ll add some defaults for service_net_map to the sample inventory, and values for the *_ip vars, then I think you could set the default here.","commit_id":"4604b6f788259d8396fd44edf80ee3ecfadcdeb1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c1d2df0fb6fdc323dd7d5b39582a153bc5e20683","unresolved":false,"context_lines":[{"line_number":157,"context_line":"tripleo_nova_compute_DEFAULT_force_config_drive: true"},{"line_number":158,"context_line":"tripleo_nova_compute_DEFAULT_host: \u0027\u0027"},{"line_number":159,"context_line":"tripleo_nova_compute_DEFAULT_log_dir: /var/log/nova"},{"line_number":160,"context_line":"tripleo_nova_compute_DEFAULT_my_ip: \u0027\u0027"},{"line_number":161,"context_line":"tripleo_nova_compute_DEFAULT_preallocate_images: none"},{"line_number":162,"context_line":"tripleo_nova_compute_DEFAULT_report_interval: 10"},{"line_number":163,"context_line":"tripleo_nova_compute_DEFAULT_rootwrap_config: /etc/nova/rootwrap.conf"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"c527b51e_78ff597c","line":160,"in_reply_to":"de5fd86c_533ab8e0","updated":"2022-09-12 12:17:41.000000000","message":"Done","commit_id":"4604b6f788259d8396fd44edf80ee3ecfadcdeb1"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"c1a2045a1e0808e4ac6066ad9b8f7610003d459d","unresolved":true,"context_lines":[{"line_number":188,"context_line":"tripleo_nova_compute_libvirt_inject_key: false"},{"line_number":189,"context_line":"tripleo_nova_compute_libvirt_inject_partition: \u0027-2\u0027"},{"line_number":190,"context_line":"tripleo_nova_compute_libvirt_inject_password: false"},{"line_number":191,"context_line":"tripleo_nova_compute_libvirt_live_migration_inbound_addr: \u0027\u0027"},{"line_number":192,"context_line":"tripleo_nova_compute_libvirt_live_migration_permit_auto_converge: true"},{"line_number":193,"context_line":"tripleo_nova_compute_libvirt_live_migration_permit_post_copy: true"},{"line_number":194,"context_line":"tripleo_nova_compute_libvirt_live_migration_tunnelled: false"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"55bc4c71_e59c82ee","line":191,"updated":"2022-08-25 13:52:58.000000000","message":"same for this one, it should probably be,\n\n{{ \u0027fqdn_\u0027 ~ service_net_map[\u0027tripleo_libvirt_network\u0027] }}","commit_id":"4604b6f788259d8396fd44edf80ee3ecfadcdeb1"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"937b2be80bd34155ccca934ddb2172f0d7b03635","unresolved":false,"context_lines":[{"line_number":188,"context_line":"tripleo_nova_compute_libvirt_inject_key: false"},{"line_number":189,"context_line":"tripleo_nova_compute_libvirt_inject_partition: \u0027-2\u0027"},{"line_number":190,"context_line":"tripleo_nova_compute_libvirt_inject_password: false"},{"line_number":191,"context_line":"tripleo_nova_compute_libvirt_live_migration_inbound_addr: \u0027\u0027"},{"line_number":192,"context_line":"tripleo_nova_compute_libvirt_live_migration_permit_auto_converge: true"},{"line_number":193,"context_line":"tripleo_nova_compute_libvirt_live_migration_permit_post_copy: true"},{"line_number":194,"context_line":"tripleo_nova_compute_libvirt_live_migration_tunnelled: false"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"bf45c4a6_6d8b1a1b","line":191,"in_reply_to":"31abbba4_6932656c","updated":"2022-09-13 13:20:34.000000000","message":"yes, you\u0027re right. it should be service_net_map[\u0027nova_libvirt_network\u0027]\n\ni\u0027ll make the corresponding change to the inventory patch.","commit_id":"4604b6f788259d8396fd44edf80ee3ecfadcdeb1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c1d2df0fb6fdc323dd7d5b39582a153bc5e20683","unresolved":true,"context_lines":[{"line_number":188,"context_line":"tripleo_nova_compute_libvirt_inject_key: false"},{"line_number":189,"context_line":"tripleo_nova_compute_libvirt_inject_partition: \u0027-2\u0027"},{"line_number":190,"context_line":"tripleo_nova_compute_libvirt_inject_password: false"},{"line_number":191,"context_line":"tripleo_nova_compute_libvirt_live_migration_inbound_addr: \u0027\u0027"},{"line_number":192,"context_line":"tripleo_nova_compute_libvirt_live_migration_permit_auto_converge: true"},{"line_number":193,"context_line":"tripleo_nova_compute_libvirt_live_migration_permit_post_copy: true"},{"line_number":194,"context_line":"tripleo_nova_compute_libvirt_live_migration_tunnelled: false"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"99d383c5_97c31e53","line":191,"in_reply_to":"55bc4c71_e59c82ee","updated":"2022-09-12 12:17:41.000000000","message":"this and other ones should become nova_libvirt_network AFAICT, see example group vars https://logserver.rdoproject.org/72/472/04eb1da6efd5ff51d9ea2c086a1c76a0ef46bdb5/github-manual/tripleo-ci-centos-9-containers-multinode/a09307f/logs/undercloud/home/zuul/config-download/overcloud/global_vars.yaml.txt.gz","commit_id":"4604b6f788259d8396fd44edf80ee3ecfadcdeb1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"18fd4412b01f7ad769cf65e38c35c67cee799c93","unresolved":false,"context_lines":[{"line_number":188,"context_line":"tripleo_nova_compute_libvirt_inject_key: false"},{"line_number":189,"context_line":"tripleo_nova_compute_libvirt_inject_partition: \u0027-2\u0027"},{"line_number":190,"context_line":"tripleo_nova_compute_libvirt_inject_password: false"},{"line_number":191,"context_line":"tripleo_nova_compute_libvirt_live_migration_inbound_addr: \u0027\u0027"},{"line_number":192,"context_line":"tripleo_nova_compute_libvirt_live_migration_permit_auto_converge: true"},{"line_number":193,"context_line":"tripleo_nova_compute_libvirt_live_migration_permit_post_copy: true"},{"line_number":194,"context_line":"tripleo_nova_compute_libvirt_live_migration_tunnelled: false"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"31abbba4_6932656c","line":191,"in_reply_to":"99d383c5_97c31e53","updated":"2022-09-12 12:35:46.000000000","message":"Done","commit_id":"4604b6f788259d8396fd44edf80ee3ecfadcdeb1"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"c1a2045a1e0808e4ac6066ad9b8f7610003d459d","unresolved":true,"context_lines":[{"line_number":192,"context_line":"tripleo_nova_compute_libvirt_live_migration_permit_auto_converge: true"},{"line_number":193,"context_line":"tripleo_nova_compute_libvirt_live_migration_permit_post_copy: true"},{"line_number":194,"context_line":"tripleo_nova_compute_libvirt_live_migration_tunnelled: false"},{"line_number":195,"context_line":"tripleo_nova_compute_libvirt_live_migration_uri: \u0027\u0027"},{"line_number":196,"context_line":"tripleo_nova_compute_libvirt_virt_type: qemu"},{"line_number":197,"context_line":"tripleo_nova_compute_neutron_default_floating_pool: public"},{"line_number":198,"context_line":"tripleo_nova_compute_neutron_extension_sync_interval: 600"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"fb8c72e7_970c4821","line":195,"updated":"2022-08-25 13:52:58.000000000","message":"can we just set this one to:\n\nqemu+ssh://nova_migration@%s:2022/system?keyfile\u003d/etc/nova/migration/identity\n\nby default?","commit_id":"4604b6f788259d8396fd44edf80ee3ecfadcdeb1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c1d2df0fb6fdc323dd7d5b39582a153bc5e20683","unresolved":false,"context_lines":[{"line_number":192,"context_line":"tripleo_nova_compute_libvirt_live_migration_permit_auto_converge: true"},{"line_number":193,"context_line":"tripleo_nova_compute_libvirt_live_migration_permit_post_copy: true"},{"line_number":194,"context_line":"tripleo_nova_compute_libvirt_live_migration_tunnelled: false"},{"line_number":195,"context_line":"tripleo_nova_compute_libvirt_live_migration_uri: \u0027\u0027"},{"line_number":196,"context_line":"tripleo_nova_compute_libvirt_virt_type: qemu"},{"line_number":197,"context_line":"tripleo_nova_compute_neutron_default_floating_pool: public"},{"line_number":198,"context_line":"tripleo_nova_compute_neutron_extension_sync_interval: 600"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"23b30092_abb65d72","line":195,"in_reply_to":"fb8c72e7_970c4821","updated":"2022-09-12 12:17:41.000000000","message":"Done","commit_id":"4604b6f788259d8396fd44edf80ee3ecfadcdeb1"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"c1a2045a1e0808e4ac6066ad9b8f7610003d459d","unresolved":true,"context_lines":[{"line_number":216,"context_line":"tripleo_nova_compute_vif_plug_ovs_ovsdb_connection: \u0027\u0027"},{"line_number":217,"context_line":"tripleo_nova_compute_vnc_enabled: true"},{"line_number":218,"context_line":"tripleo_nova_compute_vncproxy_host: \u0027\u0027 # EndpointMap, NovaPublic, host_nobrackets"},{"line_number":219,"context_line":"tripleo_nova_compute_vnc_server_listen: \u0027\u0027"},{"line_number":220,"context_line":"tripleo_nova_compute_vncserver_proxyclient_address: \u0027\u0027 # ServiceNetMap, NovaLibvirt"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"# TODO(bogdando): wire-in into aansible config templates"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"485fd495_7cd452d5","line":219,"updated":"2022-08-25 13:52:58.000000000","message":"{{ service_net_map[\u0027nova_libvirt\u0027] ~ \u0027_ip\u0027 }}","commit_id":"4604b6f788259d8396fd44edf80ee3ecfadcdeb1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c1d2df0fb6fdc323dd7d5b39582a153bc5e20683","unresolved":false,"context_lines":[{"line_number":216,"context_line":"tripleo_nova_compute_vif_plug_ovs_ovsdb_connection: \u0027\u0027"},{"line_number":217,"context_line":"tripleo_nova_compute_vnc_enabled: true"},{"line_number":218,"context_line":"tripleo_nova_compute_vncproxy_host: \u0027\u0027 # EndpointMap, NovaPublic, host_nobrackets"},{"line_number":219,"context_line":"tripleo_nova_compute_vnc_server_listen: \u0027\u0027"},{"line_number":220,"context_line":"tripleo_nova_compute_vncserver_proxyclient_address: \u0027\u0027 # ServiceNetMap, NovaLibvirt"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"# TODO(bogdando): wire-in into aansible config templates"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"1c74fdbd_af81d267","line":219,"in_reply_to":"485fd495_7cd452d5","updated":"2022-09-12 12:17:41.000000000","message":"Done","commit_id":"4604b6f788259d8396fd44edf80ee3ecfadcdeb1"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"c1a2045a1e0808e4ac6066ad9b8f7610003d459d","unresolved":true,"context_lines":[{"line_number":217,"context_line":"tripleo_nova_compute_vnc_enabled: true"},{"line_number":218,"context_line":"tripleo_nova_compute_vncproxy_host: \u0027\u0027 # EndpointMap, NovaPublic, host_nobrackets"},{"line_number":219,"context_line":"tripleo_nova_compute_vnc_server_listen: \u0027\u0027"},{"line_number":220,"context_line":"tripleo_nova_compute_vncserver_proxyclient_address: \u0027\u0027 # ServiceNetMap, NovaLibvirt"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"# TODO(bogdando): wire-in into aansible config templates"},{"line_number":223,"context_line":"# from t-h-t hiera mappings, and/or user-provided config snippets"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"fb546775_e2efbd82","line":220,"updated":"2022-08-25 13:52:58.000000000","message":"same,\n\n{{ service_net_map[\u0027nova_libvirt\u0027] ~ \u0027_ip\u0027 }}","commit_id":"4604b6f788259d8396fd44edf80ee3ecfadcdeb1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c1d2df0fb6fdc323dd7d5b39582a153bc5e20683","unresolved":false,"context_lines":[{"line_number":217,"context_line":"tripleo_nova_compute_vnc_enabled: true"},{"line_number":218,"context_line":"tripleo_nova_compute_vncproxy_host: \u0027\u0027 # EndpointMap, NovaPublic, host_nobrackets"},{"line_number":219,"context_line":"tripleo_nova_compute_vnc_server_listen: \u0027\u0027"},{"line_number":220,"context_line":"tripleo_nova_compute_vncserver_proxyclient_address: \u0027\u0027 # ServiceNetMap, NovaLibvirt"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"# TODO(bogdando): wire-in into aansible config templates"},{"line_number":223,"context_line":"# from t-h-t hiera mappings, and/or user-provided config snippets"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"0a3798a2_eac7459d","line":220,"in_reply_to":"fb546775_e2efbd82","updated":"2022-09-12 12:17:41.000000000","message":"Done","commit_id":"4604b6f788259d8396fd44edf80ee3ecfadcdeb1"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"133cdf98fa89cafbe6a789c419d91e8cfbc47533","unresolved":true,"context_lines":[{"line_number":157,"context_line":"tripleo_nova_compute_DEFAULT_force_config_drive: true"},{"line_number":158,"context_line":"tripleo_nova_compute_DEFAULT_host: \u0027{{ ansible_facts[\"nodename\"] }}\u0027"},{"line_number":159,"context_line":"tripleo_nova_compute_DEFAULT_log_dir: /var/log/nova"},{"line_number":160,"context_line":"tripleo_nova_compute_DEFAULT_my_ip: \u0027{{ hostvars[inventory_hostname][service_net_map[\"nova_api\"] ~ \"_ip\"] }}\u0027"},{"line_number":161,"context_line":"tripleo_nova_compute_DEFAULT_preallocate_images: none"},{"line_number":162,"context_line":"tripleo_nova_compute_DEFAULT_report_interval: 10"},{"line_number":163,"context_line":"tripleo_nova_compute_DEFAULT_rootwrap_config: /etc/nova/rootwrap.conf"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"4cfface6_d019a13a","line":160,"range":{"start_line":160,"start_character":37,"end_line":160,"end_character":109},"updated":"2022-09-15 08:04:35.000000000","message":"It is breaking here.\nHere is the https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_70c/843836/29/check/tripleo-ci-centos-9-singlenode-external-compute-standalone/70c6b3d/logs/undercloud/home/zuul/99-standalone-vars\n\nand\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_70c/843836/29/check/tripleo-ci-centos-9-singlenode-external-compute-standalone/70c6b3d/logs/undercloud/usr/share/ansible/tripleo-inventory/index.html\n\nDo I need to add some here in inventory?","commit_id":"bf7b885600c7e42e3c45541aff914c4eee49099c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4a9870b379211a81234db6b49b754e5e8dc5114f","unresolved":false,"context_lines":[{"line_number":157,"context_line":"tripleo_nova_compute_DEFAULT_force_config_drive: true"},{"line_number":158,"context_line":"tripleo_nova_compute_DEFAULT_host: \u0027{{ ansible_facts[\"nodename\"] }}\u0027"},{"line_number":159,"context_line":"tripleo_nova_compute_DEFAULT_log_dir: /var/log/nova"},{"line_number":160,"context_line":"tripleo_nova_compute_DEFAULT_my_ip: \u0027{{ hostvars[inventory_hostname][service_net_map[\"nova_api\"] ~ \"_ip\"] }}\u0027"},{"line_number":161,"context_line":"tripleo_nova_compute_DEFAULT_preallocate_images: none"},{"line_number":162,"context_line":"tripleo_nova_compute_DEFAULT_report_interval: 10"},{"line_number":163,"context_line":"tripleo_nova_compute_DEFAULT_rootwrap_config: /etc/nova/rootwrap.conf"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"adf56456_2fdb871f","line":160,"range":{"start_line":160,"start_character":37,"end_line":160,"end_character":109},"in_reply_to":"4cfface6_d019a13a","updated":"2022-09-15 12:25:59.000000000","message":"Done","commit_id":"bf7b885600c7e42e3c45541aff914c4eee49099c"}],"tripleo_ansible/roles/tripleo_nova_compute/files/.gitkeep":[{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"57733212629914595a5d2582be65b906728f717b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":43,"id":"ff4ec3a3_541d10c2","updated":"2022-09-27 08:26:51.000000000","message":"Do we need this file?","commit_id":"44671760001115c343639963a4031956be5aafae"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5c0d70701836ee52b690cacae1b0b3bdecf07cd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"d6a3f42a_2880ba32","in_reply_to":"ff4ec3a3_541d10c2","updated":"2022-10-06 13:54:42.000000000","message":"maybe? 😊 this is probably how that skeleton generation works","commit_id":"44671760001115c343639963a4031956be5aafae"}],"tripleo_ansible/roles/tripleo_nova_compute/files/check-run-nova-compute":[{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"57733212629914595a5d2582be65b906728f717b","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    #"},{"line_number":25,"context_line":"    migrations \u003d connection.migrations.list(host\u003dhostname)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    print(\"Checking %d migrations\" % len(migrations))"},{"line_number":28,"context_line":"    for migration in migrations:"},{"line_number":29,"context_line":"        # print migration.to_dict()"},{"line_number":30,"context_line":"        #"}],"source_content_type":"application/octet-stream","patch_set":43,"id":"3edc069a_7af4a3bb","line":27,"updated":"2022-09-27 08:26:51.000000000","message":"We can probably use f-strings here.","commit_id":"44671760001115c343639963a4031956be5aafae"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5c0d70701836ee52b690cacae1b0b3bdecf07cd5","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    #"},{"line_number":25,"context_line":"    migrations \u003d connection.migrations.list(host\u003dhostname)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    print(\"Checking %d migrations\" % len(migrations))"},{"line_number":28,"context_line":"    for migration in migrations:"},{"line_number":29,"context_line":"        # print migration.to_dict()"},{"line_number":30,"context_line":"        #"}],"source_content_type":"application/octet-stream","patch_set":43,"id":"b5d736fd_53cdc81a","line":27,"in_reply_to":"3edc069a_7af4a3bb","updated":"2022-10-06 13:54:42.000000000","message":"curretnly, we simply transfer the scripts like this one as is, from t-h-t. We can refactor it in follow-ups","commit_id":"44671760001115c343639963a4031956be5aafae"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"57733212629914595a5d2582be65b906728f717b","unresolved":true,"context_lines":[{"line_number":127,"context_line":"        except Exception as e:"},{"line_number":128,"context_line":"            logging.warning(\"Nova connection failed. %s: %s\" % (e.__class__.__name__, e))"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    print(\"Couldn\u0027t obtain a supported connection to nova, tried: %s\\n\" % repr(nova_versions))"},{"line_number":131,"context_line":"    return None"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":43,"id":"3c790a21_c6ce266d","line":130,"updated":"2022-09-27 08:26:51.000000000","message":"Same here we can probably start to use f-strings.","commit_id":"44671760001115c343639963a4031956be5aafae"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5c0d70701836ee52b690cacae1b0b3bdecf07cd5","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        except Exception as e:"},{"line_number":128,"context_line":"            logging.warning(\"Nova connection failed. %s: %s\" % (e.__class__.__name__, e))"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    print(\"Couldn\u0027t obtain a supported connection to nova, tried: %s\\n\" % repr(nova_versions))"},{"line_number":131,"context_line":"    return None"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":43,"id":"3ea35272_83bce029","line":130,"in_reply_to":"3c790a21_c6ce266d","updated":"2022-10-06 13:54:42.000000000","message":"curretnly, we simply transfer the scripts like this one as is, from t-h-t. We can refactor it in follow-ups","commit_id":"44671760001115c343639963a4031956be5aafae"}],"tripleo_ansible/roles/tripleo_nova_compute/files/nova_compute.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e60545100096c94d942df954ddc5f0e5f86e5d74","unresolved":true,"context_lines":[{"line_number":1,"context_line":"command: /usr/sbin/httpd"},{"line_number":2,"context_line":"config_files:"},{"line_number":3,"context_line":"  - source: \"/var/lib/kolla/config_files/src/etc/nova_compute/fernet-keys\""},{"line_number":4,"context_line":"    dest: \"/etc/nova_compute/fernet-keys\""},{"line_number":5,"context_line":"    merge: false"},{"line_number":6,"context_line":"    preserve_properties: true"},{"line_number":7,"context_line":"  - source: \"/var/lib/kolla/config_files/src/etc/httpd/conf.d\""},{"line_number":8,"context_line":"    dest: \"/etc/httpd/conf.d\""},{"line_number":9,"context_line":"    merge: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d790edf4_ff7cae96","line":6,"range":{"start_line":3,"start_character":0,"end_line":6,"end_character":29},"updated":"2022-06-02 13:52:11.000000000","message":"you can proably remove this\n\nthis is not part of what we normally include\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/deployment/nova/nova-compute-container-puppet.yaml#L1263-L1313\u003d\n\ninfact this entire file looks like it was copied form keysone and not updated.\n\nthe nova_compute serice does not use httpd at all.","commit_id":"050dd10e263c1abfd4d64f81f9dfff54c33e1e2d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"75f14e80e4a7c1df90aebe3b40559f7cd296f86d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"command: /usr/sbin/httpd"},{"line_number":2,"context_line":"config_files:"},{"line_number":3,"context_line":"  - source: \"/var/lib/kolla/config_files/src/etc/nova_compute/fernet-keys\""},{"line_number":4,"context_line":"    dest: \"/etc/nova_compute/fernet-keys\""},{"line_number":5,"context_line":"    merge: false"},{"line_number":6,"context_line":"    preserve_properties: true"},{"line_number":7,"context_line":"  - source: \"/var/lib/kolla/config_files/src/etc/httpd/conf.d\""},{"line_number":8,"context_line":"    dest: \"/etc/httpd/conf.d\""},{"line_number":9,"context_line":"    merge: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"59c7537a_794d2a5f","line":6,"range":{"start_line":3,"start_character":0,"end_line":6,"end_character":29},"in_reply_to":"71020d77_1105389e","updated":"2022-06-02 15:28:38.000000000","message":"Done","commit_id":"050dd10e263c1abfd4d64f81f9dfff54c33e1e2d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ae65a20f45e1a59f66a22fac200246ccab67bd34","unresolved":true,"context_lines":[{"line_number":1,"context_line":"command: /usr/sbin/httpd"},{"line_number":2,"context_line":"config_files:"},{"line_number":3,"context_line":"  - source: \"/var/lib/kolla/config_files/src/etc/nova_compute/fernet-keys\""},{"line_number":4,"context_line":"    dest: \"/etc/nova_compute/fernet-keys\""},{"line_number":5,"context_line":"    merge: false"},{"line_number":6,"context_line":"    preserve_properties: true"},{"line_number":7,"context_line":"  - source: \"/var/lib/kolla/config_files/src/etc/httpd/conf.d\""},{"line_number":8,"context_line":"    dest: \"/etc/httpd/conf.d\""},{"line_number":9,"context_line":"    merge: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"71020d77_1105389e","line":6,"range":{"start_line":3,"start_character":0,"end_line":6,"end_character":29},"in_reply_to":"d790edf4_ff7cae96","updated":"2022-06-02 14:43:49.000000000","message":"yes, it is still WIP. thank you for keeping an eye on it!","commit_id":"050dd10e263c1abfd4d64f81f9dfff54c33e1e2d"}],"tripleo_ansible/roles/tripleo_nova_compute/files/nova_statedir_ownership.py":[{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"57733212629914595a5d2582be65b906728f717b","unresolved":true,"context_lines":[{"line_number":58,"context_line":"            self.gid,"},{"line_number":59,"context_line":"            self.path,"},{"line_number":60,"context_line":"            \u0027/\u0027 if self.is_dir else \u0027\u0027"},{"line_number":61,"context_line":"        )"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def has_owner(self, uid, gid):"},{"line_number":64,"context_line":"        return self.uid \u003d\u003d uid and self.gid \u003d\u003d gid"}],"source_content_type":"text/x-python","patch_set":43,"id":"91828ab9_f213a3d0","line":61,"updated":"2022-09-27 08:26:51.000000000","message":"We can use f-strings here I think.","commit_id":"44671760001115c343639963a4031956be5aafae"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5c0d70701836ee52b690cacae1b0b3bdecf07cd5","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            self.gid,"},{"line_number":59,"context_line":"            self.path,"},{"line_number":60,"context_line":"            \u0027/\u0027 if self.is_dir else \u0027\u0027"},{"line_number":61,"context_line":"        )"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def has_owner(self, uid, gid):"},{"line_number":64,"context_line":"        return self.uid \u003d\u003d uid and self.gid \u003d\u003d gid"}],"source_content_type":"text/x-python","patch_set":43,"id":"0d1895f5_ab15e48e","line":61,"in_reply_to":"91828ab9_f213a3d0","updated":"2022-10-06 13:54:42.000000000","message":"that\u0027s produced by the roles generator (skeleton?) template, and I think is common for all newly produced standalone roles...","commit_id":"44671760001115c343639963a4031956be5aafae"}],"tripleo_ansible/roles/tripleo_nova_compute/files/tests/test_nova_statedir_ownership.py":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f2234a4e186f6bbfdf5eef29b24894972b32d463","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2018 Red Hat Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"b0720bad_6d837a9c","line":1,"updated":"2022-06-02 14:45:10.000000000","message":"woa, thank you for adding unit tests!","commit_id":"050dd10e263c1abfd4d64f81f9dfff54c33e1e2d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"135c717a0f8c285e4a0a0e8678736e76d371710b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2018 Red Hat Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"64701e23_5b75989c","line":1,"in_reply_to":"b0720bad_6d837a9c","updated":"2022-06-02 16:57:49.000000000","message":"Done","commit_id":"050dd10e263c1abfd4d64f81f9dfff54c33e1e2d"}],"tripleo_ansible/roles/tripleo_nova_compute/meta/main.yml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"af944675cd69e9fd699971c965a8de01005c531a","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    - name: CentOS"},{"line_number":33,"context_line":"      versions:"},{"line_number":34,"context_line":"        - 7"},{"line_number":35,"context_line":"        - 8"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  galaxy_tags:"},{"line_number":38,"context_line":"    - tripleo"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3cd14157_bdfe40fa","line":35,"updated":"2022-06-01 11:52:31.000000000","message":"you shoudl drop 7 and add 9","commit_id":"d6ee5d5885441b065107e70798781372c5e97c04"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3aad0b3b17de7c2cf6c30b7110ad9e4139aab820","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    - name: CentOS"},{"line_number":33,"context_line":"      versions:"},{"line_number":34,"context_line":"        - 7"},{"line_number":35,"context_line":"        - 8"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  galaxy_tags:"},{"line_number":38,"context_line":"    - tripleo"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bdda020a_daae9ad6","line":35,"in_reply_to":"3cd14157_bdfe40fa","updated":"2022-06-01 13:23:29.000000000","message":"right, but all that is mostly boilerplated","commit_id":"d6ee5d5885441b065107e70798781372c5e97c04"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"052f585eda79cac582da20925992ede9842c90ad","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    - name: CentOS"},{"line_number":33,"context_line":"      versions:"},{"line_number":34,"context_line":"        - 7"},{"line_number":35,"context_line":"        - 8"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  galaxy_tags:"},{"line_number":38,"context_line":"    - tripleo"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c4d7a57b_985d8989","line":35,"in_reply_to":"bdda020a_daae9ad6","updated":"2022-06-03 13:28:18.000000000","message":"https://review.opendev.org/c/openstack/tripleo-ansible/+/841794 will address that after a rebase","commit_id":"d6ee5d5885441b065107e70798781372c5e97c04"}],"tripleo_ansible/roles/tripleo_nova_compute/molecule/default/molecule.yml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"af944675cd69e9fd699971c965a8de01005c531a","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  name: podman"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"provisioner:"},{"line_number":6,"context_line":"  inventory:"},{"line_number":7,"context_line":"    hosts:"},{"line_number":8,"context_line":"      all:"},{"line_number":9,"context_line":"        hosts:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fcea3084_48e123a6","line":6,"updated":"2022-06-01 11:52:31.000000000","message":"were are you specifying the podman image to use as a base for testing?","commit_id":"d6ee5d5885441b065107e70798781372c5e97c04"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7b97c7c4a01a246c9a187bef7fa44b0c50fde96f","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  name: podman"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"provisioner:"},{"line_number":6,"context_line":"  inventory:"},{"line_number":7,"context_line":"    hosts:"},{"line_number":8,"context_line":"      all:"},{"line_number":9,"context_line":"        hosts:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a5b5be04_1a2d28bd","line":6,"in_reply_to":"8235c260_e22fc44b","updated":"2022-08-03 11:57:52.000000000","message":"molecule testing is something left TBD","commit_id":"d6ee5d5885441b065107e70798781372c5e97c04"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3ab9b6e6c0a666f7070285b2ab783d0d312e23a2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  name: podman"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"provisioner:"},{"line_number":6,"context_line":"  inventory:"},{"line_number":7,"context_line":"    hosts:"},{"line_number":8,"context_line":"      all:"},{"line_number":9,"context_line":"        hosts:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6752d55a_2e4acaa5","line":6,"in_reply_to":"a5b5be04_1a2d28bd","updated":"2022-08-04 11:55:53.000000000","message":"here is an example run https://d61baeaf4d9f7d3428f3-dc70ab9394959c53b3693d5e7d60f03a.ssl.cf5.rackcdn.com/852027/2/check/tripleo-ansible-centos-stream-molecule-tripleo_nova_compute/edb6c90/reports.html\n\nthe image used was ubi9/ubi-init\n\nnote that the coverage is just a few tasks yet: setting facts for conditions and gathering OS vars","commit_id":"d6ee5d5885441b065107e70798781372c5e97c04"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"18198d0159e0836e9c1de25c5459b5480df6e2d2","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  name: podman"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"provisioner:"},{"line_number":6,"context_line":"  inventory:"},{"line_number":7,"context_line":"    hosts:"},{"line_number":8,"context_line":"      all:"},{"line_number":9,"context_line":"        hosts:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8235c260_e22fc44b","line":6,"in_reply_to":"fcea3084_48e123a6","updated":"2022-06-01 13:24:02.000000000","message":"that\u0027s a good question for James perhaps :)","commit_id":"d6ee5d5885441b065107e70798781372c5e97c04"}],"tripleo_ansible/roles/tripleo_nova_compute/tasks/configure.yml":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"133cdf98fa89cafbe6a789c419d91e8cfbc47533","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        - copy_config_files.rc !\u003d 0"},{"line_number":108,"context_line":"      failed_when: true"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    - name: Configure nova.conf"},{"line_number":111,"context_line":"      ini_file:"},{"line_number":112,"context_line":"        path: \"{{ tripleo_nova_compute_config_dir }}/etc/nova/nova.conf\""},{"line_number":113,"context_line":"        section: \"{{ item.section }}\""}],"source_content_type":"text/x-yaml","patch_set":41,"id":"c5e5c664_183ebbe3","line":110,"range":{"start_line":110,"start_character":4,"end_line":110,"end_character":31},"updated":"2022-09-15 08:04:35.000000000","message":"While testing this series https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_70c/843836/29/check/tripleo-ci-centos-9-singlenode-external-compute-standalone/70c6b3d/logs/undercloud/home/zuul/overcloud_compute.log\n\n```\nTASK [tripleo_nova_compute : Configure nova.conf] ******************************\nfatal: [localhost]: FAILED! \u003d\u003e {\"msg\": \"{% set _nova_conf \u003d [] %}\\n{% for section, options in (tripleo_nova_compute_config | combine(tripleo_nova_compute_config_overrides, recursive\u003dTrue)).items() %}\\n{% for option, value in options.items() %}\\n{% set _ \u003d _nova_conf.append({\u0027section\u0027: section, \u0027option\u0027: option, \u0027value\u0027: value}) %}\\n{% endfor %}\\n{% endfor %}\\n{{ _nova_conf }}\\n: {\u0027DEFAULT\u0027: {\u0027compute_driver\u0027: \u0027{{ tripleo_nova_compute_DEFAULT_compute_driver }}\u0027, \u0027cpu_allocation_ratio\u0027: \u0027{{ tripleo_nova_compute_cpu_allocation_ratio }}\u0027, \u0027debug\u0027: \u0027{{ tripleo_nova_compute_debug }}\u0027, \u0027dhcp_domain\u0027: \u0027{{ tripleo_nova_compute_DEFAULT_dhcp_domain }}\u0027, \u0027disk_allocation_ratio\u0027: \u0027{{ tripleo_nova_compute_disk_allocation_ratio }}\u0027, \u0027force_config_drive\u0027: \u0027{{ tripleo_nova_compute_DEFAULT_force_config_drive }}\u0027, \u0027force_raw_images\u0027: \u0027{{ tripleo_nova_compute_force_raw_images }}\u0027, \u0027host\u0027: \u0027{{ tripleo_nova_compute_DEFAULT_host }}\u0027, \u0027log_dir\u0027: \u0027{{ tripleo_nova_compute_DEFAULT_log_dir }}\u0027, \u0027mkisofs_cmd\u0027: \u0027{{ tripleo_nova_compute_mkisofs_cmd }}\u0027, \u0027my_ip\u0027: \u0027{{ tripleo_nova_compute_DEFAULT_my_ip }}\u0027, \u0027preallocate_images\u0027: \u0027{{ tripleo_nova_compute_DEFAULT_preallocate_images }}\u0027, \u0027ram_allocation_ratio\u0027: \u0027{{ tripleo_nova_compute_ram_allocation_ratio }}\u0027, \u0027report_interval\u0027: \u0027{{ tripleo_nova_compute_DEFAULT_report_interval }}\u0027, \u0027reserved_host_memory_mb\u0027: \u0027{{ tripleo_nova_compute_reserved_host_memory }}\u0027, \u0027resume_guests_state_on_host_boot\u0027: \u0027{{ tripleo_nova_compute_resume_guests_state_on_host_boot }}\u0027, \u0027rootwrap_config\u0027: \u0027{{ tripleo_nova_compute_DEFAULT_rootwrap_config }}\u0027, \u0027rpc_response_timeout\u0027: \u0027{{ tripleo_nova_compute_DEFAULT_rpc_response_timeout }}\u0027, \u0027service_down_time\u0027: \u0027{{ tripleo_nova_compute_DEFAULT_service_down_time }}\u0027, \u0027ssl_only\u0027: \u0027{{ tripleo_nova_compute_DEFAULT_ssl_only }}\u0027, \u0027state_path\u0027: \u0027{{ tripleo_nova_compute_DEFAULT_state_path }}\u0027, \u0027sync_power_state_interval\u0027: \u0027{{ tripleo_nova_compute_DEFAULT_sync_power_state_interval }}\u0027, \u0027transport_url\u0027: \u0027{{ tripleo_nova_compute_DEFAULT_transport_url }}\u0027, \u0027use_cow_images\u0027: \u0027{{ tripleo_nova_compute_use_cow_images }}\u0027, \u0027vif_plugging_is_fatal\u0027: \u0027{{ tripleo_nova_compute_DEFAULT_vif_plugging_is_fatal }}\u0027, \u0027vif_plugging_timeout\u0027: \u0027{{ tripleo_nova_compute_DEFAULT_vif_plugging_timeout }}\u0027}, \u0027cinder\u0027: {\u0027auth_type\u0027: \u0027{{ tripleo_nova_compute_cinder_auth_type }}\u0027, \u0027auth_url\u0027: \u0027{{ tripleo_nova_compute_cinder_auth_url }}\u0027, \u0027catalog_info\u0027: \u0027{{ tripleo_nova_compute_cinder_catalog_info }}\u0027, \u0027cross_az_attach\u0027: \u0027{{ tripleo_nova_compute_cross_az_attach }}\u0027, \u0027os_region_name\u0027: \u0027{{ tripleo_nova_compute_keystone_region }}\u0027, \u0027password\u0027: \u0027{{ tripleo_nova_compute_cinder_password }}\u0027, \u0027project_domain_name\u0027: \u0027{{ tripleo_nova_compute_cinder_project_domain_name }}\u0027, \u0027project_name\u0027: \u0027{{ tripleo_nova_compute_cinder_project_name }}\u0027, \u0027user_domain_name\u0027: \u0027{{ tripleo_nova_compute_cinder_user_domain_name }}\u0027, \u0027username\u0027: \u0027{{ tripleo_nova_compute_cinder_username }}\u0027}, \u0027compute\u0027: {\u0027consecutive_build_service_disable_threshold\u0027: \u0027{{ tripleo_nova_compute_compute_consecutive_build_service_disable_threshold }}\u0027, \u0027cpu_dedicated_set\u0027: \u0027{{ tripleo_nova_compute_compute_cpu_dedicated_set }}\u0027, \u0027cpu_shared_set\u0027: \u0027{{ tripleo_nova_compute_compute_cpu_shared_set }}\u0027, \u0027live_migration_wait_for_vif_plug\u0027: \u0027{{ tripleo_nova_compute_compute_live_migration_wait_for_vif_plug }}\u0027, \u0027max_disk_devices_to_attach\u0027: \u0027{{ tripleo_nova_compute_compute_max_disk_devices_to_attach }}\u0027, \u0027provider_config_location\u0027: \u0027{{ tripleo_nova_compute_compute_provider_config_location }}\u0027}, \u0027image_cache\u0027: {\u0027manager_interval\u0027: \u0027{{ tripleo_nova_compute_image_cache_manager_interval }}\u0027, \u0027precache_concurrency\u0027: \u0027{{ tripleo_nova_compute_image_cache_precache_concurrency }}\u0027, \u0027remove_unused_base_images\u0027: \u0027{{ tripleo_nova_compute_image_cache_remove_unused_base_images }}\u0027, \u0027remove_unused_original_minimum_age_seconds\u0027: \u0027{{ tripleo_nova_compute_image_cache_ttl }}\u0027, \u0027remove_unused_resized_minimum_age_seconds\u0027: \u0027{{ tripleo_nova_compute_image_cache_remove_unused_resized_minimum_age }}\u0027}, \u0027key_manager\u0027: {\u0027backend\u0027: \u0027{{ tripleo_nova_compute_key_manager_backend }}\u0027}, \u0027libvirt\u0027: {\u0027cpu_mode\u0027: \u0027{{ tripleo_nova_compute_cpu_mode }}\u0027, \u0027cpu_model_extra_flags\u0027: \u0027{{ tripleo_nova_compute_cpu_model_extra_flags }}\u0027, \u0027enabled_perf_events\u0027: \u0027{{ tripleo_nova_compute_libvirt_enabled_perf_events }}\u0027, \u0027file_backed_memory\u0027: \u0027{{ tripleo_nova_compute_file_backed_memory }}\u0027, \u0027hw_machine_type\u0027: \u0027{{ tripleo_nova_compute_hw_machine_type }}\u0027, \u0027inject_key\u0027: \u0027{{ tripleo_nova_compute_libvirt_inject_key }}\u0027, \u0027inject_partition\u0027: \u0027{{ tripleo_nova_compute_libvirt_inject_partition }}\u0027, \u0027inject_password\u0027: \u0027{{ tripleo_nova_compute_libvirt_inject_password }}\u0027, \u0027live_migration_inbound_addr\u0027: \u0027{{ tripleo_nova_compute_libvirt_live_migration_inbound_addr }}\u0027, \u0027live_migration_permit_auto_converge\u0027: \u0027{{ tripleo_nova_compute_libvirt_live_migration_permit_auto_converge }}\u0027, \u0027live_migration_permit_post_copy\u0027: \u0027{{ tripleo_nova_compute_libvirt_live_migration_permit_post_copy }}\u0027, \u0027live_migration_tunnelled\u0027: \u0027{{ tripleo_nova_compute_libvirt_live_migration_tunnelled }}\u0027, \u0027live_migration_uri\u0027: \u0027{{ tripleo_nova_compute_libvirt_live_migration_uri }}\u0027, \u0027mem_stats_period_seconds\u0027: \u0027{{ tripleo_nova_compute_mem_stats_period_seconds }}\u0027, \u0027num_pcie_ports\u0027: \u0027{{ tripleo_nova_compute_num_pcie_ports }}\u0027, \u0027pmem_namespaces\u0027: \u0027{{ tripleo_nova_compute_pmem_mappings }}\u0027, \u0027rx_queue_size\u0027: \u0027{{ tripleo_nova_compute_rx_queue_size }}\u0027, \u0027swtpm_enabled\u0027: \u0027{{ tripleo_nova_compute_enable_vtpm }}\u0027, \u0027tx_queue_size\u0027: \u0027{{ tripleo_nova_compute_tx_queue_size }}\u0027, \u0027virt_type\u0027: \u0027{{ tripleo_nova_compute_libvirt_virt_type }}\u0027, \u0027volume_use_multipath\u0027: \u0027{{ tripleo_nova_compute_volume_use_multipath }}\u0027}, \u0027neutron\u0027: {\u0027default_floating_pool\u0027: \u0027{{ tripleo_nova_compute_neutron_default_floating_pool }}\u0027, \u0027extension_sync_interval\u0027: \u0027{{ tripleo_nova_compute_neutron_extension_sync_interval }}\u0027, \u0027ovs_bridge\u0027: \u0027{{ tripleo_nova_compute_neutron_ovs_bridge }}\u0027, \u0027timeout\u0027: \u0027{{ tripleo_nova_compute_neutron_timeout }}\u0027, \u0027valid_interfaces\u0027: \u0027{{ tripleo_nova_compute_neutron_valid_interfaces }}\u0027}, \u0027notifications\u0027: {\u0027notification_format\u0027: \u0027{{ tripleo_nova_compute_notifications_notification_format }}\u0027, \u0027notify_on_state_change\u0027: \u0027{{ tripleo_nova_compute_notifications_notify_on_state_change }}\u0027}, \u0027oslo_concurrency\u0027: {\u0027lock_path\u0027: \u0027{{ tripleo_nova_compute_oslo_concurrency_lock_path }}\u0027}, \u0027oslo_messaging_notifications\u0027: {\u0027driver\u0027: \u0027{{ tripleo_nova_compute_oslo_messaging_notifications_driver }}\u0027, \u0027transport_url\u0027: \u0027{{ tripleo_nova_compute_oslo_messaging_notifications_transport_url }}\u0027}, \u0027oslo_messaging_rabbit\u0027: {\u0027heartbeat_timeout_threshold\u0027: \u0027{{ tripleo_nova_compute_oslo_messaging_rabbit_heartbeat_timeout_threshold }}\u0027, \u0027ssl\u0027: \u0027{{ tripleo_nova_compute_oslo_messaging_rabbit_ssl }}\u0027}, \u0027oslo_policy\u0027: {\u0027enforce_new_defaults\u0027: \u0027{{ tripleo_nova_compute_oslo_policy_enforce_new_defaults }}\u0027, \u0027enforce_scope\u0027: \u0027{{ tripleo_nova_compute_oslo_policy_enforce_scope }}\u0027, \u0027policy_file\u0027: \u0027{{ tripleo_nova_compute_oslo_policy_policy_file }}\u0027}, \u0027spice\u0027: {\u0027enabled\u0027: \u0027{{ tripleo_nova_compute_spice_enabled }}\u0027}, \u0027vendordata_dynamic_auth\u0027: {\u0027project_domain_name\u0027: \u0027{{ tripleo_nova_compute_vendordata_dynamic_auth_project_domain_name }}\u0027, \u0027user_domain_name\u0027: \u0027{{ tripleo_nova_compute_vendordata_dynamic_auth_user_domain_name }}\u0027}, \u0027vif_plug_ovs\u0027: {\u0027ovsdb_connection\u0027: \u0027{{ tripleo_nova_compute_vif_plug_ovs_ovsdb_connection }}\u0027}, \u0027vnc\u0027: {\u0027enabled\u0027: \u0027{{ tripleo_nova_compute_vnc_enabled }}\u0027, \u0027novncproxy_base_url\u0027: \u0027{{ tripleo_nova_compute_vncproxy_host }}\u0027, \u0027server_listen\u0027: \u0027{{ tripleo_nova_compute_vnc_server_listen }}\u0027, \u0027server_proxyclient_address\u0027: \u0027{{ tripleo_nova_compute_vncserver_proxyclient_address }}\u0027}, \u0027workarounds\u0027: {\u0027disable_compute_service_check_for_ffu\u0027: \u0027{{ tripleo_nova_compute_disable_compute_service_check_for_ffu }}\u0027, \u0027never_download_image_if_on_rbd\u0027: \u0027{{ tripleo_nova_compute_disable_image_download_to_rbd }}\u0027}}: {{ hostvars[inventory_hostname][service_net_map[\\\"nova_api\\\"] ~ \\\"_ip\\\"] }}: \u0027dict object\u0027 has no attribute \u0027nova_api\u0027\"}\n```","commit_id":"bf7b885600c7e42e3c45541aff914c4eee49099c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4a9870b379211a81234db6b49b754e5e8dc5114f","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        - copy_config_files.rc !\u003d 0"},{"line_number":108,"context_line":"      failed_when: true"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    - name: Configure nova.conf"},{"line_number":111,"context_line":"      ini_file:"},{"line_number":112,"context_line":"        path: \"{{ tripleo_nova_compute_config_dir }}/etc/nova/nova.conf\""},{"line_number":113,"context_line":"        section: \"{{ item.section }}\""}],"source_content_type":"text/x-yaml","patch_set":41,"id":"2a0344ce_0d17ce48","line":110,"range":{"start_line":110,"start_character":4,"end_line":110,"end_character":31},"in_reply_to":"c5e5c664_183ebbe3","updated":"2022-09-15 12:25:59.000000000","message":"Done","commit_id":"bf7b885600c7e42e3c45541aff914c4eee49099c"}],"tripleo_ansible/roles/tripleo_nova_compute/templates/kolla_config/nova_compute.yaml.j2":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"6044e0cb0cfc3acb228cb56af5a3c3b1631f1937","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    dest: \"/\""},{"line_number":12,"context_line":"    merge: true"},{"line_number":13,"context_line":"    preserve_properties: true"},{"line_number":14,"context_line":"  - source: \"/var/lib/kolla/config_files/src-iscsid/*\""},{"line_number":15,"context_line":"    dest: \"/etc/iscsi/\""},{"line_number":16,"context_line":"    merge: true"},{"line_number":17,"context_line":"    preserve_properties: true"}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"f7f428cc_ab92de5d","line":14,"range":{"start_line":14,"start_character":52,"end_line":14,"end_character":53},"updated":"2022-10-05 16:37:30.000000000","message":"Can this * be removed?\n\nEven with the following patch:\n\n  https://review.opendev.org/c/openstack/tripleo-ansible/+/860472\n\nMy nova_compute container exits with:\n\nERROR:__main__:MissingRequiredSource: /var/lib/kolla/config_files/src-iscsid/* file is not found\n\nHowever, removing the * is not sufficient either. I need both to remove the * here and use patch 860472 (to create the directory \"src-iscsid\") in order for the nova_compute container to not exit.\n\nI assume that if /var/lib/kolla/config_files/src-iscsid is populated, then when its contents are mounted that they\u0027ll be available and that the * is not necessary.","commit_id":"7ea774138423a0b20e9480260ef4b3bcd1d51c30"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5c0d70701836ee52b690cacae1b0b3bdecf07cd5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    dest: \"/\""},{"line_number":12,"context_line":"    merge: true"},{"line_number":13,"context_line":"    preserve_properties: true"},{"line_number":14,"context_line":"  - source: \"/var/lib/kolla/config_files/src-iscsid/*\""},{"line_number":15,"context_line":"    dest: \"/etc/iscsi/\""},{"line_number":16,"context_line":"    merge: true"},{"line_number":17,"context_line":"    preserve_properties: true"}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"adb38d2f_91788e3f","line":14,"range":{"start_line":14,"start_character":52,"end_line":14,"end_character":53},"in_reply_to":"78407dc2_c1775990","updated":"2022-10-06 13:54:42.000000000","message":"Done","commit_id":"7ea774138423a0b20e9480260ef4b3bcd1d51c30"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"1ddeb1e8c75ce00d21ef98d605b11b4340fb8eea","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    dest: \"/\""},{"line_number":12,"context_line":"    merge: true"},{"line_number":13,"context_line":"    preserve_properties: true"},{"line_number":14,"context_line":"  - source: \"/var/lib/kolla/config_files/src-iscsid/*\""},{"line_number":15,"context_line":"    dest: \"/etc/iscsi/\""},{"line_number":16,"context_line":"    merge: true"},{"line_number":17,"context_line":"    preserve_properties: true"}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"335eeb94_e8c0f2be","line":14,"range":{"start_line":14,"start_character":52,"end_line":14,"end_character":53},"in_reply_to":"f7f428cc_ab92de5d","updated":"2022-10-06 13:56:29.000000000","message":"\u003e However, removing the * is not sufficient either. I need both to remove the * here and use patch 860472\n\nThe above is not the right fix however. I got some feedback from slagle:\n\n- /var/lib/kolla/config_files/src-iscsid/ is not to be created on the host\n- the \"source\" is telling kolla-start where to read from inside the container\n- /var/lib/kolla/config_files on the host is for the kolla configuration files\n- short term fix is probably to comment out that whole key for now (lines 14-17)\n- long term fix is to make iscsid role actually generate a config file. then we could leave the glob, which is what we want\n\nThanks for commenting out lines 14-17 in PS46.","commit_id":"7ea774138423a0b20e9480260ef4b3bcd1d51c30"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"c9f0b05543c72d99a164670bd97a9cf55a8ccfd1","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    dest: \"/\""},{"line_number":12,"context_line":"    merge: true"},{"line_number":13,"context_line":"    preserve_properties: true"},{"line_number":14,"context_line":"  - source: \"/var/lib/kolla/config_files/src-iscsid/*\""},{"line_number":15,"context_line":"    dest: \"/etc/iscsi/\""},{"line_number":16,"context_line":"    merge: true"},{"line_number":17,"context_line":"    preserve_properties: true"}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"78407dc2_c1775990","line":14,"range":{"start_line":14,"start_character":52,"end_line":14,"end_character":53},"in_reply_to":"f7f428cc_ab92de5d","updated":"2022-10-06 13:31:00.000000000","message":"i commented it out for now.","commit_id":"7ea774138423a0b20e9480260ef4b3bcd1d51c30"}],"tripleo_ansible/roles/tripleo_nova_compute/templates/nova_compute.yaml.j2":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2c1e1a441dac6fed07b2045694905aa5511fcee3","unresolved":true,"context_lines":[{"line_number":3,"context_line":"net: host"},{"line_number":4,"context_line":"privileged: false"},{"line_number":5,"context_line":"restart: always"},{"line_number":6,"context_line":"healthcheck:"},{"line_number":7,"context_line":"  test: /openstack/healthcheck"},{"line_number":8,"context_line":"volumes:"},{"line_number":9,"context_line":"  {% set nova_compute_volumes \u003d [] %}"},{"line_number":10,"context_line":"  {%- set nova_compute_volumes \u003d"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"0b033ef7_fe4f341f","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":30},"updated":"2022-06-02 13:54:32.000000000","message":"is this a healthcheck that ooo is adding\n\nnova_compute does not support heatchecks itslef currently and the upstream nova project recomemnd agaisnt using the keystone middelway for the api process.\nnova compute woudl not use the midelware in anycase sicne it does not have a rest api.","commit_id":"050dd10e263c1abfd4d64f81f9dfff54c33e1e2d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"75f14e80e4a7c1df90aebe3b40559f7cd296f86d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"net: host"},{"line_number":4,"context_line":"privileged: false"},{"line_number":5,"context_line":"restart: always"},{"line_number":6,"context_line":"healthcheck:"},{"line_number":7,"context_line":"  test: /openstack/healthcheck"},{"line_number":8,"context_line":"volumes:"},{"line_number":9,"context_line":"  {% set nova_compute_volumes \u003d [] %}"},{"line_number":10,"context_line":"  {%- set nova_compute_volumes \u003d"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"89b45a0e_38c49736","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":30},"in_reply_to":"0b033ef7_fe4f341f","updated":"2022-06-02 15:28:38.000000000","message":"Done","commit_id":"050dd10e263c1abfd4d64f81f9dfff54c33e1e2d"}],"tripleo_ansible/roles/tripleo_nova_compute/vars/main.yml":[{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"57733212629914595a5d2582be65b906728f717b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":43,"id":"1c433dfa_bc6be0f7","line":23,"updated":"2022-09-27 08:26:51.000000000","message":"Do we need to have this file if we don\u0027t use it to declare variables?","commit_id":"44671760001115c343639963a4031956be5aafae"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5c0d70701836ee52b690cacae1b0b3bdecf07cd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"dda41858_f66ea49a","line":23,"in_reply_to":"1c433dfa_bc6be0f7","updated":"2022-10-06 13:54:42.000000000","message":"that\u0027s produced by the roles generator (skeleton?) template, and I think is common for all newly produced standalone roles...","commit_id":"44671760001115c343639963a4031956be5aafae"}],"zuul.d/molecule.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"1ddeb1e8c75ce00d21ef98d605b11b4340fb8eea","unresolved":true,"context_lines":[{"line_number":53,"context_line":"      - tripleo-ansible-centos-stream-molecule-tripleo_nodes_validation"},{"line_number":54,"context_line":"      - tripleo-ansible-centos-stream-molecule-tripleo_nova_image_cache"},{"line_number":55,"context_line":"      - tripleo-ansible-centos-stream-molecule-tripleo_nova_libvirt"},{"line_number":56,"context_line":"      - tripleo-ansible-centos-stream-molecule-tripleo_nova_compute"},{"line_number":57,"context_line":"      - tripleo-ansible-centos-stream-molecule-tripleo_nvdimm"},{"line_number":58,"context_line":"      - tripleo-ansible-centos-stream-molecule-tripleo_ovn_cluster"},{"line_number":59,"context_line":"      - tripleo-ansible-centos-stream-molecule-tripleo_ovs_dpdk"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"b81ea6a4_11f9e14e","line":56,"updated":"2022-10-06 13:56:29.000000000","message":"molecule test working:\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_7f5/843659/45/check/tripleo-ansible-centos-stream-molecule-tripleo_container_standalone/7f5210a/reports.html","commit_id":"1917e9e192f4205587f6f60c28483f8a8c29819a"}]}