)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"7e4cf20d2167de98f309f3df2aaf29bcc94e45d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"510ed0ce_03ffb57a","updated":"2022-06-30 15:47:10.000000000","message":"Gateway setting needs clarification","commit_id":"4a8896e851da0cf66f18dab8464f982ffa6ce054"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"c996152fc548810d2abdf9630fe56d2c75cf9a0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"c7a9d10e_6291c3d4","updated":"2022-09-30 12:16:59.000000000","message":"LGTM","commit_id":"15fae468527bf56f3f540dfe50744ad5918fdc43"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"13783cad9009a459d38d0ed78f0045fca8df137c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ca8e1ab7_3aa3323d","updated":"2022-09-28 07:26:59.000000000","message":"Needs a bit more testing","commit_id":"15fae468527bf56f3f540dfe50744ad5918fdc43"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"895251e72b3ca9f8e56188a1185143e1c6ef3ba8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"96863666_dbcf405c","updated":"2022-09-30 13:08:17.000000000","message":"Ready for review.","commit_id":"15fae468527bf56f3f540dfe50744ad5918fdc43"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"eca3553718e526a9015c517424a55b8706300826","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"f2db7479_15c4d77a","updated":"2023-01-12 15:37:17.000000000","message":"recheck ERROR! Unknown error when attempting to call Galaxy at \u0027https://galaxy.ansible.com/api/v2/collections/containers/podman/versions/1.0.0/\u0027: The read operation timed out","commit_id":"8a82487a64fd8ce45a08711feb72d98d0b4f46b0"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"c672b5497cb2dad6bf6dd8e355e42e241d63ba53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1fff0a47_785c600c","updated":"2023-01-31 14:37:14.000000000","message":"I think the case I was thinking about is not very probable, so looks good to me","commit_id":"f4ed39060ed4ed5734705e3263d9fa78855f487a"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"c4c92d915c0c6daaf301a8bbf41f8d5cd9babcb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"dbc9f532_f93493fd","updated":"2023-02-01 13:03:06.000000000","message":"recheck The read operation timed out","commit_id":"f4ed39060ed4ed5734705e3263d9fa78855f487a"}],"tripleo_ansible/roles/octavia_overcloud_config/tasks/network.yml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"110c7658dbe0d22627276b1d724f30a5eca42bc7","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    if [[ $(openstack subnet show {{ lb_mgmt_subnet_name }} \u003e /dev/null; echo $?) -eq 1 ]]; then"},{"line_number":40,"context_line":"      openstack subnet create {{ lb_mgmt_subnet_name }} \\"},{"line_number":41,"context_line":"        --allocation-pool\u003dstart\u003d{{ lb_mgmt_subnet_pool_start }},end\u003d{{ lb_mgmt_subnet_pool_end }} \\"},{"line_number":42,"context_line":"        --gateway {{ lb_mgmt_subnet_gateway }} \\"},{"line_number":43,"context_line":"        --ip-version 6 --ipv6-address-mode slaac --ipv6-ra-mode slaac \\"},{"line_number":44,"context_line":"        --network {{ lb_mgmt_net_id }} \\"},{"line_number":45,"context_line":"        --subnet-range {{ lb_mgmt_subnet_cidr }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"52be123a_22bf1ade","line":42,"updated":"2022-06-30 15:47:12.000000000","message":"I don\u0027t think this gateway is valid.\nThis configuration isn\u0027t a routed topology, so a gateway should not be necessary. Also, the gateway address will not be known until the router is created below, and that router create is not specifying an address.","commit_id":"4a8896e851da0cf66f18dab8464f982ffa6ce054"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"ef92e0c88e1f6f367e6e41668da23673f97658a0","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    if [[ $(openstack subnet show {{ lb_mgmt_subnet_name }} \u003e /dev/null; echo $?) -eq 1 ]]; then"},{"line_number":40,"context_line":"      openstack subnet create {{ lb_mgmt_subnet_name }} \\"},{"line_number":41,"context_line":"        --allocation-pool\u003dstart\u003d{{ lb_mgmt_subnet_pool_start }},end\u003d{{ lb_mgmt_subnet_pool_end }} \\"},{"line_number":42,"context_line":"        --gateway {{ lb_mgmt_subnet_gateway }} \\"},{"line_number":43,"context_line":"        --ip-version 6 --ipv6-address-mode slaac --ipv6-ra-mode slaac \\"},{"line_number":44,"context_line":"        --network {{ lb_mgmt_net_id }} \\"},{"line_number":45,"context_line":"        --subnet-range {{ lb_mgmt_subnet_cidr }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"f33dbf47_9fdb4831","line":42,"in_reply_to":"52be123a_22bf1ade","updated":"2022-07-04 10:57:30.000000000","message":"Doing \"--gateway none\" as done above doesn\u0027t work. It fails with:\n\n\"No Subnet found for lb-mgmt-subnet BadRequestException: 400: Client Error for url: http://192.168.122.2:9696/v2.0/routers/5b577aae-a65a-4745-9258-a71cd973b13c/add_router_interface, Bad router request: Subnet for router interface must have a gateway IP.\"\n\nHowever, it works if leave \"--gateway\" away. In that case the router port IP becomes the gateway for the amphorae.","commit_id":"4a8896e851da0cf66f18dab8464f982ffa6ce054"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"01defb0c2daebf22f5ed6a1dd1030ad541609294","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    set -o pipefail"},{"line_number":39,"context_line":"    if [[ $(openstack subnet show {{ lb_mgmt_subnet_name }} \u003e /dev/null; echo $?) -eq 1 ]]; then"},{"line_number":40,"context_line":"      openstack subnet create {{ lb_mgmt_subnet_name }} \\"},{"line_number":41,"context_line":"        --allocation-pool\u003dstart\u003d{{ lb_mgmt_subnet_pool_start }},end\u003d{{ lb_mgmt_subnet_pool_end }} \\"},{"line_number":42,"context_line":"        --ip-version 6 --ipv6-address-mode slaac --ipv6-ra-mode slaac \\"},{"line_number":43,"context_line":"        --network {{ lb_mgmt_net_id }} \\"},{"line_number":44,"context_line":"        --subnet-range {{ lb_mgmt_subnet_cidr }}"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"4d0c6175_180a4cc3","line":41,"range":{"start_line":41,"start_character":35,"end_line":41,"end_character":60},"updated":"2023-01-31 13:59:18.000000000","message":"As far as I understand, the default values of both lb_mgmt_subnet_pool_start and lb_mgmt_subnet_pool_end can be only ipv4 values.","commit_id":"f4ed39060ed4ed5734705e3263d9fa78855f487a"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"01defb0c2daebf22f5ed6a1dd1030ad541609294","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        --allocation-pool\u003dstart\u003d{{ lb_mgmt_subnet_pool_start }},end\u003d{{ lb_mgmt_subnet_pool_end }} \\"},{"line_number":42,"context_line":"        --ip-version 6 --ipv6-address-mode slaac --ipv6-ra-mode slaac \\"},{"line_number":43,"context_line":"        --network {{ lb_mgmt_net_id }} \\"},{"line_number":44,"context_line":"        --subnet-range {{ lb_mgmt_subnet_cidr }}"},{"line_number":45,"context_line":"      # SLAAC needs a router on the subnet to advertise the prefix."},{"line_number":46,"context_line":"      openstack router create lb-mgmt-router"},{"line_number":47,"context_line":"      openstack router add subnet lb-mgmt-router lb-mgmt-subnet"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"dde3058f_228d8c21","line":44,"range":{"start_line":44,"start_character":26,"end_line":44,"end_character":45},"updated":"2023-01-31 13:59:18.000000000","message":"Same comment about lb_mgmt_subnet_cidr","commit_id":"f4ed39060ed4ed5734705e3263d9fa78855f487a"}],"tripleo_ansible/roles/octavia_overcloud_config/vars/main.yml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"424ee8062b98e7226ab7761734b0b6223ffa1007","unresolved":true,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"lb_mgmt_net_ipv: \"{{ 6 if lb_mgmt_subnet_cidr | ansible.netcommon.ipv6 else 4 }}\""},{"line_number":18,"context_line":"ip_range: \"{{ \u0027::/0\u0027 if lb_mgmt_net_ipv \u003d\u003d \u00276\u0027 else \u00270.0.0.0/0\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"59be6441_608dd9eb","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":15},"updated":"2023-01-31 01:52:09.000000000","message":"we we rename this to lb_mgmt_net_ip_version ? I think it\u0027s not very clear ipv represents ip version.","commit_id":"8a82487a64fd8ce45a08711feb72d98d0b4f46b0"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"00a8d01f74f797b383e6934c381d23e6ae7850fd","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"lb_mgmt_net_ipv: \"{{ 6 if lb_mgmt_subnet_cidr | ansible.netcommon.ipv6 else 4 }}\""},{"line_number":18,"context_line":"ip_range: \"{{ \u0027::/0\u0027 if lb_mgmt_net_ipv \u003d\u003d \u00276\u0027 else \u00270.0.0.0/0\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"b465d8d1_eede3c5f","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":15},"in_reply_to":"59be6441_608dd9eb","updated":"2023-01-31 12:56:22.000000000","message":"Done","commit_id":"8a82487a64fd8ce45a08711feb72d98d0b4f46b0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"424ee8062b98e7226ab7761734b0b6223ffa1007","unresolved":true,"context_lines":[{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"lb_mgmt_net_ipv: \"{{ 6 if lb_mgmt_subnet_cidr | ansible.netcommon.ipv6 else 4 }}\""},{"line_number":18,"context_line":"ip_range: \"{{ \u0027::/0\u0027 if lb_mgmt_net_ipv \u003d\u003d \u00276\u0027 else \u00270.0.0.0/0\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"e92e1023_69c53367","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":8},"updated":"2023-01-31 01:52:09.000000000","message":"we probably have to rename this to better represent what this is. Probably ip_all_range.","commit_id":"8a82487a64fd8ce45a08711feb72d98d0b4f46b0"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"00a8d01f74f797b383e6934c381d23e6ae7850fd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"lb_mgmt_net_ipv: \"{{ 6 if lb_mgmt_subnet_cidr | ansible.netcommon.ipv6 else 4 }}\""},{"line_number":18,"context_line":"ip_range: \"{{ \u0027::/0\u0027 if lb_mgmt_net_ipv \u003d\u003d \u00276\u0027 else \u00270.0.0.0/0\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"e2b682cc_b17aa0e1","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":8},"in_reply_to":"e92e1023_69c53367","updated":"2023-01-31 12:56:22.000000000","message":"Done","commit_id":"8a82487a64fd8ce45a08711feb72d98d0b4f46b0"}]}
