)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e287e009f91811116f983330d3ae4f92f931f3d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d1cc61cf_ab10f485","updated":"2022-08-18 08:55:48.000000000","message":"Some initial questions/thoughts.","commit_id":"acbce9599fea976a6c2b3f5bda57b23fbf23f1be"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"c9eb783dfaf17de938fc605a5591d5b99eac7400","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"dd2a47a5_eab4293d","updated":"2022-10-04 08:21:35.000000000","message":"Documentation needs update before merging it based on https://review.opendev.org/c/openstack/tripleo-ansible/+/840509","commit_id":"13b53e1701c9e37f99644f4e900292b593c5ae7b"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2332c50cabd39bddf9f121a18b22c05694318cfa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"38d378ff_9784c292","updated":"2022-10-03 14:07:13.000000000","message":"let\u0027s please merge this. That should help the roles developers. While it doesn\u0027t by sitting in review :)","commit_id":"13b53e1701c9e37f99644f4e900292b593c5ae7b"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"1a5b871287f3ac8bd72cd0008f9aed4c34451322","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"eb136b97_d2be8dc4","updated":"2022-10-04 07:47:20.000000000","message":"recheck","commit_id":"13b53e1701c9e37f99644f4e900292b593c5ae7b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"80829b94a1bf1532d6d15a5cbd3bc490fdb82668","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"11d2a5cc_a75a967e","updated":"2022-10-07 09:51:24.000000000","message":"https://ce69f794e5194a88167e-55f728dd0276ae72b3fe1bf93bf80aa1.ssl.cf5.rackcdn.com/847347/14/check/openstack-tox-linters/5d4dbcd/job-output.txt\n```\n2022-10-07 09:38:10.177175 | ubuntu-focal | Fix End of Files.........................................................Failed\n2022-10-07 09:38:10.177262 | ubuntu-focal | - hook id: end-of-file-fixer\n2022-10-07 09:38:10.177279 | ubuntu-focal | - exit code: 1\n2022-10-07 09:38:10.177301 | ubuntu-focal | - files were modified by this hook\n2022-10-07 09:38:10.177314 | ubuntu-focal |\n2022-10-07 09:38:10.177326 | ubuntu-focal | Fixing doc/source/roles/role-tripleo_ovn.rst\n2022-10-07 09:38:10.177338 | ubuntu-focal | Fixing tripleo_ansible/roles/tripleo_ovn/molecule/default/converge.yml\n```\nfailure seems to be coming from\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/845653 patch","commit_id":"541141c7758a7e4533deb884dd07c090c565141c"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"262514320a6890f5415d7f4e26caa70ce49728bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"f0c00722_f9ae4ea9","updated":"2022-10-11 12:20:23.000000000","message":"recheck","commit_id":"541141c7758a7e4533deb884dd07c090c565141c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"573692bbdccb78af9c49655eac58ffe0ba927e46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"fd76b729_f94cf03f","updated":"2022-10-17 15:29:05.000000000","message":"is likely good to go","commit_id":"6f723f43cab40aa9afb6b3b4ff60fe5e555737b8"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f0e3a0965f2caaf75e83b59c7cf1f32e6433b4be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1f8a7d87_c11c356b","updated":"2022-10-24 14:14:31.000000000","message":"recheck it seems the event got lost","commit_id":"6f723f43cab40aa9afb6b3b4ff60fe5e555737b8"}],"doc/source/standalone-roles-playbooks.rst":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"9de9c76bc46034cb8a7a761ecf6702b49e846674","unresolved":true,"context_lines":[{"line_number":25,"context_line":"applicable, and different roles have already been developed. However, new"},{"line_number":26,"context_line":"development SHOULD follow these patterns in every extent possible."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Standalone roles names should be formatted as `tripleo__\u003cservice\u003e_\u003ccomponent\u003e`,"},{"line_number":29,"context_line":"like `tripleo_ovn_dbs`, and `tripleo_ovn_controller`. Each component of a"},{"line_number":30,"context_line":"service, or services shared configs, should become a standalone ansible role."},{"line_number":31,"context_line":"Small shared components of a service, like ones responsible for common service"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ebda32e4_f8dec6db","line":28,"range":{"start_line":28,"start_character":54,"end_line":28,"end_character":56},"updated":"2022-06-27 14:49:26.000000000","message":"Double _ did you mean `tripleo_\u003cservice\u003e_\u003ccomponent\u003e`","commit_id":"6a3f2253f1852248cecc625e1793abe0ab1891f1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"87bdda3ef7855f81f02f83a1949ee8ca8b7a0eb7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"applicable, and different roles have already been developed. However, new"},{"line_number":26,"context_line":"development SHOULD follow these patterns in every extent possible."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Standalone roles names should be formatted as `tripleo__\u003cservice\u003e_\u003ccomponent\u003e`,"},{"line_number":29,"context_line":"like `tripleo_ovn_dbs`, and `tripleo_ovn_controller`. Each component of a"},{"line_number":30,"context_line":"service, or services shared configs, should become a standalone ansible role."},{"line_number":31,"context_line":"Small shared components of a service, like ones responsible for common service"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e6f053dc_9f2329c2","line":28,"range":{"start_line":28,"start_character":54,"end_line":28,"end_character":56},"in_reply_to":"e4d5099e_07da443c","updated":"2022-07-15 14:21:21.000000000","message":"Done","commit_id":"6a3f2253f1852248cecc625e1793abe0ab1891f1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1a12a7853cc029580754a7261e7d4d923a473874","unresolved":true,"context_lines":[{"line_number":25,"context_line":"applicable, and different roles have already been developed. However, new"},{"line_number":26,"context_line":"development SHOULD follow these patterns in every extent possible."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Standalone roles names should be formatted as `tripleo__\u003cservice\u003e_\u003ccomponent\u003e`,"},{"line_number":29,"context_line":"like `tripleo_ovn_dbs`, and `tripleo_ovn_controller`. Each component of a"},{"line_number":30,"context_line":"service, or services shared configs, should become a standalone ansible role."},{"line_number":31,"context_line":"Small shared components of a service, like ones responsible for common service"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e4d5099e_07da443c","line":28,"range":{"start_line":28,"start_character":54,"end_line":28,"end_character":56},"in_reply_to":"ebda32e4_f8dec6db","updated":"2022-07-04 14:11:59.000000000","message":"yes, just a typo, sorry","commit_id":"6a3f2253f1852248cecc625e1793abe0ab1891f1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7027ad4877a0e44b68d84341ae337c6f24704999","unresolved":true,"context_lines":[{"line_number":53,"context_line":"   `tripleo_nova_compute_upgrade_level_compute` for the `tripleo_nova_compute`"},{"line_number":54,"context_line":"   role. And both should failback to `tripleo_upgrade_level_compute` in the"},{"line_number":55,"context_line":"   roles default vars."},{"line_number":56,"context_line":"#. Complex values should be evaluated in `main.yml`. For example,"},{"line_number":57,"context_line":"   `cinder_common_kolla_permissions` and `kolla_permissions` that correspond to"},{"line_number":58,"context_line":"   `CephExternalMultiConfig` of Nova Libvirt and Cinder Common t-h-t services,"},{"line_number":59,"context_line":"   could be defined via the service-name prefixed `*_ceph_multiconfig_permissions`"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bde78dff_1c7956e3","line":56,"range":{"start_line":56,"start_character":3,"end_line":56,"end_character":51},"updated":"2022-07-15 11:10:58.000000000","message":"Is this defaults/main.yml, tasks/main.yml or vars/main.yml (or some other location in the role)?","commit_id":"a095df76088a520219990f6f87301bf2896d2fde"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"87bdda3ef7855f81f02f83a1949ee8ca8b7a0eb7","unresolved":false,"context_lines":[{"line_number":53,"context_line":"   `tripleo_nova_compute_upgrade_level_compute` for the `tripleo_nova_compute`"},{"line_number":54,"context_line":"   role. And both should failback to `tripleo_upgrade_level_compute` in the"},{"line_number":55,"context_line":"   roles default vars."},{"line_number":56,"context_line":"#. Complex values should be evaluated in `main.yml`. For example,"},{"line_number":57,"context_line":"   `cinder_common_kolla_permissions` and `kolla_permissions` that correspond to"},{"line_number":58,"context_line":"   `CephExternalMultiConfig` of Nova Libvirt and Cinder Common t-h-t services,"},{"line_number":59,"context_line":"   could be defined via the service-name prefixed `*_ceph_multiconfig_permissions`"}],"source_content_type":"text/x-rst","patch_set":3,"id":"f6bdd6df_4ee16132","line":56,"range":{"start_line":56,"start_character":3,"end_line":56,"end_character":51},"in_reply_to":"bde78dff_1c7956e3","updated":"2022-07-15 14:21:21.000000000","message":"Done","commit_id":"a095df76088a520219990f6f87301bf2896d2fde"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6e36c0935c4ebfa34fd3521e5fab73e335ba1815","unresolved":true,"context_lines":[{"line_number":53,"context_line":"   `tripleo_nova_compute_upgrade_level_compute` for the `tripleo_nova_compute`"},{"line_number":54,"context_line":"   role. And both should failback to `tripleo_upgrade_level_compute` in the"},{"line_number":55,"context_line":"   roles default vars."},{"line_number":56,"context_line":"#. Complex values should be evaluated as facts in `tasks/main.yml`. For example,"},{"line_number":57,"context_line":"   `cinder_common_kolla_permissions` and `kolla_permissions` that correspond to"},{"line_number":58,"context_line":"   `CephExternalMultiConfig` of Nova Libvirt and Cinder Common t-h-t services,"},{"line_number":59,"context_line":"   could be defined via the service-name prefixed `*_ceph_multiconfig_permissions`"},{"line_number":60,"context_line":"   facts for the `tripleo_nova_libvirt` and `tripleo_cinder_common` roles."},{"line_number":61,"context_line":"   Then roles for cinder backup and volume components may share that fact from"},{"line_number":62,"context_line":"   the cinder common role."},{"line_number":63,"context_line":"#. Puppet Hiera data should ideally be mapped into standalone roles variables"},{"line_number":64,"context_line":"   as well. Unless there is ansible config templating and/or conf files snippets"},{"line_number":65,"context_line":"   used as direct user inputs. However, please always remember about the goal of"}],"source_content_type":"text/x-rst","patch_set":10,"id":"01566a73_9947f3be","line":62,"range":{"start_line":56,"start_character":0,"end_line":62,"end_character":26},"updated":"2022-07-15 14:52:56.000000000","message":"Setting facts is expensive - it requires running a task. Every task run costs more time.\n\nhttps://docs.ansible.com/ansible/latest/user_guide/playbooks_variables.html#tips-on-where-to-set-variables indicates that variables are inherited from one role to another. Why not use defaults/main.yml or vars/main.yml instead?\n\nThe load of defaults/vars from a role is done automatically when the role is included/imported without the need for an additional task.\n\nAlso consider the fact that ansible variables are evaluated lazily. It only needs the variable when it is accessed via a task or template. This means that we can set variables in vars/defaults which reference things like facts or other set facts.","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"dde95fa6bc01940b1629cce14dfbd53c054d218e","unresolved":true,"context_lines":[{"line_number":53,"context_line":"   `tripleo_nova_compute_upgrade_level_compute` for the `tripleo_nova_compute`"},{"line_number":54,"context_line":"   role. And both should failback to `tripleo_upgrade_level_compute` in the"},{"line_number":55,"context_line":"   roles default vars."},{"line_number":56,"context_line":"#. Complex values should be evaluated as facts in `tasks/main.yml`. For example,"},{"line_number":57,"context_line":"   `cinder_common_kolla_permissions` and `kolla_permissions` that correspond to"},{"line_number":58,"context_line":"   `CephExternalMultiConfig` of Nova Libvirt and Cinder Common t-h-t services,"},{"line_number":59,"context_line":"   could be defined via the service-name prefixed `*_ceph_multiconfig_permissions`"},{"line_number":60,"context_line":"   facts for the `tripleo_nova_libvirt` and `tripleo_cinder_common` roles."},{"line_number":61,"context_line":"   Then roles for cinder backup and volume components may share that fact from"},{"line_number":62,"context_line":"   the cinder common role."},{"line_number":63,"context_line":"#. Puppet Hiera data should ideally be mapped into standalone roles variables"},{"line_number":64,"context_line":"   as well. Unless there is ansible config templating and/or conf files snippets"},{"line_number":65,"context_line":"   used as direct user inputs. However, please always remember about the goal of"}],"source_content_type":"text/x-rst","patch_set":10,"id":"75bce3d5_19e33ef1","line":62,"range":{"start_line":56,"start_character":0,"end_line":62,"end_character":26},"in_reply_to":"01566a73_9947f3be","updated":"2022-08-17 21:36:59.000000000","message":"that would be a question for Bogdan. I\u0027m not sure what he had in mind here.\n\nHowever he doesn\u0027t explicitly say the plan is to set facts. If you look at the vars file that already exists in some of the proposed standalone roles, there are several instances of variable composition and references to reduce re-use. I think that would be preferred approach instead of set_fact tasks.","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"9cb62523017b0f7e49b5db3e8f8567637320eccf","unresolved":true,"context_lines":[{"line_number":53,"context_line":"   `tripleo_nova_compute_upgrade_level_compute` for the `tripleo_nova_compute`"},{"line_number":54,"context_line":"   role. And both should failback to `tripleo_upgrade_level_compute` in the"},{"line_number":55,"context_line":"   roles default vars."},{"line_number":56,"context_line":"#. Complex values should be evaluated as facts in `tasks/main.yml`. For example,"},{"line_number":57,"context_line":"   `cinder_common_kolla_permissions` and `kolla_permissions` that correspond to"},{"line_number":58,"context_line":"   `CephExternalMultiConfig` of Nova Libvirt and Cinder Common t-h-t services,"},{"line_number":59,"context_line":"   could be defined via the service-name prefixed `*_ceph_multiconfig_permissions`"},{"line_number":60,"context_line":"   facts for the `tripleo_nova_libvirt` and `tripleo_cinder_common` roles."},{"line_number":61,"context_line":"   Then roles for cinder backup and volume components may share that fact from"},{"line_number":62,"context_line":"   the cinder common role."},{"line_number":63,"context_line":"#. Puppet Hiera data should ideally be mapped into standalone roles variables"},{"line_number":64,"context_line":"   as well. Unless there is ansible config templating and/or conf files snippets"},{"line_number":65,"context_line":"   used as direct user inputs. However, please always remember about the goal of"}],"source_content_type":"text/x-rst","patch_set":10,"id":"119a83f9_d5703ce2","line":62,"range":{"start_line":56,"start_character":0,"end_line":62,"end_character":26},"in_reply_to":"0be89bdd_86959031","updated":"2022-08-18 14:33:37.000000000","message":"Jesse, I agree that facts are expensive but I don\u0027t think we should forbid them. We should warn about them and encourage their minimization. At the same time, there are a lot of complicated expressions to translate from the old language to the new and fact setting can help with that [0].\n\nThus, I\u0027ve added new copy to the proposed text which warns against fact setting but allows it to be used in certain cases. I hope this addresses your concern. I think at this stage of the project it\u0027s better to use the facts in some cases and get working code sooner. Forbidding completely them seems like premature optimization [1]. Instead use them sparingly.\n\n[0] https://review.opendev.org/c/openstack/tripleo-ansible/+/842152/32/tripleo_ansible/roles/tripleo_nova_libvirt/tasks/main.yml#75\n[1] https://stackify.com/premature-optimization-evil/","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a65beff43c10c324a1a35cfd36e0aef8ac427c9e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"   `tripleo_nova_compute_upgrade_level_compute` for the `tripleo_nova_compute`"},{"line_number":54,"context_line":"   role. And both should failback to `tripleo_upgrade_level_compute` in the"},{"line_number":55,"context_line":"   roles default vars."},{"line_number":56,"context_line":"#. Complex values should be evaluated as facts in `tasks/main.yml`. For example,"},{"line_number":57,"context_line":"   `cinder_common_kolla_permissions` and `kolla_permissions` that correspond to"},{"line_number":58,"context_line":"   `CephExternalMultiConfig` of Nova Libvirt and Cinder Common t-h-t services,"},{"line_number":59,"context_line":"   could be defined via the service-name prefixed `*_ceph_multiconfig_permissions`"},{"line_number":60,"context_line":"   facts for the `tripleo_nova_libvirt` and `tripleo_cinder_common` roles."},{"line_number":61,"context_line":"   Then roles for cinder backup and volume components may share that fact from"},{"line_number":62,"context_line":"   the cinder common role."},{"line_number":63,"context_line":"#. Puppet Hiera data should ideally be mapped into standalone roles variables"},{"line_number":64,"context_line":"   as well. Unless there is ansible config templating and/or conf files snippets"},{"line_number":65,"context_line":"   used as direct user inputs. However, please always remember about the goal of"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5e7a8784_a5d01777","line":62,"range":{"start_line":56,"start_character":0,"end_line":62,"end_character":26},"in_reply_to":"119a83f9_d5703ce2","updated":"2022-08-18 14:42:28.000000000","message":"Done","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ddd5c13f3580bf4c4b15ab657d99109fcbb3e6ef","unresolved":true,"context_lines":[{"line_number":53,"context_line":"   `tripleo_nova_compute_upgrade_level_compute` for the `tripleo_nova_compute`"},{"line_number":54,"context_line":"   role. And both should failback to `tripleo_upgrade_level_compute` in the"},{"line_number":55,"context_line":"   roles default vars."},{"line_number":56,"context_line":"#. Complex values should be evaluated as facts in `tasks/main.yml`. For example,"},{"line_number":57,"context_line":"   `cinder_common_kolla_permissions` and `kolla_permissions` that correspond to"},{"line_number":58,"context_line":"   `CephExternalMultiConfig` of Nova Libvirt and Cinder Common t-h-t services,"},{"line_number":59,"context_line":"   could be defined via the service-name prefixed `*_ceph_multiconfig_permissions`"},{"line_number":60,"context_line":"   facts for the `tripleo_nova_libvirt` and `tripleo_cinder_common` roles."},{"line_number":61,"context_line":"   Then roles for cinder backup and volume components may share that fact from"},{"line_number":62,"context_line":"   the cinder common role."},{"line_number":63,"context_line":"#. Puppet Hiera data should ideally be mapped into standalone roles variables"},{"line_number":64,"context_line":"   as well. Unless there is ansible config templating and/or conf files snippets"},{"line_number":65,"context_line":"   used as direct user inputs. However, please always remember about the goal of"}],"source_content_type":"text/x-rst","patch_set":10,"id":"0be89bdd_86959031","line":62,"range":{"start_line":56,"start_character":0,"end_line":62,"end_character":26},"in_reply_to":"75bce3d5_19e33ef1","updated":"2022-08-18 13:52:41.000000000","message":"If things can be done w/o facts, that\u0027s fine.\nI\u0027ve had a few examples that probably could not have been addressed via vars, because we need to decide based on the default role vars provided by a user.\n\n1) Composition of complex conditions, when interpolating it from t-h-t\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/842152/32/tripleo_ansible/roles/tripleo_nova_libvirt/tasks/main.yml#35\n\n2) Translating t-h-t yaql and str_replace etc templating funcs for ansible (can\u0027t be done as vars AFAIK??)\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/842152/32/tripleo_ansible/roles/tripleo_nova_libvirt/tasks/main.yml#75","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"ee2b2e8c9fecb3bc11686d8fa2df8ee6e893d321","unresolved":true,"context_lines":[{"line_number":87,"context_line":"parameters and Puppet Hiera data, there is a helper script_ (provided as the"},{"line_number":88,"context_line":"best effort)."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":".. _script: https://gist.github.com/bogdando/ab2118f4c6fbb88c1c127fd6eb82b756"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Task files"},{"line_number":93,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"4f581dc8_07a0e7c4","line":90,"updated":"2022-08-10 10:24:35.000000000","message":"Can we move this helper script to tripleo-ansible repo?","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"0cda6ad4155d6ea8991f267b0d028124a97aaf66","unresolved":false,"context_lines":[{"line_number":87,"context_line":"parameters and Puppet Hiera data, there is a helper script_ (provided as the"},{"line_number":88,"context_line":"best effort)."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":".. _script: https://gist.github.com/bogdando/ab2118f4c6fbb88c1c127fd6eb82b756"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Task files"},{"line_number":93,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"645f132d_1217700c","line":90,"in_reply_to":"3dc54670_a36c6667","updated":"2022-09-07 14:44:19.000000000","message":"Done","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"ba5b3251883759c6611ea3f5e7e37cc3e0ca6fd5","unresolved":true,"context_lines":[{"line_number":87,"context_line":"parameters and Puppet Hiera data, there is a helper script_ (provided as the"},{"line_number":88,"context_line":"best effort)."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":".. _script: https://gist.github.com/bogdando/ab2118f4c6fbb88c1c127fd6eb82b756"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Task files"},{"line_number":93,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"60869e83_afd68c82","line":90,"in_reply_to":"3dc54670_a36c6667","updated":"2022-09-07 08:06:01.000000000","message":"ack, then if we mention it here would be possible to open a WIP change request to tripleo-ansible with this script? That way anyone can suggest improvments to the script.","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9dd6c0f6bdc8292c02c44bb5f95090b40a72a986","unresolved":true,"context_lines":[{"line_number":87,"context_line":"parameters and Puppet Hiera data, there is a helper script_ (provided as the"},{"line_number":88,"context_line":"best effort)."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":".. _script: https://gist.github.com/bogdando/ab2118f4c6fbb88c1c127fd6eb82b756"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Task files"},{"line_number":93,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3dc54670_a36c6667","line":90,"in_reply_to":"4f581dc8_07a0e7c4","updated":"2022-08-18 14:46:31.000000000","message":"Probably. Although, it should be enhanced and likely no included as the best effort tool. For now, that\u0027s just a quick and dirty version of it, to have things prepared for PoC quickly, while following the naming rules from day 1.","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"ee2b2e8c9fecb3bc11686d8fa2df8ee6e893d321","unresolved":true,"context_lines":[{"line_number":104,"context_line":"  run.yaml"},{"line_number":105,"context_line":"  update.yaml"},{"line_number":106,"context_line":"  upgrade.yaml"},{"line_number":107,"context_line":"  scale.yaml"},{"line_number":108,"context_line":"  scale-down.yaml"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"install.yaml"}],"source_content_type":"text/x-rst","patch_set":10,"id":"c53c44aa_65d8377d","line":107,"updated":"2022-08-10 10:24:35.000000000","message":"If we have scale-down.yaml task file, maybe we should be more explicit and call it scale_up.yaml if the purpose of it is as described in [1]\n[1]https://review.opendev.org/c/openstack/tripleo-ansible/+/847347/10/doc/source/standalone-roles-playbooks.rst#132","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"ba5b3251883759c6611ea3f5e7e37cc3e0ca6fd5","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  run.yaml"},{"line_number":105,"context_line":"  update.yaml"},{"line_number":106,"context_line":"  upgrade.yaml"},{"line_number":107,"context_line":"  scale.yaml"},{"line_number":108,"context_line":"  scale-down.yaml"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"install.yaml"}],"source_content_type":"text/x-rst","patch_set":10,"id":"ac59fb8c_48677d6c","line":107,"in_reply_to":"68a49e94_42c83e43","updated":"2022-09-07 08:06:01.000000000","message":"Done","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"dde95fa6bc01940b1629cce14dfbd53c054d218e","unresolved":true,"context_lines":[{"line_number":104,"context_line":"  run.yaml"},{"line_number":105,"context_line":"  update.yaml"},{"line_number":106,"context_line":"  upgrade.yaml"},{"line_number":107,"context_line":"  scale.yaml"},{"line_number":108,"context_line":"  scale-down.yaml"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"install.yaml"}],"source_content_type":"text/x-rst","patch_set":10,"id":"68a49e94_42c83e43","line":107,"in_reply_to":"c53c44aa_65d8377d","updated":"2022-08-17 21:36:59.000000000","message":"ok","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"9b8ed0d6f69c00a01318af8c64fb70c3e4049fbb","unresolved":true,"context_lines":[{"line_number":105,"context_line":"  update.yaml"},{"line_number":106,"context_line":"  upgrade.yaml"},{"line_number":107,"context_line":"  scale.yaml"},{"line_number":108,"context_line":"  scale-down.yaml"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"install.yaml"},{"line_number":111,"context_line":"  Installation tasks. Tasks that install software from remote repositories, or"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7d74479b_b1668ed4","line":108,"range":{"start_line":108,"start_character":2,"end_line":108,"end_character":12},"updated":"2022-08-10 08:24:31.000000000","message":"I think it should be \"scale_down.yaml\" instead.","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"dde95fa6bc01940b1629cce14dfbd53c054d218e","unresolved":true,"context_lines":[{"line_number":105,"context_line":"  update.yaml"},{"line_number":106,"context_line":"  upgrade.yaml"},{"line_number":107,"context_line":"  scale.yaml"},{"line_number":108,"context_line":"  scale-down.yaml"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"install.yaml"},{"line_number":111,"context_line":"  Installation tasks. Tasks that install software from remote repositories, or"}],"source_content_type":"text/x-rst","patch_set":10,"id":"a45acfe7_3a6abc88","line":108,"range":{"start_line":108,"start_character":2,"end_line":108,"end_character":12},"in_reply_to":"7d74479b_b1668ed4","updated":"2022-08-17 21:36:59.000000000","message":"ok","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"ee2b2e8c9fecb3bc11686d8fa2df8ee6e893d321","unresolved":true,"context_lines":[{"line_number":153,"context_line":"For containerized OpenStack services (and other services), that use"},{"line_number":154,"context_line":"configuration files, the following configuration pattern can be used:"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"#. Start a container from the service image"},{"line_number":157,"context_line":"#. Copy out all needed configuration files from the running container to"},{"line_number":158,"context_line":"   the ``/var/lib/config-data/ansible-generated/\u003cservice\u003e`` directory on the"},{"line_number":159,"context_line":"   managed node."}],"source_content_type":"text/x-rst","patch_set":10,"id":"058bc2a7_e0e95258","line":156,"updated":"2022-08-10 10:24:35.000000000","message":"I followed the example implementation, but I\u0027m not sure how this will work. \nWe are starting container with sleep inf, creating all required modifications in bind mounted files. Do we need to start container again after, but without \u0027sleep inf\u0027 in order to containerized service start working?  Could you elaborate on it?","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"dde95fa6bc01940b1629cce14dfbd53c054d218e","unresolved":true,"context_lines":[{"line_number":153,"context_line":"For containerized OpenStack services (and other services), that use"},{"line_number":154,"context_line":"configuration files, the following configuration pattern can be used:"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"#. Start a container from the service image"},{"line_number":157,"context_line":"#. Copy out all needed configuration files from the running container to"},{"line_number":158,"context_line":"   the ``/var/lib/config-data/ansible-generated/\u003cservice\u003e`` directory on the"},{"line_number":159,"context_line":"   managed node."}],"source_content_type":"text/x-rst","patch_set":10,"id":"37d3c106_04964c4f","line":156,"in_reply_to":"058bc2a7_e0e95258","updated":"2022-08-17 21:36:59.000000000","message":"Yes, after the files have been copied out of the configuration container, it is podman rm\u0027d. A container whose process is the running openstack service is then started from run.yaml, with the generated config files bind mounted into the correct locations.\n\nYou can see an example here from configure.yaml from the tripleo_nova_compute role:\n\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/843659/29/tripleo_ansible/roles/tripleo_nova_compute/tasks/configure.yml#75\n\nAnd later, the actual container is started from run.yaml:\n\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/843659/29/tripleo_ansible/roles/tripleo_nova_compute/tasks/run.yml#55","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"ba5b3251883759c6611ea3f5e7e37cc3e0ca6fd5","unresolved":false,"context_lines":[{"line_number":153,"context_line":"For containerized OpenStack services (and other services), that use"},{"line_number":154,"context_line":"configuration files, the following configuration pattern can be used:"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"#. Start a container from the service image"},{"line_number":157,"context_line":"#. Copy out all needed configuration files from the running container to"},{"line_number":158,"context_line":"   the ``/var/lib/config-data/ansible-generated/\u003cservice\u003e`` directory on the"},{"line_number":159,"context_line":"   managed node."}],"source_content_type":"text/x-rst","patch_set":10,"id":"b6716cbb_1787df3f","line":156,"in_reply_to":"37d3c106_04964c4f","updated":"2022-09-07 08:06:01.000000000","message":"ack, thank you","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"ee2b2e8c9fecb3bc11686d8fa2df8ee6e893d321","unresolved":true,"context_lines":[{"line_number":283,"context_line":"manage an OpenStack environment entirely with ansible runtimes (ansible /"},{"line_number":284,"context_line":"ansible-playbook). To separate these playbooks from playbooks for other"},{"line_number":285,"context_line":"purposes within tripleo-ansible, the standalone playbooks are prefixed with"},{"line_number":286,"context_line":"``deploy-`` within the `tripleo_ansible/playbooks`_ directory."},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"The playbooks are organized by management function like the task files within"},{"line_number":289,"context_line":"each role. Additionally, they are further organized to allow managing operating"}],"source_content_type":"text/x-rst","patch_set":10,"id":"d60173bb_5b94b6ce","line":286,"range":{"start_line":286,"start_character":2,"end_line":286,"end_character":8},"updated":"2022-08-10 10:24:35.000000000","message":"Just curious why deploy prefix was choosen and not standalone for instance? \nThere are going to be update/upgrades playbooks. And for these playbooks, we will need to call them deploy-tripleo-openstack-update.yaml/deploy-tripleo-openstack-upgrade.yaml?","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"dde95fa6bc01940b1629cce14dfbd53c054d218e","unresolved":true,"context_lines":[{"line_number":283,"context_line":"manage an OpenStack environment entirely with ansible runtimes (ansible /"},{"line_number":284,"context_line":"ansible-playbook). To separate these playbooks from playbooks for other"},{"line_number":285,"context_line":"purposes within tripleo-ansible, the standalone playbooks are prefixed with"},{"line_number":286,"context_line":"``deploy-`` within the `tripleo_ansible/playbooks`_ directory."},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"The playbooks are organized by management function like the task files within"},{"line_number":289,"context_line":"each role. Additionally, they are further organized to allow managing operating"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fde2eb97_f8e52ae5","line":286,"range":{"start_line":286,"start_character":2,"end_line":286,"end_character":8},"in_reply_to":"d60173bb_5b94b6ce","updated":"2022-08-17 21:36:59.000000000","message":"no good reason. it\u0027s just a name. I\u0027m open to changing it. we could drop the \"deploy-\" prefix entirely.","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"ba5b3251883759c6611ea3f5e7e37cc3e0ca6fd5","unresolved":true,"context_lines":[{"line_number":283,"context_line":"manage an OpenStack environment entirely with ansible runtimes (ansible /"},{"line_number":284,"context_line":"ansible-playbook). To separate these playbooks from playbooks for other"},{"line_number":285,"context_line":"purposes within tripleo-ansible, the standalone playbooks are prefixed with"},{"line_number":286,"context_line":"``deploy-`` within the `tripleo_ansible/playbooks`_ directory."},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"The playbooks are organized by management function like the task files within"},{"line_number":289,"context_line":"each role. Additionally, they are further organized to allow managing operating"}],"source_content_type":"text/x-rst","patch_set":10,"id":"36d5ba47_b812a34c","line":286,"range":{"start_line":286,"start_character":2,"end_line":286,"end_character":8},"in_reply_to":"fde2eb97_f8e52ae5","updated":"2022-09-07 08:06:01.000000000","message":"I\u0027m for droping prefix entirely or changing it to standalone. On the other hand, standalone might not be the best candidate, as there is already `standalone` type deployment in tripleo.","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"d62d4f7446b1ac0ac3b9d94051209aa5ef9a05b9","unresolved":true,"context_lines":[{"line_number":467,"context_line":""},{"line_number":468,"context_line":"   .. code-block:: shell"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    python3 generate-99-custom.py /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"#. The script will generate ``99-custom.yaml`` in the current directory. Copy the file to the ansible control node where the inventory is defined."},{"line_number":473,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"d277778f_0ab47d93","line":470,"updated":"2022-08-10 17:14:50.000000000","message":"FYI: I ran into an issue when running this python script as described above. I\u0027ve left a comment in the review for the python script.\n\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/840509/comments/be157e78_9706c0c5","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"dde95fa6bc01940b1629cce14dfbd53c054d218e","unresolved":true,"context_lines":[{"line_number":467,"context_line":""},{"line_number":468,"context_line":"   .. code-block:: shell"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    python3 generate-99-custom.py /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"#. The script will generate ``99-custom.yaml`` in the current directory. Copy the file to the ansible control node where the inventory is defined."},{"line_number":473,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"b1d738f4_9ab77183","line":470,"in_reply_to":"d277778f_0ab47d93","updated":"2022-08-17 21:36:59.000000000","message":"thanks, i\u0027ll take a look.","commit_id":"0a75764aa7392f1db02085a219a5ad4ac94c82ac"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"9cb62523017b0f7e49b5db3e8f8567637320eccf","unresolved":true,"context_lines":[{"line_number":53,"context_line":"   `tripleo_nova_compute_upgrade_level_compute` for the `tripleo_nova_compute`"},{"line_number":54,"context_line":"   role. And both should failback to `tripleo_upgrade_level_compute` in the"},{"line_number":55,"context_line":"   roles default vars."},{"line_number":56,"context_line":"#. Complex values should be evaluated as facts in `tasks/main.yml`. For example,"},{"line_number":57,"context_line":"   `cinder_common_kolla_permissions` and `kolla_permissions` that correspond to"},{"line_number":58,"context_line":"   `CephExternalMultiConfig` of Nova Libvirt and Cinder Common t-h-t services,"},{"line_number":59,"context_line":"   could be defined via the service-name prefixed `*_ceph_multiconfig_permissions`"}],"source_content_type":"text/x-rst","patch_set":11,"id":"85779eab_308d45c8","line":56,"range":{"start_line":56,"start_character":67,"end_line":56,"end_character":68},"updated":"2022-08-18 14:33:37.000000000","message":"Setting facts is expensive - it requires running a task which costs time and thus it should be avoided. However, when there are complex t-h-t yaql and str_replace templating functions from Heat, it is OK to translate these into jinja and set facts. If bottlenecks are found which will affecting production clusters, then they can be optimized later.","commit_id":"acbce9599fea976a6c2b3f5bda57b23fbf23f1be"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"9cb62523017b0f7e49b5db3e8f8567637320eccf","unresolved":true,"context_lines":[{"line_number":53,"context_line":"   `tripleo_nova_compute_upgrade_level_compute` for the `tripleo_nova_compute`"},{"line_number":54,"context_line":"   role. And both should failback to `tripleo_upgrade_level_compute` in the"},{"line_number":55,"context_line":"   roles default vars."},{"line_number":56,"context_line":"#. Complex values should be evaluated as facts in `tasks/main.yml`. For example,"},{"line_number":57,"context_line":"   `cinder_common_kolla_permissions` and `kolla_permissions` that correspond to"},{"line_number":58,"context_line":"   `CephExternalMultiConfig` of Nova Libvirt and Cinder Common t-h-t services,"},{"line_number":59,"context_line":"   could be defined via the service-name prefixed `*_ceph_multiconfig_permissions`"}],"source_content_type":"text/x-rst","patch_set":11,"id":"5aeae7f3_c449410c","line":56,"range":{"start_line":56,"start_character":18,"end_line":56,"end_character":24},"updated":"2022-08-18 14:33:37.000000000","message":"may","commit_id":"acbce9599fea976a6c2b3f5bda57b23fbf23f1be"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ffc097c60d42a211b8d17dedfad92cbf7e0e929e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"   `tripleo_nova_compute_upgrade_level_compute` for the `tripleo_nova_compute`"},{"line_number":54,"context_line":"   role. And both should failback to `tripleo_upgrade_level_compute` in the"},{"line_number":55,"context_line":"   roles default vars."},{"line_number":56,"context_line":"#. Complex values should be evaluated as facts in `tasks/main.yml`. For example,"},{"line_number":57,"context_line":"   `cinder_common_kolla_permissions` and `kolla_permissions` that correspond to"},{"line_number":58,"context_line":"   `CephExternalMultiConfig` of Nova Libvirt and Cinder Common t-h-t services,"},{"line_number":59,"context_line":"   could be defined via the service-name prefixed `*_ceph_multiconfig_permissions`"}],"source_content_type":"text/x-rst","patch_set":11,"id":"d8b9dd58_2c63d6ee","line":56,"range":{"start_line":56,"start_character":18,"end_line":56,"end_character":24},"in_reply_to":"5aeae7f3_c449410c","updated":"2022-08-18 14:42:46.000000000","message":"Done","commit_id":"acbce9599fea976a6c2b3f5bda57b23fbf23f1be"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a65beff43c10c324a1a35cfd36e0aef8ac427c9e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"   `tripleo_nova_compute_upgrade_level_compute` for the `tripleo_nova_compute`"},{"line_number":54,"context_line":"   role. And both should failback to `tripleo_upgrade_level_compute` in the"},{"line_number":55,"context_line":"   roles default vars."},{"line_number":56,"context_line":"#. Complex values should be evaluated as facts in `tasks/main.yml`. For example,"},{"line_number":57,"context_line":"   `cinder_common_kolla_permissions` and `kolla_permissions` that correspond to"},{"line_number":58,"context_line":"   `CephExternalMultiConfig` of Nova Libvirt and Cinder Common t-h-t services,"},{"line_number":59,"context_line":"   could be defined via the service-name prefixed `*_ceph_multiconfig_permissions`"}],"source_content_type":"text/x-rst","patch_set":11,"id":"95befb98_c9dd772b","line":56,"range":{"start_line":56,"start_character":67,"end_line":56,"end_character":68},"in_reply_to":"85779eab_308d45c8","updated":"2022-08-18 14:42:28.000000000","message":"thanks! done","commit_id":"acbce9599fea976a6c2b3f5bda57b23fbf23f1be"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e287e009f91811116f983330d3ae4f92f931f3d2","unresolved":true,"context_lines":[{"line_number":83,"context_line":"also help a lot the TripleO project users to convert their Heat templates and"},{"line_number":84,"context_line":"customizations to quickly provide it as inputs for standalone roles."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"To simplify code generation and verification of role vars mappings to Heat"},{"line_number":87,"context_line":"parameters and Puppet Hiera data, there is a helper script_ (provided as the"},{"line_number":88,"context_line":"best effort)."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":".. _script: https://gist.github.com/bogdando/ab2118f4c6fbb88c1c127fd6eb82b756"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"e653e72c_279612a7","line":88,"range":{"start_line":86,"start_character":0,"end_line":88,"end_character":13},"updated":"2022-08-18 08:55:48.000000000","message":"IMHO, mapping and transforming to THT parameters to ansible vars/puppet hiera (with all kinds of available heat intrinsic functions) is one of the key features of the THT atm. We probably would need a official tool to do that without THT. Expecting users to understand these transformations and provide appropriate variables would probably be too much to ask(?).\n\nAlso, we would possibly end up with \u0027n\u0027 times ansible variables as compared to THT parameters with all the proposed dedicated role and service vars. Heat parameters have descriptions which helps in understanding their usage, which we\u0027ve to provide for all ansible vars and possibly ensure that with linting checks.","commit_id":"acbce9599fea976a6c2b3f5bda57b23fbf23f1be"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2cdeb7d3f134afec755537ef181eea38b9a01f37","unresolved":true,"context_lines":[{"line_number":83,"context_line":"also help a lot the TripleO project users to convert their Heat templates and"},{"line_number":84,"context_line":"customizations to quickly provide it as inputs for standalone roles."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"To simplify code generation and verification of role vars mappings to Heat"},{"line_number":87,"context_line":"parameters and Puppet Hiera data, there is a helper script_ (provided as the"},{"line_number":88,"context_line":"best effort)."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":".. _script: https://gist.github.com/bogdando/ab2118f4c6fbb88c1c127fd6eb82b756"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"ee207ba4_aad14e2e","line":88,"range":{"start_line":86,"start_character":0,"end_line":88,"end_character":13},"in_reply_to":"e653e72c_279612a7","updated":"2022-08-18 14:07:37.000000000","message":"I probably have explained this poorly. The intent is to not request knowing ansible variables mappings to t-h-t/puppet from users, but from roles developers and tripleo maintainers, to keep them synced, especially when backporting changes around. And the helper script, like that example that I linked, is intended to help developers with that task. While for the end users, indeed, official tooling would be very nice to have, to help them to convert their deployment data into new format consumed for ansible. Or maybe have them keep using heat when converting it via tripleo DF, and passing as group vars. That just a detail of how tripleo would support user inputs further, after the standalone roles come into reality.","commit_id":"acbce9599fea976a6c2b3f5bda57b23fbf23f1be"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e287e009f91811116f983330d3ae4f92f931f3d2","unresolved":true,"context_lines":[{"line_number":356,"context_line":"compute node. It is a sample inventory, using standard TripleO defaults and is"},{"line_number":357,"context_line":"meant to be copied and modified for different environments."},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"The files provided by the sample inventory are as follows:"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":".. code-block::"},{"line_number":362,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"0ccd240e_d8e6d1aa","line":359,"range":{"start_line":359,"start_character":0,"end_line":359,"end_character":58},"updated":"2022-08-18 08:55:48.000000000","message":"Are we expecting users to create/update the inventory manually vs. auto generated atm? How would it work with baremetal provisioning which generates bits of the inventory from neutron data? Are we going to change that to also generate in these formats and structure(?).","commit_id":"acbce9599fea976a6c2b3f5bda57b23fbf23f1be"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"c9eb783dfaf17de938fc605a5591d5b99eac7400","unresolved":true,"context_lines":[{"line_number":468,"context_line":"OpenStack control plane. Use the generated ``99-custom`` from the below"},{"line_number":469,"context_line":"commands when ``ansible-playbook`` is executed."},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"#. Execute the ``generate-99-custom.py`` script on the standalone control plane node, with the ``nova.conf`` configuration file as the only argument."},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"   .. code-block:: shell"},{"line_number":474,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"d04b536d_776042b0","line":471,"range":{"start_line":471,"start_character":17,"end_line":471,"end_character":38},"updated":"2022-10-04 08:21:35.000000000","message":"based on this review \nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/840509/45/scripts/tripleo-standalone-vars\n\ngenerate-99-custom.py is renamed to tripleo-standalone-vars. \n\nand here is the usage.\n```\npython3 tripleo-standalone-vars -r Standalone -c home/zuul/tripleo-deploy/standalone-ansible-* -o 99-standalone-vars\n\nWhere \n-r -\u003e Role name\n-c -\u003e config download path\n-o -\u003e is the output file.\n```\n\nWe need update 99-custom instance with 99-standalone-vars. Rest of the stuff looks good.","commit_id":"13b53e1701c9e37f99644f4e900292b593c5ae7b"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"e24f120c9ab3eec5672a3a237b92184a27835bf7","unresolved":true,"context_lines":[{"line_number":321,"context_line":"  deploy-tripleo-facts.yml"},{"line_number":322,"context_line":"  deploy-tripleo-selinux.yml"},{"line_number":323,"context_line":"  deploy-tripleo-pre-network.yml"},{"line_number":324,"context_line":"  deploy-tripleo-network-configure.yml"},{"line_number":325,"context_line":"  deploy-tripleo-network-validate.yml"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"In the simplest form, the standalone playbooks will consume standalone roles"}],"source_content_type":"text/x-rst","patch_set":14,"id":"b8772289_008f495a","line":324,"updated":"2022-10-10 20:02:25.000000000","message":"Regarding network configuration is there a plan to use tripleo_hosts_entries role to create /etc/hosts file on standalone compute with all dns names of overcloud node?  Shouldn\u0027t it be run as a part of deploy-tripleo-network-configure.yml or deploy-tripleo-pre-network.yml playbook ?","commit_id":"541141c7758a7e4533deb884dd07c090c565141c"}]}