)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0087dd8e50102f9cff0b0c03a5faf78f70bb2a2c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"71078337_482c2d9e","updated":"2022-07-13 14:13:13.000000000","message":"I\u0027m not sure why we need to update the default according to infrared. If infrared uses a different default value then why don\u0027t we fix this in infrared ?","commit_id":"70a2facbc24db10f02495e8d8c9aa4b970408198"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6c3ffc75487e773d21f6e5b90c2148c774d2f691","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9a069e0d_7f45d94f","in_reply_to":"401ed038_6f2f6834","updated":"2022-07-14 12:48:35.000000000","message":"This variable can be overridden by the --storage-ip option, right ? I\u0027ve not yet fully understood how this is used in infrared but if infrared uses a different ip then why don\u0027t we use the --storage-ip option in infrared. That would be more reasonable option than adjusting upstream code for our downstream tooling.\n\nIf using undercloud by default is a quite bad idea, then we should make this parameter required one. The new proposed default is not what we\u0027ve used in current default setup implemented in TripleO code and is just another bad default, IMO.","commit_id":"70a2facbc24db10f02495e8d8c9aa4b970408198"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"66fde38be99e3e8a8d4e8c146b0e09a9ac8e59af","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"401ed038_6f2f6834","in_reply_to":"71078337_482c2d9e","updated":"2022-07-14 10:10:47.000000000","message":"Thank you for you comment Takashi. The comment might be confusing: this does not need to be the Undercloud node, this variable points to the NFS server that will hold the backups. My understanding is that in a production setting, no one will use the undercloud as the NFS server for their backups. Even if they do, and we support that, it is a very edge use case.\n\nThe idea that it points to the Undercloud by default is that it is easier for development. As we use Infrared during development, this change would make our lifes easier.\n\nChanging Infrared to use default Undercloud ip 192.168.24.1? That might be an option, but if they are using .254 instead, it should be because of reasons, right?","commit_id":"70a2facbc24db10f02495e8d8c9aa4b970408198"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"b270ed6b11ed62597af81ea0b97d15d1f67876d6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a9b78c7d_a540e233","in_reply_to":"9a069e0d_7f45d94f","updated":"2022-07-14 13:54:28.000000000","message":"OK, understood and agreed. Abandoning this change.","commit_id":"70a2facbc24db10f02495e8d8c9aa4b970408198"}],"tripleo_ansible/roles/backup_and_restore/defaults/main.yml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8d3a7ea7991040bc38db93a90c3ae5ee356487af","unresolved":true,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# All variables within this role should have a prefix of \"tripleo_backup_and_restore\""},{"line_number":43,"context_line":"# By default this should be the Undercloud node"},{"line_number":44,"context_line":"tripleo_backup_and_restore_server: 192.168.24.254"},{"line_number":45,"context_line":"tripleo_backup_and_restore_shared_storage_folder: /ctl_plane_backups"},{"line_number":46,"context_line":"tripleo_backup_and_restore_shared_storage_subfolders: []"},{"line_number":47,"context_line":"tripleo_backup_and_restore_clients_nets: [\u0027192.168.24.0/24\u0027, \u002710.0.0.0/24\u0027, \u0027172.16.0.0/24\u0027]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7d3d77c8_033ed86f","line":44,"range":{"start_line":44,"start_character":35,"end_line":44,"end_character":49},"updated":"2022-07-13 14:12:27.000000000","message":"Accorrding to L42/43, the defualt should point Undercloud node.\n\nWe use 192.168.24.1 by default for local_ip in undercloud. Updating this default breaks consistency with that.","commit_id":"70a2facbc24db10f02495e8d8c9aa4b970408198"}]}