)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cc9541e5c602681e28dc598aecf741a745ec7ab0","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Require tripleo_ceph_client_vars to be overridden"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The roles tripleo_run_cephadm, tripleo_cephadm and"},{"line_number":10,"context_line":"tripleo_ceph_client all need tripleo_ceph_client_vars"},{"line_number":11,"context_line":"to be set consistently. However, they cannot be set"},{"line_number":12,"context_line":"consistently if they contain {{ playbook_dir }} because"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"e4471358_8bd1f82f","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":29},"updated":"2022-07-26 07:29:17.000000000","message":"I\u0027ve checked current implementation of the tripleo_run_cephadm role but there is not implementation reffering to tripleo_ceph_client_vars. Is this expected or something you\u0027ll fix later ?\n\nThis explanation sounds like that role should be using  tripleo_ceph_client_vars.","commit_id":"99f2fb3f12d32c0185467f0a84dac64ea6209026"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"af3748c979cf42d53c589b53a187526d39592e34","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Require tripleo_ceph_client_vars to be overridden"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The roles tripleo_run_cephadm, tripleo_cephadm and"},{"line_number":10,"context_line":"tripleo_ceph_client all need tripleo_ceph_client_vars"},{"line_number":11,"context_line":"to be set consistently. However, they cannot be set"},{"line_number":12,"context_line":"consistently if they contain {{ playbook_dir }} because"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"942547d7_10273c4c","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":29},"in_reply_to":"e4471358_8bd1f82f","updated":"2022-10-11 13:12:52.000000000","message":"This is expected.\n\ntripleo_ceph_client_vars can be put in place by THT [1]\nand put inside cephadm_extra_vars [2]. cephadm_extra_vars\nis then used by the tripleo_run_cephadm role [3].\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/cephadm/ceph-base.yaml#L450\n[2] https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/cephadm/ceph-base.yaml#L573\n[3] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_run_cephadm/tasks/prepare.yml#L57","commit_id":"99f2fb3f12d32c0185467f0a84dac64ea6209026"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"5eb624dbaca2c72504a8a5cd2ab3999b26a2b70f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a47c798d_81c745ed","updated":"2022-07-19 15:22:59.000000000","message":"standalone-001 failure \u0027tripleo_ceph_client_vars\u0027 is undefined can be addressed by depending on the python-tripleoclient change which will set this variable.\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_275/850307/1/check/tripleo-ci-centos-9-scenario001-standalone/275a532/logs/undercloud/home/zuul/ansible.log","commit_id":"c63c25d0b9eec87b073c367f5ab5eae18e2a9a0f"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"f2563676c36e4e3710e5b3e6d701f80d199e6432","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5ed5d682_4375e990","updated":"2022-07-19 15:42:43.000000000","message":"recheck","commit_id":"a1996774f6962b6b34ef6f33adf174e811936b59"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"82480e58eb78fe0fcb4a3efb1b0d05fa66d47359","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"acbe7ad7_854af5b4","updated":"2022-07-19 21:30:40.000000000","message":"The logs [1] show this task [2] fails because \u0027tripleo_ceph_client_vars\u0027 is undefined.\ndeployed_ceph.yaml has \"CephClientConfigVars: /root/overcloud-deploy/standalone/ceph_client.yml\" [3]\ncephadm-extra-vars-heat.yml has \"tripleo_ceph_client_vars: /root/overcloud-deploy/standalone/ceph_client.yml\" [4]\nThe file exists and contains the variables per [1][5] (root is odd but that\u0027s standalone)\nSo it works on the real ceph client but fails on the mock ones from CephExternalMultiConfig [6]\nIt will handle that scenario fine as it will be be the external one [7]\nBut in the external scenario, it needs to gracefully handle this variable not being defined.\nPS3 adds a condition to handle this scenario.\n\n[1] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b46/850307/2/check/tripleo-ci-centos-9-scenario001-standalone/b46fc4d/logs/undercloud/home/zuul/ansible.log\n\n[2] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_ceph_client/tasks/main.yml#L27-L30\n\n[3] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b46/850307/2/check/tripleo-ci-centos-9-scenario001-standalone/b46fc4d/logs/undercloud/home/zuul/deployed_ceph.yaml\n\n[4] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b46/850307/2/check/tripleo-ci-centos-9-scenario001-standalone/b46fc4d/logs/undercloud/home/zuul/tripleo-deploy/standalone-ansible-jj_ba95g/cephadm/cephadm-extra-vars-heat.yml\n\n[5] \n2022-07-19 18:05:24,789 p\u003d91987 u\u003droot n\u003dansible | 2022-07-19 18:05:24.788924 | bc764e10-1131-0bfa-b9f6-000000002955 |       TASK | Check if the input variables exist\n2022-07-19 18:05:25,130 p\u003d91987 u\u003droot n\u003dansible | 2022-07-19 18:05:25.128588 | bc764e10-1131-0bfa-b9f6-000000002955 |         OK | Check if the input variables exist | undercloud\n2022-07-19 18:05:25,162 p\u003d91987 u\u003droot n\u003dansible | 2022-07-19 18:05:25.162184 | bc764e10-1131-0bfa-b9f6-000000002956 |       TASK | Load variables produced by the cephadm provisioning process\n2022-07-19 18:05:25,213 p\u003d91987 u\u003droot n\u003dansible | 2022-07-19 18:05:25.212447 | bc764e10-1131-0bfa-b9f6-000000002956 |         OK | Load variables produced by the cephadm provisioning process | undercloud\n\n[6] https://github.com/openstack/tripleo-heat-templates/blob/master/ci/environments/scenario001-standalone.yaml#L81\n\n[7] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_ceph_client/tasks/main.yml#L42-L45","commit_id":"124cbf0c7f4af54cf9af57ab28d3b86c1e28f338"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"9d7ac5445fd7cba24e662b2f90e1bf0060ebfe37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"78ea00dd_f0857b0d","updated":"2022-07-22 12:49:04.000000000","message":"recheck","commit_id":"99f2fb3f12d32c0185467f0a84dac64ea6209026"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"0f2f414b911bb7cf3acb4b05e3cd89481b3e1454","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"906cb5e7_b67bb2d0","updated":"2022-07-21 19:16:53.000000000","message":"recheck","commit_id":"99f2fb3f12d32c0185467f0a84dac64ea6209026"}]}