)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"deffda98b777de04fcb08b69f88a78eb16ece86e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7d27cd1d_77af7f78","updated":"2022-08-03 07:13:53.000000000","message":"lgtm, looking as I said I would yesterday afternoon in irc ;)\ncant spot something to complain about\n","commit_id":"1a87dad727c2e9db4620cf7987762971ea176929"}],"tripleo_ansible/roles/tripleo_podman/tasks/tripleo_podman_install.yml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"0fbf679aecc925eefc87b5eb9d9efe90f7172e35","unresolved":true,"context_lines":[{"line_number":65,"context_line":"        - \u0027\"cni-podman0\" not in ansible_facts[\"interfaces\"]\u0027"},{"line_number":66,"context_line":"        - tripleo_container_default_network_backend \u003d\u003d \u0027cni\u0027"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    - name: Update netavark container network configuration"},{"line_number":69,"context_line":"      block:"},{"line_number":70,"context_line":"        - name: Make sure /etc/containers/networks exists"},{"line_number":71,"context_line":"          file:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"16985659_a6f46a00","line":68,"range":{"start_line":68,"start_character":12,"end_line":68,"end_character":59},"updated":"2022-07-30 03:31:20.000000000","message":"Did we try using \u0027hostNetwork: true\u0027 in pod spec[1] instead? All containers atm use host network and ephemeral heat containers can also do that?\n\n[1] https://github.com/openstack/python-tripleoclient/blob/master/templates/ephemeral-heat/heat-pod.yaml.j2#L7","commit_id":"045710d93f59b4d8932bcbfdad0d139d9affdb27"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"80493ba299f32b9080918a23afce1dfe3a5cf452","unresolved":true,"context_lines":[{"line_number":65,"context_line":"        - \u0027\"cni-podman0\" not in ansible_facts[\"interfaces\"]\u0027"},{"line_number":66,"context_line":"        - tripleo_container_default_network_backend \u003d\u003d \u0027cni\u0027"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    - name: Update netavark container network configuration"},{"line_number":69,"context_line":"      block:"},{"line_number":70,"context_line":"        - name: Make sure /etc/containers/networks exists"},{"line_number":71,"context_line":"          file:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1e85770a_923a0bdd","line":68,"range":{"start_line":68,"start_character":12,"end_line":68,"end_character":59},"in_reply_to":"16985659_a6f46a00","updated":"2022-07-30 12:28:03.000000000","message":"Sounds like a plausible solution, I tried this, changed file: /usr/share/python-tripleoclient/templates/ephemeral-heat/heat-pod.yaml.j2\n\n  apiVersion: v1\n  kind: Pod\n  metadata:\n    labels:\n      app: {{ heat_pod_name }}\n    name: {{ heat_pod_name }}\n  spec:\n    hostNetwork: true      \u003c-- Added this line\n    containers:\n    - command:\n      - heat-engine\n\n  760147c37969  localhost/tripleo/openstack-heat-api:ephemeral                                                            heat-manage db_sy...  1 second ago  Up 2 seconds ago                       fervent_albattani\n\n  [root@undercloud tripleo_podman]# podman exec -it fervent_albattani /bin/bash\n  [heat@760147c37969 /]$ ip addr show\n  1: lo: \u003cLOOPBACK,UP,LOWER_UP\u003e mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000\n      link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00\n      inet 127.0.0.1/8 scope host lo\n         valid_lft forever preferred_lft forever\n      inet6 ::1/128 scope host \n         valid_lft forever preferred_lft forever\n  2: eth0@if46: \u003cBROADCAST,MULTICAST,UP,LOWER_UP\u003e mtu 1500 qdisc noqueue state UP group default qlen 1000\n      link/ether ba:6d:dd:4b:40:4b brd ff:ff:ff:ff:ff:ff link-netnsid 0\n      inet 10.255.255.6/24 brd 10.255.255.255 scope global eth0\n         valid_lft forever preferred_lft forever\n      inet6 fe80::b86d:ddff:fe4b:404b/64 scope link \n         valid_lft forever preferred_lft forever\n\nIt still fail with:\n  2022-07-30 12:23:55.810 2 WARNING oslo_db.sqlalchemy.engines [-] SQL connection failed. 10 attempts left.: oslo_db.exception.DBConnectionError: (pymysql.err.OperationalError) (2003, \"Can\u0027t connect to MySQL server on \u00272620:dead:beef:4::3\u0027\n ([Errno 101] Network is unreachable)\")\n\n\nIs /usr/share/python-tripleoclient/templates/ephemeral-heat/heat-pod.yaml.j2 not the correct file to update on a running system, did I do it wrong?","commit_id":"045710d93f59b4d8932bcbfdad0d139d9affdb27"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"eac474c7df6d7ed565cfdc485ea1ccd7ac5e57c4","unresolved":true,"context_lines":[{"line_number":65,"context_line":"        - \u0027\"cni-podman0\" not in ansible_facts[\"interfaces\"]\u0027"},{"line_number":66,"context_line":"        - tripleo_container_default_network_backend \u003d\u003d \u0027cni\u0027"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    - name: Update netavark container network configuration"},{"line_number":69,"context_line":"      block:"},{"line_number":70,"context_line":"        - name: Make sure /etc/containers/networks exists"},{"line_number":71,"context_line":"          file:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"37ea7bc9_c47c94f5","line":68,"range":{"start_line":68,"start_character":12,"end_line":68,"end_character":59},"in_reply_to":"1e85770a_923a0bdd","updated":"2022-07-30 15:13:58.000000000","message":"I think it\u0027s due to https://github.com/containers/podman/issues/14015 in 4.0.2 (a regression with https://github.com/containers/podman/commit/3e9af2029f1f92fbc069f81ba9ca90c090617e9c) and fixed in 4.1.0. We still use podman 4.0.2 in OSP17.","commit_id":"045710d93f59b4d8932bcbfdad0d139d9affdb27"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ac2ee11363d47374bd99512e5079305cf9ba5bfa","unresolved":true,"context_lines":[{"line_number":65,"context_line":"        - \u0027\"cni-podman0\" not in ansible_facts[\"interfaces\"]\u0027"},{"line_number":66,"context_line":"        - tripleo_container_default_network_backend \u003d\u003d \u0027cni\u0027"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    - name: Update netavark container network configuration"},{"line_number":69,"context_line":"      block:"},{"line_number":70,"context_line":"        - name: Make sure /etc/containers/networks exists"},{"line_number":71,"context_line":"          file:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"96f9ed63_5b1d9a77","line":68,"range":{"start_line":68,"start_character":12,"end_line":68,"end_character":59},"in_reply_to":"29547ab6_4d44ac78","updated":"2022-08-02 14:56:30.000000000","message":"No other service other than ephemeral heat would use this network. We\u0027ve seen default podman network range (cni-podman0 was changed earlier) clashing with overcloud network ranges and creating issues. May not be an issue with ephemeral heat.","commit_id":"045710d93f59b4d8932bcbfdad0d139d9affdb27"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"8fb13b0bcc84a3dd53785407032a02561474e195","unresolved":true,"context_lines":[{"line_number":65,"context_line":"        - \u0027\"cni-podman0\" not in ansible_facts[\"interfaces\"]\u0027"},{"line_number":66,"context_line":"        - tripleo_container_default_network_backend \u003d\u003d \u0027cni\u0027"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    - name: Update netavark container network configuration"},{"line_number":69,"context_line":"      block:"},{"line_number":70,"context_line":"        - name: Make sure /etc/containers/networks exists"},{"line_number":71,"context_line":"          file:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"29547ab6_4d44ac78","line":68,"range":{"start_line":68,"start_character":12,"end_line":68,"end_character":59},"in_reply_to":"37ea7bc9_c47c94f5","updated":"2022-08-01 14:56:09.000000000","message":"Too bad. I guess we need to go with this approach then.\n\nI wonder if we should:\na) Configure our own tripleo-specific network instead of re-using the default?\n  This would require a change to set heat-pod.yaml\nb) Instead of using the template, should we add a `tripleo_podman_default_network_config` section to the `tripleo_ansible/roles/tripleo_podman/vars/redhat-9.yml` vars file instead and merge that with the result of `podman network inspect`? (Personally I think the template approach is good, but I see there is a conflicting change that takes this approach.)","commit_id":"045710d93f59b4d8932bcbfdad0d139d9affdb27"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"deffda98b777de04fcb08b69f88a78eb16ece86e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            owner: root"},{"line_number":88,"context_line":"            group: root"},{"line_number":89,"context_line":"          when:"},{"line_number":90,"context_line":"            - podman_network_inspect is not skipped"},{"line_number":91,"context_line":"      when:"},{"line_number":92,"context_line":"        - tripleo_container_default_network_backend \u003d\u003d \u0027netavark\u0027"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"52a8c4d5_af73cc44","line":90,"range":{"start_line":90,"start_character":44,"end_line":90,"end_character":51},"updated":"2022-08-03 07:13:53.000000000","message":"i see you\u0027re using the registered var in the template. so what if this is failed?\ni.e. why are you only using \u0027is not skipped\u0027 ... why not more like \u0027is success\u0027 or \u0027is not failed\u0027 or maybe is not skipped and is not failed?\n\n[EDIT]: OK I guess if it is failed we would not be executing this task so... :/ skipped is ok i think","commit_id":"1a87dad727c2e9db4620cf7987762971ea176929"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ac2ee11363d47374bd99512e5079305cf9ba5bfa","unresolved":true,"context_lines":[{"line_number":89,"context_line":"          when:"},{"line_number":90,"context_line":"            - podman_network_inspect is not skipped"},{"line_number":91,"context_line":"      when:"},{"line_number":92,"context_line":"        - tripleo_container_default_network_backend \u003d\u003d \u0027netavark\u0027"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    - name: Write containers registries.conf"},{"line_number":95,"context_line":"      template:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"064103f1_cf425f29","line":92,"range":{"start_line":92,"start_character":10,"end_line":92,"end_character":65},"updated":"2022-08-02 14:56:30.000000000","message":"I suspect netavark is not there in wallaby centos8 podman version (though we don\u0027t test ipv6 ctlplane upstream). So, we need to add the ipv6 section in 87-podman-bridge.conflist as well.","commit_id":"1a87dad727c2e9db4620cf7987762971ea176929"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ed75b1aacb429fa18fc1f828103f1daa2311b9e9","unresolved":true,"context_lines":[{"line_number":89,"context_line":"          when:"},{"line_number":90,"context_line":"            - podman_network_inspect is not skipped"},{"line_number":91,"context_line":"      when:"},{"line_number":92,"context_line":"        - tripleo_container_default_network_backend \u003d\u003d \u0027netavark\u0027"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    - name: Write containers registries.conf"},{"line_number":95,"context_line":"      template:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"0a637a67_e84c7fe4","line":92,"range":{"start_line":92,"start_character":10,"end_line":92,"end_character":65},"in_reply_to":"064103f1_cf425f29","updated":"2022-08-02 15:41:17.000000000","message":"I get the feeling that is just not going to work - https://github.com/containers/podman/issues/13377 ...","commit_id":"1a87dad727c2e9db4620cf7987762971ea176929"}]}
