)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1865d491eda5350152a8b9b81a7ea23a8e337553","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"d2a36151_d36ea8d3","updated":"2022-08-26 05:23:45.000000000","message":"Leaving a few initial comments regarding the capability of vhost settings.\n\nThe core httpd_config part looks good to me but I\u0027ll take another chance to go through all again.","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"9256170d1d910e4de05dc46a2b4293e36312516a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"c3336cc4_d06cf68b","updated":"2022-09-06 16:44:33.000000000","message":"looking good, but a couple of inline comments that need addressing. thanks!","commit_id":"f7694003bfbd2c3acf30637e2f44ae70b1a81287"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"9a556daaa9294d7b9e17d0f5cf998547deed6da7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"20740531_c00363ff","updated":"2022-09-07 06:08:15.000000000","message":"the files/ directory is removed here, I\u0027d rather discuss and fix the other concerns together. So I\u0027ll push the next patchset once we\u0027re good.\n\nThanks for the comments, James!","commit_id":"f7694003bfbd2c3acf30637e2f44ae70b1a81287"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"5a1e6076738fcd2e75ff2f6676e9777692fe0679","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"da755ef5_3194605b","updated":"2022-09-13 07:00:17.000000000","message":"Looks good, Just a nit suggestion.","commit_id":"4686132a7cf1cb3c1cf097dfd9425f7a00746ca9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c10c4a0720758a887f511ce5af6ef2f771ba78e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"d77fe631_9373304c","updated":"2022-09-13 07:53:52.000000000","message":"Thanks for working on this. The change looks almost good to me.\n\nPlease allow me to put -1 to discuss design of custom_fragment.","commit_id":"4686132a7cf1cb3c1cf097dfd9425f7a00746ca9"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"d8ae54023351f713c951d68d105aad23b38aef81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":47,"id":"6940d982_0c2cb6d9","updated":"2022-09-14 02:25:48.000000000","message":"Very nice. Glad to see some Puppet modules being replaced.\n\nJust some comments about inconsistent usage of statements that define files as being managed by Ansible.\n\nAdditionally, I think for new modules, we should adhere to the recommended Ansible practise of using module FQCN\u0027s like `ansible.builtin.template` `ansible.builtin.lineinfile` etc.","commit_id":"1d33618f79d7279ab7a1e4131dd4ecb134645b3b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"accdb5894b899f84b43d729e81c8fd5ab2046a6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":48,"id":"66800dcc_ed54e377","updated":"2022-09-14 10:11:17.000000000","message":"Adding +2 because my previous concern was addressed.\n\nI like the idea of inc.j2 to explicitly show it\u0027s included by another j2 file but I\u0027m wondering whether that comes from any best-practise in ansible world.","commit_id":"1cf52227567b175599cf9898efdac5fe87703e51"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"79c8bbd9a7549a63d2f5ba3ceea7a73fd01c76c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":48,"id":"715bf3c5_2e313557","updated":"2022-09-14 10:39:38.000000000","message":"Nice one. Looks good.","commit_id":"1cf52227567b175599cf9898efdac5fe87703e51"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"313028de155f137bb6e2db901e0f1ae1a3170702","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":48,"id":"e0b8a295_5e538199","in_reply_to":"66800dcc_ed54e377","updated":"2022-09-14 12:24:03.000000000","message":"I don\u0027t think there\u0027s any best practice about this - the \".inc.foo\" comes from that old time where I was coding things in some other language - it was good to get a clear vision on the fact \"those files are included while those others aren\u0027t\".\n\nThought it was a good idea to re-use that in this context.","commit_id":"1cf52227567b175599cf9898efdac5fe87703e51"}],"tripleo_ansible/roles/tripleo_httpd_config/files/apache-status.conf":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"5a1e6076738fcd2e75ff2f6676e9777692fe0679","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\u003cLocation /server-status\u003e"},{"line_number":2,"context_line":"    SetHandler server-status"},{"line_number":3,"context_line":"    Require ip 127.0.0.1 ::1"},{"line_number":4,"context_line":"\u003c/Location\u003e"},{"line_number":5,"context_line":"ExtendedStatus On"},{"line_number":6,"context_line":""}],"source_content_type":"text/plain","patch_set":45,"id":"86ceb9d6_7d2bc7e6","line":3,"range":{"start_line":3,"start_character":15,"end_line":3,"end_character":28},"updated":"2022-09-13 07:00:17.000000000","message":"Can we convert this config file into a template and make the ip customizable via ansible var? Just a thought.","commit_id":"4686132a7cf1cb3c1cf097dfd9425f7a00746ca9"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"c5a0913e2e21632ba86bc72a9ac960b9c20fd3f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cLocation /server-status\u003e"},{"line_number":2,"context_line":"    SetHandler server-status"},{"line_number":3,"context_line":"    Require ip 127.0.0.1 ::1"},{"line_number":4,"context_line":"\u003c/Location\u003e"},{"line_number":5,"context_line":"ExtendedStatus On"},{"line_number":6,"context_line":""}],"source_content_type":"text/plain","patch_set":45,"id":"b5c089da_3548e983","line":3,"range":{"start_line":3,"start_character":15,"end_line":3,"end_character":28},"in_reply_to":"86ceb9d6_7d2bc7e6","updated":"2022-09-13 07:30:01.000000000","message":"I was also thinking about something like that. And maybe, instead of getting this as an actual conf.d file, get it loaded from the \"modules.conf\" when we hit the \"status\" module...\n\nNote: currently, it\u0027s not possible to customize this from within puppet-openstacklib, and I didn\u0027t see any attempt at doing that. So maybe more as a follow-up, imho. Also for my other thoughts.","commit_id":"4686132a7cf1cb3c1cf097dfd9425f7a00746ca9"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"295921c072c4b5b668b694e1cda463470f8e650f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cLocation /server-status\u003e"},{"line_number":2,"context_line":"    SetHandler server-status"},{"line_number":3,"context_line":"    Require ip 127.0.0.1 ::1"},{"line_number":4,"context_line":"\u003c/Location\u003e"},{"line_number":5,"context_line":"ExtendedStatus On"},{"line_number":6,"context_line":""}],"source_content_type":"text/plain","patch_set":45,"id":"9e11734d_677ae7d4","line":3,"range":{"start_line":3,"start_character":15,"end_line":3,"end_character":28},"in_reply_to":"b5c089da_3548e983","updated":"2022-09-13 07:37:31.000000000","message":"Thank you Tengu for considering it. Sounds good as a follow up.","commit_id":"4686132a7cf1cb3c1cf097dfd9425f7a00746ca9"}],"tripleo_ansible/roles/tripleo_httpd_config/vars/main.yml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"9256170d1d910e4de05dc46a2b4293e36312516a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":27,"id":"c96a66e2_f9b1cadc","updated":"2022-09-06 16:44:33.000000000","message":"why are these defined here instead of defaults/main.yml? I get there is a precedence difference [1], but is there a reason behind that?\n\n[1] https://docs.ansible.com/ansible/latest/user_guide/playbooks_variables.html#understanding-variable-precedence","commit_id":"69eb97e700cd08f125636a90cbee2d38ad05588f"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"b6ec9a810646d22673a452d11c0218f7279a2c96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"af84a8f3_5dc1e495","in_reply_to":"119fafef_2ad86bfc","updated":"2022-09-09 08:49:31.000000000","message":"Done","commit_id":"69eb97e700cd08f125636a90cbee2d38ad05588f"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"9a556daaa9294d7b9e17d0f5cf998547deed6da7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":27,"id":"119fafef_2ad86bfc","in_reply_to":"c96a66e2_f9b1cadc","updated":"2022-09-07 06:08:15.000000000","message":"hmmmm I think this is the right place : those are defaults thing that shouldn\u0027t be modified by the user, usually merged with other vars that are aimed at being customized.","commit_id":"69eb97e700cd08f125636a90cbee2d38ad05588f"}],"tripleo_ansible/roles/tripleo_httpd_vhost/defaults/main.yml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1865d491eda5350152a8b9b81a7ea23a8e337553","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"tripleo_httpd_vhost_access_log_file: \"/var/log/httpd/{{ tripleo_httpd_vhost_service_name }}_access.log\""},{"line_number":28,"context_line":"tripleo_httpd_vhost_access_log_format: \u0027combined\u0027"},{"line_number":29,"context_line":"tripleo_httpd_vhost_access_log_pipe: null"},{"line_number":30,"context_line":"tripleo_httpd_vhost_access_log_syslog: null"},{"line_number":31,"context_line":"tripleo_httpd_vhost_aliases: null"},{"line_number":32,"context_line":"tripleo_httpd_vhost_allow_encoded_slashes: null"},{"line_number":33,"context_line":"tripleo_httpd_vhost_bind_host: \u0027*\u0027"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"b8efdc77_ff3460b3","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":43},"updated":"2022-08-26 05:23:45.000000000","message":"The functionality to use syslog is not globally implemented in puppet modules.\nI think we can omit this in the initial tripleo-ansible implementation.","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"e9aa52de0b5d4abe6c0b8cf59ca3221ba75d9116","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"tripleo_httpd_vhost_access_log_file: \"/var/log/httpd/{{ tripleo_httpd_vhost_service_name }}_access.log\""},{"line_number":28,"context_line":"tripleo_httpd_vhost_access_log_format: \u0027combined\u0027"},{"line_number":29,"context_line":"tripleo_httpd_vhost_access_log_pipe: null"},{"line_number":30,"context_line":"tripleo_httpd_vhost_access_log_syslog: null"},{"line_number":31,"context_line":"tripleo_httpd_vhost_aliases: null"},{"line_number":32,"context_line":"tripleo_httpd_vhost_allow_encoded_slashes: null"},{"line_number":33,"context_line":"tripleo_httpd_vhost_bind_host: \u0027*\u0027"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"f1c14040_be3cf242","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":43},"in_reply_to":"b8efdc77_ff3460b3","updated":"2022-08-30 07:41:01.000000000","message":"Done","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1865d491eda5350152a8b9b81a7ea23a8e337553","unresolved":true,"context_lines":[{"line_number":29,"context_line":"tripleo_httpd_vhost_access_log_pipe: null"},{"line_number":30,"context_line":"tripleo_httpd_vhost_access_log_syslog: null"},{"line_number":31,"context_line":"tripleo_httpd_vhost_aliases: null"},{"line_number":32,"context_line":"tripleo_httpd_vhost_allow_encoded_slashes: null"},{"line_number":33,"context_line":"tripleo_httpd_vhost_bind_host: \u0027*\u0027"},{"line_number":34,"context_line":"tripleo_httpd_vhost_bind_port: 80"},{"line_number":35,"context_line":"tripleo_httpd_vhost_custom_wsgi_process_options: {}"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"b5c52dd8_7e78e07b","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":41},"updated":"2022-08-26 05:23:45.000000000","message":"I\u0027m not aware of any cases where this is used. Maybe we can omit this now.","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"efa08efa65812329f78b4542b07b11b1d99841ca","unresolved":false,"context_lines":[{"line_number":29,"context_line":"tripleo_httpd_vhost_access_log_pipe: null"},{"line_number":30,"context_line":"tripleo_httpd_vhost_access_log_syslog: null"},{"line_number":31,"context_line":"tripleo_httpd_vhost_aliases: null"},{"line_number":32,"context_line":"tripleo_httpd_vhost_allow_encoded_slashes: null"},{"line_number":33,"context_line":"tripleo_httpd_vhost_bind_host: \u0027*\u0027"},{"line_number":34,"context_line":"tripleo_httpd_vhost_bind_port: 80"},{"line_number":35,"context_line":"tripleo_httpd_vhost_custom_wsgi_process_options: {}"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"82a95116_be2e14e3","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":41},"in_reply_to":"8e9851f7_e7141839","updated":"2022-08-29 13:53:12.000000000","message":"ah, I\u0027ll more than probably have to amend my current patches to cover that, iirc I didn\u0027t actually use that parameter for now..","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3f8514c2b69d1e6759926338455e62ddc5903399","unresolved":false,"context_lines":[{"line_number":29,"context_line":"tripleo_httpd_vhost_access_log_pipe: null"},{"line_number":30,"context_line":"tripleo_httpd_vhost_access_log_syslog: null"},{"line_number":31,"context_line":"tripleo_httpd_vhost_aliases: null"},{"line_number":32,"context_line":"tripleo_httpd_vhost_allow_encoded_slashes: null"},{"line_number":33,"context_line":"tripleo_httpd_vhost_bind_host: \u0027*\u0027"},{"line_number":34,"context_line":"tripleo_httpd_vhost_bind_port: 80"},{"line_number":35,"context_line":"tripleo_httpd_vhost_custom_wsgi_process_options: {}"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"8e9851f7_e7141839","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":41},"in_reply_to":"b5c52dd8_7e78e07b","updated":"2022-08-26 07:47:42.000000000","message":"Hmm... We do use this for Heat.","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1865d491eda5350152a8b9b81a7ea23a8e337553","unresolved":true,"context_lines":[{"line_number":33,"context_line":"tripleo_httpd_vhost_bind_host: \u0027*\u0027"},{"line_number":34,"context_line":"tripleo_httpd_vhost_bind_port: 80"},{"line_number":35,"context_line":"tripleo_httpd_vhost_custom_wsgi_process_options: {}"},{"line_number":36,"context_line":"tripleo_httpd_vhost_custom_wsgi_script_aliases: null"},{"line_number":37,"context_line":"tripleo_httpd_vhost_document_root: \u0027/var/www/cgi-bin\u0027"},{"line_number":38,"context_line":"tripleo_httpd_vhost_error_log_file: \"/var/log/httpd/{{ tripleo_httpd_vhost_service_name }}_error.log\""},{"line_number":39,"context_line":"tripleo_httpd_vhost_error_log_pipe: null"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"e7f559cf_9edb18d8","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":52},"updated":"2022-08-26 05:23:45.000000000","message":"This is not really used in TripleO deployment and I don\u0027t think users need to switch to a different script. The default should work.","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"e9aa52de0b5d4abe6c0b8cf59ca3221ba75d9116","unresolved":false,"context_lines":[{"line_number":33,"context_line":"tripleo_httpd_vhost_bind_host: \u0027*\u0027"},{"line_number":34,"context_line":"tripleo_httpd_vhost_bind_port: 80"},{"line_number":35,"context_line":"tripleo_httpd_vhost_custom_wsgi_process_options: {}"},{"line_number":36,"context_line":"tripleo_httpd_vhost_custom_wsgi_script_aliases: null"},{"line_number":37,"context_line":"tripleo_httpd_vhost_document_root: \u0027/var/www/cgi-bin\u0027"},{"line_number":38,"context_line":"tripleo_httpd_vhost_error_log_file: \"/var/log/httpd/{{ tripleo_httpd_vhost_service_name }}_error.log\""},{"line_number":39,"context_line":"tripleo_httpd_vhost_error_log_pipe: null"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"ff3b2906_0fa2cff0","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":52},"in_reply_to":"e7f559cf_9edb18d8","updated":"2022-08-30 07:41:01.000000000","message":"Done","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1865d491eda5350152a8b9b81a7ea23a8e337553","unresolved":true,"context_lines":[{"line_number":36,"context_line":"tripleo_httpd_vhost_custom_wsgi_script_aliases: null"},{"line_number":37,"context_line":"tripleo_httpd_vhost_document_root: \u0027/var/www/cgi-bin\u0027"},{"line_number":38,"context_line":"tripleo_httpd_vhost_error_log_file: \"/var/log/httpd/{{ tripleo_httpd_vhost_service_name }}_error.log\""},{"line_number":39,"context_line":"tripleo_httpd_vhost_error_log_pipe: null"},{"line_number":40,"context_line":"tripleo_httpd_vhost_error_log_syslog: null"},{"line_number":41,"context_line":"tripleo_httpd_vhost_group: \u0027apache\u0027"},{"line_number":42,"context_line":"tripleo_httpd_vhost_headers: null"},{"line_number":43,"context_line":"tripleo_httpd_vhost_log_level: null"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"eb5ae127_c3968d0f","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":42},"updated":"2022-08-26 05:23:45.000000000","message":"ditto. Let\u0027s omit this now.","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"e9aa52de0b5d4abe6c0b8cf59ca3221ba75d9116","unresolved":false,"context_lines":[{"line_number":36,"context_line":"tripleo_httpd_vhost_custom_wsgi_script_aliases: null"},{"line_number":37,"context_line":"tripleo_httpd_vhost_document_root: \u0027/var/www/cgi-bin\u0027"},{"line_number":38,"context_line":"tripleo_httpd_vhost_error_log_file: \"/var/log/httpd/{{ tripleo_httpd_vhost_service_name }}_error.log\""},{"line_number":39,"context_line":"tripleo_httpd_vhost_error_log_pipe: null"},{"line_number":40,"context_line":"tripleo_httpd_vhost_error_log_syslog: null"},{"line_number":41,"context_line":"tripleo_httpd_vhost_group: \u0027apache\u0027"},{"line_number":42,"context_line":"tripleo_httpd_vhost_headers: null"},{"line_number":43,"context_line":"tripleo_httpd_vhost_log_level: null"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"076894df_787dc4dc","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":42},"in_reply_to":"eb5ae127_c3968d0f","updated":"2022-08-30 07:41:01.000000000","message":"Done","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1865d491eda5350152a8b9b81a7ea23a8e337553","unresolved":true,"context_lines":[{"line_number":54,"context_line":"tripleo_httpd_vhost_request_headers: []"},{"line_number":55,"context_line":"tripleo_httpd_vhost_servername: \"{{ ansible_facts[\u0027fqdn\u0027] }}\""},{"line_number":56,"context_line":"tripleo_httpd_vhost_setenv: []"},{"line_number":57,"context_line":"tripleo_httpd_vhost_set_wsgi_import_script: false"},{"line_number":58,"context_line":"tripleo_httpd_vhost_ssl_ca: null"},{"line_number":59,"context_line":"tripleo_httpd_vhost_ssl_certs_dir: null"},{"line_number":60,"context_line":"tripleo_httpd_vhost_ssl_cert: null"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"605334f5_b346006a","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":49},"updated":"2022-08-26 05:23:45.000000000","message":"this is not used in TripleO.","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"e9aa52de0b5d4abe6c0b8cf59ca3221ba75d9116","unresolved":false,"context_lines":[{"line_number":54,"context_line":"tripleo_httpd_vhost_request_headers: []"},{"line_number":55,"context_line":"tripleo_httpd_vhost_servername: \"{{ ansible_facts[\u0027fqdn\u0027] }}\""},{"line_number":56,"context_line":"tripleo_httpd_vhost_setenv: []"},{"line_number":57,"context_line":"tripleo_httpd_vhost_set_wsgi_import_script: false"},{"line_number":58,"context_line":"tripleo_httpd_vhost_ssl_ca: null"},{"line_number":59,"context_line":"tripleo_httpd_vhost_ssl_certs_dir: null"},{"line_number":60,"context_line":"tripleo_httpd_vhost_ssl_cert: null"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"42b786e7_014f455d","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":49},"in_reply_to":"5af1851f_775985af","updated":"2022-08-30 07:41:01.000000000","message":"keeping it, the code behind it in the template isn\u0027t THAT big.","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"efa08efa65812329f78b4542b07b11b1d99841ca","unresolved":true,"context_lines":[{"line_number":54,"context_line":"tripleo_httpd_vhost_request_headers: []"},{"line_number":55,"context_line":"tripleo_httpd_vhost_servername: \"{{ ansible_facts[\u0027fqdn\u0027] }}\""},{"line_number":56,"context_line":"tripleo_httpd_vhost_setenv: []"},{"line_number":57,"context_line":"tripleo_httpd_vhost_set_wsgi_import_script: false"},{"line_number":58,"context_line":"tripleo_httpd_vhost_ssl_ca: null"},{"line_number":59,"context_line":"tripleo_httpd_vhost_ssl_certs_dir: null"},{"line_number":60,"context_line":"tripleo_httpd_vhost_ssl_cert: null"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"5af1851f_775985af","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":49},"in_reply_to":"605334f5_b346006a","updated":"2022-08-29 13:53:12.000000000","message":"hmmm iirc it\u0027s used in puppet-openstacklib","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"}],"tripleo_ansible/roles/tripleo_httpd_vhost/files/.gitkeep":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"9256170d1d910e4de05dc46a2b4293e36312516a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":37,"id":"477602d5_2c96d984","updated":"2022-09-06 16:44:33.000000000","message":"i guess we can delete this and the dir if it\u0027s not needed?","commit_id":"f7694003bfbd2c3acf30637e2f44ae70b1a81287"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"9a556daaa9294d7b9e17d0f5cf998547deed6da7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"3e4a37b3_a4705526","in_reply_to":"477602d5_2c96d984","updated":"2022-09-07 06:08:15.000000000","message":"Done","commit_id":"f7694003bfbd2c3acf30637e2f44ae70b1a81287"}],"tripleo_ansible/roles/tripleo_httpd_vhost/handlers/main.yml":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"d8ae54023351f713c951d68d105aad23b38aef81","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2022 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":47,"id":"e1a3ecab_5bc6d331","line":1,"updated":"2022-09-14 02:25:48.000000000","message":"We can remove the handlers directory if we\u0027re not using handlers.","commit_id":"1d33618f79d7279ab7a1e4131dd4ecb134645b3b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"986f9185e7d3c17c19ad2bc4619310164f6eac7d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2022 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":47,"id":"4f402b39_72d6529c","line":1,"in_reply_to":"e1a3ecab_5bc6d331","updated":"2022-09-14 06:18:03.000000000","message":"ah, right.","commit_id":"1d33618f79d7279ab7a1e4131dd4ecb134645b3b"}],"tripleo_ansible/roles/tripleo_httpd_vhost/tasks/install.yml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"9256170d1d910e4de05dc46a2b4293e36312516a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":37,"id":"abe7c430_715f20ca","line":23,"updated":"2022-09-06 16:44:33.000000000","message":"this would run tasks from main.yml. Do we not want to use tasks_from: install.yml here?","commit_id":"f7694003bfbd2c3acf30637e2f44ae70b1a81287"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"b6ec9a810646d22673a452d11c0218f7279a2c96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"f89f5bd5_e578f514","line":23,"in_reply_to":"4852d728_48672d4c","updated":"2022-09-09 08:49:31.000000000","message":"Done","commit_id":"f7694003bfbd2c3acf30637e2f44ae70b1a81287"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"9a556daaa9294d7b9e17d0f5cf998547deed6da7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":37,"id":"4852d728_48672d4c","line":23,"in_reply_to":"abe7c430_715f20ca","updated":"2022-09-07 06:08:15.000000000","message":"nope, we really want the whole role. The \"main.yaml\" calls the \"install\" and \"configure\", which are:\n- creating the directory tree via install.yaml\n- pushing the httpd configuration (i.e. httpd.conf, modules.conf, and empty ports.conf) from the configure.yaml\n\nDoing so allows to only include one role from tripleo-heat-templates.","commit_id":"f7694003bfbd2c3acf30637e2f44ae70b1a81287"}],"tripleo_ansible/roles/tripleo_httpd_vhost/tasks/main.yml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"9256170d1d910e4de05dc46a2b4293e36312516a","unresolved":true,"context_lines":[{"line_number":62,"context_line":"      when: item.v \u003d\u003d None"},{"line_number":63,"context_line":"      loop:"},{"line_number":64,"context_line":"        - k: \u0027tripleo_httpd_vhost_wsgi_script_alias\u0027"},{"line_number":65,"context_line":"          v: \"{{ tripleo_httpd_vhost_wsgi_script_alias }}\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"- name: Gather some facts"},{"line_number":68,"context_line":"  when: \"\u0027processor_count\u0027 not in ansible_facts or \u0027fqdn\u0027 not in ansible_facts\""}],"source_content_type":"text/x-yaml","patch_set":37,"id":"7e209fb4_e72ccf96","line":65,"updated":"2022-09-06 16:44:33.000000000","message":"could we move these tasks to a parameters.yml? And then have that included from install.yml and/or vhost.yml?\n\nIf these are actually needed for either of those tasks files, I just wonder how it will use them when you want to just run install.yml or vhost.yml, etc.","commit_id":"f7694003bfbd2c3acf30637e2f44ae70b1a81287"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"b6ec9a810646d22673a452d11c0218f7279a2c96","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      when: item.v \u003d\u003d None"},{"line_number":63,"context_line":"      loop:"},{"line_number":64,"context_line":"        - k: \u0027tripleo_httpd_vhost_wsgi_script_alias\u0027"},{"line_number":65,"context_line":"          v: \"{{ tripleo_httpd_vhost_wsgi_script_alias }}\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"- name: Gather some facts"},{"line_number":68,"context_line":"  when: \"\u0027processor_count\u0027 not in ansible_facts or \u0027fqdn\u0027 not in ansible_facts\""}],"source_content_type":"text/x-yaml","patch_set":37,"id":"649377d7_0a2e561e","line":65,"in_reply_to":"00936bea_a3055117","updated":"2022-09-09 08:49:31.000000000","message":"Done","commit_id":"f7694003bfbd2c3acf30637e2f44ae70b1a81287"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"9a556daaa9294d7b9e17d0f5cf998547deed6da7","unresolved":true,"context_lines":[{"line_number":62,"context_line":"      when: item.v \u003d\u003d None"},{"line_number":63,"context_line":"      loop:"},{"line_number":64,"context_line":"        - k: \u0027tripleo_httpd_vhost_wsgi_script_alias\u0027"},{"line_number":65,"context_line":"          v: \"{{ tripleo_httpd_vhost_wsgi_script_alias }}\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"- name: Gather some facts"},{"line_number":68,"context_line":"  when: \"\u0027processor_count\u0027 not in ansible_facts or \u0027fqdn\u0027 not in ansible_facts\""}],"source_content_type":"text/x-yaml","patch_set":37,"id":"00936bea_a3055117","line":65,"in_reply_to":"7e209fb4_e72ccf96","updated":"2022-09-07 06:08:15.000000000","message":"it\u0027s not really intended to run only this or that task file. I mean, the install.yaml can be covered by calling the tripleo_httpd_config role instead. Here, the \"install.yaml\" is really just a helper/wrapper.\n\nI\u0027m OK to split those parameters verification into another file, but I\u0027m not really sure it\u0027s worth it... ?","commit_id":"f7694003bfbd2c3acf30637e2f44ae70b1a81287"}],"tripleo_ansible/roles/tripleo_httpd_vhost/tasks/vhost.yml":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"d8ae54023351f713c951d68d105aad23b38aef81","unresolved":true,"context_lines":[{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Push vhost port"},{"line_number":18,"context_line":"  lineinfile:"},{"line_number":19,"context_line":"    path: \"{{ tripleo_httpd_vhost_config }}/conf/ports.conf\""},{"line_number":20,"context_line":"    line: \u0027Listen {{ tripleo_httpd_vhost_bind_host }}:{{ tripleo_httpd_vhost_bind_port }}\u0027"},{"line_number":21,"context_line":"    create: true"}],"source_content_type":"text/x-yaml","patch_set":47,"id":"82d1bd50_1b6b2be2","line":18,"updated":"2022-09-14 02:25:48.000000000","message":"Since this is a new role, we should use the FQCN for all of these modules. `ansible.builtin.lineinfile` to adhere to the Ansible recommendations:\nhttps://docs.ansible.com/ansible/latest/collections/ansible/builtin/lineinfile_module.html","commit_id":"1d33618f79d7279ab7a1e4131dd4ecb134645b3b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"986f9185e7d3c17c19ad2bc4619310164f6eac7d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Push vhost port"},{"line_number":18,"context_line":"  lineinfile:"},{"line_number":19,"context_line":"    path: \"{{ tripleo_httpd_vhost_config }}/conf/ports.conf\""},{"line_number":20,"context_line":"    line: \u0027Listen {{ tripleo_httpd_vhost_bind_host }}:{{ tripleo_httpd_vhost_bind_port }}\u0027"},{"line_number":21,"context_line":"    create: true"}],"source_content_type":"text/x-yaml","patch_set":47,"id":"a696ce5f_2d739f97","line":18,"in_reply_to":"82d1bd50_1b6b2be2","updated":"2022-09-14 06:18:03.000000000","message":"Ack","commit_id":"1d33618f79d7279ab7a1e4131dd4ecb134645b3b"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"d8ae54023351f713c951d68d105aad23b38aef81","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    mode: 0644"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- name: Push vhost configuration file"},{"line_number":27,"context_line":"  template:"},{"line_number":28,"context_line":"    dest: \"{{ tripleo_httpd_vhost_config }}/conf.d/{{ tripleo_httpd_vhost_priority }}-{{ tripleo_httpd_vhost_service_name }}.conf\""},{"line_number":29,"context_line":"    src: vhost.conf.j2"}],"source_content_type":"text/x-yaml","patch_set":47,"id":"6f8449db_894807a0","line":27,"updated":"2022-09-14 02:25:48.000000000","message":"`ansible.builtin.template`","commit_id":"1d33618f79d7279ab7a1e4131dd4ecb134645b3b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"986f9185e7d3c17c19ad2bc4619310164f6eac7d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    mode: 0644"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- name: Push vhost configuration file"},{"line_number":27,"context_line":"  template:"},{"line_number":28,"context_line":"    dest: \"{{ tripleo_httpd_vhost_config }}/conf.d/{{ tripleo_httpd_vhost_priority }}-{{ tripleo_httpd_vhost_service_name }}.conf\""},{"line_number":29,"context_line":"    src: vhost.conf.j2"}],"source_content_type":"text/x-yaml","patch_set":47,"id":"b601c246_6bde792a","line":27,"in_reply_to":"6f8449db_894807a0","updated":"2022-09-14 06:18:03.000000000","message":"Ack","commit_id":"1d33618f79d7279ab7a1e4131dd4ecb134645b3b"}],"tripleo_ansible/roles/tripleo_httpd_vhost/templates/proxy.j2":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"d8ae54023351f713c951d68d105aad23b38aef81","unresolved":true,"context_lines":[{"line_number":1,"context_line":"  # Proxy configuration"},{"line_number":2,"context_line":"  ProxyRequests {{ tripleo_httpd_vhost_proxy_requests }}"},{"line_number":3,"context_line":"  ProxyPreserveHost {{ tripleo_httpd_vhost_proxy_preserve_host }}"},{"line_number":4,"context_line":"  ProxyPass {{ tripleo_httpd_vhost_proxy_path }} http://{{ tripleo_httpd_vhost_proxy_host }}:{{ tripleo_httpd_vhost_proxy_port }}/ {{ tripleo_httpd_vhost_proxy_params.items() | map(\u0027join\u0027, \u0027\u003d\u0027) | join(\u0027 \u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":47,"id":"eb4fc5a7_4bf4391f","line":1,"updated":"2022-09-14 02:25:48.000000000","message":"Do we want the ansible_managed statement in this file too? We are using it in other template files within this change. Might be good to have it in all of them?\n\nEven though we aren\u0027t using the actual `{{ ansible_managed }}` variable, we are at least defining that the file is one that is managed by Ansible:\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/853481/47/tripleo_ansible/roles/tripleo_httpd_config/templates/httpd.conf.j2#1","commit_id":"1d33618f79d7279ab7a1e4131dd4ecb134645b3b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"986f9185e7d3c17c19ad2bc4619310164f6eac7d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"  # Proxy configuration"},{"line_number":2,"context_line":"  ProxyRequests {{ tripleo_httpd_vhost_proxy_requests }}"},{"line_number":3,"context_line":"  ProxyPreserveHost {{ tripleo_httpd_vhost_proxy_preserve_host }}"},{"line_number":4,"context_line":"  ProxyPass {{ tripleo_httpd_vhost_proxy_path }} http://{{ tripleo_httpd_vhost_proxy_host }}:{{ tripleo_httpd_vhost_proxy_port }}/ {{ tripleo_httpd_vhost_proxy_params.items() | map(\u0027join\u0027, \u0027\u003d\u0027) | join(\u0027 \u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":47,"id":"ee77cf11_d5f0289f","line":1,"in_reply_to":"eb4fc5a7_4bf4391f","updated":"2022-09-14 06:18:03.000000000","message":"not really - this one is included in the main vhost.j2 - so it would be a repetition.","commit_id":"1d33618f79d7279ab7a1e4131dd4ecb134645b3b"}],"tripleo_ansible/roles/tripleo_httpd_vhost/templates/vhost.conf.j2":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1865d491eda5350152a8b9b81a7ea23a8e337553","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# File managed by tripleo-ansible/tripleo_httpd_vhost"},{"line_number":2,"context_line":"\u003cVirtualHost {{ tripleo_httpd_vhost_bind_host }}:{{ tripleo_httpd_vhost_bind_port }}\u003e"},{"line_number":3,"context_line":"  ServerName {{ tripleo_httpd_vhost_servername }}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  ## Vhost docroot"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"63f0ede2_735cc205","line":2,"updated":"2022-08-26 05:23:45.000000000","message":"Currently cinder and heat use vhost_custom_fragment to set the timeout option. which seems to be globally useful. Can we implement the native parameter ?","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"efa08efa65812329f78b4542b07b11b1d99841ca","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# File managed by tripleo-ansible/tripleo_httpd_vhost"},{"line_number":2,"context_line":"\u003cVirtualHost {{ tripleo_httpd_vhost_bind_host }}:{{ tripleo_httpd_vhost_bind_port }}\u003e"},{"line_number":3,"context_line":"  ServerName {{ tripleo_httpd_vhost_servername }}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  ## Vhost docroot"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"f0ea6e99_1e92f745","line":2,"in_reply_to":"63f0ede2_735cc205","updated":"2022-08-29 13:53:12.000000000","message":"we can pass a dict of options that will be merged into httpd.conf and the defaults. Should do the trick.","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"824c5f8019d3a292a6f0c029d867b7232448a250","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# File managed by tripleo-ansible/tripleo_httpd_vhost"},{"line_number":2,"context_line":"\u003cVirtualHost {{ tripleo_httpd_vhost_bind_host }}:{{ tripleo_httpd_vhost_bind_port }}\u003e"},{"line_number":3,"context_line":"  ServerName {{ tripleo_httpd_vhost_servername }}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  ## Vhost docroot"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"580884c7_0e08cb07","line":2,"in_reply_to":"f0ea6e99_1e92f745","updated":"2022-09-05 13:09:16.000000000","message":"Done","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1865d491eda5350152a8b9b81a7ea23a8e337553","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  ## Logging"},{"line_number":15,"context_line":"  ErrorLog \"{{ tripleo_httpd_vhost_error_log_file }}\""},{"line_number":16,"context_line":"  ServerSignature Off"},{"line_number":17,"context_line":"  CustomLog \"tripleo_httpd_vhost_access_log_file\" {{ tripleo_httpd_vhost_access_log_format }}"},{"line_number":18,"context_line":"  SetEnvIf X-Forwarded-Proto https HTTPS\u003d1"},{"line_number":19,"context_line":"{% for request_header in tripleo_httpd_vhost_request_headers %}"},{"line_number":20,"context_line":"  RequestHeader {{ request_header }}"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"1988e587_0ab13d60","line":17,"range":{"start_line":17,"start_character":13,"end_line":17,"end_character":48},"updated":"2022-08-26 05:23:45.000000000","message":"I think this should be;\n\n{{ tripleo_httpd_vhost_access_log_file }}","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"e9aa52de0b5d4abe6c0b8cf59ca3221ba75d9116","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  ## Logging"},{"line_number":15,"context_line":"  ErrorLog \"{{ tripleo_httpd_vhost_error_log_file }}\""},{"line_number":16,"context_line":"  ServerSignature Off"},{"line_number":17,"context_line":"  CustomLog \"tripleo_httpd_vhost_access_log_file\" {{ tripleo_httpd_vhost_access_log_format }}"},{"line_number":18,"context_line":"  SetEnvIf X-Forwarded-Proto https HTTPS\u003d1"},{"line_number":19,"context_line":"{% for request_header in tripleo_httpd_vhost_request_headers %}"},{"line_number":20,"context_line":"  RequestHeader {{ request_header }}"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"a8bb0958_e2aa3d9e","line":17,"range":{"start_line":17,"start_character":13,"end_line":17,"end_character":48},"in_reply_to":"1988e587_0ab13d60","updated":"2022-08-30 07:41:01.000000000","message":"Done","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1865d491eda5350152a8b9b81a7ea23a8e337553","unresolved":true,"context_lines":[{"line_number":19,"context_line":"{% for request_header in tripleo_httpd_vhost_request_headers %}"},{"line_number":20,"context_line":"  RequestHeader {{ request_header }}"},{"line_number":21,"context_line":"{% endfor -%}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  ## Proxy rules"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{% if tripleo_httpd_vhost_wsgi|bool %}"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"e1190e08_f5024d7d","line":22,"updated":"2022-08-26 05:23:45.000000000","message":"Can we also support Header ?\n\nI\u0027ve seen a few cases where the option needs to be configured.","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"e9aa52de0b5d4abe6c0b8cf59ca3221ba75d9116","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{% for request_header in tripleo_httpd_vhost_request_headers %}"},{"line_number":20,"context_line":"  RequestHeader {{ request_header }}"},{"line_number":21,"context_line":"{% endfor -%}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  ## Proxy rules"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{% if tripleo_httpd_vhost_wsgi|bool %}"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"65d41603_a24f8af6","line":22,"in_reply_to":"244e8d9e_2c6ba438","updated":"2022-08-30 07:41:01.000000000","message":"Done","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"efa08efa65812329f78b4542b07b11b1d99841ca","unresolved":true,"context_lines":[{"line_number":19,"context_line":"{% for request_header in tripleo_httpd_vhost_request_headers %}"},{"line_number":20,"context_line":"  RequestHeader {{ request_header }}"},{"line_number":21,"context_line":"{% endfor -%}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  ## Proxy rules"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{% if tripleo_httpd_vhost_wsgi|bool %}"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"244e8d9e_2c6ba438","line":22,"in_reply_to":"e1190e08_f5024d7d","updated":"2022-08-29 13:53:12.000000000","message":"hmm ok. have to check for that.","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1865d491eda5350152a8b9b81a7ea23a8e337553","unresolved":true,"context_lines":[{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":"{% if tripleo_httpd_vhost_proxy|bool %}"},{"line_number":32,"context_line":"{%   include \u0027templates/proxy.j2\u0027 %}"},{"line_number":33,"context_line":"{% endif %}"},{"line_number":34,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"35882156_d25a72f8","line":33,"range":{"start_line":33,"start_character":9,"end_line":33,"end_character":11},"updated":"2022-08-26 05:23:45.000000000","message":"seems vhost_custom_fragment is missing ?","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"efa08efa65812329f78b4542b07b11b1d99841ca","unresolved":true,"context_lines":[{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":"{% if tripleo_httpd_vhost_proxy|bool %}"},{"line_number":32,"context_line":"{%   include \u0027templates/proxy.j2\u0027 %}"},{"line_number":33,"context_line":"{% endif %}"},{"line_number":34,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"69bb620a_245c0a00","line":33,"range":{"start_line":33,"start_character":9,"end_line":33,"end_character":11},"in_reply_to":"35882156_d25a72f8","updated":"2022-08-29 13:53:12.000000000","message":"Hmmm nope. Also, I\u0027ve done a huge refactoring locally (sorry) - still under test with molecule.","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"e9aa52de0b5d4abe6c0b8cf59ca3221ba75d9116","unresolved":false,"context_lines":[{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":"{% if tripleo_httpd_vhost_proxy|bool %}"},{"line_number":32,"context_line":"{%   include \u0027templates/proxy.j2\u0027 %}"},{"line_number":33,"context_line":"{% endif %}"},{"line_number":34,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"a44097db_74df7dc8","line":33,"range":{"start_line":33,"start_character":9,"end_line":33,"end_character":11},"in_reply_to":"69bb620a_245c0a00","updated":"2022-08-30 07:41:01.000000000","message":"Done","commit_id":"9cc42aec8d191cd047fa4bb819ac61405d065c3e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c10c4a0720758a887f511ce5af6ef2f771ba78e0","unresolved":true,"context_lines":[{"line_number":22,"context_line":"{% for header in tripleo_httpd_vhost_headers %}"},{"line_number":23,"context_line":"  Header {{ header }}"},{"line_number":24,"context_line":"{% endfor %}"},{"line_number":25,"context_line":"{% if tripleo_httpd_vhost_allow_encoded_slashes !\u003d None and tripleo_httpd_vhost_allow_encoded_slashes in [\u0027on\u0027, \u0027off\u0027, \u0027nodecode\u0027] %}"},{"line_number":26,"context_line":"  AllowEncodedSlashes {{ tripleo_httpd_vhost_allow_encoded_slashes }}"},{"line_number":27,"context_line":"{% endif %}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"6990fce9_3f6e1762","line":25,"range":{"start_line":25,"start_character":60,"end_line":25,"end_character":130},"updated":"2022-09-13 07:53:52.000000000","message":"nit: I\u0027d prefer we validate the value instead of just ignore invalid ones.","commit_id":"4686132a7cf1cb3c1cf097dfd9425f7a00746ca9"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"92ab11565335228742afafcd281c24a689f8282a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"{% for header in tripleo_httpd_vhost_headers %}"},{"line_number":23,"context_line":"  Header {{ header }}"},{"line_number":24,"context_line":"{% endfor %}"},{"line_number":25,"context_line":"{% if tripleo_httpd_vhost_allow_encoded_slashes !\u003d None and tripleo_httpd_vhost_allow_encoded_slashes in [\u0027on\u0027, \u0027off\u0027, \u0027nodecode\u0027] %}"},{"line_number":26,"context_line":"  AllowEncodedSlashes {{ tripleo_httpd_vhost_allow_encoded_slashes }}"},{"line_number":27,"context_line":"{% endif %}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"104692bc_ca7ba543","line":25,"range":{"start_line":25,"start_character":60,"end_line":25,"end_character":130},"in_reply_to":"2088ef8b_d0cb8971","updated":"2022-09-13 11:17:53.000000000","message":"Done","commit_id":"4686132a7cf1cb3c1cf097dfd9425f7a00746ca9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8f964666c0f7c4fc96c74f68bb3f8a252c24ee8b","unresolved":true,"context_lines":[{"line_number":22,"context_line":"{% for header in tripleo_httpd_vhost_headers %}"},{"line_number":23,"context_line":"  Header {{ header }}"},{"line_number":24,"context_line":"{% endfor %}"},{"line_number":25,"context_line":"{% if tripleo_httpd_vhost_allow_encoded_slashes !\u003d None and tripleo_httpd_vhost_allow_encoded_slashes in [\u0027on\u0027, \u0027off\u0027, \u0027nodecode\u0027] %}"},{"line_number":26,"context_line":"  AllowEncodedSlashes {{ tripleo_httpd_vhost_allow_encoded_slashes }}"},{"line_number":27,"context_line":"{% endif %}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"2088ef8b_d0cb8971","line":25,"range":{"start_line":25,"start_character":60,"end_line":25,"end_character":130},"in_reply_to":"68b1e908_3bc84711","updated":"2022-09-13 09:16:03.000000000","message":"I think we can just remove these validations.","commit_id":"4686132a7cf1cb3c1cf097dfd9425f7a00746ca9"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"45213860ab2b09481335bbdd281e26a7e3b1a09c","unresolved":true,"context_lines":[{"line_number":22,"context_line":"{% for header in tripleo_httpd_vhost_headers %}"},{"line_number":23,"context_line":"  Header {{ header }}"},{"line_number":24,"context_line":"{% endfor %}"},{"line_number":25,"context_line":"{% if tripleo_httpd_vhost_allow_encoded_slashes !\u003d None and tripleo_httpd_vhost_allow_encoded_slashes in [\u0027on\u0027, \u0027off\u0027, \u0027nodecode\u0027] %}"},{"line_number":26,"context_line":"  AllowEncodedSlashes {{ tripleo_httpd_vhost_allow_encoded_slashes }}"},{"line_number":27,"context_line":"{% endif %}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"68b1e908_3bc84711","line":25,"range":{"start_line":25,"start_character":60,"end_line":25,"end_character":130},"in_reply_to":"6990fce9_3f6e1762","updated":"2022-09-13 08:50:55.000000000","message":"hmmm so this is adding a couple of new tasks in the role itself. Sure we can do it, but is it worth the time?\nMaybe I can just remove the \"and tripleo_... in [\u0027on\u0027, ...]\" part and let the service crash if the value is wrong in there?","commit_id":"4686132a7cf1cb3c1cf097dfd9425f7a00746ca9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c10c4a0720758a887f511ce5af6ef2f771ba78e0","unresolved":true,"context_lines":[{"line_number":37,"context_line":"{% endif %}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"{%- for key, value in tripleo_httpd_vhost_custom_fragment.items() %}"},{"line_number":40,"context_line":"  {{ key }} {{ value }}"},{"line_number":41,"context_line":"{% endfor %}"},{"line_number":42,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"d8daac1c_7951f5c4","line":40,"range":{"start_line":40,"start_character":2,"end_line":40,"end_character":23},"updated":"2022-09-13 07:53:52.000000000","message":"the custom fragment parameter is put directory into the config file and it allows more than {{ key }} {{ value }} format. If we keep the current name (fragment) then I think we better mimic the same behavior.\n\nSee https://github.com/puppetlabs/puppetlabs-apache/blob/main/manifests/vhost.pp#L1331-L1354\n\nLooking at existing usage, it seems just supporting key-value might be enough but in that case I\u0027d prefer renaming this (eg tripleo_httpd_vhost_custom_options )","commit_id":"4686132a7cf1cb3c1cf097dfd9425f7a00746ca9"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"92ab11565335228742afafcd281c24a689f8282a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"{% endif %}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"{%- for key, value in tripleo_httpd_vhost_custom_fragment.items() %}"},{"line_number":40,"context_line":"  {{ key }} {{ value }}"},{"line_number":41,"context_line":"{% endfor %}"},{"line_number":42,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"b2186d26_38f81c8f","line":40,"range":{"start_line":40,"start_character":2,"end_line":40,"end_character":23},"in_reply_to":"71fe7497_6b2268a4","updated":"2022-09-13 11:17:53.000000000","message":"Ack","commit_id":"4686132a7cf1cb3c1cf097dfd9425f7a00746ca9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8f964666c0f7c4fc96c74f68bb3f8a252c24ee8b","unresolved":true,"context_lines":[{"line_number":37,"context_line":"{% endif %}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"{%- for key, value in tripleo_httpd_vhost_custom_fragment.items() %}"},{"line_number":40,"context_line":"  {{ key }} {{ value }}"},{"line_number":41,"context_line":"{% endfor %}"},{"line_number":42,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"71fe7497_6b2268a4","line":40,"range":{"start_line":40,"start_character":2,"end_line":40,"end_character":23},"in_reply_to":"a5fc3365_5c8752ad","updated":"2022-09-13 09:16:03.000000000","message":"IMHO providing different functionalities in a similar name is more confusing. In case we make this behave differently then we better use a different name so that users can notice difference between the existing fragment interface and this new interface.","commit_id":"4686132a7cf1cb3c1cf097dfd9425f7a00746ca9"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"45213860ab2b09481335bbdd281e26a7e3b1a09c","unresolved":true,"context_lines":[{"line_number":37,"context_line":"{% endif %}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"{%- for key, value in tripleo_httpd_vhost_custom_fragment.items() %}"},{"line_number":40,"context_line":"  {{ key }} {{ value }}"},{"line_number":41,"context_line":"{% endfor %}"},{"line_number":42,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"a5fc3365_5c8752ad","line":40,"range":{"start_line":40,"start_character":2,"end_line":40,"end_character":23},"in_reply_to":"d8daac1c_7951f5c4","updated":"2022-09-13 08:50:55.000000000","message":"soooo yeah - the key/value usage is enough in this case and, well, even better imho: it allows to NOT include new files, so it\u0027s «easier» to parse when we\u0027re reading the generated configuration.\n\nNow, for the name itself... yeah, we can change it, though _fragment is \"known\" in the tripleo world already. The final layout (dedicated file/fragment file or just plain written things) is probably not that a big concern?","commit_id":"4686132a7cf1cb3c1cf097dfd9425f7a00746ca9"}]}