)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"89dc3000dd20178fc018bcfb1c6c26b1517117b7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8802c892_c2e8eb25","updated":"2022-08-22 13:26:02.000000000","message":"recheck Seems unrelated to my change\n","commit_id":"d3fea89a42fd1479cc92dee309a3d82105a127df"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"24064f4e307d8ee89656c920c57afbd75670f5b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fdb2706f_b5feebf7","updated":"2022-08-22 13:25:25.000000000","message":"recheck Seems unrelated to my change ","commit_id":"d3fea89a42fd1479cc92dee309a3d82105a127df"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"48143af5b50aeb00324db835a5c8e741adf54c40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"46398db2_08a50c8c","updated":"2022-09-14 09:48:59.000000000","message":"Hey Lewis, currently working on https://review.opendev.org/c/openstack/tripleo-heat-templates/+/850933/8/deployment/ovn/ovn-controller-container-puppet.yaml .\n\nMaybe we put this one on hold, until 850933 is merged, and then I\u0027ll send the patch here and we finalize the transition for this code snippet ?","commit_id":"09b4a842c62ca677e90b72d704e6a6cf0f245633"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"1d1793887ccf2157fa4be70a5fd636e7fb2842df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b7dedb01_350a4c66","updated":"2022-09-13 00:08:54.000000000","message":"Yeah, I think we can move the rest of those tasks from THT over to this role as well. We just need to define the variables in `ansible_group_vars` within THT and ensure this role has defaults.\n\nJust need to fix the variable names here in-line with the standard and fix the spaces on that newline. Otherwise, looks good.","commit_id":"09b4a842c62ca677e90b72d704e6a6cf0f245633"}],"tripleo_ansible/roles/tripleo_ovn/tasks/external_update_tasks.yml":[{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"a047183d529f0230066b38a5342711ee1f802372","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2022 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1d1ca51f_78c554c6","line":1,"updated":"2022-09-20 07:33:50.000000000","message":"Shouldn\u0027t this file be called update.yaml? Do we need additional functional file? If so please leave comment in\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/847347/13/doc/source/standalone-roles-playbooks.rst#127","commit_id":"09b4a842c62ca677e90b72d704e6a6cf0f245633"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"48143af5b50aeb00324db835a5c8e741adf54c40","unresolved":true,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Update ovn_controller."},{"line_number":18,"context_line":"  tags: ovn"},{"line_number":19,"context_line":"  become: true"},{"line_number":20,"context_line":"  loop: \"{{ groups[\u0027ovn_controller\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e5d0faf7_630b2553","line":17,"updated":"2022-09-14 09:48:59.000000000","message":"We have another patch coming that way : https://review.opendev.org/c/openstack/tripleo-heat-templates/+/850933/8/deployment/ovn/ovn-controller-container-puppet.yaml","commit_id":"09b4a842c62ca677e90b72d704e6a6cf0f245633"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"a047183d529f0230066b38a5342711ee1f802372","unresolved":true,"context_lines":[{"line_number":17,"context_line":"- name: Update ovn_controller."},{"line_number":18,"context_line":"  tags: ovn"},{"line_number":19,"context_line":"  become: true"},{"line_number":20,"context_line":"  loop: \"{{ groups[\u0027ovn_controller\u0027] }}\""},{"line_number":21,"context_line":"  delegate_to: \"{{ item }}\""},{"line_number":22,"context_line":"  async: \"{{ async_value }}\""},{"line_number":23,"context_line":"  poll: 0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"35662ce7_2504fff0","line":20,"updated":"2022-09-20 07:33:50.000000000","message":"Please  make sure that you have the excluded nodes filter added in your change as well:\nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/856408/5/deployment/ovn/ovn-controller-container-puppet.yaml","commit_id":"09b4a842c62ca677e90b72d704e6a6cf0f245633"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"48143af5b50aeb00324db835a5c8e741adf54c40","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    config_dir: \"/var/lib/tripleo-config/container-startup-config/step_4\""},{"line_number":28,"context_line":"    config_patterns: \u0027ovn_controller.json\u0027"},{"line_number":29,"context_line":"    config_id: \u0027tripleo_step4\u0027"},{"line_number":30,"context_line":"    log_base_path: \"{{ container_log_stdout_path }}\""},{"line_number":31,"context_line":"    debug: \"{{ enable_debug | bool }}\""},{"line_number":32,"context_line":"    config_overrides:"},{"line_number":33,"context_line":"      ovn_controller:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"99fb3093_c8ec33ec","line":30,"updated":"2022-09-14 09:48:59.000000000","message":"Nice, I see that it\u0027s already fixed in there, we just merged master https://review.opendev.org/c/openstack/tripleo-heat-templates/+/857199/1/deployment/ovn/ovn-controller-container-puppet.yaml","commit_id":"09b4a842c62ca677e90b72d704e6a6cf0f245633"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"1d1793887ccf2157fa4be70a5fd636e7fb2842df","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    debug: \"{{ enable_debug | bool }}\""},{"line_number":32,"context_line":"    config_overrides:"},{"line_number":33,"context_line":"      ovn_controller:"},{"line_number":34,"context_line":"        image: \"{{ image }}\""},{"line_number":35,"context_line":"        "},{"line_number":36,"context_line":"- name: Was the ovn_controller successful."},{"line_number":37,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4ae28296_b09de34d","line":34,"updated":"2022-09-13 00:08:54.000000000","message":"variables here should be prepended with the role name `tripleo_ovn_*`: `tripleo_ovn_controller_image` for example:\n\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/845653/43/tripleo_ansible/roles/tripleo_ovn/defaults/main.yml","commit_id":"09b4a842c62ca677e90b72d704e6a6cf0f245633"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"1d1793887ccf2157fa4be70a5fd636e7fb2842df","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    config_overrides:"},{"line_number":33,"context_line":"      ovn_controller:"},{"line_number":34,"context_line":"        image: \"{{ image }}\""},{"line_number":35,"context_line":"        "},{"line_number":36,"context_line":"- name: Was the ovn_controller successful."},{"line_number":37,"context_line":"  when:"},{"line_number":38,"context_line":"    - \"\u0027results\u0027 in ovn_controller_update\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"496841a2_b2d8d899","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":8},"updated":"2022-09-13 00:08:54.000000000","message":"nit: spaces","commit_id":"09b4a842c62ca677e90b72d704e6a6cf0f245633"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"48143af5b50aeb00324db835a5c8e741adf54c40","unresolved":true,"context_lines":[{"line_number":46,"context_line":"    loop_var: \"async_result_item\""},{"line_number":47,"context_line":"  register: async_poll_results"},{"line_number":48,"context_line":"  until: async_poll_results.finished"},{"line_number":49,"context_line":"  retries: \"{{ retries }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a9379315_da540909","line":49,"updated":"2022-09-14 09:48:59.000000000","message":"It\u0027s not in master, but I think that delay should be set to 1, because the default is 5 and we advertise in the template that \"retries\" is the number of seconds we wait.","commit_id":"09b4a842c62ca677e90b72d704e6a6cf0f245633"}],"tripleo_ansible/roles/tripleo_ovn/tasks/main.yml":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"48143af5b50aeb00324db835a5c8e741adf54c40","unresolved":true,"context_lines":[{"line_number":19,"context_line":"- name: Include external deploy tasks"},{"line_number":20,"context_line":"  include_tasks: externaldeploy.yml"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Include external update tasks"},{"line_number":23,"context_line":"  include_tasks: external_update_tasks.yml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ba70284_29ae59f7","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":42},"updated":"2022-09-14 09:48:59.000000000","message":"Is main.yaml used at all or is it just a \"dummy\" file. I\u0027m wondering because that sequence of event hostprep, externaldeploy and external_update don\u0027t make much sense in real life I think. Sorry for the dumb question ...","commit_id":"09b4a842c62ca677e90b72d704e6a6cf0f245633"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"8f9a9e352cc5a50ff30739b4f37a394ad09f61d4","unresolved":true,"context_lines":[{"line_number":19,"context_line":"- name: Include external deploy tasks"},{"line_number":20,"context_line":"  include_tasks: externaldeploy.yml"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Include external update tasks"},{"line_number":23,"context_line":"  include_tasks: external_update_tasks.yml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"39b8d62d_4cee2949","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":42},"in_reply_to":"099766f7_05fdced5","updated":"2022-09-20 07:22:04.000000000","message":"According to docs for standalone roles there should not be main.yaml or at least it is not documented why we would need it.\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/847347/13/doc/source/standalone-roles-playbooks.rst#97","commit_id":"09b4a842c62ca677e90b72d704e6a6cf0f245633"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"4432f3b9976e148970194070e99f703ee63955ce","unresolved":true,"context_lines":[{"line_number":19,"context_line":"- name: Include external deploy tasks"},{"line_number":20,"context_line":"  include_tasks: externaldeploy.yml"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Include external update tasks"},{"line_number":23,"context_line":"  include_tasks: external_update_tasks.yml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"099766f7_05fdced5","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":42},"in_reply_to":"9ba70284_29ae59f7","updated":"2022-09-14 12:01:50.000000000","message":"Yeah, we can probably just remove these main.yml files. They would never actually be called in any real life situation. I think the main function of it was just for molecule. But we can specifically call out the playbooks we want to test.","commit_id":"09b4a842c62ca677e90b72d704e6a6cf0f245633"}]}