)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"1ffeb0ba1f277ea50a998a9d2c9c8a9cd1a183ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3a9c3870_f558bcfb","updated":"2022-10-12 21:11:30.000000000","message":"recheck","commit_id":"c15abb9b958cab4d35cbb8ee13929bfdf181cc08"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"bafe5926a1764740871b535cfcab19a20131fbb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a632426d_37cf1ac7","updated":"2022-10-11 12:46:49.000000000","message":"recheck","commit_id":"c15abb9b958cab4d35cbb8ee13929bfdf181cc08"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ce92174dc4bc1c6f675ba0eee9a64125730a17b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"05c18f10_5c8bf911","updated":"2022-10-13 10:47:41.000000000","message":"recheck unrelated error","commit_id":"c15abb9b958cab4d35cbb8ee13929bfdf181cc08"}],"tripleo_ansible/roles/tripleo_ceph_client/tasks/multiple_external_ceph_clusters.yml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"15e3970c2580a61a1d4b9fccda23c02ca0d63b7d","unresolved":true,"context_lines":[{"line_number":19,"context_line":"    - name: Prepare ceph config variables"},{"line_number":20,"context_line":"      set_fact:"},{"line_number":21,"context_line":"        external_cluster_mon_ips: \"{{ multiple.external_cluster_mon_ips }}\""},{"line_number":22,"context_line":"        tripleo_ceph_client_fsid: \"{{ multiple.fsid | default(multiple.tripleo_ceph_cluster_fsid) }}\""},{"line_number":23,"context_line":"        tripleo_ceph_client_cluster_network: \u0027\u0027"},{"line_number":24,"context_line":"        tripleo_ceph_client_mon_ips: []"},{"line_number":25,"context_line":"        tripleo_ceph_client_cluster: \"{{ multiple.cluster | default(multiple.tripleo_ceph_cluster_name) }}\""},{"line_number":26,"context_line":"        tripleo_ceph_client_keys: \"{{ multiple.get(\u0027keys\u0027,[]) | default(multiple.get(\u0027tripleo_ceph_cluster_keys\u0027, [])) }}\""},{"line_number":27,"context_line":"        tripleo_ceph_client_config_overrides: \"{{ multiple.get(\u0027ceph_conf_overrides\u0027,{}) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"74f8a8fa_2145da9e","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":107},"updated":"2022-10-06 11:55:33.000000000","message":"do this miss default(..., true)?","commit_id":"f8e2d3dc11a3659ee4a69532cdbaad1e7d4f214a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"184db99ad43469ebeb28dcd7c134568bafeeb032","unresolved":true,"context_lines":[{"line_number":19,"context_line":"    - name: Prepare ceph config variables"},{"line_number":20,"context_line":"      set_fact:"},{"line_number":21,"context_line":"        external_cluster_mon_ips: \"{{ multiple.external_cluster_mon_ips }}\""},{"line_number":22,"context_line":"        tripleo_ceph_client_fsid: \"{{ multiple.fsid | default(multiple.tripleo_ceph_cluster_fsid) }}\""},{"line_number":23,"context_line":"        tripleo_ceph_client_cluster_network: \u0027\u0027"},{"line_number":24,"context_line":"        tripleo_ceph_client_mon_ips: []"},{"line_number":25,"context_line":"        tripleo_ceph_client_cluster: \"{{ multiple.cluster | default(multiple.tripleo_ceph_cluster_name) }}\""},{"line_number":26,"context_line":"        tripleo_ceph_client_keys: \"{{ multiple.get(\u0027keys\u0027,[]) | default(multiple.get(\u0027tripleo_ceph_cluster_keys\u0027, [])) }}\""},{"line_number":27,"context_line":"        tripleo_ceph_client_config_overrides: \"{{ multiple.get(\u0027ceph_conf_overrides\u0027,{}) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"84e14c69_caeacc26","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":107},"in_reply_to":"4361f6c6_1889a344","updated":"2022-10-07 14:57:00.000000000","message":"meant to say\n\ndefault(multiple.tripleo_ceph_cluster_name, true)?\n\nso that it fails back also when tripleo_ceph_client_cluster is an empty string (which seems an expected case, according to https://review.opendev.org/c/openstack/tripleo-ansible/+/859149/1/tripleo_ansible/roles/tripleo_ceph_client/defaults/main.yml#25 )","commit_id":"f8e2d3dc11a3659ee4a69532cdbaad1e7d4f214a"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"460b9e54f00a0fcb35100485e63d100e35b32d99","unresolved":true,"context_lines":[{"line_number":19,"context_line":"    - name: Prepare ceph config variables"},{"line_number":20,"context_line":"      set_fact:"},{"line_number":21,"context_line":"        external_cluster_mon_ips: \"{{ multiple.external_cluster_mon_ips }}\""},{"line_number":22,"context_line":"        tripleo_ceph_client_fsid: \"{{ multiple.fsid | default(multiple.tripleo_ceph_cluster_fsid) }}\""},{"line_number":23,"context_line":"        tripleo_ceph_client_cluster_network: \u0027\u0027"},{"line_number":24,"context_line":"        tripleo_ceph_client_mon_ips: []"},{"line_number":25,"context_line":"        tripleo_ceph_client_cluster: \"{{ multiple.cluster | default(multiple.tripleo_ceph_cluster_name) }}\""},{"line_number":26,"context_line":"        tripleo_ceph_client_keys: \"{{ multiple.get(\u0027keys\u0027,[]) | default(multiple.get(\u0027tripleo_ceph_cluster_keys\u0027, [])) }}\""},{"line_number":27,"context_line":"        tripleo_ceph_client_config_overrides: \"{{ multiple.get(\u0027ceph_conf_overrides\u0027,{}) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4361f6c6_1889a344","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":107},"in_reply_to":"74f8a8fa_2145da9e","updated":"2022-10-06 17:55:29.000000000","message":"It\u0027s not boolean. It\u0027s the cluster name.","commit_id":"f8e2d3dc11a3659ee4a69532cdbaad1e7d4f214a"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"ea1a320ec4ebd5db35f6778812ca9250c1e368d8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    - name: Prepare ceph config variables"},{"line_number":20,"context_line":"      set_fact:"},{"line_number":21,"context_line":"        external_cluster_mon_ips: \"{{ multiple.external_cluster_mon_ips }}\""},{"line_number":22,"context_line":"        tripleo_ceph_client_fsid: \"{{ multiple.fsid | default(multiple.tripleo_ceph_cluster_fsid) }}\""},{"line_number":23,"context_line":"        tripleo_ceph_client_cluster_network: \u0027\u0027"},{"line_number":24,"context_line":"        tripleo_ceph_client_mon_ips: []"},{"line_number":25,"context_line":"        tripleo_ceph_client_cluster: \"{{ multiple.cluster | default(multiple.tripleo_ceph_cluster_name) }}\""},{"line_number":26,"context_line":"        tripleo_ceph_client_keys: \"{{ multiple.get(\u0027keys\u0027,[]) | default(multiple.get(\u0027tripleo_ceph_cluster_keys\u0027, [])) }}\""},{"line_number":27,"context_line":"        tripleo_ceph_client_config_overrides: \"{{ multiple.get(\u0027ceph_conf_overrides\u0027,{}) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2483076d_70a8f12d","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":107},"in_reply_to":"84e14c69_caeacc26","updated":"2022-10-08 18:35:34.000000000","message":"Done","commit_id":"f8e2d3dc11a3659ee4a69532cdbaad1e7d4f214a"}]}