)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"33ebf60669118b5631210edf45a4a49c6543b207","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2183bab5_cb8f05ff","updated":"2022-10-11 14:25:13.000000000","message":"recheck","commit_id":"00f95a23559096a006b334385b7c35b24066615b"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"4e2ae6c0eaa2be07a8e0b6304fdccdc20990c8a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d1337d5d_390ec412","updated":"2022-10-12 21:15:17.000000000","message":"this lgtm and is failing zuul due to the lint failures on https://review.opendev.org/c/openstack/tripleo-ansible/+/845653","commit_id":"124522f2604f95baa5797603b4ef62d8ea715ff3"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"e22d9f9517be9a8ea2652b86880cc1a412c255f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9cf35171_b3013840","updated":"2023-01-12 20:07:57.000000000","message":"Intended for EDPM","commit_id":"4270b5458d0b80ac520a9abb79d54b8ddc7ac857"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"3d79ec18d92fafafe925676b432177b88c2b2c46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1a771c74_faac41bd","updated":"2022-12-07 10:02:05.000000000","message":"Looks good to me. Let\u0027s wait for depends-on change to be merged first.","commit_id":"4270b5458d0b80ac520a9abb79d54b8ddc7ac857"}],"tripleo_ansible/playbooks/deploy-tripleo-openstack-configure.yml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"05e5836d99f584489838e4374d8618336da5a317","unresolved":true,"context_lines":[{"line_number":41,"context_line":"      import_role:"},{"line_number":42,"context_line":"        name: tripleo_ceph_client"},{"line_number":43,"context_line":"      tags:"},{"line_number":44,"context_line":"        - tripleo_ceph_client"},{"line_number":45,"context_line":"    - name: Configure tripleo_nova_libvirt"},{"line_number":46,"context_line":"      import_role:"},{"line_number":47,"context_line":"        name: tripleo_nova_libvirt"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"853c0fad_fb136c05","line":44,"updated":"2022-10-03 16:38:59.000000000","message":"I think I might add the following to this task:\n\n  when: tripleo_cinder_enable_rbd_backend\n\nHow this should work is described at:\n\n  https://review.opendev.org/c/openstack/tripleo-docs/+/859142","commit_id":"fc4be5f6227212723966498d18a87fef7ae3084a"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"0a65d18840ede229623cb4f841fde17f765a5b4e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"      import_role:"},{"line_number":42,"context_line":"        name: tripleo_ceph_client"},{"line_number":43,"context_line":"      tags:"},{"line_number":44,"context_line":"        - tripleo_ceph_client"},{"line_number":45,"context_line":"    - name: Configure tripleo_nova_libvirt"},{"line_number":46,"context_line":"      import_role:"},{"line_number":47,"context_line":"        name: tripleo_nova_libvirt"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a44d4355_ef563f94","line":44,"in_reply_to":"853c0fad_fb136c05","updated":"2022-10-08 18:58:21.000000000","message":"Done","commit_id":"fc4be5f6227212723966498d18a87fef7ae3084a"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"f22ff1e74b30dc7a42c73c3d6ff381d2b311f20f","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        name: tripleo_ceph_client_files"},{"line_number":44,"context_line":"      vars:"},{"line_number":45,"context_line":"        # user must populate as per https://review.opendev.org/859142"},{"line_number":46,"context_line":"        tripleo_ceph_client_files_source: /home/stack/ceph_client_files"},{"line_number":47,"context_line":"      when:"},{"line_number":48,"context_line":"        - tripleo_nova_libvirt_enable_rbd_backend | bool | default(false) or"},{"line_number":49,"context_line":"          tripleo_nova_libvirt_cinder_enable_rbd_backend | bool | default(false)"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"766e9040_4d97e0fa","line":46,"updated":"2023-01-03 21:26:54.000000000","message":"this feels really out of place. /home/stack isn\u0027t a reasonable default. maybe the role could handle this, and if the dir doesn\u0027t exist, then do nothing?","commit_id":"4270b5458d0b80ac520a9abb79d54b8ddc7ac857"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"2b2ccbc439f66bb6b3ff9a83e5c806ac29422bf4","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        name: tripleo_ceph_client_files"},{"line_number":44,"context_line":"      vars:"},{"line_number":45,"context_line":"        # user must populate as per https://review.opendev.org/859142"},{"line_number":46,"context_line":"        tripleo_ceph_client_files_source: /home/stack/ceph_client_files"},{"line_number":47,"context_line":"      when:"},{"line_number":48,"context_line":"        - tripleo_nova_libvirt_enable_rbd_backend | bool | default(false) or"},{"line_number":49,"context_line":"          tripleo_nova_libvirt_cinder_enable_rbd_backend | bool | default(false)"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"cf2cc397_75f799dc","line":46,"in_reply_to":"766e9040_4d97e0fa","updated":"2023-01-11 16:12:07.000000000","message":"I agree it\u0027s out of place.\n\nI have the role working with the ansibleEE container like this:\n\n  extraMounts:\n    - extraVolType: Ceph\n      volumes:\n      - name: ceph\n        projected:\n          sources:\n          - secret:\n              name: ceph-client-conf\n      mounts:\n      - name: ceph\n        mountPath: /runner/config/ceph\n        readOnly: true\n  play: |\n    - hosts: all\n      gather_facts: false\n      tasks:\n        - name: Configure Ceph Clients\n          include_role:\n            name: tripleo_ceph_client_files\n          vars:\n            tripleo_ceph_client_files_source: /runner/config/ceph\n            tripleo_ceph_client_files_config_home: /var/lib/tripleo-config/ceph/\n\nCould I require that a variable like tripleo_ceph_client_files_source be set (e.g. in the inventory or similar) and have this playbook include role if the variable is defined?\n\nI think within ansibleEE we\u0027d want to use it like this:\n\n    - name: Deploy TripleO configure OpenStack playbook\n      ansible.builtin.import_playbook: deploy-tripleo-openstack-configure.yml\n\nAssuming that the mount is in place and a variable like tripleo_ceph_client_files_source is set to based on the mount.\n\nHow does that interface seem to you?","commit_id":"4270b5458d0b80ac520a9abb79d54b8ddc7ac857"}]}