)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"9cde3f8e0f74b24b811d38c0855432b17c9d0cee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b97cfe3d_ff8ea02d","updated":"2022-10-10 20:25:12.000000000","message":"My inventory has the following defined:\n\n    tripleo_cinder_rbd_multi_config:\n      ceph2:\n        CephClientUserName: openstack\n        CephClusterName: ceph2\n      ceph3:\n        CephClientUserName: openstack\n        CephClusterName: ceph3\n\nThis role suceeds if I use PS2 but PS1 failed with:\n\n  TASK [tripleo_container_standalone : Create kolla config files] ******************************\n  fatal: [localhost]: FAILED! \u003d\u003e {\"msg\": \"An unhandled exception occurred while templating \u0027{\u0027nova_compute\u0027: \\\"{{ lookup(\u0027template\u0027, \u0027templates/kolla_config/nova_compute.yaml.j2\u0027) | from_yaml }}\\\"}\u0027. Error was a \u003cclass \u0027yaml.scanner.ScannerError\u0027\u003e, original message: block sequence entries are not allowed in this context\\n  in \\\"\u003cunicode string\u003e\\\", line 24, column 19\"}\n\nThis is why I made the jinja2 whitespace control change in PS2 [1].\nI\u0027m then able to see my ceph keys correctly mounted into my container:\n\n  [stack@centos standalone]$ sudo podman exec nova_compute ls -l /etc/ceph/\n  total 28\n  -rw-------. 1 nova nova 236 Oct 10 12:50 ceph2.client.openstack.keyring\n  -rw-r--r--. 1 root root 247 Oct 10 12:31 ceph2.conf\n  -rw-------. 1 nova nova 236 Oct 10 12:50 ceph3.client.openstack.keyring\n  -rw-r--r--. 1 root root 247 Oct 10 12:31 ceph3.conf\n  -rw-------. 1 nova nova 218 Oct  7 21:31 ceph.client.openstack.keyring\n  -rw-r--r--. 1 root root 230 Oct  7 21:31 ceph.conf\n  -rw-r--r--. 1 root root  92 Aug  8 17:32 rbdmap\n  [stack@centos standalone]$ \n\n[1] https://review.opendev.org/c/openstack/tripleo-ansible/+/860873/1..2/tripleo_ansible/roles/tripleo_nova_compute/templates/kolla_config/nova_compute.yaml.j2","commit_id":"0923de221c2c6eda9abcb1f3b57a115cd97cff1c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"80aa96fde73dd36aa60ca9b8f28eb1d2fe565c8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"40fd39e0_3fc2d4de","updated":"2022-10-11 06:41:20.000000000","message":"recheck \n\nthe undercloud-upgrade job is fixed now","commit_id":"0923de221c2c6eda9abcb1f3b57a115cd97cff1c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3ec963c55eb4657bb0ccc2ab100794fe7cee879a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f7d424a_d772dab6","updated":"2022-10-12 15:38:10.000000000","message":"thank you for taking care of it.\nDid you compare that to the approach taken with libvirt role?\n\nhttps://codesearch.opendev.org/?q\u003dtripleo_nova_libvirt_ceph_multiconfig_permissions%7Ctripleo_nova_libvirt_ceph_multiconfig_keyrings\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d\n\nPerhaps we could align, if setting the facts works for you better... ","commit_id":"0923de221c2c6eda9abcb1f3b57a115cd97cff1c"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"63b5fdc029935bff663f7d54c15f97c6b1e22896","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9f68d355_8a9f6331","in_reply_to":"5f7d424a_d772dab6","updated":"2022-10-12 17:18:28.000000000","message":"\u003e Did you compare that to the approach taken with libvirt role?\n\nYes. Not only did I compare it to the approach taken by the libvirt role, I tested both with the same inputs and got the desired outputs for each (aside from needing this small update).\n\nBoth tripleo_nova_compute [1] and tripleo_nova_libivrt [2] take the same common input for tripleo_cinder_rbd_multi_config and each does what they need to with it. \n\nI used the multiple ceph cluster case documented here:\n\n https://review.opendev.org/c/openstack/tripleo-docs/+/859142\n \n\n[1] https://review.opendev.org/c/openstack/tripleo-ansible/+/843659/46/tripleo_ansible/roles/tripleo_nova_compute/defaults/main.yml#41\n[2] https://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/roles/tripleo_nova_libvirt/defaults/main.yml#L41","commit_id":"0923de221c2c6eda9abcb1f3b57a115cd97cff1c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7a1e3818e5389a32c5b024f15f7786ccee426319","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"54d3af12_f6f10fb5","in_reply_to":"9f68d355_8a9f6331","updated":"2022-10-17 15:06:43.000000000","message":"thanks a lot!","commit_id":"0923de221c2c6eda9abcb1f3b57a115cd97cff1c"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"3c18831a8297278a9292774bdcd13f8d89600bd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dca8f306_12984a11","updated":"2022-10-17 14:28:16.000000000","message":"The newlines clarification makes sense. This change looks good otherwise.","commit_id":"0d10e97f34e30e6594da3bd8ee5d1a73512eefe1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"906c8f8c9dc9097204e166875949b9bf5a3ff891","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c23a1ed2_339e92b0","updated":"2022-10-17 07:15:36.000000000","message":"looks ok just wondering if the newlines are intentional or do we want to leave it as it already was (without newlines?)","commit_id":"0d10e97f34e30e6594da3bd8ee5d1a73512eefe1"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"be7f59a925acf709e0e047d43c2a6d47d2aa4062","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"38ebe60f_9f23ec1a","updated":"2022-10-12 21:11:16.000000000","message":"recheck","commit_id":"0d10e97f34e30e6594da3bd8ee5d1a73512eefe1"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"fc54a7f159692fcde28d2951c555ef42a668de80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3ccca579_6fd21c39","in_reply_to":"c23a1ed2_339e92b0","updated":"2022-10-17 13:04:20.000000000","message":"The newlines are intentional. Otherwise I do not get valid yaml.\n\nThis role succeeds if I use PS2 but PS1 failed with:\n\n  TASK [tripleo_container_standalone : Create kolla config files] ******************************\n  fatal: [localhost]: FAILED! \u003d\u003e {\"msg\": \"An unhandled exception occurred while templating \u0027{\u0027nova_compute\u0027: \\\"{{ lookup(\u0027template\u0027, \u0027templates/kolla_config/nova_compute.yaml.j2\u0027) | from_yaml }}\\\"}\u0027. Error was a \u003cclass \u0027yaml.scanner.ScannerError\u0027\u003e, original message: block sequence entries are not allowed in this context\\n  in \\\"\u003cunicode string\u003e\\\", line 24, column 19\"}\n\nThis is why I made the jinja2 whitespace control change in PS2 [1].\n\n[1] https://review.opendev.org/c/openstack/tripleo-ansible/+/860873/1..2/tripleo_ansible/roles/tripleo_nova_compute/templates/kolla_config/nova_compute.yaml.j2","commit_id":"0d10e97f34e30e6594da3bd8ee5d1a73512eefe1"}],"tripleo_ansible/roles/tripleo_nova_compute/templates/kolla_config/nova_compute.yaml.j2":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"80aa96fde73dd36aa60ca9b8f28eb1d2fe565c8c","unresolved":true,"context_lines":[{"line_number":34,"context_line":"    owner: nova:nova"},{"line_number":35,"context_line":"    perm: \u00270600\u0027"},{"line_number":36,"context_line":"{% endfor %}"},{"line_number":37,"context_line":"{% for key, store in tripleo_nova_compute_cinder_rbd_multi_config.items() %}"},{"line_number":38,"context_line":"  - path: /etc/ceph/{{ store.CephClusterName | default(tripleo_nova_compute_ceph_cluster_name) }}.client.{{ store.CephClientUserName | default(tripleo_nova_compute_ceph_client_user_name) }}.keyring"},{"line_number":39,"context_line":"    owner: nova:nova"},{"line_number":40,"context_line":"    perm: \u00270600\u0027"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"c5c229f6_7e075f94","line":37,"range":{"start_line":37,"start_character":7,"end_line":37,"end_character":10},"updated":"2022-10-11 06:41:20.000000000","message":"but you\u0027re not using this anywhere? what is being added here then","commit_id":"0923de221c2c6eda9abcb1f3b57a115cd97cff1c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"906c8f8c9dc9097204e166875949b9bf5a3ff891","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    owner: nova:nova"},{"line_number":35,"context_line":"    perm: \u00270600\u0027"},{"line_number":36,"context_line":"{% endfor %}"},{"line_number":37,"context_line":"{% for key, store in tripleo_nova_compute_cinder_rbd_multi_config.items() %}"},{"line_number":38,"context_line":"  - path: /etc/ceph/{{ store.CephClusterName | default(tripleo_nova_compute_ceph_cluster_name) }}.client.{{ store.CephClientUserName | default(tripleo_nova_compute_ceph_client_user_name) }}.keyring"},{"line_number":39,"context_line":"    owner: nova:nova"},{"line_number":40,"context_line":"    perm: \u00270600\u0027"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"0a746f7f_ee2f50bb","line":37,"range":{"start_line":37,"start_character":7,"end_line":37,"end_character":10},"in_reply_to":"7bf5388c_6d5cefd7","updated":"2022-10-17 07:15:36.000000000","message":"ok thanks for update fulton makes more sense now","commit_id":"0923de221c2c6eda9abcb1f3b57a115cd97cff1c"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"2d583e0bf0449ae77b34a623864d7d5f78ff52f0","unresolved":true,"context_lines":[{"line_number":34,"context_line":"    owner: nova:nova"},{"line_number":35,"context_line":"    perm: \u00270600\u0027"},{"line_number":36,"context_line":"{% endfor %}"},{"line_number":37,"context_line":"{% for key, store in tripleo_nova_compute_cinder_rbd_multi_config.items() %}"},{"line_number":38,"context_line":"  - path: /etc/ceph/{{ store.CephClusterName | default(tripleo_nova_compute_ceph_cluster_name) }}.client.{{ store.CephClientUserName | default(tripleo_nova_compute_ceph_client_user_name) }}.keyring"},{"line_number":39,"context_line":"    owner: nova:nova"},{"line_number":40,"context_line":"    perm: \u00270600\u0027"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"e4e82f58_773e3a1a","line":37,"range":{"start_line":37,"start_character":7,"end_line":37,"end_character":10},"in_reply_to":"c5c229f6_7e075f94","updated":"2022-10-11 12:32:34.000000000","message":"Yes, I\u0027m not using the key. Should I call it _? The structure is not correctly unpacked unless I use .items() and access the value (but not the key). The following from before is not sufficient:\n\n  for store in tripleo_nova_compute_cinder_rbd_multi_config\n  \nIt returns this:\n\n  permissions:\n    - path: /etc/ceph/default_name.client.default_user.keyring\n      owner: nova:nova\n      perm: \u00270600\u0027\n    - path: /etc/ceph/default_name.client.default_user.keyring\n      owner: nova:nova\n      perm: \u00270600\u0027\n    - path: /etc/ceph/default_name.client.default_user.keyring\n      owner: nova:nova\n      perm: \u00270600\u0027\n\nbut that\u0027s not the correct output. If I only add .items() \n\n  for store in tripleo_nova_compute_cinder_rbd_multi_config.items()\n\nthen I get this:\n\n  permissions:\n    - path: /etc/ceph/default_name.client.default_user.keyring\n      owner: nova:nova\n      perm: \u00270600\u0027\n    - path: /etc/ceph/default_name.client.default_user.keyring\n      owner: nova:nova\n      perm: \u00270600\u0027\n    - path: /etc/ceph/default_name.client.default_user.keyring\n      owner: nova:nova\n      perm: \u00270600\u0027\n\nStill not right. Now here it is again:\n\n  for _, store in tripleo_nova_compute_cinder_rbd_multi_config.items()\n\nand I get what I need:\n\n  permissions:\n    - path: /etc/ceph/ceph.client.openstack.keyring\n      owner: nova:nova\n      perm: \u00270600\u0027\n    - path: /etc/ceph/ceph2.client.openstack.keyring\n      owner: nova:nova\n      perm: \u00270600\u0027\n    - path: /etc/ceph/ceph3.client.openstack.keyring\n      owner: nova:nova\n      perm: \u00270600\u0027","commit_id":"0923de221c2c6eda9abcb1f3b57a115cd97cff1c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3ec963c55eb4657bb0ccc2ab100794fe7cee879a","unresolved":true,"context_lines":[{"line_number":34,"context_line":"    owner: nova:nova"},{"line_number":35,"context_line":"    perm: \u00270600\u0027"},{"line_number":36,"context_line":"{% endfor %}"},{"line_number":37,"context_line":"{% for key, store in tripleo_nova_compute_cinder_rbd_multi_config.items() %}"},{"line_number":38,"context_line":"  - path: /etc/ceph/{{ store.CephClusterName | default(tripleo_nova_compute_ceph_cluster_name) }}.client.{{ store.CephClientUserName | default(tripleo_nova_compute_ceph_client_user_name) }}.keyring"},{"line_number":39,"context_line":"    owner: nova:nova"},{"line_number":40,"context_line":"    perm: \u00270600\u0027"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"eb2ac1ad_4b56cefc","line":37,"range":{"start_line":37,"start_character":7,"end_line":37,"end_character":10},"in_reply_to":"e4e82f58_773e3a1a","updated":"2022-10-12 15:38:10.000000000","message":"yes, you could replace that key arg with _","commit_id":"0923de221c2c6eda9abcb1f3b57a115cd97cff1c"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"63b5fdc029935bff663f7d54c15f97c6b1e22896","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    owner: nova:nova"},{"line_number":35,"context_line":"    perm: \u00270600\u0027"},{"line_number":36,"context_line":"{% endfor %}"},{"line_number":37,"context_line":"{% for key, store in tripleo_nova_compute_cinder_rbd_multi_config.items() %}"},{"line_number":38,"context_line":"  - path: /etc/ceph/{{ store.CephClusterName | default(tripleo_nova_compute_ceph_cluster_name) }}.client.{{ store.CephClientUserName | default(tripleo_nova_compute_ceph_client_user_name) }}.keyring"},{"line_number":39,"context_line":"    owner: nova:nova"},{"line_number":40,"context_line":"    perm: \u00270600\u0027"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7bf5388c_6d5cefd7","line":37,"range":{"start_line":37,"start_character":7,"end_line":37,"end_character":10},"in_reply_to":"eb2ac1ad_4b56cefc","updated":"2022-10-12 17:18:28.000000000","message":"OK, I\u0027ve done this.","commit_id":"0923de221c2c6eda9abcb1f3b57a115cd97cff1c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"906c8f8c9dc9097204e166875949b9bf5a3ff891","unresolved":true,"context_lines":[{"line_number":29,"context_line":"  - path: {{ \"/etc/ceph/\" ~ tripleo_nova_compute_ceph_cluster_name ~ \".client.\" ~ tripleo_nova_compute_ceph_client_user_name ~ \".keyring\" }}"},{"line_number":30,"context_line":"    owner: nova:nova"},{"line_number":31,"context_line":"    perm: \u00270600\u0027"},{"line_number":32,"context_line":"{% for _, store in tripleo_nova_compute_glance_multistore_config.items() %}"},{"line_number":33,"context_line":"  - path: /etc/ceph/{{ store.CephClusterName | default(tripleo_nova_compute_ceph_cluster_name) }}.client.{{ store.CephClientUserName | default(tripleo_nova_compute_ceph_client_user_name) }}.keyring"},{"line_number":34,"context_line":"    owner: nova:nova"},{"line_number":35,"context_line":"    perm: \u00270600\u0027"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"668acc69_001ad131","line":32,"range":{"start_line":32,"start_character":2,"end_line":32,"end_character":3},"updated":"2022-10-17 07:15:36.000000000","message":"maybe keep this as before i.e. with the leading \u0027-\u0027\n\n{%-","commit_id":"0d10e97f34e30e6594da3bd8ee5d1a73512eefe1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"906c8f8c9dc9097204e166875949b9bf5a3ff891","unresolved":true,"context_lines":[{"line_number":33,"context_line":"  - path: /etc/ceph/{{ store.CephClusterName | default(tripleo_nova_compute_ceph_cluster_name) }}.client.{{ store.CephClientUserName | default(tripleo_nova_compute_ceph_client_user_name) }}.keyring"},{"line_number":34,"context_line":"    owner: nova:nova"},{"line_number":35,"context_line":"    perm: \u00270600\u0027"},{"line_number":36,"context_line":"{% endfor %}"},{"line_number":37,"context_line":"{% for _, store in tripleo_nova_compute_cinder_rbd_multi_config.items() %}"},{"line_number":38,"context_line":"  - path: /etc/ceph/{{ store.CephClusterName | default(tripleo_nova_compute_ceph_cluster_name) }}.client.{{ store.CephClientUserName | default(tripleo_nova_compute_ceph_client_user_name) }}.keyring"},{"line_number":39,"context_line":"    owner: nova:nova"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"f9362025_653858ee","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":2},"updated":"2022-10-17 07:15:36.000000000","message":"same keep the - here?\n\nor do we really want to add the newlines\n\nas you have it now it will include newline after each entry so that is perhaps what you want","commit_id":"0d10e97f34e30e6594da3bd8ee5d1a73512eefe1"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"c4663f80ea9f9fc66f83226bae224daad777af83","unresolved":true,"context_lines":[{"line_number":34,"context_line":"    owner: nova:nova"},{"line_number":35,"context_line":"    perm: \u00270600\u0027"},{"line_number":36,"context_line":"{% endfor %}"},{"line_number":37,"context_line":"{% for _, store in tripleo_nova_compute_cinder_rbd_multi_config.items() %}"},{"line_number":38,"context_line":"  - path: /etc/ceph/{{ store.CephClusterName | default(tripleo_nova_compute_ceph_cluster_name) }}.client.{{ store.CephClientUserName | default(tripleo_nova_compute_ceph_client_user_name) }}.keyring"},{"line_number":39,"context_line":"    owner: nova:nova"},{"line_number":40,"context_line":"    perm: \u00270600\u0027"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"005e22a0_982f4235","line":37,"range":{"start_line":37,"start_character":64,"end_line":37,"end_character":71},"updated":"2022-10-17 14:33:31.000000000","message":"Probably should just use .values() here actually, since we don\u0027t care about the keys. But I guess it\u0027s not the end of the world.","commit_id":"0d10e97f34e30e6594da3bd8ee5d1a73512eefe1"}]}