)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dc08009ea07e4eb5e69dff4f48c8318009e539c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a899c8e5_f22d5f18","updated":"2023-01-11 05:23:51.000000000","message":"Sorry I missed notification because of massive ones coming from gerrit...","commit_id":"89b1058146e819d7eeea2d70f2cdbf95dc569293"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"8655feb95bbcb21b40d24f97ebe1397097c3da73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"714c9e6d_f4447684","updated":"2022-10-12 12:02:32.000000000","message":"lgtm","commit_id":"89b1058146e819d7eeea2d70f2cdbf95dc569293"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"89b9bf1443e8cb69cf1cf5358aaae25411e3292d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"df0c5524_b8822782","updated":"2023-02-13 14:00:03.000000000","message":"(holding +A because of failed CI)","commit_id":"bcd631f6add2da69d526c3ae74d3efa815075138"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"4c869c46f6ac7f4e7350ac90135c422143c82297","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"551017fe_800ffce0","updated":"2023-02-13 13:02:48.000000000","message":"recheck CI fixed","commit_id":"bcd631f6add2da69d526c3ae74d3efa815075138"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"55a97393c76d8a37590d5ae7737a0fa9f8ceefe9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3518ab80_287a053c","in_reply_to":"df0c5524_b8822782","updated":"2023-02-14 07:02:01.000000000","message":"It looks good now ;-)","commit_id":"bcd631f6add2da69d526c3ae74d3efa815075138"}],"tripleo_ansible/roles/octavia_undercloud/tasks/main.yml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dbc427894ee30ac5e546c961ab4bea8279ef0b36","unresolved":true,"context_lines":[{"line_number":27,"context_line":"- name: install/update amphora image from RPM"},{"line_number":28,"context_line":"  package:"},{"line_number":29,"context_line":"    name: octavia-amphora-image"},{"line_number":30,"context_line":"    state: latest"},{"line_number":31,"context_line":"  ignore_errors: true"},{"line_number":32,"context_line":"  when:"},{"line_number":33,"context_line":"    - amp_image_filename is not defined or (amp_image_filename | length) \u003c 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d7d30e57_4e4f401c","line":30,"range":{"start_line":30,"start_character":11,"end_line":30,"end_character":17},"updated":"2022-10-18 05:47:22.000000000","message":"we should NOT use latest here because we don\u0027t want to update any packages during non-update operations such as scale-out.\n\nWe have the task to update all installed packages in tripelo-packages to update all installed packages so that should cover the update/upgrade case.\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/stable/wallaby/deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml#L447-L456\n\n(Using wallaby for reference because the task was migrated to trieplo-ansible in master)","commit_id":"89b1058146e819d7eeea2d70f2cdbf95dc569293"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dc08009ea07e4eb5e69dff4f48c8318009e539c9","unresolved":true,"context_lines":[{"line_number":27,"context_line":"- name: install/update amphora image from RPM"},{"line_number":28,"context_line":"  package:"},{"line_number":29,"context_line":"    name: octavia-amphora-image"},{"line_number":30,"context_line":"    state: latest"},{"line_number":31,"context_line":"  ignore_errors: true"},{"line_number":32,"context_line":"  when:"},{"line_number":33,"context_line":"    - amp_image_filename is not defined or (amp_image_filename | length) \u003c 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"896db839_4bab25b4","line":30,"range":{"start_line":30,"start_character":11,"end_line":30,"end_character":17},"in_reply_to":"0333085c_f1d21b5d","updated":"2023-01-11 05:23:51.000000000","message":"Doesn\u0027t ``state: present`` work ?\nIf that does not work in upgrade case then we probably have to add some tasks specific to upgrade to replace the amphora image pcakge from el7ost by one from el8ost.","commit_id":"89b1058146e819d7eeea2d70f2cdbf95dc569293"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"ac5b73967f5ea4279f9905c6601720fbc3ca24c1","unresolved":true,"context_lines":[{"line_number":27,"context_line":"- name: install/update amphora image from RPM"},{"line_number":28,"context_line":"  package:"},{"line_number":29,"context_line":"    name: octavia-amphora-image"},{"line_number":30,"context_line":"    state: latest"},{"line_number":31,"context_line":"  ignore_errors: true"},{"line_number":32,"context_line":"  when:"},{"line_number":33,"context_line":"    - amp_image_filename is not defined or (amp_image_filename | length) \u003c 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0333085c_f1d21b5d","line":30,"range":{"start_line":30,"start_character":11,"end_line":30,"end_character":17},"in_reply_to":"3a3c4513_d72f63ad","updated":"2023-01-06 14:49:12.000000000","message":"Hi Takashi, where do you think we could ensure that octavia-amphora-image is installed/updated?\nso far we have had 2 issues:\n- during an update from 13 to 16, all the *el7ost* packages are removed from the undercloud, so the package is not updated/re-install by this ansible task\n- during a fresh osp17 install with uefi support, there\u0027s no dependency that pulls octavia-amphora-image (it is a dep of rhos-director-images, which doesn\u0027t make much sense)\nI think we could add an explicit step for installing it, but I don\u0027t know where.","commit_id":"89b1058146e819d7eeea2d70f2cdbf95dc569293"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"a80f51106454bbd96da1f2b324630e3f037b0c88","unresolved":true,"context_lines":[{"line_number":27,"context_line":"- name: install/update amphora image from RPM"},{"line_number":28,"context_line":"  package:"},{"line_number":29,"context_line":"    name: octavia-amphora-image"},{"line_number":30,"context_line":"    state: latest"},{"line_number":31,"context_line":"  ignore_errors: true"},{"line_number":32,"context_line":"  when:"},{"line_number":33,"context_line":"    - amp_image_filename is not defined or (amp_image_filename | length) \u003c 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fc7b002d_43f41879","line":30,"range":{"start_line":30,"start_character":11,"end_line":30,"end_character":17},"in_reply_to":"d7d30e57_4e4f401c","updated":"2022-11-21 20:00:35.000000000","message":"Does this really apply where this is task only runs on the undercloud?","commit_id":"89b1058146e819d7eeea2d70f2cdbf95dc569293"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5414d57d21e32854f80f6a2224c390e8c1d662f9","unresolved":true,"context_lines":[{"line_number":27,"context_line":"- name: install/update amphora image from RPM"},{"line_number":28,"context_line":"  package:"},{"line_number":29,"context_line":"    name: octavia-amphora-image"},{"line_number":30,"context_line":"    state: latest"},{"line_number":31,"context_line":"  ignore_errors: true"},{"line_number":32,"context_line":"  when:"},{"line_number":33,"context_line":"    - amp_image_filename is not defined or (amp_image_filename | length) \u003c 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a3c4513_d72f63ad","line":30,"range":{"start_line":30,"start_character":11,"end_line":30,"end_character":17},"in_reply_to":"fc7b002d_43f41879","updated":"2022-11-22 00:23:23.000000000","message":"Yes. For undercloud, the undercloud upgrade command executs upgrade tasks so the packages should be updated when a user updates u-c.","commit_id":"89b1058146e819d7eeea2d70f2cdbf95dc569293"}]}