)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ee727493db1d25a6e34a1ab0baf3e4cb2df09622","unresolved":true,"context_lines":[{"line_number":9,"context_line":"There is a script in every node that checks correctly if the"},{"line_number":10,"context_line":"Galera node has been correctly re-introduced in the cluster"},{"line_number":11,"context_line":"as the previous check on the local port open had some"},{"line_number":12,"context_line":"disadvantages, and does not wait for IST to complete."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id49274f5bade4af5b88b6354cfa092e4b041eb6e"},{"line_number":15,"context_line":"(cherry picked from commit dc4e574ba10807ea23155017c0bd9e734023fae5)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f419017_1e26ac30","line":12,"updated":"2022-10-24 07:26:32.000000000","message":"if you are not going to cherrypick the conditionals then please add a note here saying why this is not a clean cherrypick.","commit_id":"8b96047133f33bca2d9d564102a8cd4112e3654d"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"49c0afcf6d89dd7c526f32cba56650a2d4dba250","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There is a script in every node that checks correctly if the"},{"line_number":10,"context_line":"Galera node has been correctly re-introduced in the cluster"},{"line_number":11,"context_line":"as the previous check on the local port open had some"},{"line_number":12,"context_line":"disadvantages, and does not wait for IST to complete."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id49274f5bade4af5b88b6354cfa092e4b041eb6e"},{"line_number":15,"context_line":"(cherry picked from commit dc4e574ba10807ea23155017c0bd9e734023fae5)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"453c6940_26275301","line":12,"in_reply_to":"3f419017_1e26ac30","updated":"2022-10-24 07:40:18.000000000","message":"Done","commit_id":"8b96047133f33bca2d9d564102a8cd4112e3654d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"28c675f2dc17b4fdfc7764eda3346b28e230951d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e167ea60_7792de5f","updated":"2022-10-20 07:30:52.000000000","message":"if my comment is right then how is ci passing perhaps this is not exericed by the molecule test? \n\n-1 for visibility\n\nping if you need me to revote (if I misunderstood something) thanks","commit_id":"74b3817e55373227c04950c774cd99c171996751"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"00d20c9b7eb22d99e9d559dc5bc5ea8fc2206810","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9b2ce73a_81dc8f74","in_reply_to":"e167ea60_7792de5f","updated":"2022-10-20 12:07:48.000000000","message":"It is not done because this bit is only used when we are doing the backup of a 3-node control plane, while at the gate we test B\u0026R with a 1-node control plane. It was important to save on resources, I was told back then. \n\nThis does not visibilize errors in tasks like this one that only execute when pacemaker is running.","commit_id":"74b3817e55373227c04950c774cd99c171996751"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"2cec00a1eb775ea5b58e2a6c06ffaf9347cf2281","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2fe85fc3_d88b6225","updated":"2022-10-21 12:00:19.000000000","message":"recheck","commit_id":"8b96047133f33bca2d9d564102a8cd4112e3654d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ee727493db1d25a6e34a1ab0baf3e4cb2df09622","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f0fb15e8_68595112","updated":"2022-10-24 07:26:32.000000000","message":"recheck\n\ncontent provider should be good now ","commit_id":"8b96047133f33bca2d9d564102a8cd4112e3654d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"703c5022e2a79606ccfcea0c6762fa33da84370e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fac5c259_f0464cd6","updated":"2022-11-03 09:02:15.000000000","message":"LGTM","commit_id":"79f92e70ade9d119a2e0d0c7d1bbe478f1481eb8"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"1b6bfda2c1c97494faf45a2eb80ecdd394a3187e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"78cdf84c_f7430712","updated":"2022-10-24 13:12:40.000000000","message":"recheck","commit_id":"79f92e70ade9d119a2e0d0c7d1bbe478f1481eb8"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"1c61182bf9f0c4fd2ec0bbe85fd84dd2444fcf5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7ee68709_5ec9cc13","updated":"2022-11-03 15:46:14.000000000","message":"recheck","commit_id":"79f92e70ade9d119a2e0d0c7d1bbe478f1481eb8"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"66b7073718149c816c9231f5345a224ace816fec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"845acf96_dcb6208d","updated":"2022-11-04 08:34:54.000000000","message":"recheck","commit_id":"79f92e70ade9d119a2e0d0c7d1bbe478f1481eb8"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"2cf69ad3722e4d15995cefb4bfe613656032ee53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b24fc581_2b531d4b","updated":"2022-11-07 10:06:51.000000000","message":"recheck","commit_id":"79f92e70ade9d119a2e0d0c7d1bbe478f1481eb8"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"65fa0d1a00a560dde61508b0036435eab908637e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c300cece_2435d3cb","updated":"2022-11-15 13:40:44.000000000","message":"recheck","commit_id":"79f92e70ade9d119a2e0d0c7d1bbe478f1481eb8"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4a9a99ac4a77dc312fba41bd49763ca021acb7a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0cd7031b_e5e1e09b","updated":"2022-11-16 07:45:45.000000000","message":"recheck \n\ngate blocker resolved now https://lists.openstack.org/pipermail/openstack-discuss/2022-November/031198.html\n\nhttps://5ac2e0019b2d88b7bbf6-2bdaf7ecf5927d28353faaebb26c863b.ssl.cf1.rackcdn.com/861833/6/check/tripleo-ci-centos-8-9-multinode-mixed-os/26d0cac/logs/undercloud/home/zuul/undercloud_install.log\nERROR! Unexpected Exception, this is probably a bug: \u0027Task\u0027 object has no attribute \u0027_valid_attrs\u0027\n","commit_id":"79f92e70ade9d119a2e0d0c7d1bbe478f1481eb8"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"83f724b8aca89c79a7844c75002b2ec04cdf7a4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"010087e8_03839d08","updated":"2022-10-25 06:59:07.000000000","message":"thanks","commit_id":"79f92e70ade9d119a2e0d0c7d1bbe478f1481eb8"}],"tripleo_ansible/roles/backup_and_restore/tasks/pacemaker_start.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"28c675f2dc17b4fdfc7764eda3346b28e230951d","unresolved":true,"context_lines":[{"line_number":23,"context_line":"- name: Wait until pacemaker has Galera up\u0026running"},{"line_number":24,"context_line":"  shell: /var/lib/container-config-scripts/pacemaker_wait_bundle.sh galera galera-bundle Master"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - bar_services_enabled is defined"},{"line_number":27,"context_line":"    - \"\u0027mysql\u0027 in bar_services_enabled_json\""},{"line_number":28,"context_line":"  tags:"},{"line_number":29,"context_line":"    - bar_create_recover_image"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d5f6195d_b6115b0f","line":26,"range":{"start_line":26,"start_character":6,"end_line":26,"end_character":26},"updated":"2022-10-20 07:30:52.000000000","message":"this is not on the master patch \n\nin master, we are registering that in [1]\nbut I don\u0027t see that in the wallaby version [2]\n\nalso cant find with grep in local checkout for stable/wallaby can you check?\n\n\n\n[1] https://opendev.org/openstack/tripleo-ansible/src/commit/3bed0b37e8b12072dc2aeb61b215579de616ee4a/tripleo_ansible/roles/backup_and_restore/tasks/pacemaker_start.yml#L25\n[2] https://opendev.org/openstack/tripleo-ansible/src/commit/2db62db08eb73f32829f3c4a5531e38e8505dde9/tripleo_ansible/roles/backup_and_restore/tasks/pacemaker_start.yml#L1","commit_id":"74b3817e55373227c04950c774cd99c171996751"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"00d20c9b7eb22d99e9d559dc5bc5ea8fc2206810","unresolved":false,"context_lines":[{"line_number":23,"context_line":"- name: Wait until pacemaker has Galera up\u0026running"},{"line_number":24,"context_line":"  shell: /var/lib/container-config-scripts/pacemaker_wait_bundle.sh galera galera-bundle Master"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - bar_services_enabled is defined"},{"line_number":27,"context_line":"    - \"\u0027mysql\u0027 in bar_services_enabled_json\""},{"line_number":28,"context_line":"  tags:"},{"line_number":29,"context_line":"    - bar_create_recover_image"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5cb66f74_5a20e9ae","line":26,"range":{"start_line":26,"start_character":6,"end_line":26,"end_character":26},"in_reply_to":"d5f6195d_b6115b0f","updated":"2022-10-20 12:07:48.000000000","message":"You are absolutely right, the part where this variable is defined was never backported to wallaby (it might should, I am investigating why we did cherry-pick it back) so it cannot be done. It was the result of a bad conflict resolution.","commit_id":"74b3817e55373227c04950c774cd99c171996751"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bfe0d81d13459079982fcd3de68ec8a7dd0e7bbc","unresolved":true,"context_lines":[{"line_number":23,"context_line":"- name: Wait until pacemaker has Galera up\u0026running"},{"line_number":24,"context_line":"  shell: /var/lib/container-config-scripts/pacemaker_wait_bundle.sh galera galera-bundle Master"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - \"\u0027mysql\u0027 in bar_services_enabled_json\""},{"line_number":27,"context_line":"  tags:"},{"line_number":28,"context_line":"    - bar_create_recover_image"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"147276c0_578bf32b","line":26,"range":{"start_line":26,"start_character":18,"end_line":26,"end_character":43},"updated":"2022-10-21 06:59:05.000000000","message":"same for this variable\n\nthis is also not in wallaby \n\nmaster there: https://opendev.org/openstack/tripleo-ansible/src/commit/9e6be93e2a87ef6f3f0a5abee72700154669c3d8/tripleo_ansible/roles/backup_and_restore/tasks/pacemaker_start.yml#L31\n\nbut not on wallaby https://opendev.org/openstack/tripleo-ansible/src/commit/90ba3a2387fee4a672a0a3a4bd0b4c7f21bd2e6f/tripleo_ansible/roles/backup_and_restore/tasks/pacemaker_start.yml#L18\n\n\n\nyou need that https://opendev.org/openstack/tripleo-ansible/commit/54ae88c1b434a89ca4c9fefe35e0d4e67e9406c4","commit_id":"c08fdba6bd42195dfd74d73e58c3292b564a8d5d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ee727493db1d25a6e34a1ab0baf3e4cb2df09622","unresolved":true,"context_lines":[{"line_number":23,"context_line":"- name: Wait until pacemaker has Galera up\u0026running"},{"line_number":24,"context_line":"  shell: /var/lib/container-config-scripts/pacemaker_wait_bundle.sh galera galera-bundle Master"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - \"\u0027mysql\u0027 in bar_services_enabled_json\""},{"line_number":27,"context_line":"  tags:"},{"line_number":28,"context_line":"    - bar_create_recover_image"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a5300625_b05613dc","line":26,"range":{"start_line":26,"start_character":18,"end_line":26,"end_character":43},"in_reply_to":"147276c0_578bf32b","updated":"2022-10-24 07:26:32.000000000","message":"so will you be backporting those conditionals to here and ontop/before this patch?\n\nor will you merge like this without conditional?","commit_id":"c08fdba6bd42195dfd74d73e58c3292b564a8d5d"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"49c0afcf6d89dd7c526f32cba56650a2d4dba250","unresolved":false,"context_lines":[{"line_number":23,"context_line":"- name: Wait until pacemaker has Galera up\u0026running"},{"line_number":24,"context_line":"  shell: /var/lib/container-config-scripts/pacemaker_wait_bundle.sh galera galera-bundle Master"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - \"\u0027mysql\u0027 in bar_services_enabled_json\""},{"line_number":27,"context_line":"  tags:"},{"line_number":28,"context_line":"    - bar_create_recover_image"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"17004f8a_b52d349e","line":26,"range":{"start_line":26,"start_character":18,"end_line":26,"end_character":43},"in_reply_to":"a5300625_b05613dc","updated":"2022-10-24 07:40:18.000000000","message":"I will merge this without the conditional. The conditionals are part of a different patch that might be backported or not, but it is independent.","commit_id":"c08fdba6bd42195dfd74d73e58c3292b564a8d5d"}]}