)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"b3f52d1efcd1ba635f0c5c4e58f5b7eb0a097ee5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5478ad2b_7ff9a504","updated":"2022-10-31 10:39:45.000000000","message":"recheck","commit_id":"e9a5e6446c381d2dad31209488926b2cdc4c289b"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"25f01b8ca21abec69ab06c9ae690e991b11620e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"420d724b_f59aff3b","updated":"2022-11-08 13:32:10.000000000","message":"Sorry, I\u0027ve one more question inline.","commit_id":"b779d63b63735d4daa4286d8621d01e2c59de906"}],"tripleo_ansible/roles/tripleo_keystone_resources/tasks/admin.yml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"28520a0c0f15208197561bda805d9cd229d9c802","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    cloud: \"{{ tripleo_keystone_resources_cloud_name }}\""},{"line_number":58,"context_line":"    name: admin"},{"line_number":59,"context_line":"    password: \"{{ tripleo_keystone_resources_admin_password }}\""},{"line_number":60,"context_line":"    update_password: \"{{ user_info_result.rc | default(False) | ternary(\u0027on_create\u0027, \u0027always\u0027) }}\""},{"line_number":61,"context_line":"    email: \"admin@localhost\""},{"line_number":62,"context_line":"    domain: default"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7742e8de_4adfa882","line":60,"range":{"start_line":60,"start_character":42,"end_line":60,"end_character":44},"updated":"2022-10-24 13:17:34.000000000","message":"Is rc valid when it\u0027s not running a command?\n\nCould use ignore_errors: true instead of failed_when: false in the admin auth check and then update_password: \"{{ user_info_result is failed | ternary(\u0027on_create\u0027, \u0027always\u0027) }}\"","commit_id":"a7be35b5b3d26fc5f859485ff6ef5b878147c607"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"bc4ee6dfcc1e2385094adf52b5ca7c2a6c4d0804","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    cloud: \"{{ tripleo_keystone_resources_cloud_name }}\""},{"line_number":58,"context_line":"    name: admin"},{"line_number":59,"context_line":"    password: \"{{ tripleo_keystone_resources_admin_password }}\""},{"line_number":60,"context_line":"    update_password: \"{{ user_info_result.rc | default(False) | ternary(\u0027on_create\u0027, \u0027always\u0027) }}\""},{"line_number":61,"context_line":"    email: \"admin@localhost\""},{"line_number":62,"context_line":"    domain: default"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b667ed8a_fc3920ab","line":60,"range":{"start_line":60,"start_character":42,"end_line":60,"end_character":44},"in_reply_to":"2f52d65e_0953bb4b","updated":"2022-11-03 08:45:35.000000000","message":"Done","commit_id":"a7be35b5b3d26fc5f859485ff6ef5b878147c607"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"80ea96a992550f9dfb3cc262f891890f451f7de1","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    cloud: \"{{ tripleo_keystone_resources_cloud_name }}\""},{"line_number":58,"context_line":"    name: admin"},{"line_number":59,"context_line":"    password: \"{{ tripleo_keystone_resources_admin_password }}\""},{"line_number":60,"context_line":"    update_password: \"{{ user_info_result.rc | default(False) | ternary(\u0027on_create\u0027, \u0027always\u0027) }}\""},{"line_number":61,"context_line":"    email: \"admin@localhost\""},{"line_number":62,"context_line":"    domain: default"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2f52d65e_0953bb4b","line":60,"range":{"start_line":60,"start_character":42,"end_line":60,"end_character":44},"in_reply_to":"7742e8de_4adfa882","updated":"2022-10-24 13:19:57.000000000","message":"\u003e Is rc valid when it\u0027s not running a command?\n\u003e \n\u003e Could use ignore_errors: true instead of failed_when: false in the admin auth check and then update_password: \"{{ user_info_result is failed | ternary(\u0027on_create\u0027, \u0027always\u0027) }}\"\n\nThat should be update_password: \"{{ user_info_result is failed | ternary(\u0027always\u0027, \u0027on_create\u0027) }}\"","commit_id":"a7be35b5b3d26fc5f859485ff6ef5b878147c607"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"fe2fb18d5ca1e0f6d41a112d303473be884b1e46","unresolved":true,"context_lines":[{"line_number":58,"context_line":"    cloud: \"{{ tripleo_keystone_resources_cloud_name }}\""},{"line_number":59,"context_line":"    name: admin"},{"line_number":60,"context_line":"    password: \"{{ tripleo_keystone_resources_admin_password }}\""},{"line_number":61,"context_line":"    update_password: \"{{ user_info_result is failed | ternary(\u0027on_create\u0027, \u0027always\u0027) }}\""},{"line_number":62,"context_line":"    email: \"admin@localhost\""},{"line_number":63,"context_line":"    domain: default"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"06904240_25c23e0d","line":61,"updated":"2022-11-03 08:26:44.000000000","message":"As owalsh mentioned it has to be  \"{{ user_info_result is failed | ternary(\u0027always\u0027, \u0027on_create\u0027) }}\" I guess","commit_id":"d9a9ac081cf081290f967cdab746475e243ce847"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"bc4ee6dfcc1e2385094adf52b5ca7c2a6c4d0804","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    cloud: \"{{ tripleo_keystone_resources_cloud_name }}\""},{"line_number":59,"context_line":"    name: admin"},{"line_number":60,"context_line":"    password: \"{{ tripleo_keystone_resources_admin_password }}\""},{"line_number":61,"context_line":"    update_password: \"{{ user_info_result is failed | ternary(\u0027on_create\u0027, \u0027always\u0027) }}\""},{"line_number":62,"context_line":"    email: \"admin@localhost\""},{"line_number":63,"context_line":"    domain: default"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"e37dffd4_86a97c42","line":61,"in_reply_to":"06904240_25c23e0d","updated":"2022-11-03 08:45:35.000000000","message":"Done","commit_id":"d9a9ac081cf081290f967cdab746475e243ce847"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"25f01b8ca21abec69ab06c9ae690e991b11620e2","unresolved":true,"context_lines":[{"line_number":57,"context_line":"  openstack.cloud.identity_user:"},{"line_number":58,"context_line":"    cloud: \"{{ tripleo_keystone_resources_cloud_name }}\""},{"line_number":59,"context_line":"    name: admin"},{"line_number":60,"context_line":"    password: \"{{ tripleo_keystone_resources_admin_password }}\""},{"line_number":61,"context_line":"    update_password: \"{{ user_info_result is failed | ternary(\u0027always\u0027, \u0027on_create\u0027) }}\""},{"line_number":62,"context_line":"    email: \"admin@localhost\""},{"line_number":63,"context_line":"    domain: default"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"adfdc17d_660c101c","line":60,"range":{"start_line":60,"start_character":18,"end_line":60,"end_character":60},"updated":"2022-11-08 13:32:10.000000000","message":"Hmm.. AdminPassword won\u0027t change without rotating the password during minor update. Are we suggesting to never allow changing this password? If that\u0027s yes, why not add to [1] instead like other passwords.\n\n[1] https://github.com/openstack/tripleo-common/blob/master/tripleo_common/constants.py#L119\n\nShould have asked this question earlier..","commit_id":"b779d63b63735d4daa4286d8621d01e2c59de906"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"53b987c17e773f2d7756b7d3f192530dd6ebe622","unresolved":true,"context_lines":[{"line_number":57,"context_line":"  openstack.cloud.identity_user:"},{"line_number":58,"context_line":"    cloud: \"{{ tripleo_keystone_resources_cloud_name }}\""},{"line_number":59,"context_line":"    name: admin"},{"line_number":60,"context_line":"    password: \"{{ tripleo_keystone_resources_admin_password }}\""},{"line_number":61,"context_line":"    update_password: \"{{ user_info_result is failed | ternary(\u0027always\u0027, \u0027on_create\u0027) }}\""},{"line_number":62,"context_line":"    email: \"admin@localhost\""},{"line_number":63,"context_line":"    domain: default"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"acc21c53_226bcd78","line":60,"range":{"start_line":60,"start_character":18,"end_line":60,"end_character":60},"in_reply_to":"8be0805e_24921dc5","updated":"2022-11-08 15:25:09.000000000","message":"OK, I looked at it from another angle too. If the password was changed manually we would be resetting it back to what THT parameter provides.","commit_id":"b779d63b63735d4daa4286d8621d01e2c59de906"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"d90c52f4153121ba40045a2edbef90a08a3fa90d","unresolved":true,"context_lines":[{"line_number":57,"context_line":"  openstack.cloud.identity_user:"},{"line_number":58,"context_line":"    cloud: \"{{ tripleo_keystone_resources_cloud_name }}\""},{"line_number":59,"context_line":"    name: admin"},{"line_number":60,"context_line":"    password: \"{{ tripleo_keystone_resources_admin_password }}\""},{"line_number":61,"context_line":"    update_password: \"{{ user_info_result is failed | ternary(\u0027always\u0027, \u0027on_create\u0027) }}\""},{"line_number":62,"context_line":"    email: \"admin@localhost\""},{"line_number":63,"context_line":"    domain: default"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"8be0805e_24921dc5","line":60,"range":{"start_line":60,"start_character":18,"end_line":60,"end_character":60},"in_reply_to":"adfdc17d_660c101c","updated":"2022-11-08 14:52:08.000000000","message":"Rabi, if I understand this patch correctly, we first check if the admin password has in fact changed by making the call above in lines 41-53.\n\nIf these lines return successfully, then the password has not changed and so will not be updated.  Otherwise, it will be changed.\n\nMaybe I\u0027m misunderstanding your question?  ..","commit_id":"b779d63b63735d4daa4286d8621d01e2c59de906"}]}