)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"bcd942b53738cf411d237a53950f8e03476b16f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"be99f82b_8561d082","updated":"2023-06-05 07:12:46.000000000","message":"As long as we don\u0027t have any lists as dictionary values we should be ok.","commit_id":"ca525ff1582651ab46d37cf0fb685cd1a2c65194"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"2526f0d2921aeaafbe93b267a033dd5cc93041f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5df7f5c0_95e71c1e","updated":"2023-05-24 14:38:00.000000000","message":"But maybe it would a be a good idea to make a note about the `tripleo_kernel_sysctl_extra_settings` overriding `tripleo_kernel_sysctl_settings` somewhere in comments around their definition. Just to really make sure it\u0027s not forgotten.","commit_id":"ca525ff1582651ab46d37cf0fb685cd1a2c65194"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e3905779a735944d5852f37cd30da2c59acfeb4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2575d661_1966fb90","updated":"2023-05-19 13:05:59.000000000","message":"FYI, I don\u0027t think we need a bug for this, as there is no standalone use of it in Wallaby. And this also doesn\u0027t change how t-h-t overrides the values via sysctl_extra. But it just makes sense to make this interface cleaner (and synced with the NG code for external dataplane as well)","commit_id":"ca525ff1582651ab46d37cf0fb685cd1a2c65194"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d7ee2d386b8e8fbe7f70a094c7855acd445bdbd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c540daaf_3e173e79","updated":"2023-10-03 15:50:59.000000000","message":"PTAL","commit_id":"ca525ff1582651ab46d37cf0fb685cd1a2c65194"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9e91e8a5bc0afd13554d1ea1ea7fed385d6dd7ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fbccca9a_3fe81ea7","updated":"2023-05-24 11:14:14.000000000","message":"PTAL","commit_id":"ca525ff1582651ab46d37cf0fb685cd1a2c65194"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e2699f3e502642fa4f17f419fe2683071f9940a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d2f6b530_14bda96b","in_reply_to":"101c4f90_2d63041b","updated":"2023-05-25 12:19:49.000000000","message":"...or should I\u0027ve said it does \"expose\" it, but as internal module, not encouraged for external use","commit_id":"ca525ff1582651ab46d37cf0fb685cd1a2c65194"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8d11195024e03f4105b28a191ef7d925654cf152","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"101c4f90_2d63041b","in_reply_to":"5df7f5c0_95e71c1e","updated":"2023-05-25 12:18:52.000000000","message":"tripleo doesn\u0027t expose these roles for end users, and this change only aligns the code and logic that we use in multiple places here and EDPM.\n\nThe t-h-t interface that uses this role won\u0027t take any changes.","commit_id":"ca525ff1582651ab46d37cf0fb685cd1a2c65194"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ad7199cd3a62a24395042eaf870808ed8b8c57c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a43ccad1_28cc1b1a","updated":"2023-10-16 13:40:16.000000000","message":"addressed the comment","commit_id":"cdf79fc6a21a04184a7af98a9516176aefad9127"}],"tripleo_ansible/roles/tripleo_kernel/tasks/main.yml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e6c02dab6be2b7a087b5317b0d9f4e9b4d9345ce","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        setype: etc_t"},{"line_number":69,"context_line":"      register: _default_sysctl_result"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    - name: Set extra sysctl options"},{"line_number":72,"context_line":"      sysctl:"},{"line_number":73,"context_line":"        name: \"{{ setting.key }}\""},{"line_number":74,"context_line":"        value: \"{{ setting.opt.value }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b2ba0575_b3cba025","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":33},"updated":"2023-10-13 06:50:11.000000000","message":"We used to write the tripleo_kernel_sysctl_settings in the task above and then the extra_settings in this task. Now that we changed tripleo-sysctl.conf.j2 to also add the extra settings (I guess we used to add  extra_settings with sysctl module to ensure validation). Now what this task is expected to do? We also do reload in the next task.","commit_id":"ca525ff1582651ab46d37cf0fb685cd1a2c65194"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ad7199cd3a62a24395042eaf870808ed8b8c57c3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        setype: etc_t"},{"line_number":69,"context_line":"      register: _default_sysctl_result"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    - name: Set extra sysctl options"},{"line_number":72,"context_line":"      sysctl:"},{"line_number":73,"context_line":"        name: \"{{ setting.key }}\""},{"line_number":74,"context_line":"        value: \"{{ setting.opt.value }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1038d2c5_1cac1998","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":33},"in_reply_to":"79886273_14a4ab3a","updated":"2023-10-16 13:40:16.000000000","message":"Done","commit_id":"ca525ff1582651ab46d37cf0fb685cd1a2c65194"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c4ed4b1752350676ab563f22caf9c0c20808284d","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        setype: etc_t"},{"line_number":69,"context_line":"      register: _default_sysctl_result"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    - name: Set extra sysctl options"},{"line_number":72,"context_line":"      sysctl:"},{"line_number":73,"context_line":"        name: \"{{ setting.key }}\""},{"line_number":74,"context_line":"        value: \"{{ setting.opt.value }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"79886273_14a4ab3a","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":33},"in_reply_to":"b2ba0575_b3cba025","updated":"2023-10-16 13:27:26.000000000","message":"this aligns the legacy Wallaby implementation with the EDPM ansible. If we want to change this, we should firstly change at the source (EDPM). This was intended to simplify maintanance of the same tasks set","commit_id":"ca525ff1582651ab46d37cf0fb685cd1a2c65194"}]}