)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"8eb7896c3c08129682630f1fe2d37a64736359dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"50118bfc_e3009551","updated":"2023-07-17 12:04:16.000000000","message":"Looks good but let\u0027s handle a post restart failure.","commit_id":"6cb048ef390e6a8bb3625f463bfc07633ed01003"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"d17f2017d5b37c983017e5c650e5ae9339e59512","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9c21632a_cafc45cb","updated":"2023-07-18 14:51:27.000000000","message":"recheck","commit_id":"6cb048ef390e6a8bb3625f463bfc07633ed01003"}],"tripleo_ansible/roles/tripleo_cephadm/tasks/monitor_ceph_orch.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"8eb7896c3c08129682630f1fe2d37a64736359dc","unresolved":true,"context_lines":[{"line_number":44,"context_line":"      command: \"{{ tripleo_cephadm_ceph_cli }} mgr fail {{ active_mgr }}\""},{"line_number":45,"context_line":"      become: true"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - name: Fail if ceph orchestrator is still not responding"},{"line_number":48,"context_line":"      command: \"{{ tripleo_cephadm_ceph_cli }} orch status --format json\""},{"line_number":49,"context_line":"      become: true"},{"line_number":50,"context_line":"      async: 30"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c8afa090_eb21f09b","line":47,"updated":"2023-07-17 12:04:16.000000000","message":"We\u0027re not actually failing here though. We\u0027re running the command which has been failing before and we expect it to work this time because it\u0027s been restarted.\n\nIn the positive case, I expect the restart (on line 43) to work and for this to return quickly, but do you want to add the actual fail task below this one? You could register mgr_stat_second_attempt and if it has the same failure as from line 31 + 32, then add a fail task stating that the restart didn\u0027t work (though we expect this to be unlikely).","commit_id":"6cb048ef390e6a8bb3625f463bfc07633ed01003"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"1b301e8a6bfd5cefa2a572c3a8d94835e908e3d5","unresolved":true,"context_lines":[{"line_number":44,"context_line":"      command: \"{{ tripleo_cephadm_ceph_cli }} mgr fail {{ active_mgr }}\""},{"line_number":45,"context_line":"      become: true"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - name: Fail if ceph orchestrator is still not responding"},{"line_number":48,"context_line":"      command: \"{{ tripleo_cephadm_ceph_cli }} orch status --format json\""},{"line_number":49,"context_line":"      become: true"},{"line_number":50,"context_line":"      async: 30"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9e33fc5d_28d3d79b","line":47,"in_reply_to":"c8afa090_eb21f09b","updated":"2023-07-17 14:44:22.000000000","message":"As per our chat, I overlooked that this task doesn\u0027t have \"failed_when: false\" (like the one above it) so it actually will fail.","commit_id":"6cb048ef390e6a8bb3625f463bfc07633ed01003"}]}