)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"change_message_id":"4fd2a3155fcf27fcb9049c06a9a57656fd6e3f45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f652aa74_2bfa8047","updated":"2023-09-13 10:24:12.000000000","message":"recheck","commit_id":"ce16976c3cb9477df5a8ea662d60e2b038ffd42f"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"e1853c62b57d496bd0daaebea5061952877fad3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"567fbce0_6e2526e5","updated":"2023-09-13 15:52:38.000000000","message":"update tested with patches from this topic and they fix rhbz#2237245","commit_id":"ce16976c3cb9477df5a8ea662d60e2b038ffd42f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"41982721c43656552fbfa6aae71cf282e247b6d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"306083c2_8a52d2b8","updated":"2023-09-14 06:50:59.000000000","message":"Removed the redundant if-else.","commit_id":"41090b97a9f16bff95bf685d79b51d07cf31a1eb"},{"author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"change_message_id":"baa389554ef49cb9ddf7e1ab7d0e7ea153867061","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"43d9d97e_2716d964","updated":"2023-09-14 11:43:48.000000000","message":"recheck","commit_id":"41090b97a9f16bff95bf685d79b51d07cf31a1eb"}],"tripleo_ansible/roles/tripleo_container_manage/templates/systemd-service.j2":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e2bbb8563e3d273478263ccf2ed0e69ec04da351","unresolved":true,"context_lines":[{"line_number":17,"context_line":"ExecStop\u003d-/usr/bin/podman exec {{ lookup(\u0027dict\u0027, container_data_unit).key }} {{ lookup(\u0027dict\u0027, container_data_unit).value.pre_stop_exec }}"},{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":"ExecStop\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"{% if tripleo_container_manage_stoppost is defined %}"},{"line_number":21,"context_line":"ExecStopPost\u003d{{ tripleo_container_manage_stoppost }}"},{"line_number":22,"context_line":"{% else %}"},{"line_number":23,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"6787210d_c1988b05","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":39},"updated":"2023-09-12 12:54:44.000000000","message":"I think this should be part of container definition (see pre_stec_exec) instead of being an independent var.","commit_id":"5c9b7e3fa63fade5d63686d84283779f7e555baa"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"518a294baf6cc0d03e1a34475c8784a158fd9040","unresolved":true,"context_lines":[{"line_number":17,"context_line":"ExecStop\u003d-/usr/bin/podman exec {{ lookup(\u0027dict\u0027, container_data_unit).key }} {{ lookup(\u0027dict\u0027, container_data_unit).value.pre_stop_exec }}"},{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":"ExecStop\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"{% if tripleo_container_manage_stoppost is defined %}"},{"line_number":21,"context_line":"ExecStopPost\u003d{{ tripleo_container_manage_stoppost }}"},{"line_number":22,"context_line":"{% else %}"},{"line_number":23,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"8b7560e9_2b6e9f76","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":39},"in_reply_to":"6787210d_c1988b05","updated":"2023-09-12 13:32:10.000000000","message":"Try\n\n```\n{% if lookup(\u0027dict\u0027, container_data_unit).value.post_stop_exec is defined %}\nExecStopPost\u003d{{lookup(\u0027dict\u0027, container_data_unit).value.post_stop_exec}}\n{% else %}\n```\n\nand add\n\n```\npost_stop_exec: \u0027/usr/bin/sleep 10\u0027\n```\n\nto the frr container definition here.\n\nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/893616/8/deployment/frr/frr-container-ansible.yaml#241","commit_id":"5c9b7e3fa63fade5d63686d84283779f7e555baa"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"518a294baf6cc0d03e1a34475c8784a158fd9040","unresolved":true,"context_lines":[{"line_number":17,"context_line":"ExecStop\u003d-/usr/bin/podman exec {{ lookup(\u0027dict\u0027, container_data_unit).key }} {{ lookup(\u0027dict\u0027, container_data_unit).value.pre_stop_exec }}"},{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":"ExecStop\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"{% if tripleo_container_manage_stoppost is defined %}"},{"line_number":21,"context_line":"ExecStopPost\u003d{{ tripleo_container_manage_stoppost }}"},{"line_number":22,"context_line":"{% else %}"},{"line_number":23,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9f59026a_1be43ee7","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":39},"in_reply_to":"6787210d_c1988b05","updated":"2023-09-12 13:32:10.000000000","message":"Try\n\n```\n{% if lookup(\u0027dict\u0027, container_data_unit).value.post_stop_exec is defined %} \n```","commit_id":"5c9b7e3fa63fade5d63686d84283779f7e555baa"},{"author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"change_message_id":"cc88d84f93eb400200c6b02a4d19d5cf8b12f5d4","unresolved":false,"context_lines":[{"line_number":17,"context_line":"ExecStop\u003d-/usr/bin/podman exec {{ lookup(\u0027dict\u0027, container_data_unit).key }} {{ lookup(\u0027dict\u0027, container_data_unit).value.pre_stop_exec }}"},{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":"ExecStop\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"{% if tripleo_container_manage_stoppost is defined %}"},{"line_number":21,"context_line":"ExecStopPost\u003d{{ tripleo_container_manage_stoppost }}"},{"line_number":22,"context_line":"{% else %}"},{"line_number":23,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"e1cfb315_9f1253eb","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":39},"in_reply_to":"9f59026a_1be43ee7","updated":"2023-09-12 13:59:52.000000000","message":"Done","commit_id":"5c9b7e3fa63fade5d63686d84283779f7e555baa"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e0f1ad282c08bee5245d76acd5a9de7fd40fc26d","unresolved":true,"context_lines":[{"line_number":20,"context_line":"{% if lookup(\u0027dict\u0027, container_data_unit).value.post_stop_exec is defined %}"},{"line_number":21,"context_line":"ExecStopPost\u003d{{lookup(\u0027dict\u0027, container_data_unit).value.post_stop_exec}}"},{"line_number":22,"context_line":"{% else %}"},{"line_number":23,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":24,"context_line":"{% endif %}"},{"line_number":25,"context_line":"SuccessExitStatus\u003d137 142 143"},{"line_number":26,"context_line":"TimeoutStopSec\u003d{{ 2*(lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int) }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"f4e96a2f_f5e87ebd","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":12},"updated":"2023-09-14 01:06:52.000000000","message":"probably we can keep this default one (I think it\u0027s needed to ensure the container is stopped even some failure is detected by systemd) but add additional ExecStopPost below this ? AFAIK systemd accepts having multiple ExtraStopPost and execute commands in the written order.","commit_id":"ce16976c3cb9477df5a8ea662d60e2b038ffd42f"},{"author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"change_message_id":"acff518531ca1477fad89ddc8566a025b9a968a6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"{% if lookup(\u0027dict\u0027, container_data_unit).value.post_stop_exec is defined %}"},{"line_number":21,"context_line":"ExecStopPost\u003d{{lookup(\u0027dict\u0027, container_data_unit).value.post_stop_exec}}"},{"line_number":22,"context_line":"{% else %}"},{"line_number":23,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":24,"context_line":"{% endif %}"},{"line_number":25,"context_line":"SuccessExitStatus\u003d137 142 143"},{"line_number":26,"context_line":"TimeoutStopSec\u003d{{ 2*(lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int) }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"883fedd9_d3320614","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":12},"in_reply_to":"f4e96a2f_f5e87ebd","updated":"2023-09-14 05:48:55.000000000","message":"Done","commit_id":"ce16976c3cb9477df5a8ea662d60e2b038ffd42f"}]}