)]}'
{"scripts/tripleo.sh":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"08d061997043b85ab262426a46dfc73735dd2094","unresolved":false,"context_lines":[{"line_number":643,"context_line":"    sudo yum install -y libffi-devel"},{"line_number":644,"context_line":"    python $HOME/tempest/tools/install_venv.py"},{"line_number":645,"context_line":"    $HOME/tempest/tools/with_venv.sh pip install junitxml"},{"line_number":646,"context_line":"    $HOME/tempest/tools/with_venv.sh $HOME/tempest/tools/config_tempest.py --out etc/tempest.conf \\"},{"line_number":647,"context_line":"    --debug \\"},{"line_number":648,"context_line":"    --create \\"},{"line_number":649,"context_line":"    --deployer-input ~/tempest-deployer-input.conf \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba0121b8_c72b8832","line":646,"updated":"2016-03-28 16:56:53.000000000","message":"config_tempest.py only exists in the Red Hat fork of Tempest (https://github.com/redhat-openstack/tempest) and (unfortunately, IMO) finds it\u0027s way into the RDO packages.\nWe have recently made sure that OpenStack Puppet Modules packaged in RDO were 100% upstream with no midstream or downstream patches. Tempest has to follow. We should not depend on this tool.\n\nTripleO already makes extensive usage of puppet modules. Packstack and Puppet OpenStack use puppet-tempest to install and configure Tempest from source. If installing from source is a problem, you can toggle the installation (see: https://bugs.launchpad.net/puppet-tempest/+bug/1549366).","commit_id":"c25b4d0ea0f0be4512fa6f4c31251d709532b8ee"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"b130023bcd28c0c76d385e84b8236f37fd9d4ec6","unresolved":false,"context_lines":[{"line_number":643,"context_line":"    sudo yum install -y libffi-devel"},{"line_number":644,"context_line":"    python $HOME/tempest/tools/install_venv.py"},{"line_number":645,"context_line":"    $HOME/tempest/tools/with_venv.sh pip install junitxml"},{"line_number":646,"context_line":"    $HOME/tempest/tools/with_venv.sh $HOME/tempest/tools/config_tempest.py --out etc/tempest.conf \\"},{"line_number":647,"context_line":"    --debug \\"},{"line_number":648,"context_line":"    --create \\"},{"line_number":649,"context_line":"    --deployer-input ~/tempest-deployer-input.conf \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba0121b8_dc9324a2","line":646,"in_reply_to":"ba0121b8_9de703e4","updated":"2016-03-29 15:56:31.000000000","message":"I don\u0027t think so, but I added it here meanwhile.","commit_id":"c25b4d0ea0f0be4512fa6f4c31251d709532b8ee"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"99db9783f6cfd36cbe0fafaa922a7f0502e0f4d9","unresolved":false,"context_lines":[{"line_number":643,"context_line":"    sudo yum install -y libffi-devel"},{"line_number":644,"context_line":"    python $HOME/tempest/tools/install_venv.py"},{"line_number":645,"context_line":"    $HOME/tempest/tools/with_venv.sh pip install junitxml"},{"line_number":646,"context_line":"    $HOME/tempest/tools/with_venv.sh $HOME/tempest/tools/config_tempest.py --out etc/tempest.conf \\"},{"line_number":647,"context_line":"    --debug \\"},{"line_number":648,"context_line":"    --create \\"},{"line_number":649,"context_line":"    --deployer-input ~/tempest-deployer-input.conf \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba0121b8_9de703e4","line":646,"in_reply_to":"ba0121b8_c72b8832","updated":"2016-03-29 09:07:53.000000000","message":"Can\u0027t we push this tool upstream ?","commit_id":"c25b4d0ea0f0be4512fa6f4c31251d709532b8ee"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"b130023bcd28c0c76d385e84b8236f37fd9d4ec6","unresolved":false,"context_lines":[{"line_number":643,"context_line":"    sudo yum install -y libffi-devel"},{"line_number":644,"context_line":"    python $HOME/tempest/tools/install_venv.py"},{"line_number":645,"context_line":"    $HOME/tempest/tools/with_venv.sh pip install junitxml"},{"line_number":646,"context_line":"    $HOME/tempest/tools/with_venv.sh $HOME/tempest/tools/config_tempest.py --out etc/tempest.conf \\"},{"line_number":647,"context_line":"    --debug \\"},{"line_number":648,"context_line":"    --create \\"},{"line_number":649,"context_line":"    --deployer-input ~/tempest-deployer-input.conf \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba0121b8_dcacc4ef","line":646,"in_reply_to":"ba0121b8_c72b8832","updated":"2016-03-29 15:56:31.000000000","message":"is being discussed in mail and tripleo meetings, as one of workaround option I add this tool here in Ci repo, to check if it runs ok","commit_id":"c25b4d0ea0f0be4512fa6f4c31251d709532b8ee"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"99db9783f6cfd36cbe0fafaa922a7f0502e0f4d9","unresolved":false,"context_lines":[{"line_number":647,"context_line":"    --debug \\"},{"line_number":648,"context_line":"    --create \\"},{"line_number":649,"context_line":"    --deployer-input ~/tempest-deployer-input.conf \\"},{"line_number":650,"context_line":"identity.uri $OS_AUTH_URL \\"},{"line_number":651,"context_line":"compute.allow_tenant_isolation true \\"},{"line_number":652,"context_line":"identity.admin_password $OS_PASSWORD \\"},{"line_number":653,"context_line":"compute.build_timeout 500 \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba0121b8_9dfee369","line":650,"updated":"2016-03-29 09:07:53.000000000","message":"is this the correct indentation ?","commit_id":"c25b4d0ea0f0be4512fa6f4c31251d709532b8ee"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"b130023bcd28c0c76d385e84b8236f37fd9d4ec6","unresolved":false,"context_lines":[{"line_number":647,"context_line":"    --debug \\"},{"line_number":648,"context_line":"    --create \\"},{"line_number":649,"context_line":"    --deployer-input ~/tempest-deployer-input.conf \\"},{"line_number":650,"context_line":"identity.uri $OS_AUTH_URL \\"},{"line_number":651,"context_line":"compute.allow_tenant_isolation true \\"},{"line_number":652,"context_line":"identity.admin_password $OS_PASSWORD \\"},{"line_number":653,"context_line":"compute.build_timeout 500 \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba0121b8_fcdd4871","line":650,"in_reply_to":"ba0121b8_9dfee369","updated":"2016-03-29 15:56:31.000000000","message":"added spaces","commit_id":"c25b4d0ea0f0be4512fa6f4c31251d709532b8ee"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"e2952d8d871521990be727a406c594adad86258f","unresolved":false,"context_lines":[{"line_number":654,"context_line":"    export FLOATING_IP_END\u003d${FLOATING_IP_END:-\"192.0.2.64\"};"},{"line_number":655,"context_line":"    export EXTERNAL_NETWORK_GATEWAY\u003d${EXTERNAL_NETWORK_GATEWAY:-\"192.0.2.1\"};"},{"line_number":656,"context_line":"    neutron net-create nova --shared --router:external\u003dTrue --provider:network_type flat --provider:physical_network datacentre;"},{"line_number":657,"context_line":"    neutron subnet-create --name ext-subnet --allocation-pool start\u003d$FLOATING_IP_START,end\u003d$FLOATING_IP_END --disable-dhcp --gateway $EXTERNAL_NETWORK_GATEWAY nova $FLOATING_IP_CIDR;"},{"line_number":658,"context_line":"    sudo yum install -y libffi-devel openssl-devel"},{"line_number":659,"context_line":"    python $HOME/tempest/tools/install_venv.py"},{"line_number":660,"context_line":"    $HOME/tempest/tools/with_venv.sh pip install junitxml"}],"source_content_type":"text/x-sh","patch_set":11,"id":"5a18252c_81be0763","line":657,"updated":"2016-04-14 13:00:40.000000000","message":"So this part of the stack is actually something we handle with Heat via the ping test. I wonder if it would make sense to create a separate \u0027network\u0027 stack which we could share across the ping and tempest tests?\n\nI\u0027m not asking you to do this yet BTW... just asking the idea to see what others think about using Heat for both of these testing options (ping test, and tempest)","commit_id":"d1986118723d3389b8f002b231f3096033e3581e"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"54bb019b3722e6754d730327a2b48a805cc8bb60","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    echo \"      --enable-check          -- Enable checks on update.\""},{"line_number":65,"context_line":"    echo \"      --overcloud-pingtest    -- Run a tenant vm, attach and ping floating IP.\""},{"line_number":66,"context_line":"    echo \"      --skip-pingtest-cleanup -- For debuging purposes, do not delete the created resources when performing a pingtest.\""},{"line_number":67,"context_line":"    echo \"      --tempest-run           -- Run tempest tests.\""},{"line_number":68,"context_line":"    echo \"      --all, -a               -- Run all of the above commands.\""},{"line_number":69,"context_line":"    echo \"      -x                      -- enable tracing\""},{"line_number":70,"context_line":"    echo \"      --help, -h              -- Print this help message.\""}],"source_content_type":"text/x-sh","patch_set":16,"id":"1a122d0e_3de221a0","line":67,"updated":"2016-04-22 11:43:08.000000000","message":"run-tempest would have match the others","commit_id":"3d678a5bccde93e448b6037a4ebb8a118306a566"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d461dc38018f7457402c38e2c96918f82f73a444","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    echo \"      --enable-check          -- Enable checks on update.\""},{"line_number":65,"context_line":"    echo \"      --overcloud-pingtest    -- Run a tenant vm, attach and ping floating IP.\""},{"line_number":66,"context_line":"    echo \"      --skip-pingtest-cleanup -- For debuging purposes, do not delete the created resources when performing a pingtest.\""},{"line_number":67,"context_line":"    echo \"      --tempest-run           -- Run tempest tests.\""},{"line_number":68,"context_line":"    echo \"      --all, -a               -- Run all of the above commands.\""},{"line_number":69,"context_line":"    echo \"      -x                      -- enable tracing\""},{"line_number":70,"context_line":"    echo \"      --help, -h              -- Print this help message.\""}],"source_content_type":"text/x-sh","patch_set":16,"id":"1a122d0e_7fe0e3cc","line":67,"in_reply_to":"1a122d0e_3de221a0","updated":"2016-04-24 08:08:11.000000000","message":"Done","commit_id":"3d678a5bccde93e448b6037a4ebb8a118306a566"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"63bdd621f0413e70c65808b95c7ddaf90c2ef505","unresolved":false,"context_lines":[{"line_number":652,"context_line":""},{"line_number":653,"context_line":"function clean_tempest {"},{"line_number":654,"context_line":"    neutron net-delete nova || echo \"Cleaning tempest: no networks were created\""},{"line_number":655,"context_line":"    rm -rf $HOME/tempest"},{"line_number":656,"context_line":"}"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"function tempest_run {"}],"source_content_type":"text/x-sh","patch_set":16,"id":"1a122d0e_1b5ac32a","line":655,"updated":"2016-04-22 15:05:01.000000000","message":"I don\u0027t like this.  It means we\u0027re going to have to completely rebuild the tempest env from scratch every time we want to run it.  That\u0027s fine for CI where it gets run once, but for developers who might be iterating on a fix it\u0027s rather unfriendly.","commit_id":"3d678a5bccde93e448b6037a4ebb8a118306a566"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d461dc38018f7457402c38e2c96918f82f73a444","unresolved":false,"context_lines":[{"line_number":652,"context_line":""},{"line_number":653,"context_line":"function clean_tempest {"},{"line_number":654,"context_line":"    neutron net-delete nova || echo \"Cleaning tempest: no networks were created\""},{"line_number":655,"context_line":"    rm -rf $HOME/tempest"},{"line_number":656,"context_line":"}"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"function tempest_run {"}],"source_content_type":"text/x-sh","patch_set":16,"id":"1a122d0e_dfe777e2","line":655,"in_reply_to":"1a122d0e_1b5ac32a","updated":"2016-04-24 08:08:11.000000000","message":"Done","commit_id":"3d678a5bccde93e448b6037a4ebb8a118306a566"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"63bdd621f0413e70c65808b95c7ddaf90c2ef505","unresolved":false,"context_lines":[{"line_number":660,"context_line":"    log \"Running tempest\""},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    overcloudrc_check"},{"line_number":663,"context_line":"    clean_tempest"},{"line_number":664,"context_line":"    root_dir\u003d$(realpath $(dirname ${BASH_SOURCE[0]:-$0}))"},{"line_number":665,"context_line":"    git clone https://github.com/openstack/tempest $HOME/tempest"},{"line_number":666,"context_line":"    pushd $HOME/tempest"}],"source_content_type":"text/x-sh","patch_set":16,"id":"1a122d0e_fbe8a718","line":663,"updated":"2016-04-22 15:05:01.000000000","message":"I\u0027d prefer to also clean up the resources created by this at the end of the run.  I\u0027m fine with asserting that the environment is clean to begin with too (we do that in the ping test as well), but we should be cleaning up after ourselves.","commit_id":"3d678a5bccde93e448b6037a4ebb8a118306a566"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d461dc38018f7457402c38e2c96918f82f73a444","unresolved":false,"context_lines":[{"line_number":660,"context_line":"    log \"Running tempest\""},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    overcloudrc_check"},{"line_number":663,"context_line":"    clean_tempest"},{"line_number":664,"context_line":"    root_dir\u003d$(realpath $(dirname ${BASH_SOURCE[0]:-$0}))"},{"line_number":665,"context_line":"    git clone https://github.com/openstack/tempest $HOME/tempest"},{"line_number":666,"context_line":"    pushd $HOME/tempest"}],"source_content_type":"text/x-sh","patch_set":16,"id":"1a122d0e_3fd78bee","line":663,"in_reply_to":"1a122d0e_fbe8a718","updated":"2016-04-24 08:08:11.000000000","message":"Cleaning after will disable any possible investigation you\u0027ll want to do. I think it\u0027s usual to clean BEFORE any run, to allow investigation of failures or anything else after the run.","commit_id":"3d678a5bccde93e448b6037a4ebb8a118306a566"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"54bb019b3722e6754d730327a2b48a805cc8bb60","unresolved":false,"context_lines":[{"line_number":664,"context_line":"    root_dir\u003d$(realpath $(dirname ${BASH_SOURCE[0]:-$0}))"},{"line_number":665,"context_line":"    git clone https://github.com/openstack/tempest $HOME/tempest"},{"line_number":666,"context_line":"    pushd $HOME/tempest"},{"line_number":667,"context_line":"    export FLOATING_IP_CIDR\u003d${FLOATING_IP_CIDR:-\"192.0.2.0/24\"};"},{"line_number":668,"context_line":"    export FLOATING_IP_START\u003d${FLOATING_IP_START:-\"192.0.2.50\"};"},{"line_number":669,"context_line":"    export FLOATING_IP_END\u003d${FLOATING_IP_END:-\"192.0.2.64\"};"},{"line_number":670,"context_line":"    export EXTERNAL_NETWORK_GATEWAY\u003d${EXTERNAL_NETWORK_GATEWAY:-\"192.0.2.1\"};"}],"source_content_type":"text/x-sh","patch_set":16,"id":"1a122d0e_581d6b65","line":667,"updated":"2016-04-22 11:43:08.000000000","message":"these should not be exported though, so that can be overridden as in overcloud_deploy","commit_id":"3d678a5bccde93e448b6037a4ebb8a118306a566"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d461dc38018f7457402c38e2c96918f82f73a444","unresolved":false,"context_lines":[{"line_number":664,"context_line":"    root_dir\u003d$(realpath $(dirname ${BASH_SOURCE[0]:-$0}))"},{"line_number":665,"context_line":"    git clone https://github.com/openstack/tempest $HOME/tempest"},{"line_number":666,"context_line":"    pushd $HOME/tempest"},{"line_number":667,"context_line":"    export FLOATING_IP_CIDR\u003d${FLOATING_IP_CIDR:-\"192.0.2.0/24\"};"},{"line_number":668,"context_line":"    export FLOATING_IP_START\u003d${FLOATING_IP_START:-\"192.0.2.50\"};"},{"line_number":669,"context_line":"    export FLOATING_IP_END\u003d${FLOATING_IP_END:-\"192.0.2.64\"};"},{"line_number":670,"context_line":"    export EXTERNAL_NETWORK_GATEWAY\u003d${EXTERNAL_NETWORK_GATEWAY:-\"192.0.2.1\"};"}],"source_content_type":"text/x-sh","patch_set":16,"id":"1a122d0e_bfd43bbd","line":667,"in_reply_to":"1a122d0e_581d6b65","updated":"2016-04-24 08:08:11.000000000","message":"Done","commit_id":"3d678a5bccde93e448b6037a4ebb8a118306a566"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e1b93362246f4116ab08d8eaeeae2b23fd7f788b","unresolved":false,"context_lines":[{"line_number":674,"context_line":"    virtualenv --no-site-packages .venv"},{"line_number":675,"context_line":"    $HOME/tempest/tools/with_venv.sh pip install -U pip setuptools"},{"line_number":676,"context_line":"    $HOME/tempest/tools/with_venv.sh pip install junitxml httplib2 -r test-requirements.txt -r requirements.txt"},{"line_number":677,"context_line":"    cp $root_dir/config_tempest.py $HOME/tempest/tools/"},{"line_number":678,"context_line":"    cp $root_dir/api_discovery.py $HOME/tempest/tempest/common/"},{"line_number":679,"context_line":"    cp $root_dir/default-overrides.conf $HOME/tempest/etc/"},{"line_number":680,"context_line":"    sudo mkdir -p /var/log/tempest/ ||:"}],"source_content_type":"text/x-sh","patch_set":16,"id":"1a122d0e_b2249baf","line":677,"updated":"2016-04-22 12:45:08.000000000","message":"is there a reason why the tempest-deployer-input.conf file generated by the tripleoclient is insufficient? can we make it better in tripleoclient and avoid this step?","commit_id":"3d678a5bccde93e448b6037a4ebb8a118306a566"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"63bdd621f0413e70c65808b95c7ddaf90c2ef505","unresolved":false,"context_lines":[{"line_number":674,"context_line":"    virtualenv --no-site-packages .venv"},{"line_number":675,"context_line":"    $HOME/tempest/tools/with_venv.sh pip install -U pip setuptools"},{"line_number":676,"context_line":"    $HOME/tempest/tools/with_venv.sh pip install junitxml httplib2 -r test-requirements.txt -r requirements.txt"},{"line_number":677,"context_line":"    cp $root_dir/config_tempest.py $HOME/tempest/tools/"},{"line_number":678,"context_line":"    cp $root_dir/api_discovery.py $HOME/tempest/tempest/common/"},{"line_number":679,"context_line":"    cp $root_dir/default-overrides.conf $HOME/tempest/etc/"},{"line_number":680,"context_line":"    sudo mkdir -p /var/log/tempest/ ||:"}],"source_content_type":"text/x-sh","patch_set":16,"id":"1a122d0e_bb558fc7","line":677,"in_reply_to":"1a122d0e_b2249baf","updated":"2016-04-22 15:05:01.000000000","message":"+1","commit_id":"3d678a5bccde93e448b6037a4ebb8a118306a566"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d461dc38018f7457402c38e2c96918f82f73a444","unresolved":false,"context_lines":[{"line_number":674,"context_line":"    virtualenv --no-site-packages .venv"},{"line_number":675,"context_line":"    $HOME/tempest/tools/with_venv.sh pip install -U pip setuptools"},{"line_number":676,"context_line":"    $HOME/tempest/tools/with_venv.sh pip install junitxml httplib2 -r test-requirements.txt -r requirements.txt"},{"line_number":677,"context_line":"    cp $root_dir/config_tempest.py $HOME/tempest/tools/"},{"line_number":678,"context_line":"    cp $root_dir/api_discovery.py $HOME/tempest/tempest/common/"},{"line_number":679,"context_line":"    cp $root_dir/default-overrides.conf $HOME/tempest/etc/"},{"line_number":680,"context_line":"    sudo mkdir -p /var/log/tempest/ ||:"}],"source_content_type":"text/x-sh","patch_set":16,"id":"1a122d0e_e2f3bc08","line":677,"in_reply_to":"1a122d0e_b2249baf","updated":"2016-04-24 08:08:11.000000000","message":"If you mean generation of tempest configuration, I very doubt in this. Like I see from the code of tripleoclient it just writes five hardcoded lines, nothing more, it could be replaced just by \"echo\"s.\n\nOn other hand, tempest configuration requires both creating resources and their discovery - tenants, users, networks, images, etc. And all this should be written in specific sections with specific keywords as tempest requires.\n\nMaybe it\u0027s possible to do such discovery of installed services and all theirs features, dumping from heat, creating stacks for tempest and then dumping their data as well. I suppose it could be good idea for separate long range project, but in scope of tripleo code. Remember that you need also to keep it compliant with tempest all the time and reflect its changes.","commit_id":"3d678a5bccde93e448b6037a4ebb8a118306a566"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d461dc38018f7457402c38e2c96918f82f73a444","unresolved":false,"context_lines":[{"line_number":674,"context_line":"    virtualenv --no-site-packages .venv"},{"line_number":675,"context_line":"    $HOME/tempest/tools/with_venv.sh pip install -U pip setuptools"},{"line_number":676,"context_line":"    $HOME/tempest/tools/with_venv.sh pip install junitxml httplib2 -r test-requirements.txt -r requirements.txt"},{"line_number":677,"context_line":"    cp $root_dir/config_tempest.py $HOME/tempest/tools/"},{"line_number":678,"context_line":"    cp $root_dir/api_discovery.py $HOME/tempest/tempest/common/"},{"line_number":679,"context_line":"    cp $root_dir/default-overrides.conf $HOME/tempest/etc/"},{"line_number":680,"context_line":"    sudo mkdir -p /var/log/tempest/ ||:"}],"source_content_type":"text/x-sh","patch_set":16,"id":"1a122d0e_c2f680f8","line":677,"in_reply_to":"1a122d0e_bb558fc7","updated":"2016-04-24 08:08:11.000000000","message":"replied above","commit_id":"3d678a5bccde93e448b6037a4ebb8a118306a566"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"63bdd621f0413e70c65808b95c7ddaf90c2ef505","unresolved":false,"context_lines":[{"line_number":702,"context_line":"        tee \u003e( subunit2junitxml --output-to\u003d/var/log/tempest/tempest.xml ) | \\"},{"line_number":703,"context_line":"        subunit-trace --no-failure-debug -f 2\u003e\u00261 | \\"},{"line_number":704,"context_line":"        tee /var/log/tempest/tempest_console.log"},{"line_number":705,"context_line":"    exitval\u003d$?"},{"line_number":706,"context_line":"    subunit2html $(find $HOME/tempest/.testrepository -name [0-9] | head -1) /var/log/tempest/tempest.html"},{"line_number":707,"context_line":"    exit ${exitval}"},{"line_number":708,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":16,"id":"1a122d0e_1b0c833a","line":705,"updated":"2016-04-22 15:05:01.000000000","message":"This will not work correctly.  This script is set -e, so if the previous command fails you\u0027ll never get here to check the exit code.","commit_id":"3d678a5bccde93e448b6037a4ebb8a118306a566"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d461dc38018f7457402c38e2c96918f82f73a444","unresolved":false,"context_lines":[{"line_number":702,"context_line":"        tee \u003e( subunit2junitxml --output-to\u003d/var/log/tempest/tempest.xml ) | \\"},{"line_number":703,"context_line":"        subunit-trace --no-failure-debug -f 2\u003e\u00261 | \\"},{"line_number":704,"context_line":"        tee /var/log/tempest/tempest_console.log"},{"line_number":705,"context_line":"    exitval\u003d$?"},{"line_number":706,"context_line":"    subunit2html $(find $HOME/tempest/.testrepository -name [0-9] | head -1) /var/log/tempest/tempest.html"},{"line_number":707,"context_line":"    exit ${exitval}"},{"line_number":708,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":16,"id":"1a122d0e_7f158399","line":705,"in_reply_to":"1a122d0e_1b0c833a","updated":"2016-04-24 08:08:11.000000000","message":"Done","commit_id":"3d678a5bccde93e448b6037a4ebb8a118306a566"}]}