)]}'
{"scripts/te-broker/create-env":[{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"6a602a36dcb20cee7b35c03b4765db825e332c5c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"done"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"nova interface-attach --net-id $(neutron net-show -F id -f value $PROVISIONNET) $UCINSTANCE"},{"line_number":53,"context_line":"if [ $NETISO -eq 1 ]; then"},{"line_number":54,"context_line":"    nova interface-attach --net-id $(neutron net-show -F id -f value $PUBLICNET) $UCINSTANCE"},{"line_number":55,"context_line":"fi"},{"line_number":56,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a629dbe_6474aa67","line":53,"updated":"2016-11-10 14:54:06.000000000","message":"Did you mean if s/1/multi-nic/ ?","commit_id":"4bc94810bde09b68c895971c4a43a4e79c324b61"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"ba9ff67489d21c5bff7e630d7692642d8be8d471","unresolved":false,"context_lines":[{"line_number":50,"context_line":"done"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"nova interface-attach --net-id $(neutron net-show -F id -f value $PROVISIONNET) $UCINSTANCE"},{"line_number":53,"context_line":"if [ $NETISO -eq 1 ]; then"},{"line_number":54,"context_line":"    nova interface-attach --net-id $(neutron net-show -F id -f value $PUBLICNET) $UCINSTANCE"},{"line_number":55,"context_line":"fi"},{"line_number":56,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a629dbe_8dfaba41","line":53,"in_reply_to":"9a629dbe_6474aa67","updated":"2016-11-10 17:27:44.000000000","message":"Crud, yes.","commit_id":"4bc94810bde09b68c895971c4a43a4e79c324b61"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"4d4448260a9cf4a3fb458772c58338350723af9c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"done"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"nova interface-attach --net-id $(neutron net-show -F id -f value $PROVISIONNET) $UCINSTANCE"},{"line_number":53,"context_line":"if [ $NETISO \u003d\u003d \u0027multi-nic\u0027 ]; then"},{"line_number":54,"context_line":"    nova interface-attach --net-id $(neutron net-show -F id -f value $PUBLICNET) $UCINSTANCE"},{"line_number":55,"context_line":"fi"},{"line_number":56,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"5a74a57a_b6f91dcb","line":53,"updated":"2016-11-23 17:44:23.000000000","message":"Crud, this should actually be !\u003d \u0027none\u0027 now that there are two net-iso settings.","commit_id":"3e7d197e5f4c931eab1caa2187ac95a6a6819d3e"}],"toci_gate_test.sh":[{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"6a602a36dcb20cee7b35c03b4765db825e332c5c","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    # TODO(bnemec): Add jobs that use public-bond"},{"line_number":230,"context_line":"    NETISO_ENV\u003d\"none\""},{"line_number":231,"context_line":"    if [ $NETISO_V4 -eq 1 -o $NETISO_V6 -eq 1 ]; then"},{"line_number":232,"context_line":"        NETISO_ENV\u003d\"multi-nic\""},{"line_number":233,"context_line":"    fi"},{"line_number":234,"context_line":"    ./testenv-client -b $GEARDSERVER:4730 -t $TIMEOUT_SECS --envsize $(($NODECOUNT+1)) --ucinstance $UCINSTANCEID --net-iso $NETISO_ENV -- $TOCIRUNNER"},{"line_number":235,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a629dbe_8488dec6","line":232,"updated":"2016-11-10 14:54:06.000000000","message":"I\u0027d prefer is we kept the setting of NETIS_ENV inside the case statement where we set all the other env settings.\n\nIt should also help with trowns  patch to make this stuff more consumable\n   https://review.openstack.org/#/c/377035/","commit_id":"4bc94810bde09b68c895971c4a43a4e79c324b61"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"ba9ff67489d21c5bff7e630d7692642d8be8d471","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    # TODO(bnemec): Add jobs that use public-bond"},{"line_number":230,"context_line":"    NETISO_ENV\u003d\"none\""},{"line_number":231,"context_line":"    if [ $NETISO_V4 -eq 1 -o $NETISO_V6 -eq 1 ]; then"},{"line_number":232,"context_line":"        NETISO_ENV\u003d\"multi-nic\""},{"line_number":233,"context_line":"    fi"},{"line_number":234,"context_line":"    ./testenv-client -b $GEARDSERVER:4730 -t $TIMEOUT_SECS --envsize $(($NODECOUNT+1)) --ucinstance $UCINSTANCEID --net-iso $NETISO_ENV -- $TOCIRUNNER"},{"line_number":235,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a629dbe_e8efa41b","line":232,"in_reply_to":"9a629dbe_8488dec6","updated":"2016-11-10 17:27:44.000000000","message":"This variable isn\u0027t meaningful unless you\u0027re calling testenv-client though.  It isn\u0027t consumed anywhere else.  It will also require some duplication if we move it into each case statement.","commit_id":"4bc94810bde09b68c895971c4a43a4e79c324b61"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"bc9008717180158792d5ab264f83b31c072d9d3c","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    # TODO(bnemec): Add jobs that use public-bond"},{"line_number":258,"context_line":"    NETISO_ENV\u003d\"none\""},{"line_number":259,"context_line":"    if [ $NETISO_V4 -eq 1 -o $NETISO_V6 -eq 1 ]; then"},{"line_number":260,"context_line":"        NETISO_ENV\u003d\"multi-nic\""},{"line_number":261,"context_line":"    fi"},{"line_number":262,"context_line":"    ./testenv-client -b $GEARDSERVER:4730 -t $TIMEOUT_SECS --envsize $(($NODECOUNT+1)) --ucinstance $UCINSTANCEID --net-iso $NETISO_ENV -- $TOCIRUNNER"},{"line_number":263,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":9,"id":"ba5201f7_3a13e1b9","line":260,"updated":"2017-01-11 16:08:54.000000000","message":"this is already the default, wouldn\u0027t you just want to check if it\u0027s not one of these and set it to none if that\u0027s the case?","commit_id":"ae1c5cc726f03681237b706b520319fb15322359"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"edd456d9c8d013d51d299be8e4bc1342ffbf9762","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    # TODO(bnemec): Add jobs that use public-bond"},{"line_number":258,"context_line":"    NETISO_ENV\u003d\"none\""},{"line_number":259,"context_line":"    if [ $NETISO_V4 -eq 1 -o $NETISO_V6 -eq 1 ]; then"},{"line_number":260,"context_line":"        NETISO_ENV\u003d\"multi-nic\""},{"line_number":261,"context_line":"    fi"},{"line_number":262,"context_line":"    ./testenv-client -b $GEARDSERVER:4730 -t $TIMEOUT_SECS --envsize $(($NODECOUNT+1)) --ucinstance $UCINSTANCEID --net-iso $NETISO_ENV -- $TOCIRUNNER"},{"line_number":263,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":9,"id":"ba5201f7_118efb78","line":260,"in_reply_to":"ba5201f7_3a13e1b9","updated":"2017-01-11 18:12:32.000000000","message":"I could, but then I\u0027d have to remove --net-iso from the testenv-client call if we\u0027re doing multi-nic net-iso.  Also, the followup patch is going to split this if into two for bond support, so it\u0027s nice to have the explicit mapping of which job uses which nic layout and not implicitly rely on the default.","commit_id":"ae1c5cc726f03681237b706b520319fb15322359"}]}