)]}'
{"scripts/quickstart/ovb-playbook.yml":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"28de3137553ff8d2a5549df784cb4785a6cb2d6d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  tags:"},{"line_number":12,"context_line":"    - local"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Set up CentOS undercloud node to run TripleO Quickstart"},{"line_number":15,"context_line":"  hosts: undercloud"},{"line_number":16,"context_line":"  gather_facts: no"},{"line_number":17,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3a1ff146_c0edc6f0","line":14,"range":{"start_line":14,"start_character":15,"end_line":14,"end_character":21},"updated":"2017-03-15 19:50:15.000000000","message":"nit... remove CentOS. We may have other images available at some point.","commit_id":"dcf467e1efde2d82e779994ddab516efe671b3d8"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"3b5a633e60dee3ae1bade752df1e5ca01baa905d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  tags:"},{"line_number":12,"context_line":"    - local"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Set up CentOS undercloud node to run TripleO Quickstart"},{"line_number":15,"context_line":"  hosts: undercloud"},{"line_number":16,"context_line":"  gather_facts: no"},{"line_number":17,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3a1ff146_e012c2b3","line":14,"range":{"start_line":14,"start_character":15,"end_line":14,"end_character":21},"in_reply_to":"3a1ff146_c0edc6f0","updated":"2017-03-15 19:55:25.000000000","message":"ok","commit_id":"dcf467e1efde2d82e779994ddab516efe671b3d8"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"28de3137553ff8d2a5549df784cb4785a6cb2d6d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  roles:"},{"line_number":57,"context_line":"    - { role: fetch-images, when: not to_build|bool }"},{"line_number":58,"context_line":"    - { role: repo-setup, repo_inject_image_path: \"$HOME/overcloud-full.qcow2\", repo_run_live: false, when: not to_build|bool }"},{"line_number":59,"context_line":"#    - { role: repo-setup, repo_inject_image_path: \"$HOME/ironic-python-agent.initramfs\", repo_run_live: false }"},{"line_number":60,"context_line":"    - { role: install-built-repo, when: compressed_gating_repo is defined and not to_build|bool }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# Deploy the undercloud"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3a1ff146_60cfb27f","line":59,"updated":"2017-03-15 19:50:15.000000000","message":"nit.. remove this line","commit_id":"dcf467e1efde2d82e779994ddab516efe671b3d8"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"3b5a633e60dee3ae1bade752df1e5ca01baa905d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  roles:"},{"line_number":57,"context_line":"    - { role: fetch-images, when: not to_build|bool }"},{"line_number":58,"context_line":"    - { role: repo-setup, repo_inject_image_path: \"$HOME/overcloud-full.qcow2\", repo_run_live: false, when: not to_build|bool }"},{"line_number":59,"context_line":"#    - { role: repo-setup, repo_inject_image_path: \"$HOME/ironic-python-agent.initramfs\", repo_run_live: false }"},{"line_number":60,"context_line":"    - { role: install-built-repo, when: compressed_gating_repo is defined and not to_build|bool }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# Deploy the undercloud"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3a1ff146_80690e28","line":59,"in_reply_to":"3a1ff146_60cfb27f","updated":"2017-03-15 19:55:25.000000000","message":"It\u0027s actually gap in functionality that we can\u0027t update initramfs image with oooq. So I\u0027d prefer to leave it so and add \"TODO\" comment there.","commit_id":"dcf467e1efde2d82e779994ddab516efe671b3d8"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"0d5776e06cd3705e194e5db7eadce8f937ae52df","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  gather_facts: no"},{"line_number":17,"context_line":"  roles:"},{"line_number":18,"context_line":"    - undercloud-setup"},{"line_number":19,"context_line":"  tasks:"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    - name: Add eth2 interface from /tmp/eth2.cfg"},{"line_number":22,"context_line":"      command: os-net-config -c /tmp/eth2.cfg -v"},{"line_number":23,"context_line":"      become: true"},{"line_number":24,"context_line":"      when: network_isolation|bool"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    - name: Remove redundant hosts from instackenv.json"},{"line_number":27,"context_line":"      shell: \u003e"},{"line_number":28,"context_line":"        cp ~/instackenv.json ~/instackenv.json.backup;"},{"line_number":29,"context_line":"        cat ~/instackenv.json | jq \u0027{\"nodes\": .nodes[:{{ overcloud_nodes_count }}]}\u0027 \u003e /tmp/instackenv1.json \u0026\u0026"},{"line_number":30,"context_line":"        mv /tmp/instackenv1.json ~/instackenv.json;"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    - name: Check if we need to build images"},{"line_number":33,"context_line":"      set_fact:"},{"line_number":34,"context_line":"        to_build: \"{{ lookup(\u0027pipe\u0027, \u0027{{ tripleo_root }}/tripleo-ci/scripts/to_build\u0027)|default(\u0027false\u0027)|bool }}\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- name: Run DLRN gate role and install repo"},{"line_number":37,"context_line":"  hosts: undercloud"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1a1ced50_fd36bee5","line":34,"range":{"start_line":19,"start_character":0,"end_line":34,"end_character":112},"updated":"2017-03-20 19:44:21.000000000","message":"IMHO we should try to keep tasks out of playbooks and instead create roles.  If upstream tripleo requires certain steps to be completed let\u0027s push these tasks into roles and use the playbooks to call the roles we need.\n\nThe roles can live in tripleo-ci and just be called with additional requirements.\n\nPutting tasks directly into playbooks seems like we\u0027re  adding technical debt and doing things a little differently in this one environment. \n\nWhat do others think?","commit_id":"09e7a6ede9fff233a8bbd6803496592b0287e896"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"13ce30eaa98caf423c6d342e3e635209f0d3614b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    - name: Remove redundant hosts from instackenv.json"},{"line_number":27,"context_line":"      shell: \u003e"},{"line_number":28,"context_line":"        cp ~/instackenv.json ~/instackenv.json.backup;"},{"line_number":29,"context_line":"        cat ~/instackenv.json | jq \u0027{\"nodes\": .nodes[:{{ overcloud_nodes_count }}]}\u0027 \u003e /tmp/instackenv1.json \u0026\u0026"},{"line_number":30,"context_line":"        mv /tmp/instackenv1.json ~/instackenv.json;"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    - name: Check if we need to build images"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffe62b97_499d3c64","line":29,"updated":"2017-03-29 14:45:24.000000000","message":"nit: you can specify the file name to jq as the last parameter\n\n    Usage: jq [options] \u003cjq filter\u003e [file...]","commit_id":"da52fac5ade385407e4abf35e72453474378fc6d"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"007405cad66e2187d5aa4e840dbd13dac3fb4e44","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    - name: Remove redundant hosts from instackenv.json"},{"line_number":27,"context_line":"      shell: \u003e"},{"line_number":28,"context_line":"        cp ~/instackenv.json ~/instackenv.json.backup;"},{"line_number":29,"context_line":"        cat ~/instackenv.json | jq \u0027{\"nodes\": .nodes[:{{ overcloud_nodes_count }}]}\u0027 \u003e /tmp/instackenv1.json \u0026\u0026"},{"line_number":30,"context_line":"        mv /tmp/instackenv1.json ~/instackenv.json;"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    - name: Check if we need to build images"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffe62b97_441ac116","line":29,"in_reply_to":"ffe62b97_499d3c64","updated":"2017-03-30 09:38:09.000000000","message":"Thanks, although I think I\u0027ll delete this part at all in followup patches. Ben Nemec modified OVB scripts so we have exactly number of nodes in instackenv.json","commit_id":"da52fac5ade385407e4abf35e72453474378fc6d"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"13ce30eaa98caf423c6d342e3e635209f0d3614b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  roles:"},{"line_number":57,"context_line":"    - { role: fetch-images, when: not to_build|bool }"},{"line_number":58,"context_line":"    - { role: repo-setup, repo_inject_image_path: \"$HOME/overcloud-full.qcow2\", repo_run_live: false, when: not to_build|bool }"},{"line_number":59,"context_line":"#    - { role: repo-setup, repo_inject_image_path: \"$HOME/ironic-python-agent.initramfs\", repo_run_live: false }"},{"line_number":60,"context_line":"    - { role: install-built-repo, when: compressed_gating_repo is defined and not to_build|bool }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# Deploy the undercloud"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffe62b97_a9e848b2","line":59,"updated":"2017-03-29 14:45:24.000000000","message":"Why is this commented out?","commit_id":"da52fac5ade385407e4abf35e72453474378fc6d"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"007405cad66e2187d5aa4e840dbd13dac3fb4e44","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  roles:"},{"line_number":57,"context_line":"    - { role: fetch-images, when: not to_build|bool }"},{"line_number":58,"context_line":"    - { role: repo-setup, repo_inject_image_path: \"$HOME/overcloud-full.qcow2\", repo_run_live: false, when: not to_build|bool }"},{"line_number":59,"context_line":"#    - { role: repo-setup, repo_inject_image_path: \"$HOME/ironic-python-agent.initramfs\", repo_run_live: false }"},{"line_number":60,"context_line":"    - { role: install-built-repo, when: compressed_gating_repo is defined and not to_build|bool }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# Deploy the undercloud"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffe62b97_6486e5bb","line":59,"in_reply_to":"ffe62b97_a9e848b2","updated":"2017-03-30 09:38:09.000000000","message":"Because modify-image role doesn\u0027t support initramfs images atm. Opened a card: https://trello.com/c/N8rGIEV0 and bug https://bugs.launchpad.net/tripleo/+bug/1677275","commit_id":"da52fac5ade385407e4abf35e72453474378fc6d"}],"scripts/quickstart/ovb-settings.yml":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"28de3137553ff8d2a5549df784cb4785a6cb2d6d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# OVB settings"},{"line_number":2,"context_line":"multinode_mode: false"},{"line_number":3,"context_line":"undercloud_user: jenkins"},{"line_number":4,"context_line":"non_root_user: jenkins"},{"line_number":5,"context_line":"ssh_user: jenkins"},{"line_number":6,"context_line":"enable_vbmc: false"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3a1ff146_e0880225","line":3,"updated":"2017-03-15 19:50:15.000000000","message":"nit.. do we have to hard code the user and not use an env var?","commit_id":"dcf467e1efde2d82e779994ddab516efe671b3d8"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"3b5a633e60dee3ae1bade752df1e5ca01baa905d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# OVB settings"},{"line_number":2,"context_line":"multinode_mode: false"},{"line_number":3,"context_line":"undercloud_user: jenkins"},{"line_number":4,"context_line":"non_root_user: jenkins"},{"line_number":5,"context_line":"ssh_user: jenkins"},{"line_number":6,"context_line":"enable_vbmc: false"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3a1ff146_604092a6","line":3,"in_reply_to":"3a1ff146_e0880225","updated":"2017-03-15 19:55:25.000000000","message":"it\u0027s possible, but anyway we gonna change these settings and split them, and I would like to focus more on playbook in this patch.","commit_id":"dcf467e1efde2d82e779994ddab516efe671b3d8"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"13ce30eaa98caf423c6d342e3e635209f0d3614b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"step_set_undercloud_hostname: true"},{"line_number":13,"context_line":"undercloud_hostname: undercloud"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"step_introspect: true"},{"line_number":16,"context_line":"undercloud_generate_service_certificate: true"},{"line_number":17,"context_line":"run_tempest: false"},{"line_number":18,"context_line":"tempest_config: false"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffe62b97_094f3493","line":15,"updated":"2017-03-29 14:45:24.000000000","message":"Shouldn\u0027t this be set on a per-job basis, rather than generally here?","commit_id":"da52fac5ade385407e4abf35e72453474378fc6d"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"007405cad66e2187d5aa4e840dbd13dac3fb4e44","unresolved":false,"context_lines":[{"line_number":12,"context_line":"step_set_undercloud_hostname: true"},{"line_number":13,"context_line":"undercloud_hostname: undercloud"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"step_introspect: true"},{"line_number":16,"context_line":"undercloud_generate_service_certificate: true"},{"line_number":17,"context_line":"run_tempest: false"},{"line_number":18,"context_line":"tempest_config: false"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffe62b97_a0fb9944","line":15,"in_reply_to":"ffe62b97_094f3493","updated":"2017-03-30 09:38:09.000000000","message":"Done","commit_id":"da52fac5ade385407e4abf35e72453474378fc6d"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"13ce30eaa98caf423c6d342e3e635209f0d3614b","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"step_introspect: true"},{"line_number":16,"context_line":"undercloud_generate_service_certificate: true"},{"line_number":17,"context_line":"run_tempest: false"},{"line_number":18,"context_line":"tempest_config: false"},{"line_number":19,"context_line":"test_regex: \u0027.*smoke\u0027"},{"line_number":20,"context_line":"ssl_overcloud: false"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffe62b97_89622409","line":17,"updated":"2017-03-29 14:45:24.000000000","message":"Same as above.","commit_id":"da52fac5ade385407e4abf35e72453474378fc6d"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"007405cad66e2187d5aa4e840dbd13dac3fb4e44","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"step_introspect: true"},{"line_number":16,"context_line":"undercloud_generate_service_certificate: true"},{"line_number":17,"context_line":"run_tempest: false"},{"line_number":18,"context_line":"tempest_config: false"},{"line_number":19,"context_line":"test_regex: \u0027.*smoke\u0027"},{"line_number":20,"context_line":"ssl_overcloud: false"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffe62b97_6097d1ed","line":17,"in_reply_to":"ffe62b97_89622409","updated":"2017-03-30 09:38:09.000000000","message":"Done","commit_id":"da52fac5ade385407e4abf35e72453474378fc6d"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"13ce30eaa98caf423c6d342e3e635209f0d3614b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  - 10.1.8.10"},{"line_number":50,"context_line":"  - 8.8.8.8"},{"line_number":51,"context_line":"  - 8.8.4.4"},{"line_number":52,"context_line":"enable_pacemaker: true"},{"line_number":53,"context_line":"network_isolation: true"},{"line_number":54,"context_line":"network_isolation_type: \"multiple-nics\""},{"line_number":55,"context_line":"network_isolation_args: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffe62b97_09985419","line":52,"updated":"2017-03-29 14:45:24.000000000","message":"Same as above.","commit_id":"da52fac5ade385407e4abf35e72453474378fc6d"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"007405cad66e2187d5aa4e840dbd13dac3fb4e44","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  - 10.1.8.10"},{"line_number":50,"context_line":"  - 8.8.8.8"},{"line_number":51,"context_line":"  - 8.8.4.4"},{"line_number":52,"context_line":"enable_pacemaker: true"},{"line_number":53,"context_line":"network_isolation: true"},{"line_number":54,"context_line":"network_isolation_type: \"multiple-nics\""},{"line_number":55,"context_line":"network_isolation_args: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffe62b97_409a8d13","line":52,"in_reply_to":"ffe62b97_09985419","updated":"2017-03-30 09:38:09.000000000","message":"Done","commit_id":"da52fac5ade385407e4abf35e72453474378fc6d"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"13ce30eaa98caf423c6d342e3e635209f0d3614b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  - 8.8.8.8"},{"line_number":51,"context_line":"  - 8.8.4.4"},{"line_number":52,"context_line":"enable_pacemaker: true"},{"line_number":53,"context_line":"network_isolation: true"},{"line_number":54,"context_line":"network_isolation_type: \"multiple-nics\""},{"line_number":55,"context_line":"network_isolation_args: \u003e-"},{"line_number":56,"context_line":"  -e {{ overcloud_templates_path }}/environments/network-isolation.yaml"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffe62b97_c99dcc0a","line":53,"updated":"2017-03-29 14:45:24.000000000","message":"Same as above.","commit_id":"da52fac5ade385407e4abf35e72453474378fc6d"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"007405cad66e2187d5aa4e840dbd13dac3fb4e44","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  - 8.8.8.8"},{"line_number":51,"context_line":"  - 8.8.4.4"},{"line_number":52,"context_line":"enable_pacemaker: true"},{"line_number":53,"context_line":"network_isolation: true"},{"line_number":54,"context_line":"network_isolation_type: \"multiple-nics\""},{"line_number":55,"context_line":"network_isolation_args: \u003e-"},{"line_number":56,"context_line":"  -e {{ overcloud_templates_path }}/environments/network-isolation.yaml"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffe62b97_209d4909","line":53,"in_reply_to":"ffe62b97_c99dcc0a","updated":"2017-03-30 09:38:09.000000000","message":"Done","commit_id":"da52fac5ade385407e4abf35e72453474378fc6d"}]}