)]}'
{"toci_gate_test-oooq.sh":[{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"bb3f8b2afb82fc69d3935a29f429c952989ecbaa","unresolved":false,"context_lines":[{"line_number":72,"context_line":"# Stores OVB undercloud instance id"},{"line_number":73,"context_line":"export UCINSTANCEID\u003d\"null\""},{"line_number":74,"context_line":"# Define environment variables file"},{"line_number":75,"context_line":"export ENV_VARS\u003d\"${ENV_VARS:-}\""},{"line_number":76,"context_line":"# Define file with set of features to test"},{"line_number":77,"context_line":"export FEATURESET_FILE\u003d\"\""},{"line_number":78,"context_line":"export FEATURESET_CONF\u003d\"\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff0f0b1f_3a2c5646","line":75,"updated":"2017-05-17 15:51:11.000000000","message":"Nothing else than this script should determine the environment. This ENV_VARS should be initialized as empty.\nAlso, the only var that should be present here should be the config/testenv/ environment file, so it doesn\u0027t make sense to call it VARS","commit_id":"e51ab2841983e56aa156d2d0134b48a53a9d444c"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"6c664265d4f23aa216596f6a58d28c6c9c573d1a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"# Stores OVB undercloud instance id"},{"line_number":73,"context_line":"export UCINSTANCEID\u003d\"null\""},{"line_number":74,"context_line":"# Define environment variables file"},{"line_number":75,"context_line":"export ENV_VARS\u003d\"${ENV_VARS:-}\""},{"line_number":76,"context_line":"# Define file with set of features to test"},{"line_number":77,"context_line":"export FEATURESET_FILE\u003d\"\""},{"line_number":78,"context_line":"export FEATURESET_CONF\u003d\"\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff0f0b1f_da20bafa","line":75,"in_reply_to":"ff0f0b1f_3a2c5646","updated":"2017-05-17 16:08:08.000000000","message":"I thought about running locally this script and general attitude to have option to predefine env vars that we had in tripleo-ci bash scripts. But I agree, it\u0027s not needed here.\n\nI don\u0027t think it could be only one file, it can be more vars here.","commit_id":"e51ab2841983e56aa156d2d0134b48a53a9d444c"}],"toci_quickstart.sh":[{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"44b0cf61a28b037730b775fb52150dc0d8feb801","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    --extra-vars @$COLLECT_CONF"},{"line_number":56,"context_line":"    --tags all"},{"line_number":57,"context_line":"    $NODES_ARGS"},{"line_number":58,"context_line":"    $ENV_VARS"},{"line_number":59,"context_line":"    $FEATURESET_CONF"},{"line_number":60,"context_line":"    $EXTRA_VARS"},{"line_number":61,"context_line":"    --playbook collect-logs.yml"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff0f0b1f_ec638c19","line":58,"updated":"2017-05-19 08:43:02.000000000","message":"I see overriding featurset file as a big red flag. We have a matrix that shows what behaviour is triggered with which featureset file. if I see featureset03 in a job I expect all the feature there to be activated. No more, no less. They were created with the purpose of showing clearly what features we were going to activate, without following any  programming logic. If we need to override, we\u0027re demolishing their purpose. I don\u0027t want to chase the chain of overrides to see what\u0027s the resulting variable at the end.","commit_id":"e51ab2841983e56aa156d2d0134b48a53a9d444c"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"bb3f8b2afb82fc69d3935a29f429c952989ecbaa","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    --extra-vars @$COLLECT_CONF"},{"line_number":56,"context_line":"    --tags all"},{"line_number":57,"context_line":"    $NODES_ARGS"},{"line_number":58,"context_line":"    $ENV_VARS"},{"line_number":59,"context_line":"    $FEATURESET_CONF"},{"line_number":60,"context_line":"    $EXTRA_VARS"},{"line_number":61,"context_line":"    --playbook collect-logs.yml"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff0f0b1f_1a21924e","line":58,"updated":"2017-05-17 15:51:11.000000000","message":"If this serves the purpose you showed me, set a default in all ovb jobs to not run tempest, then let it be overridden by the featureset file, I don\u0027t think this is the right approach. If you need to override a variable from the featureset, you need another featureset file. If two jobs need a different sets of tests, the need two different featureset files. Environment variables should not override feature set files, and vice versa, they should cover two different aspects of the job. Overriding makes reproducibility difficult, and means we are doing something wrong.","commit_id":"e51ab2841983e56aa156d2d0134b48a53a9d444c"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"6c664265d4f23aa216596f6a58d28c6c9c573d1a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    --extra-vars @$COLLECT_CONF"},{"line_number":56,"context_line":"    --tags all"},{"line_number":57,"context_line":"    $NODES_ARGS"},{"line_number":58,"context_line":"    $ENV_VARS"},{"line_number":59,"context_line":"    $FEATURESET_CONF"},{"line_number":60,"context_line":"    $EXTRA_VARS"},{"line_number":61,"context_line":"    --playbook collect-logs.yml"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff0f0b1f_5ab70a88","line":58,"in_reply_to":"ff0f0b1f_1a21924e","updated":"2017-05-17 16:08:08.000000000","message":"I don\u0027t agree, there could be environment specific features, for example \"all multinode jobs should have feature x\", \"all ovb jobs should skip tempest\", etc. I want to have option to turn features on for all jobs in these specific two environments and not to set it in multiple featuresets. Other approach would be like this: https://review.openstack.org/#/c/465587/ and this is not the way I\u0027d like to see the configuration.\n\nAlso I don\u0027t understand the approach to set ovb settings before featureset and to set them after in next run - of logs playbook.","commit_id":"e51ab2841983e56aa156d2d0134b48a53a9d444c"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"add508a81f4d4e491407218792752838131318e3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    --extra-vars @$COLLECT_CONF"},{"line_number":56,"context_line":"    --tags all"},{"line_number":57,"context_line":"    $NODES_ARGS"},{"line_number":58,"context_line":"    $ENV_VARS"},{"line_number":59,"context_line":"    $FEATURESET_CONF"},{"line_number":60,"context_line":"    $EXTRA_VARS"},{"line_number":61,"context_line":"    --playbook collect-logs.yml"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff0f0b1f_dea28e4b","line":58,"in_reply_to":"ff0f0b1f_ec638c19","updated":"2017-05-20 17:14:22.000000000","message":"@Gabriele, I don\u0027t understand what are you arguing with. Featureset file in this patch exactly overrides everything so it\u0027s only file that represents the job. It\u0027s not like it behaves right now. So my fix exactly fixes it and makes featureset file the most important. Please, if something is not clear here, contact me in IRC for further discussion. This patch is blocking a new job and I still don\u0027t understand why.","commit_id":"e51ab2841983e56aa156d2d0134b48a53a9d444c"}]}
