)]}'
{"scripts/mirror-server/mirror-images.sh":[{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"9011c7c9c048170002e5234e6dd5e54016c09f93","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"RELEASE\u003d$1"},{"line_number":4,"context_line":"BUILDS\u003d\"/var/www/html/builds-${RELEASE}/current-tripleo\""},{"line_number":5,"context_line":"MIRRORURL\u003d\"https://images.rdoproject.org/${RELEASE}/delorean/current-tripleo/stable\""},{"line_number":6,"context_line":"IMAGES\u003d\"overcloud-full.tar ironic-python-agent.tar\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function check_new_image {"}],"source_content_type":"text/x-sh","patch_set":4,"id":"5f4e5783_f1180682","line":5,"updated":"2017-10-11 10:11:10.000000000","message":"This should be just\n\n    MIRRORURL\u003d\"https://images.rdoproject.org/${RELEASE}/delorean/current-tripleo\"\n\n(without /stable, we\u0027re removing that)","commit_id":"9329b8a3ebd7cfb9a06de42dc2c3505c2d463a48"}],"scripts/mirror-server/mirror-server.pp":[{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"ec15e1ef971e00b3cd2e1f6233d17a499a1597cc","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    hour  \u003d\u003e \"2\","},{"line_number":60,"context_line":"    minute  \u003d\u003e \"0\""},{"line_number":61,"context_line":"}"},{"line_number":62,"context_line":"cron {\"mirror-images\":"},{"line_number":63,"context_line":"    command \u003d\u003e \"timeout 60m /opt/stack/tripleo-ci/scripts/mirror-server/mirror-images.sh pike | tee /var/log/images_update-pike.log\","},{"line_number":64,"context_line":"    hour  \u003d\u003e \"2\","},{"line_number":65,"context_line":"    minute  \u003d\u003e \"0\""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7f515b1d_f023f7a5","line":62,"updated":"2017-10-09 13:23:26.000000000","message":"puppet resource titles must be unique per resource type, you should rename these to mirror-images-$release","commit_id":"2cc58a737b2c2ae5395233efcfd6cb6052e83d45"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"83c3f356e8def2410918ff23ffb7f2852ec1aae3","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    hour  \u003d\u003e \"2\","},{"line_number":60,"context_line":"    minute  \u003d\u003e \"0\""},{"line_number":61,"context_line":"}"},{"line_number":62,"context_line":"cron {\"mirror-images\":"},{"line_number":63,"context_line":"    command \u003d\u003e \"timeout 60m /opt/stack/tripleo-ci/scripts/mirror-server/mirror-images.sh pike | tee /var/log/images_update-pike.log\","},{"line_number":64,"context_line":"    hour  \u003d\u003e \"2\","},{"line_number":65,"context_line":"    minute  \u003d\u003e \"0\""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7f515b1d_dd7c93b7","line":62,"in_reply_to":"7f515b1d_f023f7a5","updated":"2017-10-09 14:34:39.000000000","message":"Done","commit_id":"2cc58a737b2c2ae5395233efcfd6cb6052e83d45"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"de1a46a27708acc6e16eb56b11cf659569d9439f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"}"},{"line_number":57,"context_line":"cron {\"mirror-images-master\":"},{"line_number":58,"context_line":"    command \u003d\u003e \"timeout 60m /opt/stack/tripleo-ci/scripts/mirror-server/mirror-images.sh master | tee /var/log/images_update-master.log\","},{"line_number":59,"context_line":"    hour  \u003d\u003e \"2\","},{"line_number":60,"context_line":"    minute  \u003d\u003e \"0\""},{"line_number":61,"context_line":"}"},{"line_number":62,"context_line":"cron {\"mirror-images-pike\":"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5f4e5783_dd066621","line":59,"updated":"2017-10-10 10:14:17.000000000","message":"Shouldn\u0027t we try to mirror images more often than once per day?","commit_id":"90ad38046878d5b795469fbac077daa0bd4bc3de"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2e1b8a04c7828fceefe69dba9cd64590502df277","unresolved":false,"context_lines":[{"line_number":56,"context_line":"}"},{"line_number":57,"context_line":"cron {\"mirror-images-master\":"},{"line_number":58,"context_line":"    command \u003d\u003e \"timeout 60m /opt/stack/tripleo-ci/scripts/mirror-server/mirror-images.sh master | tee /var/log/images_update-master.log\","},{"line_number":59,"context_line":"    hour  \u003d\u003e \"2\","},{"line_number":60,"context_line":"    minute  \u003d\u003e \"0\""},{"line_number":61,"context_line":"}"},{"line_number":62,"context_line":"cron {\"mirror-images-pike\":"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3f4b6375_7ce64feb","line":59,"updated":"2017-10-18 16:41:35.000000000","message":"nit: technically puppet-lint problems with the \u003d\u003e\u0027s not being lined up","commit_id":"b56e22a835fcbf88ee3e5433a10efcbcdb56595b"}],"scripts/shell-builders/rdo-infra-config/upload-cloud-images.sh":[{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"ec3c93f22fb7fa55f3dc6916704fc7dc55e0e97a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"UPLOAD_URL\u003duploader@images.rdoproject.org:/var/www/html/images/$RELEASE/delorean/tripleo-upstream"},{"line_number":14,"context_line":"mkdir $FULL_HASH"},{"line_number":15,"context_line":"mv overcloud-full.tar overcloud-full.tar.md5 $FULL_HASH"},{"line_number":16,"context_line":"mv ironic-python-agent.tar $FULL_HASH/"},{"line_number":17,"context_line":"mv ironic-python-agent.tar.md5 $FULL_HASH/"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"$rsync_cmd $FULL_HASH $UPLOAD_URL"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5f4e5783_7d32d2a9","line":16,"updated":"2017-10-10 09:53:58.000000000","message":"This is not the upload script we\u0027re using.\n\nhttps://github.com/rdo-infra/ci-config/blob/03029d4d7d7af6164e93bff2eb2c8c1205030589/ci-scripts/tripleo-upstream/upload-cloud-images.sh#L15-L16\n\nThis is the one. So if you\u0027re planning to rename the image archive, it has to be done there. Until then we\u0027re going to upload with the wrong name and this won\u0027t work.","commit_id":"90ad38046878d5b795469fbac077daa0bd4bc3de"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d85a62d3b9798beff26340720fb69074d8d6f777","unresolved":false,"context_lines":[{"line_number":13,"context_line":"UPLOAD_URL\u003duploader@images.rdoproject.org:/var/www/html/images/$RELEASE/delorean/tripleo-upstream"},{"line_number":14,"context_line":"mkdir $FULL_HASH"},{"line_number":15,"context_line":"mv overcloud-full.tar overcloud-full.tar.md5 $FULL_HASH"},{"line_number":16,"context_line":"mv ironic-python-agent.tar $FULL_HASH/"},{"line_number":17,"context_line":"mv ironic-python-agent.tar.md5 $FULL_HASH/"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"$rsync_cmd $FULL_HASH $UPLOAD_URL"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5f4e5783_ddaae617","line":16,"in_reply_to":"5f4e5783_7d32d2a9","updated":"2017-10-10 10:09:05.000000000","message":"https://review.rdoproject.org/r/#/c/10055/","commit_id":"90ad38046878d5b795469fbac077daa0bd4bc3de"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"26455d99b8cc9d3b9a9a09fe5b814b1906e2ec27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5f4e5783_ec394941","updated":"2017-10-11 10:42:40.000000000","message":"You\u0027re deleting this file in https://review.openstack.org/510828\n\nThe correct place to change is here which you already did:\n\nhttps://review.rdoproject.org/r/#/c/10055/1/ci-scripts/tripleo-upstream/upload-cloud-images.sh\n\nso this shouldn\u0027t be fixed here. You\u0027re going to have a merge conflict down the road.","commit_id":"85e855c08f26d77cd6cc026bb7351d6f5fc8cde8"}],"toci_instack_ovb.sh":[{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"ec15e1ef971e00b3cd2e1f6233d17a499a1597cc","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    if [ -f ironic-python-agent.tar ] ; then"},{"line_number":93,"context_line":"        tar -xf ironic-python-agent.tar"},{"line_number":94,"context_line":"        update_image $PWD/ironic-python-agent.initramfs"},{"line_number":95,"context_line":"        mv ironic-python-agent.* ~"},{"line_number":96,"context_line":"        rm ironic-python-agent.tar"},{"line_number":97,"context_line":"    fi"},{"line_number":98,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7f515b1d_f5476976","line":95,"updated":"2017-10-09 13:23:26.000000000","message":"this mv command will move also the .tar file, so the rm command will have no effect","commit_id":"2cc58a737b2c2ae5395233efcfd6cb6052e83d45"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"83c3f356e8def2410918ff23ffb7f2852ec1aae3","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    if [ -f ironic-python-agent.tar ] ; then"},{"line_number":93,"context_line":"        tar -xf ironic-python-agent.tar"},{"line_number":94,"context_line":"        update_image $PWD/ironic-python-agent.initramfs"},{"line_number":95,"context_line":"        mv ironic-python-agent.* ~"},{"line_number":96,"context_line":"        rm ironic-python-agent.tar"},{"line_number":97,"context_line":"    fi"},{"line_number":98,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7f515b1d_5d3783ff","line":95,"in_reply_to":"7f515b1d_f5476976","updated":"2017-10-09 14:34:39.000000000","message":"Done","commit_id":"2cc58a737b2c2ae5395233efcfd6cb6052e83d45"}]}