)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2846f0824ffbb231ca698a07837518f3607c375d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Upgrade UC and OC using tripleo-upgrade role"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: I89aeeed9ead1fb7a625634cef386645dd65f04de"},{"line_number":10,"context_line":"Change-Id: Ic0e8dcf22444ece6fa5f9459f6aec3b2c0f08c80"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"7f96bb07_b5034b42","line":9,"updated":"2018-01-23 20:00:30.000000000","message":"Please mention https://blueprints.launchpad.net/tripleo/+spec/tripleo-upgrade","commit_id":"4c454923fff958f5f8c00c13a034075c630e4fb8"}],"toci-quickstart/playbooks/multinode-overcloud-upgrade.yml":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"9bd26c6979f8f472349355f39a464fc1d63f936d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      # Avoid running yum update, only set up repos"},{"line_number":13,"context_line":"      repo_cmd_after: \"yum clean metadata\""},{"line_number":14,"context_line":"      when: containerized_overcloud_upgrade|bool"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Upgrade TripleO"},{"line_number":17,"context_line":"  hosts: undercloud"},{"line_number":18,"context_line":"  gather_facts: yes"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"5f93b717_781a3817","line":15,"updated":"2018-02-01 11:08:07.000000000","message":"Use overcloud-prep-containers, default setting should be ok.","commit_id":"6f54815c4481de3124fbf0164333e2437d927c33"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"ccf1303f0ccf2d58361d81d9fa26aedbdc376bd8","unresolved":false,"context_lines":[{"line_number":42,"context_line":"         virtualenv: local_working_dir"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    - name: Run Tripleo-upgrade role"},{"line_number":45,"context_line":"      vars:"},{"line_number":46,"context_line":"        tht_directory: \"{{ overcloud_templates_path }}\""},{"line_number":47,"context_line":"        upstream_container_images: \u0027true\u0027"},{"line_number":48,"context_line":"        create_container_images_download_script: \u0027false\u0027"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"5f93b717_74da5c4b","line":45,"updated":"2018-01-31 16:58:09.000000000","message":"Far safety maybe we should add:\n\ncontainerized_overcloud_upgrade: false\n\nto those.","commit_id":"6f54815c4481de3124fbf0164333e2437d927c33"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"76d251c5feb002380521c64e9a224e9ecefcdfa7","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    - name: Run Tripleo-upgrade role"},{"line_number":45,"context_line":"      vars:"},{"line_number":46,"context_line":"        tht_directory: \"{{ overcloud_templates_path }}\""},{"line_number":47,"context_line":"        upstream_container_images: \u0027true\u0027"},{"line_number":48,"context_line":"        create_container_images_download_script: \u0027false\u0027"},{"line_number":49,"context_line":"        container_images_download_script: \u0027{{ working_dir }}/overcloud-prep-containers.sh\u0027"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"5f93b717_74e49ce0","line":46,"updated":"2018-01-31 17:13:17.000000000","message":"To imprvoe re-use and maybe we could do that:\n\n  upstream_container_images: {{upstream_container_images|default(\u0027true\u0027)\n\nand so on ... so that the user can override it from the feautureset if needed.","commit_id":"6f54815c4481de3124fbf0164333e2437d927c33"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"ccf1303f0ccf2d58361d81d9fa26aedbdc376bd8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        create_docker_registry: \u0027false\u0027"},{"line_number":53,"context_line":"        tripleo_ci: \u0027true\u0027"},{"line_number":54,"context_line":"        use_oooq: \u0027true\u0027"},{"line_number":55,"context_line":"        undercloud_upgrade: \u0027false\u0027"},{"line_number":56,"context_line":"        overcloud_upgrade: \u0027true\u0027"},{"line_number":57,"context_line":"      include_role:"},{"line_number":58,"context_line":"        name: tripleo-upgrade"},{"line_number":59,"context_line":"      when: containerized_overcloud_upgrade|bool"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"5f93b717_34237458","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":33},"updated":"2018-01-31 16:58:09.000000000","message":"All the other variable are kind of mandatory, but maybe we can move those two to the featureset so that we can re-use code for ffu/update/undercloud upgrade and so on, wdyt?","commit_id":"6f54815c4481de3124fbf0164333e2437d927c33"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"76d251c5feb002380521c64e9a224e9ecefcdfa7","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        overcloud_upgrade: \u0027true\u0027"},{"line_number":57,"context_line":"      include_role:"},{"line_number":58,"context_line":"        name: tripleo-upgrade"},{"line_number":59,"context_line":"      when: containerized_overcloud_upgrade|bool"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"5f93b717_f4a8ac20","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":48},"updated":"2018-01-31 17:13:17.000000000","message":"Do we want to keep that one or use a new one and set this one to false, so that we can keep the both of them in // ?","commit_id":"6f54815c4481de3124fbf0164333e2437d927c33"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"fe0c230685e8573d312ac8239f0abca08f258eac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Set up repos on subnodes for upgrading"},{"line_number":2,"context_line":"  hosts: overcloud"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    ib_repo_host: undercloud"},{"line_number":5,"context_line":"  roles:"},{"line_number":6,"context_line":"    - role: repo-setup"},{"line_number":7,"context_line":"      when: mixed_upgrade|default(false)|bool"},{"line_number":8,"context_line":"    - role: install-built-repo"},{"line_number":9,"context_line":"      when: hostvars[\u0027undercloud\u0027][\u0027compressed_gating_repo\u0027] is defined and mixed_upgrade|default(false)|bool"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name:  Upgrade Tripleo"},{"line_number":12,"context_line":"  hosts: undercloud"},{"line_number":13,"context_line":"  tags:"},{"line_number":14,"context_line":"    - overcloud-upgrade"},{"line_number":15,"context_line":"  gather_facts: no"},{"line_number":16,"context_line":"  roles:"},{"line_number":17,"context_line":"    - role: overcloud-upgrade"},{"line_number":18,"context_line":"      when: containerized_overcloud_upgrade|bool"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"5f93b717_9370470a","side":"PARENT","line":17,"range":{"start_line":1,"start_character":1,"end_line":17,"end_character":29},"updated":"2018-02-01 11:58:05.000000000","message":"We should keep them with a relevant conditional so that we keep \"backward\" compatibility.","commit_id":"b1b027e4b8d5c72c59d4013ba76aec216be44ab3"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"fe0c230685e8573d312ac8239f0abca08f258eac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Prepare for containerized deployment"},{"line_number":2,"context_line":"  hosts: undercloud"},{"line_number":3,"context_line":"  gather_facts: no"},{"line_number":4,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"5f93b717_337cd3ea","line":1,"range":{"start_line":1,"start_character":8,"end_line":1,"end_character":43},"updated":"2018-02-01 11:58:05.000000000","message":"\"Upgrade containers\"\n\njust change the name so that doesn\u0027t duplicate the other tasks (for readability)","commit_id":"91cb30257eb4bda605fd0d7b78c2fc8bc2c92782"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"2c335ed888206f62ec42011a8c8c8f7ec8782558","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  roles:"},{"line_number":20,"context_line":"    - role: repo-setup"},{"line_number":21,"context_line":"      # Avoid running yum update, only set up repos"},{"line_number":22,"context_line":"      repo_setup_for_upgrade: true"},{"line_number":23,"context_line":"      when: containerized_overcloud_upgrade|bool"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Upgrade TripleO"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"5f93b717_3c7484ce","line":22,"updated":"2018-02-02 13:29:42.000000000","message":"We can maybe add it into vars section now, right?","commit_id":"502d4071f9501b8062e4dd35e2ba484b83129443"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"5526f76e850c528bd85a27072794d61fab4c21f6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  roles:"},{"line_number":20,"context_line":"    - role: repo-setup"},{"line_number":21,"context_line":"      # Avoid running yum update, only set up repos"},{"line_number":22,"context_line":"      repo_setup_for_upgrade: true"},{"line_number":23,"context_line":"      when: containerized_overcloud_upgrade|bool"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Upgrade TripleO"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"5f93b717_fa405ba7","line":22,"in_reply_to":"5f93b717_3c7484ce","updated":"2018-02-02 15:15:26.000000000","message":"well, not sure how it matters, as far as var precedence are concerned.  Your choice.","commit_id":"502d4071f9501b8062e4dd35e2ba484b83129443"}]}
