)]}'
{"playbooks/tripleo-ci/templates/toci_gate_test.sh.j2":[{"author":{"_account_id":27898,"name":"Quique Llorente","email":"ellorent@redhat.com","username":"quiquell"},"change_message_id":"8224516eb99a309871544e5266d98595b35d035a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"export FEATURESET\u003d{{ featureset | default(\u0027\u0027) }}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"#TODO(rfolco): Translate featureset logic in native ansible task"},{"line_number":100,"context_line":"if [ -n \"${FEATURESET}\" ]; then"},{"line_number":101,"context_line":"    FEATURESET_FILE\u003d\"$LWD/config/general_config/featureset${FEATURESET}.yml\""},{"line_number":102,"context_line":"    FEATURESET_CONF\u003d\"$FEATURESET_CONF --extra-vars @$FEATURESET_FILE\""},{"line_number":103,"context_line":"    MIXED_UPGRADE_TYPE\u003d\u0027\u0027"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5f7c97a3_7596dff1","line":100,"updated":"2018-07-18 08:42:51.000000000","message":"We can set an ansible conditional here, to check if featureset is set, so we can remove the  previous export.\n\n{% if featureset is defined %}\n...\n{% endif %}","commit_id":"a87974e18d6370c1196315445c4ae40415818acc"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"2d0f501331cdc639e19926283d11a34c8eef948d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"export FEATURESET\u003d{{ featureset | default(\u0027\u0027) }}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"#TODO(rfolco): Translate featureset logic in native ansible task"},{"line_number":100,"context_line":"if [ -n \"${FEATURESET}\" ]; then"},{"line_number":101,"context_line":"    FEATURESET_FILE\u003d\"$LWD/config/general_config/featureset${FEATURESET}.yml\""},{"line_number":102,"context_line":"    FEATURESET_CONF\u003d\"$FEATURESET_CONF --extra-vars @$FEATURESET_FILE\""},{"line_number":103,"context_line":"    MIXED_UPGRADE_TYPE\u003d\u0027\u0027"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5f7c97a3_ba91bbf9","line":100,"in_reply_to":"5f7c97a3_7596dff1","updated":"2018-07-18 17:43:20.000000000","message":"done","commit_id":"a87974e18d6370c1196315445c4ae40415818acc"},{"author":{"_account_id":27898,"name":"Quique Llorente","email":"ellorent@redhat.com","username":"quiquell"},"change_message_id":"8224516eb99a309871544e5266d98595b35d035a","unresolved":false,"context_lines":[{"line_number":125,"context_line":"# Assemble quickstart configuration based on job type keywords"},{"line_number":126,"context_line":"for JOB_TYPE_PART in $(sed \u0027s/-/ /g\u0027 \u003c\u003c\u003c \"${TOCI_JOBTYPE:-}\") ; do"},{"line_number":127,"context_line":"    case $JOB_TYPE_PART in"},{"line_number":128,"context_line":"       featureset*)"},{"line_number":129,"context_line":"       ;;"},{"line_number":130,"context_line":"       ovb)"},{"line_number":131,"context_line":"            OVB\u003d1"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5f7c97a3_b58797b3","line":128,"updated":"2018-07-18 08:42:51.000000000","message":"We cannot remove this ?","commit_id":"a87974e18d6370c1196315445c4ae40415818acc"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"2d0f501331cdc639e19926283d11a34c8eef948d","unresolved":false,"context_lines":[{"line_number":125,"context_line":"# Assemble quickstart configuration based on job type keywords"},{"line_number":126,"context_line":"for JOB_TYPE_PART in $(sed \u0027s/-/ /g\u0027 \u003c\u003c\u003c \"${TOCI_JOBTYPE:-}\") ; do"},{"line_number":127,"context_line":"    case $JOB_TYPE_PART in"},{"line_number":128,"context_line":"       featureset*)"},{"line_number":129,"context_line":"       ;;"},{"line_number":130,"context_line":"       ovb)"},{"line_number":131,"context_line":"            OVB\u003d1"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5f7c97a3_9a6abfe9","line":128,"in_reply_to":"5f7c97a3_b58797b3","updated":"2018-07-18 17:43:20.000000000","message":"Not here in this patch. This is removed in the follow-up patches when the case loop is gone. Still needed as *) defines the nodes file for anything that is not previously handled by the TOCI_JOBTYPE case loop. Until the case loop mixes different variables in the same TOCI_JOBTYPE string, we keep it here.","commit_id":"a87974e18d6370c1196315445c4ae40415818acc"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"9f1e907c358259a7b24aabca1e48ce17dc6aff70","unresolved":false,"context_lines":[{"line_number":94,"context_line":"export RELEASES_SCRIPT\u003d$TRIPLEO_ROOT/tripleo-ci/scripts/emit_releases_file/emit_releases_file.py"},{"line_number":95,"context_line":"export RELEASES_SCRIPT_LOGFILE\u003d$WORKSPACE/logs/emit_releases_file.log"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"{% if featureset is defined %}"},{"line_number":98,"context_line":"FEATURESET_FILE\u003d\"$LWD/config/general_config/featureset{{ featureset }}.yml\""},{"line_number":99,"context_line":"FEATURESET_CONF\u003d\"$FEATURESET_CONF --extra-vars @$FEATURESET_FILE\""},{"line_number":100,"context_line":"MIXED_UPGRADE_TYPE\u003d\u0027\u0027"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"5f7c97a3_32357044","line":97,"updated":"2018-07-23 14:27:25.000000000","message":"we always define at least the featureset","commit_id":"ddc474be96fd9fb9d0b5a8cef884ea008f8b2a6e"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"693ae3050d4a77ff3c11456d049c7a21c54d561d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"export RELEASES_SCRIPT\u003d$TRIPLEO_ROOT/tripleo-ci/scripts/emit_releases_file/emit_releases_file.py"},{"line_number":95,"context_line":"export RELEASES_SCRIPT_LOGFILE\u003d$WORKSPACE/logs/emit_releases_file.log"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"{% if featureset is defined %}"},{"line_number":98,"context_line":"FEATURESET_FILE\u003d\"$LWD/config/general_config/featureset{{ featureset }}.yml\""},{"line_number":99,"context_line":"FEATURESET_CONF\u003d\"$FEATURESET_CONF --extra-vars @$FEATURESET_FILE\""},{"line_number":100,"context_line":"MIXED_UPGRADE_TYPE\u003d\u0027\u0027"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"5f7c97a3_0ca5b448","line":97,"in_reply_to":"5f7c97a3_32357044","updated":"2018-07-23 16:09:29.000000000","message":"ack to address in a separate change","commit_id":"ddc474be96fd9fb9d0b5a8cef884ea008f8b2a6e"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"0e49e63a22c4b866f9416bbb24ee7e3ad80d6099","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"{% if featureset is defined %}"},{"line_number":98,"context_line":"FEATURESET_FILE\u003d\"$LWD/config/general_config/featureset{{ featureset }}.yml\""},{"line_number":99,"context_line":"FEATURESET_CONF\u003d\"$FEATURESET_CONF --extra-vars @$FEATURESET_FILE\""},{"line_number":100,"context_line":"MIXED_UPGRADE_TYPE\u003d\u0027\u0027"},{"line_number":101,"context_line":"# Order matters.  ffu featureset has both mixed version and ffu_overcloud_upgrade."},{"line_number":102,"context_line":"if is_featureset ffu_overcloud_upgrade \"$TRIPLEO_ROOT/tripleo-quickstart/config/general_config/featureset{{ featureset }}.yml\"; then"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"5f7c97a3_f24ff889","line":99,"updated":"2018-07-23 14:39:05.000000000","message":"FEATURESET_CONF was put here to account for the multinode common file in the loop. It\u0027s ok to have it here. multinode common will correctly be set the featureset conf","commit_id":"ddc474be96fd9fb9d0b5a8cef884ea008f8b2a6e"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"693ae3050d4a77ff3c11456d049c7a21c54d561d","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"{% if featureset is defined %}"},{"line_number":98,"context_line":"FEATURESET_FILE\u003d\"$LWD/config/general_config/featureset{{ featureset }}.yml\""},{"line_number":99,"context_line":"FEATURESET_CONF\u003d\"$FEATURESET_CONF --extra-vars @$FEATURESET_FILE\""},{"line_number":100,"context_line":"MIXED_UPGRADE_TYPE\u003d\u0027\u0027"},{"line_number":101,"context_line":"# Order matters.  ffu featureset has both mixed version and ffu_overcloud_upgrade."},{"line_number":102,"context_line":"if is_featureset ffu_overcloud_upgrade \"$TRIPLEO_ROOT/tripleo-quickstart/config/general_config/featureset{{ featureset }}.yml\"; then"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"5f7c97a3_2c50b02c","line":99,"in_reply_to":"5f7c97a3_f24ff889","updated":"2018-07-23 16:09:29.000000000","message":"keeping bash stuff here to make conservative changes. The remaining code/vars in bash will be converted to equivalent ansible.","commit_id":"ddc474be96fd9fb9d0b5a8cef884ea008f8b2a6e"}]}