)]}'
{".gitreview":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8ca73f7d42e175bd30feb964bd1d493d61cf6969","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[gerrit]"},{"line_number":2,"context_line":"host\u003dreview.opendev.org"},{"line_number":3,"context_line":"port\u003d29418"},{"line_number":4,"context_line":"project\u003dopenstack/tripleo-ci.git"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"ffb9cba7_1f96bb94","line":4,"updated":"2019-04-30 03:06:04.000000000","message":"this should be done in a separated patch.","commit_id":"6acb70068af816c7630766de6f26a06de8279338"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"14d922b68491953decee6e9593e56c4e43fa9abd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[gerrit]"},{"line_number":2,"context_line":"host\u003dreview.opendev.org"},{"line_number":3,"context_line":"port\u003d29418"},{"line_number":4,"context_line":"project\u003dopenstack/tripleo-ci.git"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"ffb9cba7_e0f9bfc7","line":4,"in_reply_to":"ffb9cba7_1f96bb94","updated":"2019-04-30 14:04:07.000000000","message":"this is already done\nhttps://github.com/openstack/tripleo-ci/blob/master/.gitreview#L2","commit_id":"6acb70068af816c7630766de6f26a06de8279338"}],"roles/build-containers/tasks/main.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8ca73f7d42e175bd30feb964bd1d493d61cf6969","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    skopeo inspect --tls-verify\u003dFalse \\"},{"line_number":110,"context_line":"      docker://{{ push_registry }}/tripleo{{ ci_branch }}/{{ item.imagename }}:{{ version_hash }} \\"},{"line_number":111,"context_line":"      2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e {{ workspace }}/inspect.log"},{"line_number":112,"context_line":"  with_items: \"{{ container_images }}\""},{"line_number":113,"context_line":"  register: inspect"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"- name: podman pull"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ffb9cba7_9fef0b1d","line":112,"updated":"2019-04-30 03:06:04.000000000","message":"This task doesn\u0027t scale. It\u0027s going to run skopeo commands for each container that we want to inspect.\n\nOn a side node, I would also investigate the inspect on the registry itself. Take a look at https://github.com/containers/skopeo#inspecting-a-repository for more infos.","commit_id":"6acb70068af816c7630766de6f26a06de8279338"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"14d922b68491953decee6e9593e56c4e43fa9abd","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    skopeo inspect --tls-verify\u003dFalse \\"},{"line_number":110,"context_line":"      docker://{{ push_registry }}/tripleo{{ ci_branch }}/{{ item.imagename }}:{{ version_hash }} \\"},{"line_number":111,"context_line":"      2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e {{ workspace }}/inspect.log"},{"line_number":112,"context_line":"  with_items: \"{{ container_images }}\""},{"line_number":113,"context_line":"  register: inspect"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"- name: podman pull"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ffb9cba7_40df6b39","line":112,"in_reply_to":"ffb9cba7_9fef0b1d","updated":"2019-04-30 14:04:07.000000000","message":"What if we just inspect a subset of the containers to make sure they are ok? This job is running in ~1h, we can make it shorter though. \n\nI am inspecting the local registry. If the suggestion is to push to a remote/test registry in rdotrunk (separate from RDO official one), might be closer to what we have in rdo registry.","commit_id":"6acb70068af816c7630766de6f26a06de8279338"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8ca73f7d42e175bd30feb964bd1d493d61cf6969","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    chdir: \u0027{{ workspace }}\u0027"},{"line_number":118,"context_line":"  shell: |"},{"line_number":119,"context_line":"    set -x"},{"line_number":120,"context_line":"    podman --log-level\u003ddebug pull --tls-verify\u003dFalse \\"},{"line_number":121,"context_line":"      {{ push_registry }}/tripleo{{ ci_branch }}/{{ item.imagename }}:{{ version_hash }} \\"},{"line_number":122,"context_line":"      2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e {{ workspace }}/pull.log"},{"line_number":123,"context_line":"  with_items: \"{{ container_images }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ffb9cba7_ffdde76f","line":120,"updated":"2019-04-30 03:06:04.000000000","message":"I don\u0027t get why you want to pull them if we built them before. What are we testing here? It\u0027s just adding more time to the tasks.","commit_id":"6acb70068af816c7630766de6f26a06de8279338"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"14d922b68491953decee6e9593e56c4e43fa9abd","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    chdir: \u0027{{ workspace }}\u0027"},{"line_number":118,"context_line":"  shell: |"},{"line_number":119,"context_line":"    set -x"},{"line_number":120,"context_line":"    podman --log-level\u003ddebug pull --tls-verify\u003dFalse \\"},{"line_number":121,"context_line":"      {{ push_registry }}/tripleo{{ ci_branch }}/{{ item.imagename }}:{{ version_hash }} \\"},{"line_number":122,"context_line":"      2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e {{ workspace }}/pull.log"},{"line_number":123,"context_line":"  with_items: \"{{ container_images }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ffb9cba7_00cf3356","line":120,"in_reply_to":"ffb9cba7_ffdde76f","updated":"2019-04-30 14:04:07.000000000","message":"The idea is to exercise the whole cycle: build-\u003epush-\u003einspect-\u003epull. This would reveal issues with the pushed containers that just will are seen when you try to pull them.\nPerhaps I need to disable cache to force downloading from remote registry ?","commit_id":"6acb70068af816c7630766de6f26a06de8279338"}],"roles/build-containers/vars/check-containers.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8ca73f7d42e175bd30feb964bd1d493d61cf6969","unresolved":false,"context_lines":[{"line_number":1,"context_line":"container_images:"},{"line_number":2,"context_line":"- imagename: centos-binary-aodh-api"},{"line_number":3,"context_line":"  image_source: kolla"},{"line_number":4,"context_line":"- imagename: centos-binary-aodh-evaluator"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ffb9cba7_dfe02329","line":1,"updated":"2019-04-30 03:06:04.000000000","message":"This file doesn\u0027t scale and we shouldn\u0027t hardcode our container list more than we already do in tripleo-common.","commit_id":"6acb70068af816c7630766de6f26a06de8279338"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"14d922b68491953decee6e9593e56c4e43fa9abd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"container_images:"},{"line_number":2,"context_line":"- imagename: centos-binary-aodh-api"},{"line_number":3,"context_line":"  image_source: kolla"},{"line_number":4,"context_line":"- imagename: centos-binary-aodh-evaluator"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ffb9cba7_2032775f","line":1,"in_reply_to":"ffb9cba7_dfe02329","updated":"2019-04-30 14:04:07.000000000","message":"Yep this is a placeholder for the overcloud containers WITHOUT docker.io registry in the image name...\nhttps://github.com/openstack/tripleo-common/blob/master/container-images/overcloud_containers.yaml\nReusing from tripleo-common would be ideal, but would require replacing docker.io from all image names I think.","commit_id":"6acb70068af816c7630766de6f26a06de8279338"}],"zuul.d/build-containers.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"2d0e7ee74941f381716c5b3cf87a0beafeaec158","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# zuul.d/build-containers.yaml"},{"line_number":3,"context_line":"# Zuul layout for TripleO Build Containers jobs."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- project-template:"},{"line_number":6,"context_line":"    name: tripleo-build-containers-jobs"},{"line_number":7,"context_line":"    check:"},{"line_number":8,"context_line":"      jobs:"},{"line_number":9,"context_line":"        - tripleo-build-containers-centos-7"},{"line_number":10,"context_line":"        - tripleo-build-containers-centos-7-stein"},{"line_number":11,"context_line":"        - tripleo-build-containers-centos-7-rocky"},{"line_number":12,"context_line":"        - tripleo-build-containers-centos-7-buildah"},{"line_number":13,"context_line":"        - tripleo-build-containers-centos-7-buildah-stein"},{"line_number":14,"context_line":"    gate:"},{"line_number":15,"context_line":"      queue: tripleo"},{"line_number":16,"context_line":"      jobs:"},{"line_number":17,"context_line":"        - tripleo-build-containers-centos-7"},{"line_number":18,"context_line":"        - tripleo-build-containers-centos-7-stein"},{"line_number":19,"context_line":"        - tripleo-build-containers-centos-7-rocky"},{"line_number":20,"context_line":"        - tripleo-build-containers-centos-7-buildah"},{"line_number":21,"context_line":"        - tripleo-build-containers-centos-7-buildah-stein"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- job:"},{"line_number":24,"context_line":"    name: tripleo-build-containers-centos-7"},{"line_number":25,"context_line":"    parent: tripleo-build-containers-base-with-files"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fce034c_10761d08","line":22,"range":{"start_line":5,"start_character":2,"end_line":22,"end_character":0},"updated":"2019-04-12 18:26:03.000000000","message":"Job tripleo-build-containers-centos-7-buildah not defined","commit_id":"c824e9d4e9d8ff344da8d71708545eb1f0c83f57"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"2d0e7ee74941f381716c5b3cf87a0beafeaec158","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# zuul.d/build-containers.yaml"},{"line_number":3,"context_line":"# Zuul layout for TripleO Build Containers jobs."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- project-template:"},{"line_number":6,"context_line":"    name: tripleo-build-containers-jobs"},{"line_number":7,"context_line":"    check:"},{"line_number":8,"context_line":"      jobs:"},{"line_number":9,"context_line":"        - tripleo-build-containers-centos-7"},{"line_number":10,"context_line":"        - tripleo-build-containers-centos-7-stein"},{"line_number":11,"context_line":"        - tripleo-build-containers-centos-7-rocky"},{"line_number":12,"context_line":"        - tripleo-build-containers-centos-7-buildah"},{"line_number":13,"context_line":"        - tripleo-build-containers-centos-7-buildah-stein"},{"line_number":14,"context_line":"    gate:"},{"line_number":15,"context_line":"      queue: tripleo"},{"line_number":16,"context_line":"      jobs:"},{"line_number":17,"context_line":"        - tripleo-build-containers-centos-7"},{"line_number":18,"context_line":"        - tripleo-build-containers-centos-7-stein"},{"line_number":19,"context_line":"        - tripleo-build-containers-centos-7-rocky"},{"line_number":20,"context_line":"        - tripleo-build-containers-centos-7-buildah"},{"line_number":21,"context_line":"        - tripleo-build-containers-centos-7-buildah-stein"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- job:"},{"line_number":24,"context_line":"    name: tripleo-build-containers-centos-7"},{"line_number":25,"context_line":"    parent: tripleo-build-containers-base-with-files"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fce034c_506ca535","line":22,"range":{"start_line":5,"start_character":2,"end_line":22,"end_character":0},"updated":"2019-04-12 18:26:03.000000000","message":"Job tripleo-build-containers-centos-7-buildah not defined","commit_id":"c824e9d4e9d8ff344da8d71708545eb1f0c83f57"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"2d0e7ee74941f381716c5b3cf87a0beafeaec158","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# zuul.d/build-containers.yaml"},{"line_number":3,"context_line":"# Zuul layout for TripleO Build Containers jobs."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- project-template:"},{"line_number":6,"context_line":"    name: tripleo-build-containers-jobs"},{"line_number":7,"context_line":"    check:"},{"line_number":8,"context_line":"      jobs:"},{"line_number":9,"context_line":"        - tripleo-build-containers-centos-7"},{"line_number":10,"context_line":"        - tripleo-build-containers-centos-7-stein"},{"line_number":11,"context_line":"        - tripleo-build-containers-centos-7-rocky"},{"line_number":12,"context_line":"        - tripleo-build-containers-centos-7-buildah"},{"line_number":13,"context_line":"        - tripleo-build-containers-centos-7-buildah-stein"},{"line_number":14,"context_line":"    gate:"},{"line_number":15,"context_line":"      queue: tripleo"},{"line_number":16,"context_line":"      jobs:"},{"line_number":17,"context_line":"        - tripleo-build-containers-centos-7"},{"line_number":18,"context_line":"        - tripleo-build-containers-centos-7-stein"},{"line_number":19,"context_line":"        - tripleo-build-containers-centos-7-rocky"},{"line_number":20,"context_line":"        - tripleo-build-containers-centos-7-buildah"},{"line_number":21,"context_line":"        - tripleo-build-containers-centos-7-buildah-stein"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- job:"},{"line_number":24,"context_line":"    name: tripleo-build-containers-centos-7"},{"line_number":25,"context_line":"    parent: tripleo-build-containers-base-with-files"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fce034c_7069a123","line":22,"range":{"start_line":5,"start_character":2,"end_line":22,"end_character":0},"updated":"2019-04-12 18:26:03.000000000","message":"Job tripleo-build-containers-centos-7-buildah not defined","commit_id":"c824e9d4e9d8ff344da8d71708545eb1f0c83f57"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"2d0e7ee74941f381716c5b3cf87a0beafeaec158","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# zuul.d/build-containers.yaml"},{"line_number":3,"context_line":"# Zuul layout for TripleO Build Containers jobs."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- project-template:"},{"line_number":6,"context_line":"    name: tripleo-build-containers-jobs"},{"line_number":7,"context_line":"    check:"},{"line_number":8,"context_line":"      jobs:"},{"line_number":9,"context_line":"        - tripleo-build-containers-centos-7"},{"line_number":10,"context_line":"        - tripleo-build-containers-centos-7-stein"},{"line_number":11,"context_line":"        - tripleo-build-containers-centos-7-rocky"},{"line_number":12,"context_line":"        - tripleo-build-containers-centos-7-buildah"},{"line_number":13,"context_line":"        - tripleo-build-containers-centos-7-buildah-stein"},{"line_number":14,"context_line":"    gate:"},{"line_number":15,"context_line":"      queue: tripleo"},{"line_number":16,"context_line":"      jobs:"},{"line_number":17,"context_line":"        - tripleo-build-containers-centos-7"},{"line_number":18,"context_line":"        - tripleo-build-containers-centos-7-stein"},{"line_number":19,"context_line":"        - tripleo-build-containers-centos-7-rocky"},{"line_number":20,"context_line":"        - tripleo-build-containers-centos-7-buildah"},{"line_number":21,"context_line":"        - tripleo-build-containers-centos-7-buildah-stein"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- job:"},{"line_number":24,"context_line":"    name: tripleo-build-containers-centos-7"},{"line_number":25,"context_line":"    parent: tripleo-build-containers-base-with-files"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fce034c_b08709d8","line":22,"range":{"start_line":5,"start_character":2,"end_line":22,"end_character":0},"updated":"2019-04-12 18:26:03.000000000","message":"Job tripleo-build-containers-centos-7-buildah not defined","commit_id":"c824e9d4e9d8ff344da8d71708545eb1f0c83f57"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"2d0e7ee74941f381716c5b3cf87a0beafeaec158","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    vars:"},{"line_number":42,"context_line":"      branch_override: stable/rocky"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- job:"},{"line_number":45,"context_line":"    name: tripleo-build-containers-centos-7-buildah"},{"line_number":46,"context_line":"    description: |"},{"line_number":47,"context_line":"      container build job (buildah cli/backend)"},{"line_number":48,"context_line":"    parent: tripleo-build-containers-centos-7"},{"line_number":49,"context_line":"    push_containers: true"},{"line_number":50,"context_line":"    vars:"},{"line_number":51,"context_line":"      use_buildah: true"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- job:"},{"line_number":54,"context_line":"    name: tripleo-build-containers-centos-7-buildah-stein"},{"line_number":55,"context_line":"    parent: tripleo-build-containers-centos-7-buildah"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fce034c_f07d91e7","line":52,"range":{"start_line":44,"start_character":2,"end_line":52,"end_character":0},"updated":"2019-04-12 18:26:03.000000000","message":"extra keys not allowed @ data[\u0027push_containers\u0027]","commit_id":"c824e9d4e9d8ff344da8d71708545eb1f0c83f57"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"2d0e7ee74941f381716c5b3cf87a0beafeaec158","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    vars:"},{"line_number":51,"context_line":"      use_buildah: true"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- job:"},{"line_number":54,"context_line":"    name: tripleo-build-containers-centos-7-buildah-stein"},{"line_number":55,"context_line":"    parent: tripleo-build-containers-centos-7-buildah"},{"line_number":56,"context_line":"    override-checkout: stable/stein"},{"line_number":57,"context_line":"    vars:"},{"line_number":58,"context_line":"      branch_override: stable/stein"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fce034c_90820dc8","line":58,"range":{"start_line":53,"start_character":2,"end_line":58,"end_character":0},"updated":"2019-04-12 18:26:03.000000000","message":"Job tripleo-build-containers-centos-7-buildah not defined","commit_id":"c824e9d4e9d8ff344da8d71708545eb1f0c83f57"}],"zuul.d/layout.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"d0f411869c0ae11fb316f159926e63db7ede9625","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# It describes the jobs that will run when submitting a change in this"},{"line_number":5,"context_line":"# repository."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- project:"},{"line_number":8,"context_line":"    check:"},{"line_number":9,"context_line":"      jobs:"},{"line_number":10,"context_line":"        - tripleo-build-containers-centos-7-buildah"},{"line_number":11,"context_line":"        - tripleo-build-containers-centos-7-buildah-stein"},{"line_number":12,"context_line":"        - openstack-tox-linters"},{"line_number":13,"context_line":"        - openstack-tox-py27: \u0026files"},{"line_number":14,"context_line":"            success-url: \"tox/reports.html\""},{"line_number":15,"context_line":"            failure-url: \"tox/reports.html\""},{"line_number":16,"context_line":"            files:"},{"line_number":17,"context_line":"              - ^bindep.txt$"},{"line_number":18,"context_line":"              - ^requirements.txt$"},{"line_number":19,"context_line":"              - ^scripts/emit_releases_file/.*$"},{"line_number":20,"context_line":"              - ^setup.cfg$"},{"line_number":21,"context_line":"              - ^setup.py$"},{"line_number":22,"context_line":"              - ^tox.ini$"},{"line_number":23,"context_line":"        - openstack-tox-py35:"},{"line_number":24,"context_line":"            \u003c\u003c: *files"},{"line_number":25,"context_line":"    gate:"},{"line_number":26,"context_line":"      queue: tripleo"},{"line_number":27,"context_line":"      jobs:"},{"line_number":28,"context_line":"        # Don\u0027t put a files section on the linters job, otherwise no"},{"line_number":29,"context_line":"        # jobs might be defined and nothing can merge in this repo."},{"line_number":30,"context_line":"        - openstack-tox-linters"},{"line_number":31,"context_line":"        - openstack-tox-py27:"},{"line_number":32,"context_line":"            files:"},{"line_number":33,"context_line":"              - ^scripts/emit_releases_file/.*$"},{"line_number":34,"context_line":"        - openstack-tox-py35:"},{"line_number":35,"context_line":"            files:"},{"line_number":36,"context_line":"              - ^scripts/emit_releases_file/.*$"},{"line_number":37,"context_line":"        - openstack-tox-pep8:"},{"line_number":38,"context_line":"            files:"},{"line_number":39,"context_line":"              - ^scripts/emit_releases_file/.*$"},{"line_number":40,"context_line":"        - tripleo-buildimage-overcloud-full-centos-7:"},{"line_number":41,"context_line":"            files:"},{"line_number":42,"context_line":"              - ^playbooks/tripleo-buildimage/.*$"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fce034c_62de626e","line":42,"range":{"start_line":7,"start_character":2,"end_line":42,"end_character":0},"updated":"2019-04-17 20:20:51.000000000","message":"Job tripleo-build-containers-centos-7-buildah-stein not defined","commit_id":"bb3735addec4ecf5c01d4ec6a462a1e34051b33f"}]}