)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f6f5116310659504e17d38d22b5799f1802defc9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"arch_tag, of the format \u0027_{{ansible_architecture}}\u0027 to the tag of the images"},{"line_number":12,"context_line":"when ansible_architecture is not x86_64. Upon promotion, the arch_tag should"},{"line_number":13,"context_line":"be removed from the tag, a manifest should be created, and the images should"},{"line_number":14,"context_line":"be uploaded to dockerhub."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I537f577c8946ffeeed989a7c686ff85fef96a3f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_513ad1cb","line":14,"updated":"2019-06-12 07:00:18.000000000","message":"wondering are we tracking this effort somewhere ... if nothing else maybe we can just file a LP bug with a description and we can comment there as discussions are had/direction changes whatever.","commit_id":"1c38733f4ec55bc228a8951b466e1ca49a16a74c"}],"roles/build-containers/tasks/main.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5e1525194ae7ce42092e66de1fc086ab2cf726e7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    version_hash: \"{{ baseurl.stdout.split(\u0027/\u0027)[-1] }}\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: Set arch_tag fact"},{"line_number":39,"context_line":"  set_fact:"},{"line_number":40,"context_line":"    arch_tag: \"{{ \u0027_\u0027 + ansible_architecture if ansible_architecture !\u003d \u0027x86_64\u0027 else \u0027\u0027}}\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: grab kolla patch if needed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_f661a9aa","line":39,"updated":"2019-06-10 07:02:52.000000000","message":"why not combine with the previous task \"Set version_hash and arch_tag facts\"","commit_id":"290b20bb6a361ce3dff67b01cf551ccd4a5f5e4f"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"728f7e681a1e062ba5b3feb6f151458e15f7a7e9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    version_hash: \"{{ baseurl.stdout.split(\u0027/\u0027)[-1] }}\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: Set arch_tag fact"},{"line_number":39,"context_line":"  set_fact:"},{"line_number":40,"context_line":"    arch_tag: \"{{ \u0027_\u0027 + ansible_architecture if ansible_architecture !\u003d \u0027x86_64\u0027 else \u0027\u0027}}\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: grab kolla patch if needed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_080f5f37","line":39,"in_reply_to":"9fb8cfa7_f661a9aa","updated":"2019-06-11 14:30:37.000000000","message":"That\u0027s a fair point! Will address in next set","commit_id":"290b20bb6a361ce3dff67b01cf551ccd4a5f5e4f"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"80b6b816a61eda78a110e2870b79fa55cf09cb0c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"- name: Set version_hash and arch_tag facts"},{"line_number":35,"context_line":"  set_fact:"},{"line_number":36,"context_line":"    version_hash: \"{{ baseurl.stdout.split(\u0027/\u0027)[-1] }}\""},{"line_number":37,"context_line":"    arch_tag: \"{{ \u0027_\u0027 + ansible_architecture if ansible_architecture !\u003d \u0027x86_64\u0027 else \u0027\u0027}}\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: grab kolla patch if needed"},{"line_number":40,"context_line":"  when: ansible_pkg_mgr \u003d\u003d \"dnf\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_e0fcb1b6","line":37,"updated":"2019-06-20 23:03:09.000000000","message":"I think we need this needs to be on all arches ... why exclude x86_64?","commit_id":"abb998ff0aaa951699e4970d274c06a3b401c5f3"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"11b81e787b49bb729506f54ff9f19a9d7643cb62","unresolved":false,"context_lines":[{"line_number":34,"context_line":"- name: Set version_hash and arch_tag facts"},{"line_number":35,"context_line":"  set_fact:"},{"line_number":36,"context_line":"    version_hash: \"{{ baseurl.stdout.split(\u0027/\u0027)[-1] }}\""},{"line_number":37,"context_line":"    arch_tag: \"{{ \u0027_\u0027 + ansible_architecture if ansible_architecture !\u003d \u0027x86_64\u0027 else \u0027\u0027}}\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: grab kolla patch if needed"},{"line_number":40,"context_line":"  when: ansible_pkg_mgr \u003d\u003d \"dnf\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_00e3dcda","line":37,"in_reply_to":"9fb8cfa7_bd0f9786","updated":"2019-06-25 13:14:15.000000000","message":"I\u0027m fine with this if it\u0027s not breaking. The hope was that the change was as non-intrusive as possible.","commit_id":"abb998ff0aaa951699e4970d274c06a3b401c5f3"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"31dcf6ad32007e824a39188035fdcaa93c3a147e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"- name: Set version_hash and arch_tag facts"},{"line_number":35,"context_line":"  set_fact:"},{"line_number":36,"context_line":"    version_hash: \"{{ baseurl.stdout.split(\u0027/\u0027)[-1] }}\""},{"line_number":37,"context_line":"    arch_tag: \"{{ \u0027_\u0027 + ansible_architecture if ansible_architecture !\u003d \u0027x86_64\u0027 else \u0027\u0027}}\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: grab kolla patch if needed"},{"line_number":40,"context_line":"  when: ansible_pkg_mgr \u003d\u003d \"dnf\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_bd0f9786","line":37,"in_reply_to":"9fb8cfa7_e0fcb1b6","updated":"2019-06-24 18:49:28.000000000","message":"Agreed. Tagging x86_64 won\u0027t break anything...\nIMHO it should be just\narch_tag: \"{{ ansible_architecture }}\"","commit_id":"abb998ff0aaa951699e4970d274c06a3b401c5f3"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"ce93ab9b51310c1245f50796a973cb5102eb779c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"- name: Set version_hash and arch_tag facts"},{"line_number":35,"context_line":"  set_fact:"},{"line_number":36,"context_line":"    version_hash: \"{{ baseurl.stdout.split(\u0027/\u0027)[-1] }}\""},{"line_number":37,"context_line":"    arch_tag: \"{{ \u0027_\u0027 + ansible_architecture if ansible_architecture !\u003d \u0027x86_64\u0027 else \u0027\u0027}}\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: grab kolla patch if needed"},{"line_number":40,"context_line":"  when: ansible_pkg_mgr \u003d\u003d \"dnf\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_4d70b8a4","line":37,"updated":"2019-08-06 20:46:58.000000000","message":"you might wonder why we\u0027re not tagging all containers with the format {{ version_hash }}_{{ ansible_architecture }} here and then retag x86_64 with {{ version_hash }} later on.\n\nThe intent is to prioritize tags. It is more important for x86_64 tags to maintain their compatibility with current consumers than it is for them to have a tag of the same format as other arches.\n\nThe containers are tagged with their \"most important\" tag first, so that if push succeeds, it is guaranteed that the most important tag can be used.\n\nIt may be a small gain, but I think it\u0027s worth the added complexity.","commit_id":"432806825b181721b7789dc423db8b5ffa66d677"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c57fd5ae3eef482a63b137993de13708320c064d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"- name: Set version_hash and arch_tag facts"},{"line_number":35,"context_line":"  set_fact:"},{"line_number":36,"context_line":"    version_hash: \"{{ baseurl.stdout.split(\u0027/\u0027)[-1] }}\""},{"line_number":37,"context_line":"    arch_tag: \"{{ \u0027_\u0027 + ansible_architecture if ansible_architecture !\u003d \u0027x86_64\u0027 else \u0027\u0027}}\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: grab kolla patch if needed"},{"line_number":40,"context_line":"  when: ansible_pkg_mgr \u003d\u003d \"dnf\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_4928a5ed","line":37,"in_reply_to":"7faddb67_4d70b8a4","updated":"2019-08-07 07:13:36.000000000","message":"so add a brief 2/line comment above this saying that ^ \"push \u0027old\u0027 style no arch first for backwards compat\"","commit_id":"432806825b181721b7789dc423db8b5ffa66d677"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fa48c620e81311fcaf85940d23a81d9075bf7379","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  block:"},{"line_number":104,"context_line":"    - name: Retrieve list of built images"},{"line_number":105,"context_line":"      shell: \u003e"},{"line_number":106,"context_line":"        podman images --format \"{{ \u0027{{\u0027 }}.Repository{{ \u0027}}\u0027 }}\" \\"},{"line_number":107,"context_line":"          --filter \"reference\u003d*:{{ version_hash }}\""},{"line_number":108,"context_line":"      register: built_images"},{"line_number":109,"context_line":"    - name: Tag images"},{"line_number":110,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_a98cb9d7","line":107,"range":{"start_line":106,"start_character":9,"end_line":107,"end_character":27},"updated":"2019-08-07 07:19:46.000000000","message":"every time we\u0027ve explored this retag, i\u0027ve had the same thought. This has the advantage of querying the registry (right?) so we confirm stuff uploaded OK. BUT its also expensive and prone to network issues etc. We could try and retrieve the list from the list of containers we just built e.g. in the build.log\n\nreally the answer is \u0027whatever is easiest to land first\u0027 .. if that podman images query works ok for you then just do that","commit_id":"432806825b181721b7789dc423db8b5ffa66d677"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"d6efd8bd2d80632d5acfa62cb6823885529ae935","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  block:"},{"line_number":104,"context_line":"    - name: Retrieve list of built images"},{"line_number":105,"context_line":"      shell: \u003e"},{"line_number":106,"context_line":"        podman images --format \"{{ \u0027{{\u0027 }}.Repository{{ \u0027}}\u0027 }}\" \\"},{"line_number":107,"context_line":"          --filter \"reference\u003d*:{{ version_hash }}\""},{"line_number":108,"context_line":"      register: built_images"},{"line_number":109,"context_line":"    - name: Tag images"},{"line_number":110,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_eb2013fb","line":107,"range":{"start_line":106,"start_character":9,"end_line":107,"end_character":27},"in_reply_to":"7faddb67_a98cb9d7","updated":"2019-08-12 16:43:11.000000000","message":"This is a fair concern.\n\nI went with it as it\u0027s an implementation that\u0027s been used in the past. Also, it gets you a confirmation that the initial push happened with the desired tag, and fails otherwise.\n\nFor now I\u0027m keeping this implementation but I am open to using something else if more people agree.","commit_id":"432806825b181721b7789dc423db8b5ffa66d677"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c57fd5ae3eef482a63b137993de13708320c064d","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    - name: Tag images"},{"line_number":110,"context_line":"      vars:"},{"line_number":111,"context_line":"        image: \"{{ item }}\""},{"line_number":112,"context_line":"      include: tag.yaml"},{"line_number":113,"context_line":"      static: no"},{"line_number":114,"context_line":"      with_items: \"{{ built_images.stdout_lines }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_c9525569","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":23},"updated":"2019-08-07 07:13:36.000000000","message":"i think you forgot to ^","commit_id":"432806825b181721b7789dc423db8b5ffa66d677"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2142045c4daa30991148a7273bb873e3960359e6","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    - name: Tag images"},{"line_number":110,"context_line":"      vars:"},{"line_number":111,"context_line":"        image: \"{{ item }}\""},{"line_number":112,"context_line":"      include: tag.yaml"},{"line_number":113,"context_line":"      static: no"},{"line_number":114,"context_line":"      with_items: \"{{ built_images.stdout_lines }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_e4ea8b0c","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":23},"in_reply_to":"7faddb67_c9525569","updated":"2019-08-12 10:35:36.000000000","message":"i mean something like that https://review.opendev.org/#/c/641348/13/playbooks/tripleo-buildcontainers/tag.yaml otherwise what is tag.yaml","commit_id":"432806825b181721b7789dc423db8b5ffa66d677"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"d6efd8bd2d80632d5acfa62cb6823885529ae935","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    - name: Tag images"},{"line_number":110,"context_line":"      vars:"},{"line_number":111,"context_line":"        image: \"{{ item }}\""},{"line_number":112,"context_line":"      include: tag.yaml"},{"line_number":113,"context_line":"      static: no"},{"line_number":114,"context_line":"      with_items: \"{{ built_images.stdout_lines }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_2be86bb1","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":23},"in_reply_to":"7faddb67_e4ea8b0c","updated":"2019-08-12 16:43:11.000000000","message":"Do\u0027h forgot to `git add`. Thanks for the heads up Marios","commit_id":"432806825b181721b7789dc423db8b5ffa66d677"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"a7d3939d6cf3518b43e967f3e3cd4386fe64214c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  set_fact:"},{"line_number":36,"context_line":"    version_hash: \"{{ baseurl.stdout.split(\u0027/\u0027)[-1] }}\""},{"line_number":37,"context_line":"    # NOTE(mjturek): Push old style tag for x86_64 first to maintain compatibility."},{"line_number":38,"context_line":"    arch_tag: \"{{ \u0027_\u0027 + ansible_architecture if ansible_architecture !\u003d \u0027x86_64\u0027 else \u0027\u0027}}\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: grab kolla patch if needed"},{"line_number":41,"context_line":"  when: ansible_pkg_mgr \u003d\u003d \"dnf\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_d0a511a1","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":91},"updated":"2019-08-22 16:05:00.000000000","message":"note: this is to keep backwards compatibility\nin kolla step:\nhash for x86_64\nhash_arch for ppc64le","commit_id":"4dcfa6e776e40a536a40b37dcdb3294c29b0f9f9"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"a7d3939d6cf3518b43e967f3e3cd4386fe64214c","unresolved":false,"context_lines":[{"line_number":99,"context_line":"- name: Retrieve by version_hash and retag x86_64 images to include arch"},{"line_number":100,"context_line":"  when:"},{"line_number":101,"context_line":"    - zuul is defined"},{"line_number":102,"context_line":"    - \"\u0027periodic\u0027 in zuul.pipeline\""},{"line_number":103,"context_line":"    - \"{{ ansible_architecture }} \u003d\u003d \u0027x86_64\u0027\""},{"line_number":104,"context_line":"  block:"},{"line_number":105,"context_line":"    - name: Retrieve list of built images"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_30fca571","line":102,"range":{"start_line":102,"start_character":4,"end_line":102,"end_character":35},"updated":"2019-08-22 16:05:00.000000000","message":"let\u0027s tag x86 containers the same way in periodic and in check. Remove this condition as we discussed with panda.\nThanks.","commit_id":"4dcfa6e776e40a536a40b37dcdb3294c29b0f9f9"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"d1c48e556dd5a7cd3c14f177a52c9d0264d2745c","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  block:"},{"line_number":105,"context_line":"    - name: Retrieve list of built images"},{"line_number":106,"context_line":"      shell: \u003e"},{"line_number":107,"context_line":"        podman images --format \"{{ \u0027{{\u0027 }}.Repository{{ \u0027}}\u0027 }}\" \\"},{"line_number":108,"context_line":"          --filter \"reference\u003d*:{{ version_hash }}\""},{"line_number":109,"context_line":"      register: built_images"},{"line_number":110,"context_line":"    - name: Tag images"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_25f833c2","line":107,"updated":"2019-08-19 11:05:25.000000000","message":"None of the current tests is actually excercising this code.\nThis change will run in periodic jobs on centos7 and will fail if podman is not installed.\nWe actually don\u0027t have any third party CI job that test periodic behaviour, so we\u0027ll realize we are breaking things only after it\u0027s merged.","commit_id":"4dcfa6e776e40a536a40b37dcdb3294c29b0f9f9"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"a7d3939d6cf3518b43e967f3e3cd4386fe64214c","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  block:"},{"line_number":105,"context_line":"    - name: Retrieve list of built images"},{"line_number":106,"context_line":"      shell: \u003e"},{"line_number":107,"context_line":"        podman images --format \"{{ \u0027{{\u0027 }}.Repository{{ \u0027}}\u0027 }}\" \\"},{"line_number":108,"context_line":"          --filter \"reference\u003d*:{{ version_hash }}\""},{"line_number":109,"context_line":"      register: built_images"},{"line_number":110,"context_line":"    - name: Tag images"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_90deb90e","line":107,"in_reply_to":"7faddb67_25f833c2","updated":"2019-08-22 16:05:00.000000000","message":"as we discussed, this will run in centos7... podman should work.","commit_id":"4dcfa6e776e40a536a40b37dcdb3294c29b0f9f9"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"f546822240b47669d2dc0393ddd1ae973f3d26f0","unresolved":false,"context_lines":[{"line_number":182,"context_line":"- name: Retrieve by version_hash and retag x86_64 images to include arch"},{"line_number":183,"context_line":"  when:"},{"line_number":184,"context_line":"    - zuul is defined"},{"line_number":185,"context_line":"    - \"{{ ansible_architecture }} \u003d\u003d \u0027x86_64\u0027\""},{"line_number":186,"context_line":"  block:"},{"line_number":187,"context_line":"    - name: Retrieve list of built images"},{"line_number":188,"context_line":"      shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_32fca571","line":185,"range":{"start_line":185,"start_character":0,"end_line":185,"end_character":46},"updated":"2019-08-22 20:42:50.000000000","message":"https://object-storage-ca-ymq-1.vexxhost.net/v1/86bbbcfa8ad043109d2d7af530225c72/logs_58/678058/3/check/tripleo-build-containers-centos-7-buildah/2cffd85/job-output.txt\n\n- ansible_architecture \u003d\u003d \u0027x86_64\u0027","commit_id":"bb727cb30a454ee833f1d63ee742ad8988a12983"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d29659d6aea89a0a70bd53292cd4bc88889d5876","unresolved":false,"context_lines":[{"line_number":186,"context_line":"  block:"},{"line_number":187,"context_line":"    - name: Retrieve list of built images"},{"line_number":188,"context_line":"      shell: \u003e"},{"line_number":189,"context_line":"        podman images --format \"{{ \u0027{{\u0027 }}.Repository{{ \u0027}}\u0027 }}\" \\"},{"line_number":190,"context_line":"          --filter \"reference\u003d*:{{ version_hash }}\""},{"line_number":191,"context_line":"      register: built_images"},{"line_number":192,"context_line":"    - name: Tag images"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_2e443919","line":189,"range":{"start_line":189,"start_character":8,"end_line":189,"end_character":21},"updated":"2019-08-23 06:16:13.000000000","message":"The CI jobs failed as podman command not found, we install podman first or is it possible to use buildah here?","commit_id":"cfc0a72f237592e9378c8d25e3cbdfbf3932139b"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"db4d693391cdc5d9b3de99fdfefaa9954a88e05d","unresolved":false,"context_lines":[{"line_number":182,"context_line":"- name: Retrieve list of built x86_64 images, retag, and push"},{"line_number":183,"context_line":"  when:"},{"line_number":184,"context_line":"    - ansible_architecture \u003d\u003d \"x86_64\""},{"line_number":185,"context_line":"    - push_containers"},{"line_number":186,"context_line":"  block:"},{"line_number":187,"context_line":"    - name: Retrieve built images ids"},{"line_number":188,"context_line":"      command: \"awk \u0027{ print $1 }\u0027 {{ workspace }}/containers-successfully-built.log\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"7faddb67_45c37d58","line":185,"range":{"start_line":185,"start_character":5,"end_line":185,"end_character":21},"updated":"2019-08-25 10:42:34.000000000","message":"|bool ?","commit_id":"f5806b004546b665f4c676d1f9cc09d49b30f8bd"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"db4d693391cdc5d9b3de99fdfefaa9954a88e05d","unresolved":false,"context_lines":[{"line_number":186,"context_line":"  block:"},{"line_number":187,"context_line":"    - name: Retrieve built images ids"},{"line_number":188,"context_line":"      command: \"awk \u0027{ print $1 }\u0027 {{ workspace }}/containers-successfully-built.log\""},{"line_number":189,"context_line":"      become: true"},{"line_number":190,"context_line":"      register: built_images"},{"line_number":191,"context_line":"    - name: Tag images"},{"line_number":192,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"7faddb67_e59dc96c","line":189,"range":{"start_line":189,"start_character":6,"end_line":189,"end_character":18},"updated":"2019-08-25 10:42:34.000000000","message":"why \"become: true\" here?","commit_id":"f5806b004546b665f4c676d1f9cc09d49b30f8bd"}],"roles/build-containers/tasks/tag.yaml":[{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"d1c48e556dd5a7cd3c14f177a52c9d0264d2745c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      command: \u003e"},{"line_number":6,"context_line":"        {{ cmd }}"},{"line_number":7,"context_line":"      with_items:"},{"line_number":8,"context_line":"        - \"podman tag {{ image }}:{{ version_hash }} {{ image }}:{{ version_hash }}_{{ansible_architecture}}\""},{"line_number":9,"context_line":"        - \"podman push {{ image }}:{{ version_hash }}_{{ ansible_architecture }}\""},{"line_number":10,"context_line":"      loop_control:"},{"line_number":11,"context_line":"        loop_var: \"cmd\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_45f52fca","line":8,"updated":"2019-08-19 11:05:25.000000000","message":"Same problem with the platforms","commit_id":"4dcfa6e776e40a536a40b37dcdb3294c29b0f9f9"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"d1c48e556dd5a7cd3c14f177a52c9d0264d2745c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"        {{ cmd }}"},{"line_number":7,"context_line":"      with_items:"},{"line_number":8,"context_line":"        - \"podman tag {{ image }}:{{ version_hash }} {{ image }}:{{ version_hash }}_{{ansible_architecture}}\""},{"line_number":9,"context_line":"        - \"podman push {{ image }}:{{ version_hash }}_{{ ansible_architecture }}\""},{"line_number":10,"context_line":"      loop_control:"},{"line_number":11,"context_line":"        loop_var: \"cmd\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_e5fd3bb2","line":9,"updated":"2019-08-19 11:05:25.000000000","message":"I understand why you\u0027re putting this here, but IIUC this code is meant to be run in rdo during periodic runs., where it will push to rdoregistry. We currently keep all the code for this kind of operations in rdo directly. I think we can discuss on this a bit.","commit_id":"4dcfa6e776e40a536a40b37dcdb3294c29b0f9f9"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"a7d3939d6cf3518b43e967f3e3cd4386fe64214c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"        {{ cmd }}"},{"line_number":7,"context_line":"      with_items:"},{"line_number":8,"context_line":"        - \"podman tag {{ image }}:{{ version_hash }} {{ image }}:{{ version_hash }}_{{ansible_architecture}}\""},{"line_number":9,"context_line":"        - \"podman push {{ image }}:{{ version_hash }}_{{ ansible_architecture }}\""},{"line_number":10,"context_line":"      loop_control:"},{"line_number":11,"context_line":"        loop_var: \"cmd\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_b04415ba","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":22},"updated":"2019-08-22 16:05:00.000000000","message":"add a condition if {{ push_containers }} here","commit_id":"4dcfa6e776e40a536a40b37dcdb3294c29b0f9f9"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"a7d3939d6cf3518b43e967f3e3cd4386fe64214c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"        {{ cmd }}"},{"line_number":7,"context_line":"      with_items:"},{"line_number":8,"context_line":"        - \"podman tag {{ image }}:{{ version_hash }} {{ image }}:{{ version_hash }}_{{ansible_architecture}}\""},{"line_number":9,"context_line":"        - \"podman push {{ image }}:{{ version_hash }}_{{ ansible_architecture }}\""},{"line_number":10,"context_line":"      loop_control:"},{"line_number":11,"context_line":"        loop_var: \"cmd\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_300a6579","line":9,"in_reply_to":"7faddb67_e5fd3bb2","updated":"2019-08-22 16:05:00.000000000","message":"we can enable push and local registry for testing","commit_id":"4dcfa6e776e40a536a40b37dcdb3294c29b0f9f9"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"37b7572fac0a8cbd0f828c2ab61ca545f559a128","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- block:"},{"line_number":3,"context_line":"    # Tag and push in the same task for the sake of doing less tasks"},{"line_number":4,"context_line":"    - name: \"Tag image: {{ image }}\""},{"line_number":5,"context_line":"      command: \u003e"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7faddb67_bc5f0e0e","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":7},"updated":"2019-08-22 18:47:14.000000000","message":"don\u0027t need this, no harm though","commit_id":"15bcb4e8c6dea52d33f0b1e77c4d814371be2628"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"37b7572fac0a8cbd0f828c2ab61ca545f559a128","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      command: \u003e"},{"line_number":6,"context_line":"        {{ cmd }}"},{"line_number":7,"context_line":"      with_items:"},{"line_number":8,"context_line":"        - \"podman tag {{ image }}:{{ version_hash }} {{ image }}:{{ version_hash }}_{{ansible_architecture}}\""},{"line_number":9,"context_line":"        - \"podman push {{ image }}:{{ version_hash }}_{{ ansible_architecture }}\""},{"line_number":10,"context_line":"      loop_control:"},{"line_number":11,"context_line":"        loop_var: \"cmd\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7faddb67_bc694e8d","line":8,"range":{"start_line":8,"start_character":86,"end_line":8,"end_character":106},"updated":"2019-08-22 18:47:14.000000000","message":"roles/build-containers/tasks/tag.yaml:8: [E206] Variables should have spaces before and after: {{ var_name }}","commit_id":"15bcb4e8c6dea52d33f0b1e77c4d814371be2628"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f6f8e94bdff936b3b13daab7ceea0a1494cde23b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  command: \u003e"},{"line_number":5,"context_line":"    {{ cmd }}"},{"line_number":6,"context_line":"  with_items:"},{"line_number":7,"context_line":"    - \"{{ container_cli }} tag {{ image }}:{{ version_hash }} {{ image }}:{{ version_hash }}_{{ ansible_architecture }}\""},{"line_number":8,"context_line":"    - \"{{ container_cli }} push {{ container_cli_opt }} {{ image }}:{{ version_hash }}_{{ ansible_architecture }}\""},{"line_number":9,"context_line":"  loop_control:"},{"line_number":10,"context_line":"    loop_var: \"cmd\""}],"source_content_type":"text/x-yaml","patch_set":32,"id":"7faddb67_269c04be","line":7,"range":{"start_line":7,"start_character":92,"end_line":7,"end_character":95},"updated":"2019-08-29 07:37:08.000000000","message":"remove the _ ?","commit_id":"31aac30d5f0373ed06cfd13156dbc17efbebb6dd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6cc45ca6f968bfb693bc7455c7549d9cf1632372","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  command: \u003e"},{"line_number":5,"context_line":"    {{ cmd }}"},{"line_number":6,"context_line":"  with_items:"},{"line_number":7,"context_line":"    - \"{{ container_cli }} tag {{ image }}:{{ version_hash }} {{ image }}:{{ version_hash }}_{{ ansible_architecture }}\""},{"line_number":8,"context_line":"    - \"{{ container_cli }} push {{ container_cli_opt }} {{ image }}:{{ version_hash }}_{{ ansible_architecture }}\""},{"line_number":9,"context_line":"  loop_control:"},{"line_number":10,"context_line":"    loop_var: \"cmd\""}],"source_content_type":"text/x-yaml","patch_set":32,"id":"7faddb67_9a066b21","line":7,"range":{"start_line":7,"start_character":92,"end_line":7,"end_character":95},"in_reply_to":"7faddb67_269c04be","updated":"2019-08-29 12:45:08.000000000","message":"as discussed just now i was confused as i thought you were using arch_tag from the main.yaml here.\n\nyou could instead use:\n\n     - \"{{ container_cli }} tag {{ image }}:{{ version_hash }} {{ image }}:{{ version_hash }}{{ arch_tag }}\"","commit_id":"31aac30d5f0373ed06cfd13156dbc17efbebb6dd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fa03a0af6a3b91a2d5073d1edef98088f2be394d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  command: \u003e"},{"line_number":5,"context_line":"    {{ cmd }}"},{"line_number":6,"context_line":"  with_items:"},{"line_number":7,"context_line":"    - \"{{ container_cli }} tag {{ image }}:{{ version_hash }} {{ image }}:{{ version_hash }}_{{ ansible_architecture }}\""},{"line_number":8,"context_line":"    - \"{{ container_cli }} push {{ container_cli_opt }} {{ image }}:{{ version_hash }}_{{ ansible_architecture }}\""},{"line_number":9,"context_line":"  loop_control:"},{"line_number":10,"context_line":"    loop_var: \"cmd\""}],"source_content_type":"text/x-yaml","patch_set":32,"id":"7faddb67_9534fce0","line":7,"range":{"start_line":7,"start_character":92,"end_line":7,"end_character":95},"in_reply_to":"7faddb67_9a066b21","updated":"2019-08-29 12:48:37.000000000","message":"15:47 \u003c marios\u003e rfolco: ah like arch_tag is the opposite in fact\n15:47 \u003c rlandy\u003e marios: hey  welcome back\n15:47 \u003c marios\u003e rfolco: if its ppc then we get _ppc64le\n15:47 \u003c marios\u003e rfolco: for arch_tag\n15:47 \u003c marios\u003e rfolco: if its x86_64 then we get \u0027\u0027 for arch_tag","commit_id":"31aac30d5f0373ed06cfd13156dbc17efbebb6dd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f6f8e94bdff936b3b13daab7ceea0a1494cde23b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    {{ cmd }}"},{"line_number":6,"context_line":"  with_items:"},{"line_number":7,"context_line":"    - \"{{ container_cli }} tag {{ image }}:{{ version_hash }} {{ image }}:{{ version_hash }}_{{ ansible_architecture }}\""},{"line_number":8,"context_line":"    - \"{{ container_cli }} push {{ container_cli_opt }} {{ image }}:{{ version_hash }}_{{ ansible_architecture }}\""},{"line_number":9,"context_line":"  loop_control:"},{"line_number":10,"context_line":"    loop_var: \"cmd\""}],"source_content_type":"text/x-yaml","patch_set":32,"id":"7faddb67_86acd8ee","line":8,"range":{"start_line":8,"start_character":86,"end_line":8,"end_character":87},"updated":"2019-08-29 07:37:08.000000000","message":"you already have it there https://review.opendev.org/#/c/663977/32/roles/build-containers/tasks/main.yaml","commit_id":"31aac30d5f0373ed06cfd13156dbc17efbebb6dd"}],"roles/build-containers/templates/kolla-build.conf.j2":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5e1525194ae7ce42092e66de1fc086ab2cf726e7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% endif %}"},{"line_number":7,"context_line":"type\u003dbinary"},{"line_number":8,"context_line":"registry\u003d{{ push_registry }}"},{"line_number":9,"context_line":"tag\u003d{{ version_hash }}{{ arch_tag }}"},{"line_number":10,"context_line":"template_override\u003d{{ openstack_git_root }}/tripleo-common/container-images/tripleo_kolla_template_overrides.j2"},{"line_number":11,"context_line":"# we use the repos off the main host as they will already have the correct mirror info in them"},{"line_number":12,"context_line":"rpm_setup_config\u003d\"{{ buildcontainers_rpm_setup_config }}\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fb8cfa7_36bd0102","line":9,"updated":"2019-06-10 07:02:52.000000000","message":"do we want to separate these with something maybe _ ?\n\n[EDIT]:  I see you made it part of the arch_tag https://review.opendev.org/#/c/663977/1/roles/build-containers/tasks/main.yaml@40","commit_id":"290b20bb6a361ce3dff67b01cf551ccd4a5f5e4f"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"31dcf6ad32007e824a39188035fdcaa93c3a147e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% endif %}"},{"line_number":7,"context_line":"type\u003dbinary"},{"line_number":8,"context_line":"registry\u003d{{ push_registry }}"},{"line_number":9,"context_line":"tag\u003d{{ version_hash }}{{ arch_tag }}"},{"line_number":10,"context_line":"template_override\u003d{{ openstack_git_root }}/tripleo-common/container-images/tripleo_kolla_template_overrides.j2"},{"line_number":11,"context_line":"# we use the repos off the main host as they will already have the correct mirror info in them"},{"line_number":12,"context_line":"rpm_setup_config\u003d\"{{ buildcontainers_rpm_setup_config }}\""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9fb8cfa7_9d58938a","line":9,"range":{"start_line":9,"start_character":22,"end_line":9,"end_character":36},"updated":"2019-06-24 18:49:28.000000000","message":"_{{ arch_tag }}","commit_id":"abb998ff0aaa951699e4970d274c06a3b401c5f3"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"11b81e787b49bb729506f54ff9f19a9d7643cb62","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% endif %}"},{"line_number":7,"context_line":"type\u003dbinary"},{"line_number":8,"context_line":"registry\u003d{{ push_registry }}"},{"line_number":9,"context_line":"tag\u003d{{ version_hash }}{{ arch_tag }}"},{"line_number":10,"context_line":"template_override\u003d{{ openstack_git_root }}/tripleo-common/container-images/tripleo_kolla_template_overrides.j2"},{"line_number":11,"context_line":"# we use the repos off the main host as they will already have the correct mirror info in them"},{"line_number":12,"context_line":"rpm_setup_config\u003d\"{{ buildcontainers_rpm_setup_config }}\""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9fb8cfa7_c953a36a","line":9,"range":{"start_line":9,"start_character":22,"end_line":9,"end_character":36},"in_reply_to":"9fb8cfa7_9d58938a","updated":"2019-06-25 13:14:15.000000000","message":"I was constructing the arch tag with a _ prefix (to avoid changing how x86_64 containers are tagged). But if we\u0027re going to tag everything the same way this is what I\u0027ll do!","commit_id":"abb998ff0aaa951699e4970d274c06a3b401c5f3"}]}