)]}'
{"roles/build-containers/tasks/main.yaml":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ef27547c6732f8dc7d3b189536cbdccdcaae49cf","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    - name: create base container with repos from rhel container"},{"line_number":133,"context_line":"      shell:"},{"line_number":134,"context_line":"        cmd: |"},{"line_number":135,"context_line":"          docker build -t {{ kolla_base_image }}:{{ kolla_base_tag }} ."},{"line_number":136,"context_line":"      args:"},{"line_number":137,"context_line":"        chdir: /tmp/base-build"},{"line_number":138,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_dd072f1c","line":135,"range":{"start_line":135,"start_character":10,"end_line":135,"end_character":71},"updated":"2019-07-09 06:54:01.000000000","message":"I think it should be buildah and as per the error:\nhttps://logs.rdoproject.org/95/21295/16/check/tripleo-build-containers-rhel-8-master/f67ec11/job-output.txt.gz#_2019-07-08_17_53_24_718417\n\n-\u003e it is related to this issue: https://github.com/containers/libpod/issues/1182#issuecomment-408876210\n\nBy setting usermod --add-subuids 10000-65536 USERNAME fixes the issue I think.","commit_id":"891d8107b2e50df1de108ffce4400e79d737f180"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"a5da0c36423a0cc0e761cdffb4ad856e08663197","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    set -euxo pipefail"},{"line_number":64,"context_line":"    git config --global user.email \"zuul@openstack.org\""},{"line_number":65,"context_line":"    git config --global user.name \"Zuul\""},{"line_number":66,"context_line":"    git remote add upstream https://review.opendev.org/openstack/kolla"},{"line_number":67,"context_line":"    git ls-remote https://review.opendev.org/openstack/kolla | \\"},{"line_number":68,"context_line":"      grep -E refs/changes/[[:digit:]]+/{{ kolla_rhel8_patch }}/ | \\"},{"line_number":69,"context_line":"      awk \u0027{print $2}\u0027 | \\"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_194e186f","line":66,"updated":"2019-07-10 18:14:55.000000000","message":"- nit, just noting that part of this task could be pulled out to a common task between lines 41 and 45.  Fine for now.","commit_id":"45370009900ef4e705ec139abb9a14f21b4d0f18"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"16293655c50756ecaf25db4fe84862f4af5ccbc2","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    git config --global user.name \"Zuul\""},{"line_number":66,"context_line":"    git remote add upstream https://review.opendev.org/openstack/kolla"},{"line_number":67,"context_line":"    git ls-remote https://review.opendev.org/openstack/kolla | \\"},{"line_number":68,"context_line":"      grep -E refs/changes/[[:digit:]]+/{{ kolla_rhel8_patch }}/ | \\"},{"line_number":69,"context_line":"      awk \u0027{print $2}\u0027 | \\"},{"line_number":70,"context_line":"      sort -t / -k 5 -g -r | \\"},{"line_number":71,"context_line":"      head -1 | \\"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"7faddb67_320870d8","line":68,"range":{"start_line":68,"start_character":43,"end_line":68,"end_character":60},"updated":"2019-07-17 06:13:03.000000000","message":"I\u0027m a little late here so this is just a suggestion would be great if we could use sthing like that in vars:\n\npatches:\n  fedora: 12345\n  rhel: 67890\n\nand then just have the same code here/one task (i.e. trying to avoid the duplication of the patching lines)\n\nit more than a minor rework so it is fine like that to get it working and we can improve when we get time (!)","commit_id":"9f6559033b2446ca28f83068365cf7401a337f39"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"16293655c50756ecaf25db4fe84862f4af5ccbc2","unresolved":false,"context_lines":[{"line_number":120,"context_line":"      become: true"},{"line_number":121,"context_line":"      shell:"},{"line_number":122,"context_line":"        cmd: |"},{"line_number":123,"context_line":"          cp /etc/yum.repos.d/delorean* /tmp/base-build/repos/"},{"line_number":124,"context_line":"          chown -R {{ ansible_user }}: /tmp/base-build/repos/*"},{"line_number":125,"context_line":"      changed_when: true"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":42,"id":"7faddb67_323150a4","line":123,"range":{"start_line":123,"start_character":30,"end_line":123,"end_character":40},"updated":"2019-07-17 06:13:03.000000000","message":"if the * is meant to pickup delorean-deps then it needs updating. with tripleo-repos we get delorean.repo and OSP15-deps.repo\n\nsounds like this has been successful for the build so far (which means you aren\u0027t using the OSP15-deps here so looks like they aren\u0027t needed for the containers build) just pointing it out the * is redundant (though if you remove you\u0027ll have to use the full name delorean.repo)","commit_id":"9f6559033b2446ca28f83068365cf7401a337f39"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"16293655c50756ecaf25db4fe84862f4af5ccbc2","unresolved":false,"context_lines":[{"line_number":153,"context_line":"  args:"},{"line_number":154,"context_line":"    chdir: \u0027{{ workspace }}\u0027"},{"line_number":155,"context_line":"  shell: set -o pipefail \u0026\u0026 bash build_containers.sh 2\u003e\u00261 {{ timestamper_cmd }} \u003e {{ workspace }}/build.log"},{"line_number":156,"context_line":"  become: true"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":42,"id":"7faddb67_122a142b","line":156,"updated":"2019-07-17 06:13:03.000000000","message":"why?","commit_id":"9f6559033b2446ca28f83068365cf7401a337f39"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fd3a815924a5e14d0c0207312deeafb0f29baff7","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  register: result"},{"line_number":58,"context_line":"  changed_when: \"\u0027nothing to commit, working directory clean\u0027 not in result.stdout_lines\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- name: grab kolla patch rhel8"},{"line_number":61,"context_line":"  when: ansible_pkg_mgr \u003d\u003d \"dnf\" and ansible_distribution|lower  \u003d\u003d \"redhat\""},{"line_number":62,"context_line":"  shell: |"},{"line_number":63,"context_line":"    set -euxo pipefail"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"7faddb67_1dde80d9","line":60,"updated":"2019-07-19 06:14:57.000000000","message":"still would be nice to combine this with the previous task and then parameterize the patch but won\u0027t block on that ... once we have the thing running so we can test it this can come as an improvement","commit_id":"d8354c5b7e801cd7132559f1425d9375cc8ef1ca"}],"roles/build-containers/templates/Dockerfile.j2":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"a5da0c36423a0cc0e761cdffb4ad856e08663197","unresolved":false,"context_lines":[{"line_number":5,"context_line":"RUN dnf clean all"},{"line_number":6,"context_line":"# TODO(rfolco): dumb-init is not available,"},{"line_number":7,"context_line":"# required by base rhel image in kolla build"},{"line_number":8,"context_line":"RUN dnf install -y https://cbs.centos.org/kojifiles/packages/dumb-init/1.1.3/17.el7/x86_64/dumb-init-1.1.3-17.el7.x86_64.rpm"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7faddb67_b96584e3","line":8,"updated":"2019-07-10 18:14:55.000000000","message":"can we ask #rhos-delivery if the dumb-init package can be uploaded to the RHUI","commit_id":"45370009900ef4e705ec139abb9a14f21b4d0f18"}],"roles/tripleo-repos/tasks/main.yml":[{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"417bf8d174b683924c801e9e8060239583646eb6","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    tripleo-repos \\"},{"line_number":82,"context_line":"      -b \"{{ ci_branch | default(\u0027master\u0027) }}\" \\"},{"line_number":83,"context_line":"    if [ ! -z \"$DISTRO_MIRROR_HOST\" ]; then"},{"line_number":84,"context_line":"      --mirror $DISTRO_MIRROR_HOST \\"},{"line_number":85,"context_line":"    fi"},{"line_number":86,"context_line":"      --rdo-mirror $RDO_MIRROR_HOST $REPO"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"7faddb67_7c59ef8b","line":83,"updated":"2019-07-16 09:58:06.000000000","message":"This is invalid bash syntax","commit_id":"75d936adf6ca877be5ee2f0f9b79285753f31bc5"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"c82525f369695189b16ccb60e69f4409e1ec7f34","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    tripleo-repos \\"},{"line_number":82,"context_line":"      -b \"{{ ci_branch | default(\u0027master\u0027) }}\" \\"},{"line_number":83,"context_line":"    if [ ! -z \"$DISTRO_MIRROR_HOST\" ]; then"},{"line_number":84,"context_line":"      --mirror $DISTRO_MIRROR_HOST \\"},{"line_number":85,"context_line":"    fi"},{"line_number":86,"context_line":"      --rdo-mirror $RDO_MIRROR_HOST $REPO"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"7faddb67_972a8429","line":83,"in_reply_to":"7faddb67_7c59ef8b","updated":"2019-07-16 10:39:28.000000000","message":"Done","commit_id":"75d936adf6ca877be5ee2f0f9b79285753f31bc5"}]}