)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cfd255587f47a9270c3801f6c5991eb44fb47230","unresolved":false,"context_lines":[{"line_number":17,"context_line":"let\u0027s use a job variable for that:"},{"line_number":18,"context_line":"\"force_periodic\" will force job to run as promotion job, using the"},{"line_number":19,"context_line":"same repositories as any promotion job uses."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ib305207dcd2b4626a7d7d340bc383dd176b11633"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_6ce3fda5","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":0},"updated":"2019-07-24 13:58:30.000000000","message":"maybe point to example rdo review where you\u0027re using it","commit_id":"108b02ff4c3bd07254c9ae0e7ae8c7a9f13ca275"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d765ef57f1b5e65ae37a4212bc088309d8953176","unresolved":false,"context_lines":[{"line_number":17,"context_line":"let\u0027s use a job variable for that:"},{"line_number":18,"context_line":"\"force_periodic\" will force job to run as promotion job, using the"},{"line_number":19,"context_line":"same repositories as any promotion job uses."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ib305207dcd2b4626a7d7d340bc383dd176b11633"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_e86267d8","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":0},"in_reply_to":"7faddb67_6ce3fda5","updated":"2019-07-25 13:16:09.000000000","message":"well, I can\u0027t use it without defining it here before.\nRunning periodic jobs in patch I think is pretty known issue.","commit_id":"108b02ff4c3bd07254c9ae0e7ae8c7a9f13ca275"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3b166bb5b63d2d2504f9a68627909ca185122938","unresolved":false,"context_lines":[{"line_number":17,"context_line":"let\u0027s use a job variable for that:"},{"line_number":18,"context_line":"\"force_periodic\" will force job to run as promotion job, using the"},{"line_number":19,"context_line":"same repositories as any promotion job uses."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ib305207dcd2b4626a7d7d340bc383dd176b11633"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_c54e6637","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":0},"in_reply_to":"7faddb67_e86267d8","updated":"2019-07-26 06:55:31.000000000","message":"ok i thought maybe you have it in depends-on somewhere already","commit_id":"108b02ff4c3bd07254c9ae0e7ae8c7a9f13ca275"}],"roles/common/vars/main.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3b166bb5b63d2d2504f9a68627909ca185122938","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  --extra-vars @{{ job_featureset_file }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"periodic: \u003e-"},{"line_number":21,"context_line":"  {% if \u0027periodic\u0027 in zuul.pipeline and not force_non_periodic|default(false)|bool or force_periodic|default(false)|bool -%}"},{"line_number":22,"context_line":"  true"},{"line_number":23,"context_line":"  {%- else -%}"},{"line_number":24,"context_line":"  false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_25597afd","line":21,"range":{"start_line":21,"start_character":47,"end_line":21,"end_character":53},"updated":"2019-07-26 06:55:31.000000000","message":"\"force_check\" and \"force_periodic\" maybe is better?\n\ni.e. instead of force_non_periodic","commit_id":"108b02ff4c3bd07254c9ae0e7ae8c7a9f13ca275"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2274e247370a1d7225525a9564b19e433ca5ac58","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  --extra-vars @{{ job_featureset_file }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"periodic: \u003e-"},{"line_number":21,"context_line":"  {% if \u0027periodic\u0027 in zuul.pipeline and not force_non_periodic|default(false)|bool or force_periodic|default(false)|bool -%}"},{"line_number":22,"context_line":"  true"},{"line_number":23,"context_line":"  {%- else -%}"},{"line_number":24,"context_line":"  false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_59da5017","line":21,"range":{"start_line":21,"start_character":47,"end_line":21,"end_character":53},"in_reply_to":"7faddb67_25597afd","updated":"2019-07-28 12:00:31.000000000","message":"Yeah, was thinking about that, but looked not so obvious what is \"check\" here.  \"force_check\" could be anything - which check exactly. \"force_non_periodic\" seems related to periodic jobs.","commit_id":"108b02ff4c3bd07254c9ae0e7ae8c7a9f13ca275"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"f32577238bd6f748bf57feace3ac2a37e4747016","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  --extra-vars @{{ job_featureset_file }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"periodic: \u003e-"},{"line_number":21,"context_line":"  {% if \u0027periodic\u0027 in zuul.pipeline and not force_non_periodic|default(false)|bool or force_periodic|default(false)|bool -%}"},{"line_number":22,"context_line":"  true"},{"line_number":23,"context_line":"  {%- else -%}"},{"line_number":24,"context_line":"  false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_64a72dbf","line":21,"range":{"start_line":21,"start_character":47,"end_line":21,"end_character":53},"in_reply_to":"7faddb67_59da5017","updated":"2019-07-31 14:45:22.000000000","message":"ok - I understand your two use cases.\nOne suggest is to bracket the first two cases so it\u0027s clear it\u0027s pipeline and not forcing non-periodic - OR - force _periodic","commit_id":"108b02ff4c3bd07254c9ae0e7ae8c7a9f13ca275"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"ad10406029b96b881fc7afbb7af23d67aa26b7d7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  --extra-vars @{{ job_featureset_file }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"periodic: \u003e-"},{"line_number":21,"context_line":"  {% if (\u0027periodic\u0027 in zuul.pipeline and not force_non_periodic|default(false)|bool) or force_periodic|default(false)|bool -%}"},{"line_number":22,"context_line":"  true"},{"line_number":23,"context_line":"  {%- else -%}"},{"line_number":24,"context_line":"  false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_e4255d0a","line":21,"updated":"2019-07-31 14:52:22.000000000","message":"let\u0027s add a code comment to fully define what you are expressing w/ \nforce_non_periodic\nforce_periodic|","commit_id":"95caa5a77a939bf591afb57cc5a8515fc446be0b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b22f6b0c3aaa9b97cafb1da0dd789e50bf4dc098","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  --extra-vars @{{ job_featureset_file }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"periodic: \u003e-"},{"line_number":21,"context_line":"  {% if (\u0027periodic\u0027 in zuul.pipeline and not force_non_periodic|default(false)|bool) or force_periodic|default(false)|bool -%}"},{"line_number":22,"context_line":"  true"},{"line_number":23,"context_line":"  {%- else -%}"},{"line_number":24,"context_line":"  false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_64688d1c","line":21,"range":{"start_line":21,"start_character":88,"end_line":21,"end_character":122},"updated":"2019-07-31 14:54:15.000000000","message":"while not 100% required for jinja2, I\u0027d wrap this in parenthesis to ensure the filters are all captures within that one condition.","commit_id":"95caa5a77a939bf591afb57cc5a8515fc446be0b"}]}
