)]}'
{"roles/oooci-build-images/tasks/pre.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d22328d81663c805d74bb194a2453d861ff7e44b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    - \"{{ python_version[python_v] }}-pip\""},{"line_number":18,"context_line":"    - \"{{ python_version[python_v] }}-virtualenv\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Check if python3 executable exists"},{"line_number":21,"context_line":"  shell: command -v python3"},{"line_number":22,"context_line":"  failed_when: false"},{"line_number":23,"context_line":"  register: python3_cmd"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_956f4bfb","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":42},"updated":"2019-07-25 15:07:51.000000000","message":"we already have python_v fact doesn\u0027t it help you. https://github.com/openstack/tripleo-ci/blob/master/roles/oooci-build-images/tasks/check_set_py3.yaml","commit_id":"40ef3118ea66433768676c112ecc33dd1263918f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c539184eb0c7633aa4112f62f71e41a5a38364f8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    - \"{{ python_version[python_v] }}-pip\""},{"line_number":18,"context_line":"    - \"{{ python_version[python_v] }}-virtualenv\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Check if python3 executable exists"},{"line_number":21,"context_line":"  shell: command -v python3"},{"line_number":22,"context_line":"  failed_when: false"},{"line_number":23,"context_line":"  register: python3_cmd"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_ad21ba4f","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":42},"in_reply_to":"7faddb67_03cb1353","updated":"2019-07-29 07:37:17.000000000","message":"what do you mean? see line 8 above?","commit_id":"40ef3118ea66433768676c112ecc33dd1263918f"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"26539f9a1ff3e765ed45a437140c3b8baedfcc85","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    - \"{{ python_version[python_v] }}-pip\""},{"line_number":18,"context_line":"    - \"{{ python_version[python_v] }}-virtualenv\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Check if python3 executable exists"},{"line_number":21,"context_line":"  shell: command -v python3"},{"line_number":22,"context_line":"  failed_when: false"},{"line_number":23,"context_line":"  register: python3_cmd"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_03cb1353","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":42},"in_reply_to":"7faddb67_956f4bfb","updated":"2019-07-28 11:57:20.000000000","message":"This \"pre.yml\" is executed yet before check_set_py3.yaml","commit_id":"40ef3118ea66433768676c112ecc33dd1263918f"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"90461db08c143da003bad52d0784cb4a9fadaaf8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    - \"{{ python_version[python_v] }}-pip\""},{"line_number":18,"context_line":"    - \"{{ python_version[python_v] }}-virtualenv\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Check if python3 executable exists"},{"line_number":21,"context_line":"  shell: command -v python3"},{"line_number":22,"context_line":"  failed_when: false"},{"line_number":23,"context_line":"  register: python3_cmd"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_c0b158e3","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":42},"in_reply_to":"7faddb67_ad21ba4f","updated":"2019-07-29 12:40:50.000000000","message":"Oh, I see what you mean, I looked at https://github.com/openstack/tripleo-ci/blob/master/roles/oooci-build-images/tasks/main.yaml#L8","commit_id":"40ef3118ea66433768676c112ecc33dd1263918f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c539184eb0c7633aa4112f62f71e41a5a38364f8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# get python_v fact used with vars/common.yaml to get"},{"line_number":7,"context_line":"# python2 or python3 packages in below tasks"},{"line_number":8,"context_line":"- name: Get python_v fact for py2 or py3 common vars"},{"line_number":9,"context_line":"  include_tasks: check_set_py3.yaml"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Install pip and virtualenv"},{"line_number":12,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_6d1bc21a","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":35},"updated":"2019-07-29 07:37:17.000000000","message":"included here @Sagi","commit_id":"971f50fb29e593c212fefb4c50c3b59e78b42a25"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c539184eb0c7633aa4112f62f71e41a5a38364f8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    - \"{{ python_version[python_v] }}-pip\""},{"line_number":18,"context_line":"    - \"{{ python_version[python_v] }}-virtualenv\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Check if python3 executable exists"},{"line_number":21,"context_line":"  shell: command -v python3"},{"line_number":22,"context_line":"  failed_when: false"},{"line_number":23,"context_line":"  register: python3_cmd"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_2dd38a3a","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":42},"updated":"2019-07-29 07:37:17.000000000","message":"not against it its just that we already have a check and infact it is checking the ansible_python version","commit_id":"971f50fb29e593c212fefb4c50c3b59e78b42a25"}],"roles/oooci-build-images/templates/pathfix_repos.sh.j2":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d22328d81663c805d74bb194a2453d861ff7e44b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/bash"},{"line_number":2,"context_line":"for python_file in \""},{"line_number":3,"context_line":"    {{ openstack_git_root }}/tripleo-image-elements/elements/os-svc-install/bin/map-services-tripleo"},{"line_number":4,"context_line":"    {{ openstack_git_root }}/diskimage-builder/diskimage_builder/lib/outfilter.py"},{"line_number":5,"context_line":"    {{ openstack_git_root }}/diskimage-builder/diskimage_builder/elements/package-installs/bin/package-installs-squash"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_753acfe7","line":2,"updated":"2019-07-25 15:07:51.000000000","message":"maybe we need some comments here about what this is working around. maybe point to the spec file you pointed to in irc earlier today","commit_id":"40ef3118ea66433768676c112ecc33dd1263918f"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"26539f9a1ff3e765ed45a437140c3b8baedfcc85","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/bash"},{"line_number":2,"context_line":"for python_file in \""},{"line_number":3,"context_line":"    {{ openstack_git_root }}/tripleo-image-elements/elements/os-svc-install/bin/map-services-tripleo"},{"line_number":4,"context_line":"    {{ openstack_git_root }}/diskimage-builder/diskimage_builder/lib/outfilter.py"},{"line_number":5,"context_line":"    {{ openstack_git_root }}/diskimage-builder/diskimage_builder/elements/package-installs/bin/package-installs-squash"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_23c64f4b","line":2,"in_reply_to":"7faddb67_753acfe7","updated":"2019-07-28 11:57:20.000000000","message":"I can copy commit message here","commit_id":"40ef3118ea66433768676c112ecc33dd1263918f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7ac82d3a0bbdc15f065c250432943b42f9990339","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    {{ openstack_git_root }}/diskimage-builder/diskimage_builder/elements/deploy-targetcli/extra-data.d/module/targetcli-wrapper"},{"line_number":13,"context_line":"\""},{"line_number":14,"context_line":"do"},{"line_number":15,"context_line":"    /usr/bin/pathfix.py -pni /usr/bin/python3 $python_file"},{"line_number":16,"context_line":"done"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_318d15d3","line":15,"range":{"start_line":15,"start_character":13,"end_line":15,"end_character":20},"updated":"2019-07-30 07:23:10.000000000","message":"do we need to install it/add it in some requirements etc?\n[EDIT]: sorry I see that\u0027s what you\u0027re doing in pre.yaml","commit_id":"91292bca8299bb9c301d2784a614bfbeee561242"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"cc06ab6bf063da85092ee08b7299e57b89875e0c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    {{ openstack_git_root }}/diskimage-builder/diskimage_builder/elements/deploy-targetcli/extra-data.d/module/targetcli-wrapper"},{"line_number":13,"context_line":"\""},{"line_number":14,"context_line":"do"},{"line_number":15,"context_line":"    /usr/bin/pathfix.py -pni /usr/bin/python3 $python_file"},{"line_number":16,"context_line":"done"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_85483c2d","line":15,"range":{"start_line":15,"start_character":13,"end_line":15,"end_character":20},"in_reply_to":"7faddb67_318d15d3","updated":"2019-07-30 14:00:02.000000000","message":"Yeah, it\u0027s provided in python3-dev","commit_id":"91292bca8299bb9c301d2784a614bfbeee561242"}]}