)]}'
{"roles/build-containers/templates/build.sh.j2":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"c42e384d8829c3024d8e1f81e3f7c60d4e401dfb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"egrep \"^Error:|No match\" /tmp/kolla-*/docker -R \u003e containers-build-errors.log 2\u003e\u00261"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"### actual built containers"},{"line_number":47,"context_line":"sudo podman images | grep tripleo{{ ci_branch }}/{{ kolla_base }}-binary \u003e containers-successfully-built.log"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"### not built (failed)"},{"line_number":50,"context_line":"for i in `cat containers-expected-to-build.log`; do"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_fbd70522","line":47,"range":{"start_line":47,"start_character":5,"end_line":47,"end_character":11},"updated":"2019-08-05 07:37:45.000000000","message":"why not using buildah? also good to rely on container_cli instead of hardcoding it here.","commit_id":"78e026187207719fb9e7fa43c3a18b3a2accdabe"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"1c470b973f2025ebc87adecdd5d67e85e5e73134","unresolved":false,"context_lines":[{"line_number":44,"context_line":"egrep \"^Error:|No match\" /tmp/kolla-*/docker -R \u003e containers-build-errors.log 2\u003e\u00261"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"### actual built containers"},{"line_number":47,"context_line":"sudo podman images | grep tripleo{{ ci_branch }}/{{ kolla_base }}-binary \u003e containers-successfully-built.log"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"### not built (failed)"},{"line_number":50,"context_line":"for i in `cat containers-expected-to-build.log`; do"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_6c326860","line":47,"range":{"start_line":47,"start_character":5,"end_line":47,"end_character":11},"in_reply_to":"7faddb67_fbd70522","updated":"2019-08-06 08:11:29.000000000","message":"Done","commit_id":"78e026187207719fb9e7fa43c3a18b3a2accdabe"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"08cbb8b83a768fba3c5c6dc909593aeeb206dfe0","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  printf \"\\nWarning: Errors found during container builds. See build-errors.log.\""},{"line_number":68,"context_line":"fi"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"if [ \"$BUILT\" -lt \"$EXPECTED\" ]; then"},{"line_number":71,"context_line":"  printf \"\\nFAILURE: I\u0027m sorry. One or more containers failed to build :(\""},{"line_number":72,"context_line":"  exit 1"},{"line_number":73,"context_line":"fi"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_f13b9698","line":70,"updated":"2019-08-05 23:50:41.000000000","message":"Why not just check $RETCODE?","commit_id":"78e026187207719fb9e7fa43c3a18b3a2accdabe"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"1c470b973f2025ebc87adecdd5d67e85e5e73134","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  printf \"\\nWarning: Errors found during container builds. See build-errors.log.\""},{"line_number":68,"context_line":"fi"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"if [ \"$BUILT\" -lt \"$EXPECTED\" ]; then"},{"line_number":71,"context_line":"  printf \"\\nFAILURE: I\u0027m sorry. One or more containers failed to build :(\""},{"line_number":72,"context_line":"  exit 1"},{"line_number":73,"context_line":"fi"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_4c244c0d","line":70,"in_reply_to":"7faddb67_f13b9698","updated":"2019-08-06 08:11:29.000000000","message":"Retcode might be got overridden based on if condition execution, we are merging the below two if conditions in a single one.","commit_id":"78e026187207719fb9e7fa43c3a18b3a2accdabe"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"c42e384d8829c3024d8e1f81e3f7c60d4e401dfb","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"printf \"\\nSUCCESS: Congratulations! All containers have been built :)\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"exit 0"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_bb28ad32","line":77,"range":{"start_line":77,"start_character":5,"end_line":77,"end_character":6},"updated":"2019-08-05 07:37:45.000000000","message":"should not return 0 always, it should be based on the build result. see comment on https://review.opendev.org/#/c/674282/","commit_id":"78e026187207719fb9e7fa43c3a18b3a2accdabe"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"1c470b973f2025ebc87adecdd5d67e85e5e73134","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"printf \"\\nSUCCESS: Congratulations! All containers have been built :)\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"exit 0"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_ec45f8b4","line":77,"range":{"start_line":77,"start_character":5,"end_line":77,"end_character":6},"in_reply_to":"7faddb67_bb28ad32","updated":"2019-08-06 08:11:29.000000000","message":"Done","commit_id":"78e026187207719fb9e7fa43c3a18b3a2accdabe"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"44550257a025c0ad05f9ce2144d8857c55018444","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  printf \"\\nWarning: Errors found during container builds. See build-errors.log.\""},{"line_number":68,"context_line":"fi"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"if [ \"$BUILT\" -lt \"$EXPECTED\" ]; then"},{"line_number":71,"context_line":"  printf \"\\nFAILURE: I\u0027m sorry. One or more containers failed to build :(\""},{"line_number":72,"context_line":"  exit 1"},{"line_number":73,"context_line":"else"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_b0d66e4e","line":70,"updated":"2019-08-06 13:34:44.000000000","message":"the var RETCODE is only set on L30 so it\u0027s not going to be overwritten. We should use that instead.  Honestly that\u0027s what it was prior to all this shell stuff around it. I think we need to fail based on the return code of the command and not anything else.","commit_id":"fec9f0f4928aa8265a8ec9dafd1894fc46064f1c"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"fcd9912d7e9d099358dc4133225e0d1c5f18624d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  printf \"\\nWarning: Errors found during container builds. See build-errors.log.\""},{"line_number":68,"context_line":"fi"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"if [ \"$BUILT\" -lt \"$EXPECTED\" ]; then"},{"line_number":71,"context_line":"  printf \"\\nFAILURE: I\u0027m sorry. One or more containers failed to build :(\""},{"line_number":72,"context_line":"  exit 1"},{"line_number":73,"context_line":"else"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_dad775c0","line":70,"in_reply_to":"7faddb67_b0d66e4e","updated":"2019-08-07 10:20:03.000000000","message":"Done","commit_id":"fec9f0f4928aa8265a8ec9dafd1894fc46064f1c"}]}