)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fad17a75fc7963038ac77bf68daaac704ff1f597","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently in container build check job running against"},{"line_number":10,"context_line":"kolla project pulls kolla rhel8 patch and is rebased against"},{"line_number":11,"context_line":"upstream master."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Where Kolla patch against which job is triggered never applied"},{"line_number":14,"context_line":"due to upstream master. Zuul always sets the local master branch"},{"line_number":15,"context_line":"with the patch under test, so it needs to rebase against origin"},{"line_number":16,"context_line":"master instead of upstream master."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7faddb67_0bd49ae8","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":20},"updated":"2019-08-12 07:17:02.000000000","message":"sorry i have no idea what this sentence means.","commit_id":"b58e00bc90c41e047ae14672615391ce065bd52f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fad17a75fc7963038ac77bf68daaac704ff1f597","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Where Kolla patch against which job is triggered never applied"},{"line_number":14,"context_line":"due to upstream master. Zuul always sets the local master branch"},{"line_number":15,"context_line":"with the patch under test, so it needs to rebase against origin"},{"line_number":16,"context_line":"master instead of upstream master."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iec836b6fa3748fca0000b77576388cc31f7e6016"},{"line_number":19,"context_line":"Signed-off-by: Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7faddb67_ab04667f","line":16,"updated":"2019-08-12 07:17:02.000000000","message":"can you please revisit that paragraph it is very hard to understand. Most I got was \"we need to rebase against origin, not upstream master\".  But what is origin and what is master please that isn\u0027t clear to me either.\n\n\ndo we need a bug for it? i mean does it explode? isn\u0027t clear for me.","commit_id":"b58e00bc90c41e047ae14672615391ce065bd52f"}],"roles/build-containers/tasks/main.yaml":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"188ce5ba4d746322adc054a766e3d13985f2d0b0","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Look for Kolla changes running in check queue and if present then"},{"line_number":75,"context_line":"    # set the git origin to origin as kolla changes are already clonned"},{"line_number":76,"context_line":"    # and master is resetted by zuul otherwise use upstream as a origin."},{"line_number":77,"context_line":"    if [ $(git ls-remote https://review.opendev.org/openstack/kolla | grep {{ zuul.ref }} | wc -l) -eq 1 ]; then"},{"line_number":78,"context_line":"        git_change\u003d{{ zuul.ref }}"},{"line_number":79,"context_line":"    else"},{"line_number":80,"context_line":"        git_chnage\u003d{{ branch_override|default(\u0027master\u0027) }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_cb9682f0","line":77,"range":{"start_line":77,"start_character":78,"end_line":77,"end_character":86},"updated":"2019-08-12 07:33:01.000000000","message":"using zuul.ref may lead to issues(checkout of master branch) in non master periodic jobs atleast.","commit_id":"b58e00bc90c41e047ae14672615391ce065bd52f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fad17a75fc7963038ac77bf68daaac704ff1f597","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Look for Kolla changes running in check queue and if present then"},{"line_number":75,"context_line":"    # set the git origin to origin as kolla changes are already clonned"},{"line_number":76,"context_line":"    # and master is resetted by zuul otherwise use upstream as a origin."},{"line_number":77,"context_line":"    if [ $(git ls-remote https://review.opendev.org/openstack/kolla | grep {{ zuul.ref }} | wc -l) -eq 1 ]; then"},{"line_number":78,"context_line":"        git_change\u003d{{ zuul.ref }}"},{"line_number":79,"context_line":"    else"},{"line_number":80,"context_line":"        git_chnage\u003d{{ branch_override|default(\u0027master\u0027) }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_ab29c6f2","line":77,"range":{"start_line":77,"start_character":82,"end_line":77,"end_character":83},"updated":"2019-08-12 07:17:02.000000000","message":"where does zuul.ref come from are we setting it or is it zuul var? is it that \" ref: refs/changes/63/675563/6 \" for example in https://logs.opendev.org/63/675563/6/check/tripleo-build-containers-centos-7/3f2b649/zuul-info/inventory.yaml","commit_id":"b58e00bc90c41e047ae14672615391ce065bd52f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fad17a75fc7963038ac77bf68daaac704ff1f597","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Look for Kolla changes running in check queue and if present then"},{"line_number":75,"context_line":"    # set the git origin to origin as kolla changes are already clonned"},{"line_number":76,"context_line":"    # and master is resetted by zuul otherwise use upstream as a origin."},{"line_number":77,"context_line":"    if [ $(git ls-remote https://review.opendev.org/openstack/kolla | grep {{ zuul.ref }} | wc -l) -eq 1 ]; then"},{"line_number":78,"context_line":"        git_change\u003d{{ zuul.ref }}"},{"line_number":79,"context_line":"    else"},{"line_number":80,"context_line":"        git_chnage\u003d{{ branch_override|default(\u0027master\u0027) }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_4b38523a","line":77,"range":{"start_line":77,"start_character":93,"end_line":77,"end_character":102},"updated":"2019-08-12 07:17:02.000000000","message":"why are you doing wc -l -eq 1 there? \n\n[m@192 ~]$ if git ls-remote https://review.opendev.org/openstack/kolla | grep refs/changes/63/675563 ; then echo \"weew\"; fi\n[m@192 ~]$ if git ls-remote https://review.opendev.org/openstack/kolla | grep refs/changes/99/556699/1 ; then echo \"weew\"; fi\n9be6b0a0e97e7a9edeae84370fdcac60f2c02e38\trefs/changes/99/556699/1\nweew\n[m@192 ~]$","commit_id":"b58e00bc90c41e047ae14672615391ce065bd52f"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"7f317bacfe19774edb29030dead39d658859a582","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Look for Kolla changes running in check queue and if present then"},{"line_number":75,"context_line":"    # set the git origin to origin as kolla changes are already clonned"},{"line_number":76,"context_line":"    # and master is resetted by zuul otherwise use upstream as a origin."},{"line_number":77,"context_line":"    if [ $(git ls-remote https://review.opendev.org/openstack/kolla | grep {{ zuul.ref }} | wc -l) -eq 1 ]; then"},{"line_number":78,"context_line":"        git_change\u003d{{ zuul.ref }}"},{"line_number":79,"context_line":"    else"},{"line_number":80,"context_line":"        git_chnage\u003d{{ branch_override|default(\u0027master\u0027) }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_c73ad8cb","line":77,"range":{"start_line":77,"start_character":93,"end_line":77,"end_character":102},"in_reply_to":"7faddb67_4b38523a","updated":"2019-08-13 13:28:12.000000000","message":"why are you doing wc -l -eq 1 there? \n- to check whether the ref change is there in git remote-ls output ot not","commit_id":"b58e00bc90c41e047ae14672615391ce065bd52f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c6f5284ebe36a301e18c136835adf14e80a973df","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Look for Kolla changes running in check queue and if present then"},{"line_number":75,"context_line":"    # set the git origin to origin as kolla changes are already clonned"},{"line_number":76,"context_line":"    # and master is resetted by zuul otherwise use upstream as a origin."},{"line_number":77,"context_line":"    if [ $(git ls-remote https://review.opendev.org/openstack/kolla | grep {{ zuul.ref }} | wc -l) -eq 1 ]; then"},{"line_number":78,"context_line":"        git_change\u003d{{ zuul.ref }}"},{"line_number":79,"context_line":"    else"},{"line_number":80,"context_line":"        git_chnage\u003d{{ branch_override|default(\u0027master\u0027) }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_2f47f7be","line":77,"range":{"start_line":77,"start_character":93,"end_line":77,"end_character":102},"in_reply_to":"7faddb67_c73ad8cb","updated":"2019-08-14 05:42:43.000000000","message":"yeah but it was unneccessary... i see you made the right change after v9 though","commit_id":"b58e00bc90c41e047ae14672615391ce065bd52f"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"188ce5ba4d746322adc054a766e3d13985f2d0b0","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    if [ $(git ls-remote https://review.opendev.org/openstack/kolla | grep {{ zuul.ref }} | wc -l) -eq 1 ]; then"},{"line_number":78,"context_line":"        git_change\u003d{{ zuul.ref }}"},{"line_number":79,"context_line":"    else"},{"line_number":80,"context_line":"        git_chnage\u003d{{ branch_override|default(\u0027master\u0027) }}"},{"line_number":81,"context_line":"    fi"},{"line_number":82,"context_line":"    git pull --rebase upstream $git_change"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_2b263618","line":80,"range":{"start_line":80,"start_character":12,"end_line":80,"end_character":17},"updated":"2019-08-12 07:33:01.000000000","message":"change","commit_id":"b58e00bc90c41e047ae14672615391ce065bd52f"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"7f317bacfe19774edb29030dead39d658859a582","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    if [ $(git ls-remote https://review.opendev.org/openstack/kolla | grep {{ zuul.ref }} | wc -l) -eq 1 ]; then"},{"line_number":78,"context_line":"        git_change\u003d{{ zuul.ref }}"},{"line_number":79,"context_line":"    else"},{"line_number":80,"context_line":"        git_chnage\u003d{{ branch_override|default(\u0027master\u0027) }}"},{"line_number":81,"context_line":"    fi"},{"line_number":82,"context_line":"    git pull --rebase upstream $git_change"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_e73594dc","line":80,"range":{"start_line":80,"start_character":12,"end_line":80,"end_character":17},"in_reply_to":"7faddb67_2b263618","updated":"2019-08-13 13:28:12.000000000","message":"Done","commit_id":"b58e00bc90c41e047ae14672615391ce065bd52f"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"87ee7aa61e872cfd2d8f89faded05fee07117792","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Look for Kolla changes running in check queue and if present then"},{"line_number":75,"context_line":"    # set the git_rebase branch as kolla change as are already clonned and"},{"line_number":76,"context_line":"    # can be grabbed from zuul.ref var otherwise use master."},{"line_number":77,"context_line":"    {% if {{ zuul.ref }} and {{ zuul.pipeline}} \u003d\u003d \u0027check\u0027 %}"},{"line_number":78,"context_line":"        if [ $(git ls-remote https://review.opendev.org/openstack/kolla | grep {{ zuul.ref }} | wc -l) -eq 1 ]; then"},{"line_number":79,"context_line":"            git_rebase_branch\u003d{{ zuul.ref }}"},{"line_number":80,"context_line":"        fi"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_b94fc4bc","line":77,"range":{"start_line":77,"start_character":13,"end_line":77,"end_character":24},"updated":"2019-08-13 14:41:07.000000000","message":"if zuul.ref is defined ..","commit_id":"d35c6b7fc1702bb370571a69056b8911449e16a9"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"87ee7aa61e872cfd2d8f89faded05fee07117792","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Look for Kolla changes running in check queue and if present then"},{"line_number":75,"context_line":"    # set the git_rebase branch as kolla change as are already clonned and"},{"line_number":76,"context_line":"    # can be grabbed from zuul.ref var otherwise use master."},{"line_number":77,"context_line":"    {% if {{ zuul.ref }} and {{ zuul.pipeline}} \u003d\u003d \u0027check\u0027 %}"},{"line_number":78,"context_line":"        if [ $(git ls-remote https://review.opendev.org/openstack/kolla | grep {{ zuul.ref }} | wc -l) -eq 1 ]; then"},{"line_number":79,"context_line":"            git_rebase_branch\u003d{{ zuul.ref }}"},{"line_number":80,"context_line":"        fi"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_1905b87a","line":77,"range":{"start_line":77,"start_character":52,"end_line":77,"end_character":58},"updated":"2019-08-13 14:41:07.000000000","message":"or openstack-check","commit_id":"d35c6b7fc1702bb370571a69056b8911449e16a9"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"87ee7aa61e872cfd2d8f89faded05fee07117792","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Look for Kolla changes running in check queue and if present then"},{"line_number":75,"context_line":"    # set the git_rebase branch as kolla change as are already clonned and"},{"line_number":76,"context_line":"    # can be grabbed from zuul.ref var otherwise use master."},{"line_number":77,"context_line":"    {% if {{ zuul.ref }} and {{ zuul.pipeline}} \u003d\u003d \u0027check\u0027 %}"},{"line_number":78,"context_line":"        if [ $(git ls-remote https://review.opendev.org/openstack/kolla | grep {{ zuul.ref }} | wc -l) -eq 1 ]; then"},{"line_number":79,"context_line":"            git_rebase_branch\u003d{{ zuul.ref }}"},{"line_number":80,"context_line":"        fi"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_79bf0caa","line":77,"range":{"start_line":77,"start_character":10,"end_line":77,"end_character":13},"updated":"2019-08-13 14:41:07.000000000","message":"you don\u0027t need {{ }} inside conditions","commit_id":"d35c6b7fc1702bb370571a69056b8911449e16a9"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9781682e13009add9afd983d2f2e51bab15b84ed","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Look for Kolla changes running in check queue and if present then"},{"line_number":75,"context_line":"    # set the git_rebase branch as kolla change as are already clonned and"},{"line_number":76,"context_line":"    # can be grabbed from zuul.ref var otherwise use master."},{"line_number":77,"context_line":"    {% if {{ zuul.ref }} and {{ zuul.pipeline}} \u003d\u003d \u0027check\u0027 %}"},{"line_number":78,"context_line":"        if [ $(git ls-remote https://review.opendev.org/openstack/kolla | grep {{ zuul.ref }} | wc -l) -eq 1 ]; then"},{"line_number":79,"context_line":"            git_rebase_branch\u003d{{ zuul.ref }}"},{"line_number":80,"context_line":"        fi"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_92cf3d56","line":77,"range":{"start_line":77,"start_character":52,"end_line":77,"end_character":58},"in_reply_to":"7faddb67_1905b87a","updated":"2019-08-13 16:15:26.000000000","message":"Done","commit_id":"d35c6b7fc1702bb370571a69056b8911449e16a9"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9781682e13009add9afd983d2f2e51bab15b84ed","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Look for Kolla changes running in check queue and if present then"},{"line_number":75,"context_line":"    # set the git_rebase branch as kolla change as are already clonned and"},{"line_number":76,"context_line":"    # can be grabbed from zuul.ref var otherwise use master."},{"line_number":77,"context_line":"    {% if {{ zuul.ref }} and {{ zuul.pipeline}} \u003d\u003d \u0027check\u0027 %}"},{"line_number":78,"context_line":"        if [ $(git ls-remote https://review.opendev.org/openstack/kolla | grep {{ zuul.ref }} | wc -l) -eq 1 ]; then"},{"line_number":79,"context_line":"            git_rebase_branch\u003d{{ zuul.ref }}"},{"line_number":80,"context_line":"        fi"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_52d9c51f","line":77,"range":{"start_line":77,"start_character":13,"end_line":77,"end_character":24},"in_reply_to":"7faddb67_b94fc4bc","updated":"2019-08-13 16:15:26.000000000","message":"Done","commit_id":"d35c6b7fc1702bb370571a69056b8911449e16a9"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"87ee7aa61e872cfd2d8f89faded05fee07117792","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    # set the git_rebase branch as kolla change as are already clonned and"},{"line_number":76,"context_line":"    # can be grabbed from zuul.ref var otherwise use master."},{"line_number":77,"context_line":"    {% if {{ zuul.ref }} and {{ zuul.pipeline}} \u003d\u003d \u0027check\u0027 %}"},{"line_number":78,"context_line":"        if [ $(git ls-remote https://review.opendev.org/openstack/kolla | grep {{ zuul.ref }} | wc -l) -eq 1 ]; then"},{"line_number":79,"context_line":"            git_rebase_branch\u003d{{ zuul.ref }}"},{"line_number":80,"context_line":"        fi"},{"line_number":81,"context_line":"    {% else %}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_f9369c51","line":78,"range":{"start_line":78,"start_character":93,"end_line":78,"end_character":108},"updated":"2019-08-13 14:41:07.000000000","message":"if you check just existence, you don\u0027t need this.\njust\nif grep -q \"pattern\" file; then ... fi\nor\nif git ls-remote https://review.opendev.org/openstack/kolla | grep -q {{ zuul.ref }}; then ...\n\nif you need to count, just \"grep -c\"","commit_id":"d35c6b7fc1702bb370571a69056b8911449e16a9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c6f5284ebe36a301e18c136835adf14e80a973df","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    # set the git_rebase branch as kolla change as are already clonned and"},{"line_number":76,"context_line":"    # can be grabbed from zuul.ref var otherwise use master."},{"line_number":77,"context_line":"    {% if {{ zuul.ref }} and {{ zuul.pipeline}} \u003d\u003d \u0027check\u0027 %}"},{"line_number":78,"context_line":"        if [ $(git ls-remote https://review.opendev.org/openstack/kolla | grep {{ zuul.ref }} | wc -l) -eq 1 ]; then"},{"line_number":79,"context_line":"            git_rebase_branch\u003d{{ zuul.ref }}"},{"line_number":80,"context_line":"        fi"},{"line_number":81,"context_line":"    {% else %}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_af33e761","line":78,"range":{"start_line":78,"start_character":93,"end_line":78,"end_character":108},"in_reply_to":"7faddb67_72d401ea","updated":"2019-08-14 05:42:43.000000000","message":":) that is what i commented on v6 (https://review.opendev.org/#/c/675563/6..12/roles/build-containers/tasks/main.yaml ) but seems you missed it ;)","commit_id":"d35c6b7fc1702bb370571a69056b8911449e16a9"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9781682e13009add9afd983d2f2e51bab15b84ed","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    # set the git_rebase branch as kolla change as are already clonned and"},{"line_number":76,"context_line":"    # can be grabbed from zuul.ref var otherwise use master."},{"line_number":77,"context_line":"    {% if {{ zuul.ref }} and {{ zuul.pipeline}} \u003d\u003d \u0027check\u0027 %}"},{"line_number":78,"context_line":"        if [ $(git ls-remote https://review.opendev.org/openstack/kolla | grep {{ zuul.ref }} | wc -l) -eq 1 ]; then"},{"line_number":79,"context_line":"            git_rebase_branch\u003d{{ zuul.ref }}"},{"line_number":80,"context_line":"        fi"},{"line_number":81,"context_line":"    {% else %}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_72d401ea","line":78,"range":{"start_line":78,"start_character":93,"end_line":78,"end_character":108},"in_reply_to":"7faddb67_f9369c51","updated":"2019-08-13 16:15:26.000000000","message":"Done","commit_id":"d35c6b7fc1702bb370571a69056b8911449e16a9"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"dc12578bc229195a6f0a21b57a30378ea08c527b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Look for Kolla changes running in check queue and if present then"},{"line_number":75,"context_line":"    # set the git_rebase branch as kolla change as are already clonned and"},{"line_number":76,"context_line":"    # can be grabbed from zuul.ref var otherwise use master."},{"line_number":77,"context_line":"    {% if zuul.ref and zuul.pipeline \u003d\u003d \u0027check\u0027 %}"},{"line_number":78,"context_line":"        if [ $(git ls-remote https://review.opendev.org/openstack/kolla | grep {{ zuul.ref }} | wc -l) -eq 1 ]; then"},{"line_number":79,"context_line":"            git_rebase_branch\u003d{{ zuul.ref }}"},{"line_number":80,"context_line":"        fi"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7faddb67_f9ebfc74","line":77,"range":{"start_line":77,"start_character":23,"end_line":77,"end_character":48},"updated":"2019-08-13 14:41:45.000000000","message":"please see my comments to previous patch","commit_id":"017263cab264015fd46d4fc7a664bfa7dbfbc5c0"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"3a75d8ffabc297243ff57e534ab7c81a940e9f57","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    # set the git_rebase branch as kolla change as are already clonned and"},{"line_number":76,"context_line":"    # can be grabbed from zuul.ref var otherwise use master."},{"line_number":77,"context_line":"    {% if zuul.ref is defined and zuul.pipeline in [\u0027check\u0027, \u0027openstack-check\u0027] %}"},{"line_number":78,"context_line":"        if git ls-remote https://review.opendev.org/openstack/kolla | grep -q {{ zuul.ref }} ; then"},{"line_number":79,"context_line":"            git_rebase_branch\u003d{{ zuul.ref }}"},{"line_number":80,"context_line":"        fi"},{"line_number":81,"context_line":"    {% else %}"},{"line_number":82,"context_line":"        git_rebase_branch\u003d{{ branch_override|default(\u0027master\u0027) }}"},{"line_number":83,"context_line":"    {% endif %}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_0d16ce56","line":80,"range":{"start_line":78,"start_character":8,"end_line":80,"end_character":10},"updated":"2019-08-13 17:32:01.000000000","message":"if this condition is false, git_rebase_branch is undefined","commit_id":"8323b468a0c8fb755afdce7001471e29dd9f53ea"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"337a9d274a87e94acb3cee470b3c219dbc82e123","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    # set the git_rebase branch as kolla change as are already clonned and"},{"line_number":76,"context_line":"    # can be grabbed from zuul.ref var otherwise use master."},{"line_number":77,"context_line":"    {% if zuul.ref is defined and zuul.pipeline in [\u0027check\u0027, \u0027openstack-check\u0027] %}"},{"line_number":78,"context_line":"        if git ls-remote https://review.opendev.org/openstack/kolla | grep -q {{ zuul.ref }} ; then"},{"line_number":79,"context_line":"            git_rebase_branch\u003d{{ zuul.ref }}"},{"line_number":80,"context_line":"        fi"},{"line_number":81,"context_line":"    {% else %}"},{"line_number":82,"context_line":"        git_rebase_branch\u003d{{ branch_override|default(\u0027master\u0027) }}"},{"line_number":83,"context_line":"    {% endif %}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_4886f467","line":80,"range":{"start_line":78,"start_character":8,"end_line":80,"end_character":10},"in_reply_to":"7faddb67_0d16ce56","updated":"2019-08-13 17:38:25.000000000","message":"Done","commit_id":"8323b468a0c8fb755afdce7001471e29dd9f53ea"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"3a75d8ffabc297243ff57e534ab7c81a940e9f57","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            git_rebase_branch\u003d{{ zuul.ref }}"},{"line_number":80,"context_line":"        fi"},{"line_number":81,"context_line":"    {% else %}"},{"line_number":82,"context_line":"        git_rebase_branch\u003d{{ branch_override|default(\u0027master\u0027) }}"},{"line_number":83,"context_line":"    {% endif %}"},{"line_number":84,"context_line":"    git pull --rebase upstream $git_rebase_branch"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_6d066223","line":82,"range":{"start_line":82,"start_character":8,"end_line":82,"end_character":65},"updated":"2019-08-13 17:32:01.000000000","message":"maybe it should be in \"else\" of bash \"if\" above?","commit_id":"8323b468a0c8fb755afdce7001471e29dd9f53ea"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"337a9d274a87e94acb3cee470b3c219dbc82e123","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            git_rebase_branch\u003d{{ zuul.ref }}"},{"line_number":80,"context_line":"        fi"},{"line_number":81,"context_line":"    {% else %}"},{"line_number":82,"context_line":"        git_rebase_branch\u003d{{ branch_override|default(\u0027master\u0027) }}"},{"line_number":83,"context_line":"    {% endif %}"},{"line_number":84,"context_line":"    git pull --rebase upstream $git_rebase_branch"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_e87c8073","line":82,"range":{"start_line":82,"start_character":8,"end_line":82,"end_character":65},"in_reply_to":"7faddb67_6d066223","updated":"2019-08-13 17:38:25.000000000","message":"Done","commit_id":"8323b468a0c8fb755afdce7001471e29dd9f53ea"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"425d108962b1729054ee7d06359bab0d0111b59c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Look for Kolla changes running in check queue and if present then"},{"line_number":75,"context_line":"    # set the git_rebase branch as kolla change as are already clonned and"},{"line_number":76,"context_line":"    # can be grabbed from zuul.ref var otherwise use master."},{"line_number":77,"context_line":"    {% if zuul.ref is defined and zuul.pipeline in [\u0027check\u0027, \u0027openstack-check\u0027] %}"},{"line_number":78,"context_line":"        if git ls-remote https://review.opendev.org/openstack/kolla | grep -q {{ zuul.ref }} ; then"},{"line_number":79,"context_line":"            git_rebase_branch\u003d{{ zuul.ref }}"},{"line_number":80,"context_line":"        else"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_40c48840","line":77,"range":{"start_line":77,"start_character":4,"end_line":77,"end_character":82},"updated":"2019-08-13 20:43:07.000000000","message":"if this is false, we again don\u0027t have $git_rebase_branch defined\n\nlet\u0027s do something like:\n\ngit_rebase_branch\u003d{{ branch_override|default(\u0027master\u0027) }}\n{% if zuul.ref is defined and zuul.pipeline in [\u0027check\u0027, \u0027openstack-check\u0027] %}\nif git ls-remote https://review.opendev.org/openstack/kolla | grep -q {{ zuul.ref }} ; then\n            git_rebase_branch\u003d{{ zuul.ref }}\nfi\n{% endif %}","commit_id":"58ec794517218fb5cae5acfce6634a5a1578de23"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"4b138ed10cf8f08d27c402e3efb9d9ca729dfa23","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Look for Kolla changes running in check queue and if present then"},{"line_number":75,"context_line":"    # set the git_rebase branch as kolla change as are already clonned and"},{"line_number":76,"context_line":"    # can be grabbed from zuul.ref var otherwise use master."},{"line_number":77,"context_line":"    {% if zuul.ref is defined and zuul.pipeline in [\u0027check\u0027, \u0027openstack-check\u0027] %}"},{"line_number":78,"context_line":"        if git ls-remote https://review.opendev.org/openstack/kolla | grep -q {{ zuul.ref }} ; then"},{"line_number":79,"context_line":"            git_rebase_branch\u003d{{ zuul.ref }}"},{"line_number":80,"context_line":"        else"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_0f623bae","line":77,"range":{"start_line":77,"start_character":4,"end_line":77,"end_character":82},"in_reply_to":"7faddb67_40c48840","updated":"2019-08-14 04:44:39.000000000","message":"Done","commit_id":"58ec794517218fb5cae5acfce6634a5a1578de23"}]}