)]}'
{"scripts/emit_releases_file/emit_releases_file.py":[{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"61ec198e7251cc72f3aec797911f20551ee99ccc","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    \"\"\""},{"line_number":91,"context_line":"    logger \u003d logging.getLogger(\u0027emit-releases\u0027)"},{"line_number":92,"context_line":"    full_hash_pattern \u003d re.compile(\u0027[a-z,0-9]{40}_[a-z,0-9]{8}\u0027)"},{"line_number":93,"context_line":"    repo_url \u003d (\u0027https://trunk.rdoproject.org/centos7-%s/%s/delorean.repo\u0027 %"},{"line_number":94,"context_line":"                (release, hash_name))"},{"line_number":95,"context_line":"    for retry_num in range(retries):"},{"line_number":96,"context_line":"        repo_file \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_684730be","line":93,"range":{"start_line":93,"start_character":17,"end_line":93,"end_character":45},"updated":"2019-08-13 17:52:58.000000000","message":"this should be using $NODEPOOL_RDO_PROXY as it is elsewhere in tripleo-ci","commit_id":"6c753e399f1418598fc896e1eeecb3f810c7404f"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"1ac49d82e95e96fa51efb7f22a6e3fbec27e5c33","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    \"\"\""},{"line_number":91,"context_line":"    logger \u003d logging.getLogger(\u0027emit-releases\u0027)"},{"line_number":92,"context_line":"    full_hash_pattern \u003d re.compile(\u0027[a-z,0-9]{40}_[a-z,0-9]{8}\u0027)"},{"line_number":93,"context_line":"    repo_url \u003d (\u0027https://trunk.rdoproject.org/centos7-%s/%s/delorean.repo\u0027 %"},{"line_number":94,"context_line":"                (release, hash_name))"},{"line_number":95,"context_line":"    for retry_num in range(retries):"},{"line_number":96,"context_line":"        repo_file \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_a021bcfe","line":93,"range":{"start_line":93,"start_character":17,"end_line":93,"end_character":45},"in_reply_to":"7faddb67_684730be","updated":"2019-08-13 20:54:57.000000000","message":"will add that in a following review","commit_id":"6c753e399f1418598fc896e1eeecb3f810c7404f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c1343a6db68499b018a100b03e51f16a11ca66cf","unresolved":false,"context_lines":[{"line_number":50,"context_line":"NEWEST_HASH_NAME \u003d \u0027current\u0027"},{"line_number":51,"context_line":"PROMOTION_HASH_NAME \u003d \u0027tripleo-ci-testing\u0027"},{"line_number":52,"context_line":"PREVIOUS_HASH_NAME \u003d \u0027previous-current-tripleo\u0027"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def get_relative_release(release, relative_idx):"},{"line_number":56,"context_line":"    current_idx \u003d RELEASES.index(release)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_4f703309","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":0},"updated":"2019-08-14 05:49:30.000000000","message":"worth adding RETRIES \u003d and TIMEOUT \u003d ?","commit_id":"eb1235fccdd9fbbdabcff90404ea8154e14b778f"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"8d32b063929b0523ca7de4690cf6889e1f076638","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    return featureset"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"def get_dlrn_hash(release, hash_name, retries\u003d20, timeout\u003d8):"},{"line_number":84,"context_line":"    \"\"\"Get the dlrn hash for the release and hash name"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    Retrieves the delorean.repo for the provided release and hash name, e.g."}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_bbeb2676","line":83,"range":{"start_line":83,"start_character":38,"end_line":83,"end_character":61},"updated":"2019-08-14 13:07:54.000000000","message":"Agree with Marios, I think it\u0027s worth to parametrize","commit_id":"eb1235fccdd9fbbdabcff90404ea8154e14b778f"}],"scripts/emit_releases_file/test_get_dlrn_hash.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c1343a6db68499b018a100b03e51f16a11ca66cf","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    repo_url \u003d (\u0027https://trunk.rdoproject.org/centos7-%s/%s/delorean.repo\u0027 %"},{"line_number":31,"context_line":"                (release, hash_name))"},{"line_number":32,"context_line":"    assert get_dlrn_hash(release, hash_name) \u003d\u003d dlrn_hash"},{"line_number":33,"context_line":"    mock_get.assert_called_once_with(repo_url, timeout\u003d8)"},{"line_number":34,"context_line":"    mock_log_info.assert_called_once_with(\"Got DLRN hash: {} for the named \""},{"line_number":35,"context_line":"                                          \"hash: {} on the {} \""},{"line_number":36,"context_line":"                                          \"release\".format(dlrn_hash,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_0f647b48","line":33,"range":{"start_line":33,"start_character":55,"end_line":33,"end_character":57},"updated":"2019-08-14 05:49:30.000000000","message":"this would be much easier if the timeout or retries were parameters/constants - e.g. defined at","commit_id":"eb1235fccdd9fbbdabcff90404ea8154e14b778f"}]}