)]}'
{"roles/run-test/tasks/main.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3d9bc6b2e36d94cadbe37990318049779682506e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  - name: Include some extra for generating toci scripts"},{"line_number":56,"context_line":"    set_fact:"},{"line_number":57,"context_line":"      extra_vars: \"--extra-vars @{{ tripleo_root }}/tripleo-ci/featureset-override.yaml\""},{"line_number":58,"context_line":"  when: featureset_override is defined and featureset_override|bool"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- name: render toci_gate_test script"},{"line_number":61,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_8c1a946c","line":58,"updated":"2019-09-13 06:09:26.000000000","message":"i mean we could also consider making the reproducer not set none there but this makes sense as a change anyway","commit_id":"65c963b6c429b7d7bbe6f327826636723aaa4369"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"709fbfba675e0c2715d702aa4fd95876fb6bf317","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  - name: Include some extra for generating toci scripts"},{"line_number":56,"context_line":"    set_fact:"},{"line_number":57,"context_line":"      extra_vars: \"--extra-vars @{{ tripleo_root }}/tripleo-ci/featureset-override.yaml\""},{"line_number":58,"context_line":"  when: featureset_override is defined and featureset_override|bool"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- name: render toci_gate_test script"},{"line_number":61,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_5adaea4a","line":58,"range":{"start_line":58,"start_character":63,"end_line":58,"end_character":67},"updated":"2019-09-16 08:18:25.000000000","message":"just a thought but wondering if \u0027length\u0027 is the more appropriate filter ... featureset_override is gonne be a set of vars: values or none in the bug case. i think |length will also catch the none/\u0027\u0027 case.\n\nno revote just came back here for my monday morning routing ;D","commit_id":"65c963b6c429b7d7bbe6f327826636723aaa4369"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"86851cd5d4468c69f0e9985bb397273849988285","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  - name: Include some extra for generating toci scripts"},{"line_number":56,"context_line":"    set_fact:"},{"line_number":57,"context_line":"      extra_vars: \"--extra-vars @{{ tripleo_root }}/tripleo-ci/featureset-override.yaml\""},{"line_number":58,"context_line":"  when: featureset_override is defined and featureset_override|bool"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- name: render toci_gate_test script"},{"line_number":61,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_995fbd74","line":58,"range":{"start_line":58,"start_character":63,"end_line":58,"end_character":67},"in_reply_to":"3fa7e38b_4413aeb9","updated":"2019-10-18 09:53:56.000000000","message":"This has caused issues, featureset-override not working now. example failure:- https://logs.rdoproject.org/30/682630/7/openstack-check/tripleo-ci-rhel-8-scenario001-standalone-rdo/79f3bc6/job-output.txt,, some jobs in the patch itself have failed due to it.","commit_id":"65c963b6c429b7d7bbe6f327826636723aaa4369"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"db52139c93274f8d365808859dfd1ecf5e9d6bfe","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  - name: Include some extra for generating toci scripts"},{"line_number":56,"context_line":"    set_fact:"},{"line_number":57,"context_line":"      extra_vars: \"--extra-vars @{{ tripleo_root }}/tripleo-ci/featureset-override.yaml\""},{"line_number":58,"context_line":"  when: featureset_override is defined and featureset_override|bool"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- name: render toci_gate_test script"},{"line_number":61,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_4413aeb9","line":58,"range":{"start_line":58,"start_character":63,"end_line":58,"end_character":67},"in_reply_to":"5faad753_5adaea4a","updated":"2019-09-16 14:54:03.000000000","message":"|bool is actually recommended way in ansible, I think it\u0027s fine to have it so. It will catch empty dictionary and empty variable","commit_id":"65c963b6c429b7d7bbe6f327826636723aaa4369"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"d4cf1b39cbb0060fbed7860c3cf98647b5158356","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  - name: Include some extra for generating toci scripts"},{"line_number":56,"context_line":"    set_fact:"},{"line_number":57,"context_line":"      extra_vars: \"--extra-vars @{{ tripleo_root }}/tripleo-ci/featureset-override.yaml\""},{"line_number":58,"context_line":"  when: featureset_override is defined and featureset_override|bool"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- name: render toci_gate_test script"},{"line_number":61,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_86b491d2","line":58,"in_reply_to":"5faad753_8c1a946c","updated":"2019-09-15 22:20:28.000000000","message":"I started with that, but its template driven with a bunch of conditionionals, so its hard","commit_id":"65c963b6c429b7d7bbe6f327826636723aaa4369"}]}