)]}'
{"roles/oooci-build-images/templates/build-images.sh.j2":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"a4e3d3c6c4dd1e1c79e5e3de210c1514dbb5e619","unresolved":false,"context_lines":[{"line_number":30,"context_line":"export DIB_LOCAL_IMAGE\u003d{{ dib_local_image }}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# disable selinux rhel8 build https://bugs.launchpad.net/tripleo/+bug/1853028"},{"line_number":33,"context_line":"sudo setenforce 0"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{% endif %}"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_ba714e48","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":17},"updated":"2019-12-16 08:29:28.000000000","message":"I would do something like this:\ndib_disable_selinux: true https://opendev.org/openstack/tripleo-ci/src/branch/master/roles/oooci-build-images/vars/main.yaml#L2\n\nthen here itself we can add,\n{% if dib_selinux_disable |bool %}\nsudo setenforce 0\n{% endif %}\n\nCurrently this role is used in upstream only but if in future it will be used in downstream then we can just disbale this flag and it will work.","commit_id":"825bf3ff361263b418223289c3504c3b439c62eb"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"428e55c59d10908bf5667f7707ba3baccd16bf5d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"export DIB_LOCAL_IMAGE\u003d{{ dib_local_image }}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# disable selinux rhel8 build https://bugs.launchpad.net/tripleo/+bug/1853028"},{"line_number":33,"context_line":"sudo setenforce 0"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{% endif %}"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_fafd863c","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":17},"in_reply_to":"3fa7e38b_ba714e48","updated":"2019-12-16 09:14:18.000000000","message":"Done","commit_id":"825bf3ff361263b418223289c3504c3b439c62eb"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"95fc230648343739a9ce6cf94ddd6fdebb5283ab","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{% endif %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% if dib_selinux_enabled|bool is False %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# disable selinux rhel8 build https://bugs.launchpad.net/tripleo/+bug/1853028"},{"line_number":37,"context_line":"sudo setenforce 0"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_150ab31d","line":34,"range":{"start_line":34,"start_character":3,"end_line":34,"end_character":39},"updated":"2019-12-16 08:56:18.000000000","message":"it\u0027s boolean, just\n\n{% if dib_selinux_enabled|bool %}","commit_id":"c4ee94ef6cb59b0e9fa76903afb295c5c92aa325"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"428e55c59d10908bf5667f7707ba3baccd16bf5d","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{% endif %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% if dib_selinux_enabled|bool is False %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# disable selinux rhel8 build https://bugs.launchpad.net/tripleo/+bug/1853028"},{"line_number":37,"context_line":"sudo setenforce 0"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_1542b30e","line":34,"range":{"start_line":34,"start_character":3,"end_line":34,"end_character":39},"in_reply_to":"3fa7e38b_150ab31d","updated":"2019-12-16 09:14:18.000000000","message":"yeah but we want the negative of that so !dib_selinux_enabled","commit_id":"c4ee94ef6cb59b0e9fa76903afb295c5c92aa325"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fda5fa73beb83d986636d0062b1c7e613c8c0b1c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"sudo setenforce 0"},{"line_number":38,"context_line":"sudo getenforce"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% endif %}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"{% if dib_node_dist is defined %}"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_96222aa6","line":40,"updated":"2019-12-16 10:47:12.000000000","message":"so it\u0027s still not clear this is the root yet.\n\nwe had a red runs with this in https://review.rdoproject.org/r/#/c/23919/ \n\ni just tried a recheck if we get at least one green without updating anything confirm it isn\u0027t selinux","commit_id":"5ef63d480edeee072ac4a127039ce55c289a2f5c"}],"roles/oooci-build-images/vars/main.yaml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"95fc230648343739a9ce6cf94ddd6fdebb5283ab","unresolved":false,"context_lines":[{"line_number":6,"context_line":"base_image_config:"},{"line_number":7,"context_line":"  py2: overcloud-images.yaml"},{"line_number":8,"context_line":"  py3: overcloud-images-python3.yaml"},{"line_number":9,"context_line":"dib_selinux_enabled: False"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_351c8f65","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":26},"updated":"2019-12-16 08:56:18.000000000","message":"better to have lowercase, it\u0027s yaml, not python","commit_id":"c4ee94ef6cb59b0e9fa76903afb295c5c92aa325"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"428e55c59d10908bf5667f7707ba3baccd16bf5d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"base_image_config:"},{"line_number":7,"context_line":"  py2: overcloud-images.yaml"},{"line_number":8,"context_line":"  py3: overcloud-images-python3.yaml"},{"line_number":9,"context_line":"dib_selinux_enabled: False"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_35548fc6","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":26},"in_reply_to":"3fa7e38b_351c8f65","updated":"2019-12-16 09:14:18.000000000","message":"well i suspect it would work either way, but i took it from https://docs.ansible.com/ansible/latest/user_guide/playbooks_tests.html#tests\n\nand I believe the jinja tests are backed by python?","commit_id":"c4ee94ef6cb59b0e9fa76903afb295c5c92aa325"}]}