)]}'
{"roles/build-containers/tasks/main.yaml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"40c569bb6687b57c37675992db2304e110bcf0bb","unresolved":false,"context_lines":[{"line_number":23,"context_line":"- name: Set excludes for kolla-build.conf for non-x86 arches"},{"line_number":24,"context_line":"  set_fact:"},{"line_number":25,"context_line":"    altarch_excludes:"},{"line_number":26,"context_line":"      dnf: None"},{"line_number":27,"context_line":"      yum:"},{"line_number":28,"context_line":"        - skydive-base"},{"line_number":29,"context_line":"        - skydive-agent"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_9036b1b3","line":26,"range":{"start_line":26,"start_character":12,"end_line":26,"end_character":15},"updated":"2019-12-16 10:10:40.000000000","message":"don\u0027t use None, see comments to vars/main","commit_id":"432e2df0052e3b7840206e2f7d0d8e43b7a3615e"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"6594030400dc85f924b290768f0bd31442d74967","unresolved":false,"context_lines":[{"line_number":23,"context_line":"- name: Set excludes for kolla-build.conf for non-x86 arches"},{"line_number":24,"context_line":"  set_fact:"},{"line_number":25,"context_line":"    altarch_excludes:"},{"line_number":26,"context_line":"      dnf: None"},{"line_number":27,"context_line":"      yum:"},{"line_number":28,"context_line":"        - skydive-base"},{"line_number":29,"context_line":"        - skydive-agent"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_aa1339b7","line":26,"range":{"start_line":26,"start_character":12,"end_line":26,"end_character":15},"in_reply_to":"3fa7e38b_9036b1b3","updated":"2019-12-16 15:04:23.000000000","message":"Done","commit_id":"432e2df0052e3b7840206e2f7d0d8e43b7a3615e"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"40c569bb6687b57c37675992db2304e110bcf0bb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        - skydive-base"},{"line_number":29,"context_line":"        - skydive-agent"},{"line_number":30,"context_line":"        - skydive-analyzer"},{"line_number":31,"context_line":"      rocky: None"},{"line_number":32,"context_line":"  when: ansible_architecture !\u003d \u0027x86_64\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Set arch_tag fact"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_303b3d9c","line":31,"range":{"start_line":31,"start_character":12,"end_line":31,"end_character":17},"updated":"2019-12-16 10:10:40.000000000","message":"ditto\n\nwhy is \"rocky\" here? It\u0027s not a package manager.","commit_id":"432e2df0052e3b7840206e2f7d0d8e43b7a3615e"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"6594030400dc85f924b290768f0bd31442d74967","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        - skydive-base"},{"line_number":29,"context_line":"        - skydive-agent"},{"line_number":30,"context_line":"        - skydive-analyzer"},{"line_number":31,"context_line":"      rocky: None"},{"line_number":32,"context_line":"  when: ansible_architecture !\u003d \u0027x86_64\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Set arch_tag fact"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_0ad5adb8","line":31,"range":{"start_line":31,"start_character":12,"end_line":31,"end_character":17},"in_reply_to":"3fa7e38b_303b3d9c","updated":"2019-12-16 15:04:23.000000000","message":"Will do!\n\nCorrect that it is not a package manager, but it is in the exclude_containers here [0] so I included a section for rocky. Let me know if I\u0027m still wrong on this one!\n\nhttps://github.com/openstack/tripleo-ci/blob/master/roles/build-containers/vars/main.yaml#L23","commit_id":"432e2df0052e3b7840206e2f7d0d8e43b7a3615e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"51254a348388a6c0430e2d97642d40bd123b8e7a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        - skydive-agent"},{"line_number":30,"context_line":"        - skydive-analyzer"},{"line_number":31,"context_line":"      rocky: None"},{"line_number":32,"context_line":"  when: ansible_architecture !\u003d \u0027x86_64\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Set arch_tag fact"},{"line_number":35,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_75ea0778","line":32,"range":{"start_line":32,"start_character":29,"end_line":32,"end_character":31},"updated":"2019-12-16 09:39:35.000000000","message":"\u003d\u003d \u0027ppc64le\u0027","commit_id":"432e2df0052e3b7840206e2f7d0d8e43b7a3615e"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"6594030400dc85f924b290768f0bd31442d74967","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        - skydive-agent"},{"line_number":30,"context_line":"        - skydive-analyzer"},{"line_number":31,"context_line":"      rocky: None"},{"line_number":32,"context_line":"  when: ansible_architecture !\u003d \u0027x86_64\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Set arch_tag fact"},{"line_number":35,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_ea1851ce","line":32,"range":{"start_line":32,"start_character":29,"end_line":32,"end_character":31},"in_reply_to":"3fa7e38b_75ea0778","updated":"2019-12-16 15:04:23.000000000","message":"See comment in vars/main for rationale here. I\u0027m up for making this ppc64le exclusive but skydive is also  unavailable for aarach as I understand it","commit_id":"432e2df0052e3b7840206e2f7d0d8e43b7a3615e"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"47bb342aeedceab64c995bcf134bf075cd08308e","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Set excludes for kolla-build.conf for non-x86 arches"},{"line_number":24,"context_line":"  set_fact:"},{"line_number":25,"context_line":"    altarch_excludes:"},{"line_number":26,"context_line":"      dnf: []"},{"line_number":27,"context_line":"      yum:"},{"line_number":28,"context_line":"        - skydive-base"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_4b5407c7","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":21},"updated":"2019-12-16 16:57:19.000000000","message":"Why do we need a separate list? Can we append to the exclude_containers ??","commit_id":"80a0939e3cbaa229815160d2b9fe611dc5b08947"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"44d53e74922ce7b63c56680ddb01a06d0be06de5","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Set excludes for kolla-build.conf for non-x86 arches"},{"line_number":24,"context_line":"  set_fact:"},{"line_number":25,"context_line":"    altarch_excludes:"},{"line_number":26,"context_line":"      dnf: []"},{"line_number":27,"context_line":"      yum:"},{"line_number":28,"context_line":"        - skydive-base"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_eb95a995","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":21},"in_reply_to":"3fa7e38b_4b5407c7","updated":"2019-12-17 07:35:49.000000000","message":"+1 to what Rafael said.\n\nWill make code easier and do exactly same.","commit_id":"80a0939e3cbaa229815160d2b9fe611dc5b08947"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"42a1167fac12fd9287ba8a6d67f43cbcf5229356","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Set excludes for kolla-build.conf for non-x86 arches"},{"line_number":24,"context_line":"  set_fact:"},{"line_number":25,"context_line":"    altarch_excludes:"},{"line_number":26,"context_line":"      dnf: []"},{"line_number":27,"context_line":"      yum:"},{"line_number":28,"context_line":"        - skydive-base"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_0b62853e","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":21},"in_reply_to":"3fa7e38b_eb95a995","updated":"2019-12-17 08:33:41.000000000","message":"yes they are the same functionally but see comment https://review.opendev.org/#/c/699024/3/roles/build-containers/vars/main.yaml \n\nIf we are going to re-use exclude_containers then we\u0027d have to extend it here not replace (if ppc need to also exclude those)","commit_id":"80a0939e3cbaa229815160d2b9fe611dc5b08947"}],"roles/build-containers/templates/build.sh.j2":[{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"47bb342aeedceab64c995bcf134bf075cd08308e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"openstack overcloud container image build {{ container_config }}\\"},{"line_number":10,"context_line":"    --kolla-config-file {{ workspace }}/kolla-build.conf \\"},{"line_number":11,"context_line":"    {% if ci_branch !\u003d \u0027rocky\u0027 %}"},{"line_number":12,"context_line":"    {% for item in exclude_containers[ansible_pkg_mgr] %}"},{"line_number":13,"context_line":"        --exclude {{ item }} \\"},{"line_number":14,"context_line":"    {% endfor %}"},{"line_number":15,"context_line":"    {% for item in altarch_excludes[ansible_pkg_mgr] %}"},{"line_number":16,"context_line":"        --exclude {{ item }} \\"},{"line_number":17,"context_line":"    {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3fa7e38b_eb4b7325","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":16},"updated":"2019-12-16 16:57:19.000000000","message":"can we use same exclude_containers list?","commit_id":"80a0939e3cbaa229815160d2b9fe611dc5b08947"}],"roles/build-containers/vars/main.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"51254a348388a6c0430e2d97642d40bd123b8e7a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  rocky:"},{"line_number":24,"context_line":"    - grafana"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"altarch_excludes:"},{"line_number":27,"context_line":"  dnf: None"},{"line_number":28,"context_line":"  yum: None"},{"line_number":29,"context_line":"  rocky: None"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_d5465ba8","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":16},"updated":"2019-12-16 09:39:35.000000000","message":"just wondering why not make it explicitly ppc64_excludes?\n\nDoes it apply to other builds? Even if it does we are currently explicitly dealing with ppc64le x86_64 in all other cases here right?","commit_id":"432e2df0052e3b7840206e2f7d0d8e43b7a3615e"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"6594030400dc85f924b290768f0bd31442d74967","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  rocky:"},{"line_number":24,"context_line":"    - grafana"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"altarch_excludes:"},{"line_number":27,"context_line":"  dnf: None"},{"line_number":28,"context_line":"  yum: None"},{"line_number":29,"context_line":"  rocky: None"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_ead131fa","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":16},"in_reply_to":"3fa7e38b_d5465ba8","updated":"2019-12-16 15:04:23.000000000","message":"Good question!\n\nskydive container builds on non-x86 will output something like \"Executable not available for non-x86 hardware\". This means aarch64 would have the same problem.\n\nI\u0027m willing to make this ppc64le_excludes for now if that\u0027s preferred!","commit_id":"432e2df0052e3b7840206e2f7d0d8e43b7a3615e"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"40c569bb6687b57c37675992db2304e110bcf0bb","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    - grafana"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"altarch_excludes:"},{"line_number":27,"context_line":"  dnf: None"},{"line_number":28,"context_line":"  yum: None"},{"line_number":29,"context_line":"  rocky: None"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"timestamper_cmd: \u003e-"},{"line_number":32,"context_line":"    | awk \u0027{ print strftime(\"%Y-%m-%d %H:%M:%S |\"), $0; fflush(); }\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_30c6dd9e","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":13},"updated":"2019-12-16 10:10:40.000000000","message":"why do you use None? according to task you will set:\n            --exclude N \\\n            --exclude o \\\n            --exclude n \\\n            --exclude e \\\n\nhttps://025b8612ea74b6df403c-82c7c26c1c9d82596e9efade16533251.ssl.cf1.rackcdn.com/699024/1/check/tripleo-build-containers-centos-7/8ae00e6/logs/build_containers.sh.txt.gz\n\nin case of iterable you should use [] or \u0027\u0027","commit_id":"432e2df0052e3b7840206e2f7d0d8e43b7a3615e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"46df66b7d1355385e0ff18992eef1f0e1e39598b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    - grafana"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"altarch_excludes:"},{"line_number":27,"context_line":"  dnf: None"},{"line_number":28,"context_line":"  yum: None"},{"line_number":29,"context_line":"  rocky: None"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"timestamper_cmd: \u003e-"},{"line_number":32,"context_line":"    | awk \u0027{ print strftime(\"%Y-%m-%d %H:%M:%S |\"), $0; fflush(); }\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_900471c7","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":13},"in_reply_to":"3fa7e38b_30c6dd9e","updated":"2019-12-16 10:13:52.000000000","message":"ouch revoting  ;)","commit_id":"432e2df0052e3b7840206e2f7d0d8e43b7a3615e"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"6594030400dc85f924b290768f0bd31442d74967","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    - grafana"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"altarch_excludes:"},{"line_number":27,"context_line":"  dnf: None"},{"line_number":28,"context_line":"  yum: None"},{"line_number":29,"context_line":"  rocky: None"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"timestamper_cmd: \u003e-"},{"line_number":32,"context_line":"    | awk \u0027{ print strftime(\"%Y-%m-%d %H:%M:%S |\"), $0; fflush(); }\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_8a251d19","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":13},"in_reply_to":"3fa7e38b_900471c7","updated":"2019-12-16 15:04:23.000000000","message":"Ouch indeed! I wish I could say I had a reason other than ignorance :)\n\nThanks, will set to an empty list!","commit_id":"432e2df0052e3b7840206e2f7d0d8e43b7a3615e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"42a1167fac12fd9287ba8a6d67f43cbcf5229356","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  yum: python"},{"line_number":11,"context_line":"  dnf: python3"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"exclude_containers:"},{"line_number":14,"context_line":"  dnf:"},{"line_number":15,"context_line":"    - fluentd"},{"line_number":16,"context_line":"    - opendaylight"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_8b64354f","line":13,"updated":"2019-12-17 08:33:41.000000000","message":"really this one is x86_64 excludes (or at least its only even applied to x86_64 thus far)\n\nand altarch_excludes is for ppc (or per discussion other archs potentially too).\n\nMy point is to answer folco\u0027s comment, not sure we can merge these two things.\n\nIt depends if we need to also keep what is in exclude_containers for ppc..\n\ni.e. for ppc builds do we need to skip all the exclude_containers stuff , as well as https://review.opendev.org/#/c/699024/3/roles/build-containers/tasks/main.yaml that stuff\n\nIf so yeah we could re-use these vars but in the set_fact for ppc you\u0027d have to extend what\u0027s already in exclude_containers and not just override it","commit_id":"80a0939e3cbaa229815160d2b9fe611dc5b08947"}]}