)]}'
{"roles/oooci-build-images/tasks/pre.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4d6ddbc548220b7c109026af22ab67d93bcf8d38","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  when:"},{"line_number":10,"context_line":"    - rhel_image_source is defined"},{"line_number":11,"context_line":"    - ansible_distribution \u003d\u003d \u0027RedHat\u0027"},{"line_number":12,"context_line":"    - ansible_distribution_major_version \u003e\u003d \u00278\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- when: tripleo_image_source is defined"},{"line_number":15,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"1fa4df85_0f1e280c","line":12,"range":{"start_line":12,"start_character":41,"end_line":12,"end_character":43},"updated":"2020-02-24 10:38:48.000000000","message":"better to use is version(","commit_id":"066b406217843b42cfc5c321621e3b65804ea288"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"a256c3f29582a51a17f7deb706d0e6ab3af03849","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  when:"},{"line_number":10,"context_line":"    - rhel_image_source is defined"},{"line_number":11,"context_line":"    - ansible_distribution \u003d\u003d \u0027RedHat\u0027"},{"line_number":12,"context_line":"    - ansible_distribution_major_version \u003e\u003d \u00278\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- when: tripleo_image_source is defined"},{"line_number":15,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"1fa4df85_e27c0322","line":12,"range":{"start_line":12,"start_character":41,"end_line":12,"end_character":43},"in_reply_to":"1fa4df85_0f1e280c","updated":"2020-02-24 12:01:18.000000000","message":"Done","commit_id":"066b406217843b42cfc5c321621e3b65804ea288"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4d6ddbc548220b7c109026af22ab67d93bcf8d38","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      set_fact:"},{"line_number":18,"context_line":"        dib_local_image: \"{{ workspace }}/{{ tripleo_image_source | urlsplit(\u0027path\u0027) | basename }}\""},{"line_number":19,"context_line":"        dib_node_dist: \u003e-"},{"line_number":20,"context_line":"          {% if ansible_distribution \u003d\u003d \u0027RedHat\u0027 and ansible_distribution_major_version \u003e\u003d \u00278\u0027 -%}"},{"line_number":21,"context_line":"          \"rhel\""},{"line_number":22,"context_line":"          {%- else -%}"},{"line_number":23,"context_line":"          \"centos\""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"1fa4df85_efe5cc0b","line":20,"range":{"start_line":20,"start_character":87,"end_line":20,"end_character":89},"updated":"2020-02-24 10:38:48.000000000","message":"same is version( \n\nhttps://docs.ansible.com/ansible/latest/user_guide/playbooks_tests.html#version-comparison","commit_id":"066b406217843b42cfc5c321621e3b65804ea288"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"a256c3f29582a51a17f7deb706d0e6ab3af03849","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      set_fact:"},{"line_number":18,"context_line":"        dib_local_image: \"{{ workspace }}/{{ tripleo_image_source | urlsplit(\u0027path\u0027) | basename }}\""},{"line_number":19,"context_line":"        dib_node_dist: \u003e-"},{"line_number":20,"context_line":"          {% if ansible_distribution \u003d\u003d \u0027RedHat\u0027 and ansible_distribution_major_version \u003e\u003d \u00278\u0027 -%}"},{"line_number":21,"context_line":"          \"rhel\""},{"line_number":22,"context_line":"          {%- else -%}"},{"line_number":23,"context_line":"          \"centos\""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"1fa4df85_027a7f23","line":20,"range":{"start_line":20,"start_character":87,"end_line":20,"end_character":89},"in_reply_to":"1fa4df85_efe5cc0b","updated":"2020-02-24 12:01:18.000000000","message":"Done","commit_id":"066b406217843b42cfc5c321621e3b65804ea288"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"8972981d61432eb690a67b9042a81f86f1cfa842","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        dib_node_dist: \u003e-"},{"line_number":20,"context_line":"          {% if ansible_distribution \u003d\u003d \u0027RedHat\u0027 and ansible_distribution_major_version \u003e\u003d \u00278\u0027 -%}"},{"line_number":21,"context_line":"          \"rhel\""},{"line_number":22,"context_line":"          {%- else -%}"},{"line_number":23,"context_line":"          \"centos\""},{"line_number":24,"context_line":"          {%- endif %}"},{"line_number":25,"context_line":"        dib_release: \"8\""},{"line_number":26,"context_line":"        dib_yum_repo_conf: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"1fa4df85_ef686cbb","line":23,"range":{"start_line":22,"start_character":10,"end_line":23,"end_character":18},"updated":"2020-02-24 10:24:30.000000000","message":"When is this condition executed?\n\"tripleo_image_source is defined\" afaiu is defined only for rhel8","commit_id":"066b406217843b42cfc5c321621e3b65804ea288"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"149ff47f9037b0439c2ee8c80f0f024209029992","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        dib_node_dist: \u003e-"},{"line_number":20,"context_line":"          {% if ansible_distribution \u003d\u003d \u0027RedHat\u0027 and ansible_distribution_major_version \u003e\u003d \u00278\u0027 -%}"},{"line_number":21,"context_line":"          \"rhel\""},{"line_number":22,"context_line":"          {%- else -%}"},{"line_number":23,"context_line":"          \"centos\""},{"line_number":24,"context_line":"          {%- endif %}"},{"line_number":25,"context_line":"        dib_release: \"8\""},{"line_number":26,"context_line":"        dib_yum_repo_conf: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"1fa4df85_cf03300f","line":23,"range":{"start_line":22,"start_character":10,"end_line":23,"end_character":18},"in_reply_to":"1fa4df85_ef686cbb","updated":"2020-02-24 11:15:33.000000000","message":"https://review.opendev.org/#/c/708599/25/roles/oooci-build-images/tasks/pre.yaml@6\nHere, when rhel_imae_source is defined via set fact tripleo_image_source will get setted then it get executted.","commit_id":"066b406217843b42cfc5c321621e3b65804ea288"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"1b290e41590fa548288ab04b9de54bc35bed19b8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        dib_release: \"8\""},{"line_number":26,"context_line":"        dib_yum_repo_conf: \u003e-"},{"line_number":27,"context_line":"          /etc/yum.repos.d/delorean.repo"},{"line_number":28,"context_line":"          {% if ansible_distribution \u003d\u003d \u0027RedHat\u0027 and ansible_distribution_major_version \u003e\u003d \u00278\u0027 -%}"},{"line_number":29,"context_line":"          /etc/yum.repos.d/delorean-rhel8-{{ release|default(\u0027master\u0027) }}-deps.repo"},{"line_number":30,"context_line":"          /etc/yum.repos.d/rh-cloud.repo"},{"line_number":31,"context_line":"          {%- else -%}"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"1fa4df85_afaa7416","line":28,"range":{"start_line":28,"start_character":54,"end_line":28,"end_character":89},"updated":"2020-02-24 11:02:03.000000000","message":"should be \"int\" or \"version(\" and Marios wrote","commit_id":"066b406217843b42cfc5c321621e3b65804ea288"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"8972981d61432eb690a67b9042a81f86f1cfa842","unresolved":false,"context_lines":[{"line_number":28,"context_line":"          {% if ansible_distribution \u003d\u003d \u0027RedHat\u0027 and ansible_distribution_major_version \u003e\u003d \u00278\u0027 -%}"},{"line_number":29,"context_line":"          /etc/yum.repos.d/delorean-rhel8-{{ release|default(\u0027master\u0027) }}-deps.repo"},{"line_number":30,"context_line":"          /etc/yum.repos.d/rh-cloud.repo"},{"line_number":31,"context_line":"          {%- else -%}"},{"line_number":32,"context_line":"          /etc/yum.repos.d/delorean-{{ release|default(\u0027master\u0027) }}-testing.repo"},{"line_number":33,"context_line":"          /etc/yum.repos.d/tripleo-centos-powertools.repo"},{"line_number":34,"context_line":"          /etc/yum.repos.d/tripleo-centos-highavailability.repo"},{"line_number":35,"context_line":"          {%- endif %}"},{"line_number":36,"context_line":"        cacheable: true"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"1fa4df85_cf5fb00c","line":34,"range":{"start_line":31,"start_character":10,"end_line":34,"end_character":63},"updated":"2020-02-24 10:24:30.000000000","message":"ditto","commit_id":"066b406217843b42cfc5c321621e3b65804ea288"}],"roles/oooci-build-images/templates/build-images.sh.j2":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"07d58ee1b67cd18efa9ac019ecf48779af4f9ae9","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"export ELEMENTS_PATH\u003d$ELEMENTS"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"openstack overcloud image build --image-name {{ tripleo_image_type }} $CONFIG_FILES \u003e {{ workspace }}/build.log 2\u003e {{ workspace }}/build-err.log"},{"line_number":62,"context_line":"RESULT\u003d$?"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"exit $RESULT"}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"1fa4df85_fff8df49","line":61,"updated":"2020-02-27 07:15:37.000000000","message":"did you mean to remove the --debug?","commit_id":"61879a7a419f15ab022272eb01ca2d303cb043ad"}],"roles/oooci-build-images/templates/pathfix_repos.sh.j2":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c9c14c423fd2fa1e077617108154390adceb0a00","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# Add the same behavior here as we build from source, not packages."},{"line_number":6,"context_line":"for python_file in \""},{"line_number":7,"context_line":"    {{ openstack_git_root }}/tripleo-image-elements/elements/os-svc-install/bin/map-services-tripleo"},{"line_number":8,"context_line":"    {% if ansible_distribution \u003d\u003d \"RedHat\" and ansible_lsb.major_release|int \u003e\u003d 8 %}"},{"line_number":9,"context_line":"    {{ openstack_git_root }}/diskimage-builder/diskimage_builder/lib/outfilter.py"},{"line_number":10,"context_line":"    {{ openstack_git_root }}/diskimage-builder/diskimage_builder/elements/package-installs/bin/package-installs-squash"},{"line_number":11,"context_line":"    {{ openstack_git_root }}/diskimage-builder/diskimage_builder/elements/svc-map/extra-data.d/10-merge-svc-map-files"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"1fa4df85_373b29d2","line":8,"range":{"start_line":8,"start_character":47,"end_line":8,"end_character":72},"updated":"2020-02-25 07:33:36.000000000","message":"why do we need a different test here compared to https://review.opendev.org/#/c/708599/26/roles/oooci-build-images/tasks/pre.yaml@20","commit_id":"88255758501703409dd2f0671cc5d9270fbc218e"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"16bff4ace12ffb206bcd5d9bf0b7bceec8a69de8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# Add the same behavior here as we build from source, not packages."},{"line_number":6,"context_line":"for python_file in \""},{"line_number":7,"context_line":"    {{ openstack_git_root }}/tripleo-image-elements/elements/os-svc-install/bin/map-services-tripleo"},{"line_number":8,"context_line":"    {% if ansible_distribution \u003d\u003d \"RedHat\" and ansible_lsb.major_release|int \u003e\u003d 8 %}"},{"line_number":9,"context_line":"    {{ openstack_git_root }}/diskimage-builder/diskimage_builder/lib/outfilter.py"},{"line_number":10,"context_line":"    {{ openstack_git_root }}/diskimage-builder/diskimage_builder/elements/package-installs/bin/package-installs-squash"},{"line_number":11,"context_line":"    {{ openstack_git_root }}/diskimage-builder/diskimage_builder/elements/svc-map/extra-data.d/10-merge-svc-map-files"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"1fa4df85_685b0087","line":8,"range":{"start_line":8,"start_character":47,"end_line":8,"end_character":72},"in_reply_to":"1fa4df85_373b29d2","updated":"2020-02-25 11:10:02.000000000","message":"Done","commit_id":"88255758501703409dd2f0671cc5d9270fbc218e"}],"zuul.d/base.yaml":[{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"0492ab98cb2d860c064b339da495af2bf75a6530","unresolved":false,"context_lines":[{"line_number":541,"context_line":"    timeout: 4200"},{"line_number":542,"context_line":"    nodeset: single-centos-8-node"},{"line_number":543,"context_line":"    vars:"},{"line_number":544,"context_line":"      tripleo_image_os: centos8"},{"line_number":545,"context_line":"    required-projects:"},{"line_number":546,"context_line":"      - opendev.org/openstack/diskimage-builder"},{"line_number":547,"context_line":"      - opendev.org/openstack/heat-agents"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"1fa4df85_55f9a64a","line":544,"updated":"2020-03-02 13:54:04.000000000","message":"There is a tripleo-build-images-base-centros-8 below.\nIf we still need centoos-7 jobs - we should leave this one","commit_id":"6994c51a1245a0a2ec7fe2c3ebf18285fa000701"}],"zuul.d/build-image.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c9c14c423fd2fa1e077617108154390adceb0a00","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- job:"},{"line_number":78,"context_line":"    name: tripleo-buildimage-overcloud-hardened-full-centos-7"},{"line_number":79,"context_line":"    nodeset: single-centos-7-node"},{"line_number":80,"context_line":"    parent: tripleo-build-images-base"},{"line_number":81,"context_line":"    vars:"},{"line_number":82,"context_line":"      tripleo_image_type: overcloud-hardened-full"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"1fa4df85_d7889572","line":79,"updated":"2020-02-25 07:33:36.000000000","message":"so we flipped the default to centos8 for base ... k but we have to make sure none of the rdo jobs that inherit from tripleo-build-images-base are affected/they may need update","commit_id":"88255758501703409dd2f0671cc5d9270fbc218e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"56a292e47e6e0d985b3850834266475d4e18b5fd","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        - tripleo-buildimage-overcloud-full-centos-8"},{"line_number":10,"context_line":"    gate:"},{"line_number":11,"context_line":"      jobs:"},{"line_number":12,"context_line":"        - tripleo-buildimage-overcloud-full-centos-7"},{"line_number":13,"context_line":"        - tripleo-buildimage-overcloud-full-centos-8"},{"line_number":14,"context_line":"    experimental:"},{"line_number":15,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"1fa4df85_bc7607d8","line":12,"range":{"start_line":12,"start_character":51,"end_line":12,"end_character":52},"updated":"2020-02-26 07:44:20.000000000","message":"if we are removing it from check then why we leave it in the gate?","commit_id":"fbbf887d6b340f035ae899974f157024aa4be422"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"067fe7ff2a3b9f709cf74c2ea2202ec42e3c6dd1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        - tripleo-buildimage-overcloud-full-centos-8"},{"line_number":10,"context_line":"    gate:"},{"line_number":11,"context_line":"      jobs:"},{"line_number":12,"context_line":"        - tripleo-buildimage-overcloud-full-centos-7"},{"line_number":13,"context_line":"        - tripleo-buildimage-overcloud-full-centos-8"},{"line_number":14,"context_line":"    experimental:"},{"line_number":15,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"1fa4df85_48e2add7","line":12,"range":{"start_line":12,"start_character":51,"end_line":12,"end_character":52},"in_reply_to":"1fa4df85_bc7607d8","updated":"2020-02-26 11:47:03.000000000","message":"Removing","commit_id":"fbbf887d6b340f035ae899974f157024aa4be422"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"067fe7ff2a3b9f709cf74c2ea2202ec42e3c6dd1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        - tripleo-buildimage-overcloud-full-centos-8"},{"line_number":10,"context_line":"    gate:"},{"line_number":11,"context_line":"      jobs:"},{"line_number":12,"context_line":"        - tripleo-buildimage-overcloud-full-centos-7"},{"line_number":13,"context_line":"        - tripleo-buildimage-overcloud-full-centos-8"},{"line_number":14,"context_line":"    experimental:"},{"line_number":15,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"1fa4df85_08d6f5c6","line":12,"range":{"start_line":12,"start_character":51,"end_line":12,"end_character":52},"in_reply_to":"1fa4df85_bc7607d8","updated":"2020-02-26 11:47:03.000000000","message":"Removing and updating the patch","commit_id":"fbbf887d6b340f035ae899974f157024aa4be422"}],"zuul.d/layout.yaml":[{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"0492ab98cb2d860c064b339da495af2bf75a6530","unresolved":false,"context_lines":[{"line_number":34,"context_line":"              - ^roles/oooci-build-images/.*$"},{"line_number":35,"context_line":"        - tripleo-buildimage-ironic-python-agent-centos-8:"},{"line_number":36,"context_line":"            files: *build_images_files"},{"line_number":37,"context_line":"        - tripleo-buildimage-overcloud-hardened-full-centos-8:"},{"line_number":38,"context_line":"            files: *build_images_files"},{"line_number":39,"context_line":"        - tripleo-ci-centos-7-scenario001-multinode-oooq-container:"},{"line_number":40,"context_line":"            files:"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"1fa4df85_35ac2a33","line":37,"updated":"2020-03-02 13:54:04.000000000","message":"Let\u0027s review if we want to keep the centos-7 job in templates","commit_id":"6994c51a1245a0a2ec7fe2c3ebf18285fa000701"}]}