)]}'
{"roles/oooci-build-images/tasks/image_sanity.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"62023db513db5e88429c5f90304f7e5de0b31329","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      loop: \"{{ files_missing.results }}\""},{"line_number":56,"context_line":"  when:"},{"line_number":57,"context_line":"    - zuul.ref is defined"},{"line_number":58,"context_line":"    - zuul.pipeline not in [\u0027check\u0027, \u0027openstack-check\u0027, \u0027gate\u0027] or force_periodic|default(false)|bool"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff570b3c_56dba1eb","line":58,"range":{"start_line":58,"start_character":6,"end_line":58,"end_character":63},"updated":"2020-06-01 07:54:26.000000000","message":"isn\u0027t it easier to check the other way around i.e. \n\n\u0027periodic\u0027 in zuul.pipeline","commit_id":"af394cd8445753522f4fb97a4013e06985084ef6"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"ee7d441c19f7d4e1855cd4b8ade85f11983515f8","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      loop: \"{{ files_missing.results }}\""},{"line_number":56,"context_line":"  when:"},{"line_number":57,"context_line":"    - zuul.ref is defined"},{"line_number":58,"context_line":"    - zuul.pipeline not in [\u0027check\u0027, \u0027openstack-check\u0027, \u0027gate\u0027] or force_periodic|default(false)|bool"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff570b3c_2c3859ec","line":58,"range":{"start_line":58,"start_character":6,"end_line":58,"end_character":63},"in_reply_to":"ff570b3c_56dba1eb","updated":"2020-06-01 13:50:10.000000000","message":"Agreed..I just followed the pattern from somewhere else in the code.","commit_id":"af394cd8445753522f4fb97a4013e06985084ef6"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"607089e554c4044aded20ad9d30513709ad78c2f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      loop: \"{{ files_missing.results }}\""},{"line_number":57,"context_line":"  when:"},{"line_number":58,"context_line":"    - zuul.ref is defined"},{"line_number":59,"context_line":"    - periodic|default(false)|bool"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_cf5f013f","line":59,"range":{"start_line":59,"start_character":6,"end_line":59,"end_character":14},"updated":"2020-06-02 06:57:51.000000000","message":"is that OK? I expected something more like we do in the featureset files i.e. \"periodic\" in zuul.pipeline\n\ne.g. https://github.com/openstack/tripleo-quickstart/blob/192ac3d0f4d026720b2940f7484cf177d1bbb002/config/general_config/featureset001.yml#L207","commit_id":"4a0ac4e1aa392277ac2d12aef785b186d766e472"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b20b4c2fd84cd8c3c3e1ecf2a3f00d134f875002","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      loop: \"{{ files_missing.results }}\""},{"line_number":57,"context_line":"  when:"},{"line_number":58,"context_line":"    - zuul.ref is defined"},{"line_number":59,"context_line":"    - periodic|default(false)|bool"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_6642576a","line":59,"range":{"start_line":59,"start_character":6,"end_line":59,"end_character":14},"in_reply_to":"ff570b3c_a312a156","updated":"2020-06-02 14:50:41.000000000","message":"ack thanks for checking","commit_id":"4a0ac4e1aa392277ac2d12aef785b186d766e472"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"f0f1656591386bc9d43b454ec5cf2da9a0c38457","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      loop: \"{{ files_missing.results }}\""},{"line_number":57,"context_line":"  when:"},{"line_number":58,"context_line":"    - zuul.ref is defined"},{"line_number":59,"context_line":"    - periodic|default(false)|bool"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_a312a156","line":59,"range":{"start_line":59,"start_character":6,"end_line":59,"end_character":14},"in_reply_to":"ff570b3c_cf5f013f","updated":"2020-06-02 13:28:55.000000000","message":"in fact we should just reuse this\nhttps://github.com/openstack/tripleo-ci/blob/af5acec7b8b1145c0eafa65ca1a1bfbae81a2de8/roles/common/vars/main.yaml#L23-L30","commit_id":"4a0ac4e1aa392277ac2d12aef785b186d766e472"}]}