)]}'
{"roles/build-containers/templates/build.sh.j2":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d59277674b5302cc516e4115c2cea0033567d3f5","unresolved":false,"context_lines":[{"line_number":58,"context_line":"fi"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"openstack tripleo container image build \\"},{"line_number":61,"context_line":"    {% if push_containers|bool %}"},{"line_number":62,"context_line":"    --push \\"},{"line_number":63,"context_line":"    {% endif %}"},{"line_number":64,"context_line":"    --base ubi8 \\"},{"line_number":65,"context_line":"    {% if distro is defined %}"},{"line_number":66,"context_line":"    --distro {{ distro }} \\"},{"line_number":67,"context_line":"    {% endif %}"},{"line_number":68,"context_line":"    {% if excludes is defined %}"},{"line_number":69,"context_line":"    {{ excludes }} \\"},{"line_number":70,"context_line":"    {% endif %}"},{"line_number":71,"context_line":"    --config-file {{ openstack_git_root }}/tripleo-common/container-images/tripleo_containers.yaml \\"},{"line_number":72,"context_line":"    --config-path {{ openstack_git_root }}/tripleo-common/container-images \\"},{"line_number":73,"context_line":"    --work-dir /tmp/container-builds \\"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ff570b3c_5deecbec","line":70,"range":{"start_line":61,"start_character":0,"end_line":70,"end_character":15},"updated":"2020-06-04 23:11:47.000000000","message":"this is a total style nit, but I would like to see us format the jinja like so\n\n    openstack tripleo container image build \\\n    {%   if push_containers|bool %}\n        --push \\\n    {%   endif %}\n        --base ubi8 \\\n    {%   if distro is defined %}\n        --distro {{ distro }} \\\n    {%   endif %}\n    {%   if excludes is defined %}\n        {{ excludes }} \\\n    {%   endif %}\n        --config-file {{ openstack_git_root }}/tripleo-common/container-images/tripleo_containers.yaml \\\n        --config-path {{ openstack_git_root }}/tripleo-common/container-images \\\n        --work-dir /tmp/container-builds \\\n        --debug 2\u003e containers-build-errors.log\n    {% endif %}\n\nWhen we format the commands like so it provides a nice way to read the template but also gets rid of extra newlines and whitespace around the rendered commands.","commit_id":"51eb79d3ad46e050f5e26aa7e8e3f412ff408a62"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"a17cb1e49ec83893ec458162bf2d5351d849e799","unresolved":false,"context_lines":[{"line_number":58,"context_line":"fi"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"openstack tripleo container image build \\"},{"line_number":61,"context_line":"    {% if push_containers|bool %}"},{"line_number":62,"context_line":"    --push \\"},{"line_number":63,"context_line":"    {% endif %}"},{"line_number":64,"context_line":"    --base ubi8 \\"},{"line_number":65,"context_line":"    {% if distro is defined %}"},{"line_number":66,"context_line":"    --distro {{ distro }} \\"},{"line_number":67,"context_line":"    {% endif %}"},{"line_number":68,"context_line":"    {% if excludes is defined %}"},{"line_number":69,"context_line":"    {{ excludes }} \\"},{"line_number":70,"context_line":"    {% endif %}"},{"line_number":71,"context_line":"    --config-file {{ openstack_git_root }}/tripleo-common/container-images/tripleo_containers.yaml \\"},{"line_number":72,"context_line":"    --config-path {{ openstack_git_root }}/tripleo-common/container-images \\"},{"line_number":73,"context_line":"    --work-dir /tmp/container-builds \\"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ff570b3c_bf09d131","line":70,"range":{"start_line":61,"start_character":0,"end_line":70,"end_character":15},"in_reply_to":"ff570b3c_5deecbec","updated":"2020-06-05 15:01:35.000000000","message":"Fine by me ...\nexcludes need to change as well (this was a first pass hack). \nIt would be better if we could pass a list of containers to skip in the job:\nexclude_containers:\n  redhat:\n    8:\n      - sahara-api\n      - sahara-engine\nThen loop through the excludes like we did before\n{% for item in exclude_containers[ansible_distribution|lower][ansible_distribution_major_version|int] %}\n--exclude {{ item }} \\","commit_id":"51eb79d3ad46e050f5e26aa7e8e3f412ff408a62"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"62ce245cdf8347a212a353fdedf8f9ad3a378b21","unresolved":false,"context_lines":[{"line_number":58,"context_line":"fi"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"openstack tripleo container image build \\"},{"line_number":61,"context_line":"    {% if push_containers|bool %}"},{"line_number":62,"context_line":"    --push \\"},{"line_number":63,"context_line":"    {% endif %}"},{"line_number":64,"context_line":"    --base ubi8 \\"},{"line_number":65,"context_line":"    {% if distro is defined %}"},{"line_number":66,"context_line":"    --distro {{ distro }} \\"},{"line_number":67,"context_line":"    {% endif %}"},{"line_number":68,"context_line":"    {% if excludes is defined %}"},{"line_number":69,"context_line":"    {{ excludes }} \\"},{"line_number":70,"context_line":"    {% endif %}"},{"line_number":71,"context_line":"    --config-file {{ openstack_git_root }}/tripleo-common/container-images/tripleo_containers.yaml \\"},{"line_number":72,"context_line":"    --config-path {{ openstack_git_root }}/tripleo-common/container-images \\"},{"line_number":73,"context_line":"    --work-dir /tmp/container-builds \\"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ff570b3c_c5d83280","line":70,"range":{"start_line":61,"start_character":0,"end_line":70,"end_character":15},"in_reply_to":"ff570b3c_bf09d131","updated":"2020-06-05 15:53:05.000000000","message":"+1 an exclude list would be excellent here.","commit_id":"51eb79d3ad46e050f5e26aa7e8e3f412ff408a62"}]}