)]}'
{"roles/build-containers/templates/build.sh.j2":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7b67be225ff93f120743af5a6f9beac6315d28fc","unresolved":false,"context_lines":[{"line_number":61,"context_line":"{%   if push_containers|bool %}"},{"line_number":62,"context_line":"     --push \\"},{"line_number":63,"context_line":"{%   if buildcontainers_authfile_path is defined %}"},{"line_number":64,"context_line":"     --authfile {{ buildcontainers_authfile_path }}"},{"line_number":65,"context_line":"{%   endif %}"},{"line_number":66,"context_line":"{%   endif %}"},{"line_number":67,"context_line":"     --base ubi8 \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf51134e_ba8bc665","line":64,"range":{"start_line":64,"start_character":7,"end_line":64,"end_character":15},"updated":"2020-06-25 07:27:19.000000000","message":"but will that break the current workflow when pushing containers \n\ni think it will unless  \u0027${XDG_RUNTIME_DIR}/containers/auth.json\u0027 exists already there?","commit_id":"34afb772c8485d74d04005f799d72f5bc9a4e5af"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"5e57680915f1b404d154e89935d8f0fd94d9efdf","unresolved":false,"context_lines":[{"line_number":61,"context_line":"{%   if push_containers|bool %}"},{"line_number":62,"context_line":"     --push \\"},{"line_number":63,"context_line":"{%   if buildcontainers_authfile_path is defined %}"},{"line_number":64,"context_line":"     --authfile {{ buildcontainers_authfile_path }}"},{"line_number":65,"context_line":"{%   endif %}"},{"line_number":66,"context_line":"{%   endif %}"},{"line_number":67,"context_line":"     --base ubi8 \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf51134e_cbdeaed8","line":64,"range":{"start_line":64,"start_character":7,"end_line":64,"end_character":15},"in_reply_to":"bf51134e_ba8bc665","updated":"2020-06-25 11:42:57.000000000","message":"push_containers workflow is not used currently anywhere in our ci. So it will not break any changes. when we do podman login ${XDG_RUNTIME_DIR}/containers/auth.json\u0027 will automatically gets generated. I can decouple the condition so if anyone using it does not break it.","commit_id":"34afb772c8485d74d04005f799d72f5bc9a4e5af"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"818d29c57a8c15186077e8f50993f9a130ac158a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"     --namespace {{ registry_namespace }} \\"},{"line_number":73,"context_line":"{%   endif%}"},{"line_number":74,"context_line":"{%   if push_registry is defined %}"},{"line_number":75,"context_line":"     --registry {{ push_registry }} \\"},{"line_number":76,"context_line":"{%   endif %}"},{"line_number":77,"context_line":"     --tag {{ version_hash }}{{ arch_tag }} \\"},{"line_number":78,"context_line":"{%   for item in exclude_containers[ci_branch] %}"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"bf51134e_a92049f9","line":75,"range":{"start_line":75,"start_character":5,"end_line":75,"end_character":7},"updated":"2020-07-02 06:48:45.000000000","message":"this is new since my last visit check jobs don\u0027t test that...  sanity check this won\u0027t break anything in the current periodic push jobs?","commit_id":"b7a60df896bd88aff21697a2bff9e0328ca16042"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d233ee9abecc9a73746d93d3762d63b88a3032fd","unresolved":false,"context_lines":[{"line_number":72,"context_line":"     --namespace {{ registry_namespace }} \\"},{"line_number":73,"context_line":"{%   endif%}"},{"line_number":74,"context_line":"{%   if push_registry is defined %}"},{"line_number":75,"context_line":"     --registry {{ push_registry }} \\"},{"line_number":76,"context_line":"{%   endif %}"},{"line_number":77,"context_line":"     --tag {{ version_hash }}{{ arch_tag }} \\"},{"line_number":78,"context_line":"{%   for item in exclude_containers[ci_branch] %}"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"bf51134e_d62a512a","line":75,"range":{"start_line":75,"start_character":5,"end_line":75,"end_character":7},"in_reply_to":"bf51134e_a92049f9","updated":"2020-07-07 09:38:48.000000000","message":"Nope it is not going to break anything.","commit_id":"b7a60df896bd88aff21697a2bff9e0328ca16042"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"818d29c57a8c15186077e8f50993f9a130ac158a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"{%   if push_registry is defined %}"},{"line_number":75,"context_line":"     --registry {{ push_registry }} \\"},{"line_number":76,"context_line":"{%   endif %}"},{"line_number":77,"context_line":"     --tag {{ version_hash }}{{ arch_tag }} \\"},{"line_number":78,"context_line":"{%   for item in exclude_containers[ci_branch] %}"},{"line_number":79,"context_line":"     --exclude {{ item }} \\"},{"line_number":80,"context_line":"{%   endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"bf51134e_29d0b9c9","line":77,"range":{"start_line":77,"start_character":7,"end_line":77,"end_character":41},"updated":"2020-07-02 06:48:45.000000000","message":"and that one is new too... can you please check there isn\u0027t any duplication?\n\ncurrently we push with {{ version_hash }} and then also re-tag/push with version_arch in https://opendev.org/openstack/tripleo-ci/src/commit/7dd82ca385ac3b1d380cf9358cb4cc120981986c/roles/build-containers/tasks/main.yaml#L224 \nunless we also set push_containers_podman -is that the case here?","commit_id":"b7a60df896bd88aff21697a2bff9e0328ca16042"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d233ee9abecc9a73746d93d3762d63b88a3032fd","unresolved":false,"context_lines":[{"line_number":74,"context_line":"{%   if push_registry is defined %}"},{"line_number":75,"context_line":"     --registry {{ push_registry }} \\"},{"line_number":76,"context_line":"{%   endif %}"},{"line_number":77,"context_line":"     --tag {{ version_hash }}{{ arch_tag }} \\"},{"line_number":78,"context_line":"{%   for item in exclude_containers[ci_branch] %}"},{"line_number":79,"context_line":"     --exclude {{ item }} \\"},{"line_number":80,"context_line":"{%   endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"bf51134e_9630d9a0","line":77,"range":{"start_line":77,"start_character":7,"end_line":77,"end_character":41},"in_reply_to":"bf51134e_29d0b9c9","updated":"2020-07-07 09:38:48.000000000","message":"For first go, we are going to use push_containers_podman: true. so we are going to need that one.","commit_id":"b7a60df896bd88aff21697a2bff9e0328ca16042"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1e4e70e59a20b31a3c82758d58bd3373b35c1e96","unresolved":false,"context_lines":[{"line_number":71,"context_line":"{%   if push_registry is defined %}"},{"line_number":72,"context_line":"     --registry {{ push_registry }} \\"},{"line_number":73,"context_line":"{%   endif %}"},{"line_number":74,"context_line":"     --tag {{ version_hash }}{{ arch_tag }} \\"},{"line_number":75,"context_line":"{%   for item in exclude_containers[ci_branch] %}"},{"line_number":76,"context_line":"     --exclude {{ item }} \\"},{"line_number":77,"context_line":"{%   endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"bf51134e_e0a4ef0a","line":74,"range":{"start_line":74,"start_character":32,"end_line":74,"end_character":40},"updated":"2020-07-06 07:53:26.000000000","message":"same question as last visit this changes current behaviour where we\u0027re pushing with version_hash first then also tagging with arch_tag.","commit_id":"6421c06592e445ec3f30c83dabdd1f1b72c088da"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"1587d97c68b1f75ad3af23a0b5e1d1a3878c1e70","unresolved":false,"context_lines":[{"line_number":71,"context_line":"{%   if push_registry is defined %}"},{"line_number":72,"context_line":"     --registry {{ push_registry }} \\"},{"line_number":73,"context_line":"{%   endif %}"},{"line_number":74,"context_line":"     --tag {{ version_hash }}{{ arch_tag }} \\"},{"line_number":75,"context_line":"{%   for item in exclude_containers[ci_branch] %}"},{"line_number":76,"context_line":"     --exclude {{ item }} \\"},{"line_number":77,"context_line":"{%   endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"bf51134e_2ce6e017","line":74,"updated":"2020-07-06 11:51:34.000000000","message":"the --tag isn\u0027t in any if, shall be moved to bellow","commit_id":"531fcdbf7f0c8bab88055c8fa6f3c0becc250bee"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"3e7c8ea505e7e22ae3c34929912c1e39811d0540","unresolved":false,"context_lines":[{"line_number":61,"context_line":"{%   if push_containers|bool %}"},{"line_number":62,"context_line":"     --push \\"},{"line_number":63,"context_line":"{%   endif %}"},{"line_number":64,"context_line":"     --base ubi8 \\"},{"line_number":65,"context_line":"{%   if distro is defined %}"},{"line_number":66,"context_line":"     --distro {{ distro }} \\"},{"line_number":67,"context_line":"{%   endif %}"}],"source_content_type":"text/x-jinja2","patch_set":29,"id":"bf51134e_52948ae8","line":64,"updated":"2020-07-06 13:12:01.000000000","message":"Sorry, I won\u0027t block, but this also should be moved to the end, it can be done in other patch, I did not pay attention, but it\u0027s easier to visualize at the end..","commit_id":"b0f1ef1a40495e4732ca23fb68d00d7d8943a3b7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fb4ef4fc700c76648b4612693d5ffaff43c3e246","unresolved":false,"context_lines":[{"line_number":73,"context_line":"{%   for item in exclude_containers[ci_branch] %}"},{"line_number":74,"context_line":"     --exclude {{ item }} \\"},{"line_number":75,"context_line":"{%   endfor %}"},{"line_number":76,"context_line":"     --tag {{ version_hash }} \\"},{"line_number":77,"context_line":"     --base ubi8 \\"},{"line_number":78,"context_line":"     --prefix {{ ansible_distribution | lower }}-binary \\"},{"line_number":79,"context_line":"     --config-file {{ openstack_git_root }}/tripleo-common/container-images/tripleo_containers.yaml \\"}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"bf51134e_1c6059a5","line":76,"range":{"start_line":76,"start_character":14,"end_line":76,"end_character":26},"updated":"2020-07-07 07:33:14.000000000","message":"ack yes this is better now","commit_id":"c2ce879c4fe84b3ebb9cc8d7d7202690e3d1cae1"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"2210927047eb4a323bbc72366476cf495f857078","unresolved":false,"context_lines":[{"line_number":73,"context_line":"{%   for item in exclude_containers[ci_branch] %}"},{"line_number":74,"context_line":"     --exclude {{ item }} \\"},{"line_number":75,"context_line":"{%   endfor %}"},{"line_number":76,"context_line":"     --tag {{ version_hash }} \\"},{"line_number":77,"context_line":"     --base ubi8 \\"},{"line_number":78,"context_line":"     --prefix {{ ansible_distribution | lower }}-binary \\"},{"line_number":79,"context_line":"     --config-file {{ openstack_git_root }}/tripleo-common/container-images/tripleo_containers.yaml \\"}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"bf51134e_258f0024","line":76,"range":{"start_line":76,"start_character":14,"end_line":76,"end_character":26},"in_reply_to":"bf51134e_1c6059a5","updated":"2020-07-07 12:19:46.000000000","message":"would be good to also add {{ arch_tag }} to suppor non arch builds.","commit_id":"c2ce879c4fe84b3ebb9cc8d7d7202690e3d1cae1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f64dc9f61f0bc58b86bec5a38d047222801d116d","unresolved":false,"context_lines":[{"line_number":73,"context_line":"{%   for item in exclude_containers[ci_branch] %}"},{"line_number":74,"context_line":"     --exclude {{ item }} \\"},{"line_number":75,"context_line":"{%   endfor %}"},{"line_number":76,"context_line":"     --tag {{ version_hash }} \\"},{"line_number":77,"context_line":"     --base ubi8 \\"},{"line_number":78,"context_line":"     --prefix {{ ansible_distribution | lower }}-binary \\"},{"line_number":79,"context_line":"     --config-file {{ openstack_git_root }}/tripleo-common/container-images/tripleo_containers.yaml \\"}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"bf51134e_225a44f2","line":76,"range":{"start_line":76,"start_character":14,"end_line":76,"end_character":26},"in_reply_to":"bf51134e_258f0024","updated":"2020-07-08 06:06:58.000000000","message":"yes but only if we *re-tag*... the previous version here was pushing only with arch_tag i.e. {{Hash}}{{arch}}... we need to push with {{hash}} and then we can also re-tag with {{arch}}","commit_id":"c2ce879c4fe84b3ebb9cc8d7d7202690e3d1cae1"}]}