)]}'
{"zuul.d/multinode-jobs.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"396e1c4d8a6dba5b2c549f64f38af973df93242f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"              - ^playbooks/tripleo-buildcontainers/.*$"},{"line_number":32,"context_line":"              - ^playbooks/tripleo-buildimages/.*$"},{"line_number":33,"context_line":"              - ^vars/sova-patterns.yml$"},{"line_number":34,"context_line":"              - zuul.d/layout.yaml"},{"line_number":35,"context_line":"              - zuul.d/build-containers.yaml"},{"line_number":36,"context_line":"              - zuul.d/build-image.yaml"},{"line_number":37,"context_line":"              - zuul.d/standalone-jobs.yaml"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fffc6b78_2a039e44","line":34,"updated":"2020-11-20 10:02:49.000000000","message":"I guess since we\u0027re here we should also add layout.yaml to https://opendev.org/openstack/tripleo-ci/src/branch/master/zuul.d/standalone-jobs.yaml#L98","commit_id":"55277e9ab2a5faea4907d5c94e2b3519369de277"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"b040950e4974c69f34054981856e7e06dfa5bff0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"              - ^playbooks/tripleo-buildcontainers/.*$"},{"line_number":32,"context_line":"              - ^playbooks/tripleo-buildimages/.*$"},{"line_number":33,"context_line":"              - ^vars/sova-patterns.yml$"},{"line_number":34,"context_line":"              - zuul.d/layout.yaml"},{"line_number":35,"context_line":"              - zuul.d/build-containers.yaml"},{"line_number":36,"context_line":"              - zuul.d/build-image.yaml"},{"line_number":37,"context_line":"              - zuul.d/standalone-jobs.yaml"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6ace3278_645d720f","line":34,"in_reply_to":"fd8df7e2_61c7ead3","updated":"2020-11-25 08:54:18.000000000","message":"No both are different, here it\u0027s being added in template not in job definition, the thing you pointed is a job definition https://opendev.org/openstack/tripleo-ci/src/branch/master/zuul.d/standalone-jobs.yaml#L93-L101, if we add in job definition itself irrelevant-files is applied to wherever that job is used unless and until it\u0027s overridden(in project-template or in project config).\n\nSo let\u0027s get this patch to restore as it used to and i will propose a follow up patch  once gate settles down to handle all other places where it will help to reduce running unnecessary jobs.","commit_id":"55277e9ab2a5faea4907d5c94e2b3519369de277"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"b52be36664adb4d9eeab26a4c55ba26ba02ac482","unresolved":false,"context_lines":[{"line_number":31,"context_line":"              - ^playbooks/tripleo-buildcontainers/.*$"},{"line_number":32,"context_line":"              - ^playbooks/tripleo-buildimages/.*$"},{"line_number":33,"context_line":"              - ^vars/sova-patterns.yml$"},{"line_number":34,"context_line":"              - zuul.d/layout.yaml"},{"line_number":35,"context_line":"              - zuul.d/build-containers.yaml"},{"line_number":36,"context_line":"              - zuul.d/build-image.yaml"},{"line_number":37,"context_line":"              - zuul.d/standalone-jobs.yaml"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fffc6b78_9dfe5603","line":34,"in_reply_to":"fffc6b78_2a039e44","updated":"2020-11-20 10:40:18.000000000","message":"i just picked which were changed in original review, wrt adding in job definition is more trickier as zuul.d/layout.yaml exist in other project where job can be used, https://opendev.org/openstack/tripleo-ci/src/branch/master/zuul.d/standalone-jobs.yaml#L98\n\nIf needed it can be added likely as follow up as i see other jobs also have missings in irrelevant-files, some example:- https://opendev.org/openstack/tripleo-ci/src/branch/master/zuul.d/standalone-jobs.yaml#L17, https://opendev.org/openstack/tripleo-ci/src/branch/master/zuul.d/standalone-jobs.yaml#L37 etc","commit_id":"55277e9ab2a5faea4907d5c94e2b3519369de277"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f60c2342e0da3c92060549f4b2a5ee68d9e5c13c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"              - ^playbooks/tripleo-buildcontainers/.*$"},{"line_number":32,"context_line":"              - ^playbooks/tripleo-buildimages/.*$"},{"line_number":33,"context_line":"              - ^vars/sova-patterns.yml$"},{"line_number":34,"context_line":"              - zuul.d/layout.yaml"},{"line_number":35,"context_line":"              - zuul.d/build-containers.yaml"},{"line_number":36,"context_line":"              - zuul.d/build-image.yaml"},{"line_number":37,"context_line":"              - zuul.d/standalone-jobs.yaml"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fd8df7e2_61c7ead3","line":34,"in_reply_to":"fffc6b78_9dfe5603","updated":"2020-11-25 08:36:43.000000000","message":"not sure what you meant by \u0027adding to job definition\u0027 ... what i pointed to https://opendev.org/openstack/tripleo-ci/src/branch/master/zuul.d/standalone-jobs.yaml#L101 is the same as you\u0027re doing here, i.e. add zuul.d/layout to the  anchor (above it is \u0026multinode_ignored and what i pointed to it is \u0026upgrade_irrelevant\n\ni still think it should be added to https://opendev.org/openstack/tripleo-ci/src/branch/master/zuul.d/standalone-jobs.yaml#L101 and it is consistent with what you\u0027re doing here for multinode and what we have already for undercloud","commit_id":"55277e9ab2a5faea4907d5c94e2b3519369de277"}]}
