)]}'
{"playbooks/tripleo-ci/install-built-repo.yml":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"46794a5c9e20e1d7d4f318a01bfce760bb4d4c2a","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- hosts: all"},{"line_number":3,"context_line":"  tasks:"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    - when: job.consumer_job|default(false)|bool"},{"line_number":6,"context_line":"      block:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"        - name: Check if we have a repo"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b54691d9_4353205c","line":5,"range":{"start_line":5,"start_character":12,"end_line":5,"end_character":48},"updated":"2020-11-27 11:50:25.000000000","message":"also this is not set for upgrade jobs, what about using registry_ip_address_branch is defined?","commit_id":"8956815afeca165df55281076c523c31f46483ec"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"c37e7c2471038776dd20eae845bc17c1c98ff5f5","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- hosts: all"},{"line_number":3,"context_line":"  tasks:"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    - when: job.consumer_job|default(false)|bool"},{"line_number":6,"context_line":"      block:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"        - name: Check if we have a repo"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5beaf717_f6c949b1","line":5,"range":{"start_line":5,"start_character":12,"end_line":5,"end_character":48},"in_reply_to":"70eecc60_6c1c7ac9","updated":"2020-11-27 15:15:32.000000000","message":"Ok i checked wrongly earlier that it\u0027s not set, you need to use consumer_job|default(false)|bool instead of job.consumer_job|default(false)|bool to get it working.","commit_id":"8956815afeca165df55281076c523c31f46483ec"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4402b2bd8d1d3cebd0cc8192e75f9c91dd7dc192","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- hosts: all"},{"line_number":3,"context_line":"  tasks:"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    - when: job.consumer_job|default(false)|bool"},{"line_number":6,"context_line":"      block:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"        - name: Check if we have a repo"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"70eecc60_6c1c7ac9","line":5,"range":{"start_line":5,"start_character":12,"end_line":5,"end_character":48},"in_reply_to":"b54691d9_4353205c","updated":"2020-11-27 14:42:19.000000000","message":"it is set for the upgrade jobs https://opendev.org/openstack/tripleo-ci/src/commit/2696e52930e6393a7496594f8b5e79d05ea0273c/zuul.d/standalone-jobs.yaml#L566-L576\n\nbasically we decided that we will use that conditional in all the places e.g. see [1] it is always \u0027if consumer job then just try directly to access registry_ip_address_branch[release]\n\nif any part of that is missing like release isn\u0027t defined or worse the registry_ip_address_branch isn\u0027t defined we just want it to fail.\n\nThis is why I added the conditional as above\n\n\n[1] https://codesearch.opendev.org/?q\u003dregistry_ip_address_branch\u0026repos\u003dopenstack/tripleo-ansible,openstack/tripleo-ci,openstack/tripleo-common,openstack/tripleo-common-tempest-plugin,openstack/tripleo-docs,openstack/tripleo-ha-utils,openstack/tripleo-heat-templates,openstack/tripleo-image-elements,openstack/tripleo-ipsec,openstack/tripleo-operator-ansible,openstack/tripleo-puppet-elements,openstack/tripleo-quickstart,openstack/tripleo-quickstart-extras,openstack/tripleo-repos,openstack/tripleo-specs,openstack/tripleo-upgrade,openstack/tripleo-validations,openstack/python-tripleoclient,openstack/puppet-tripleo","commit_id":"8956815afeca165df55281076c523c31f46483ec"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c0a3996329b21902cb6a9d0469e69928f2357ee3","unresolved":true,"context_lines":[{"line_number":9,"context_line":"          wait_for:"},{"line_number":10,"context_line":"            timeout: 2"},{"line_number":11,"context_line":"            port: 8766"},{"line_number":12,"context_line":"            host: \u0027{{ registry_ip_address_branch[release] }}\u0027"},{"line_number":13,"context_line":"          register: waitfor"},{"line_number":14,"context_line":"          ignore_errors: true"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"53b8f661_ee490bd1","line":12,"range":{"start_line":12,"start_character":49,"end_line":12,"end_character":56},"updated":"2020-11-27 11:36:06.000000000","message":"13:31 \u003c marios\u003e ykarel: ? release is set\n13:31 \u003c ykarel\u003e marios, no release is not set at that level, that\u0027s zuul playbook\n13:32 \u003c ykarel\u003e so need to detect like it\u0027s done in build containers/build images job, non quickstart deploy \n                jobs\n13:32 \u003c marios\u003e ykarel: where are you referring to exactly? \u0027that lever, thats zuul playbook\u0027 \n13:32 \u003c marios\u003e level\n13:33 \u003c ykarel\u003e marios, pre-run: install-built-repo.yaml\n13:34 \u003c ykarel\u003e something like \nhttps://github.com/openstack/tripleo-ci/blob/d5514028452f9d427949f5a8fac26b48bd0d7c03/playbooks/tripleo-ci/run-provider.yml#L17-L33 can be done\n13:34 \u003c marios\u003e ykarel: yes, i see, because we aren\u0027t passing in --extra-vars \n                @/home/zuul/workspace/.quickstart/config/release/tripleo-ci/CentOS-8/victoria.yml at this point \n                for the pre-run plays\n13:34 \u003c ykarel\u003e or if those vars are exported and available to consumer job, can be used from there too\n13:35 \u003c ykarel\u003e yeap exactly those things are passed for quickstart playbooks\n13:35 \u003c ykarel\u003e or nested ansible runs\n13:35 \u003c marios\u003e ykarel: ack can you comment on the review i will update it after i finish current thing\n13:35 \u003c marios\u003e ykarel: i\u0027ll copy/pasta from here now \n13:35 \u003c ykarel\u003e ok will do","commit_id":"8956815afeca165df55281076c523c31f46483ec"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"c37e7c2471038776dd20eae845bc17c1c98ff5f5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"          wait_for:"},{"line_number":10,"context_line":"            timeout: 2"},{"line_number":11,"context_line":"            port: 8766"},{"line_number":12,"context_line":"            host: \u0027{{ registry_ip_address_branch[release] }}\u0027"},{"line_number":13,"context_line":"          register: waitfor"},{"line_number":14,"context_line":"          ignore_errors: true"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0e93073e_f965360b","line":12,"range":{"start_line":12,"start_character":49,"end_line":12,"end_character":56},"in_reply_to":"02768e33_98e53ec1","updated":"2020-11-27 15:15:32.000000000","message":"i checked that earlier before suggesting ci_branch detection, as with multiple provider provider_job_branch can mess.","commit_id":"8956815afeca165df55281076c523c31f46483ec"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4402b2bd8d1d3cebd0cc8192e75f9c91dd7dc192","unresolved":false,"context_lines":[{"line_number":9,"context_line":"          wait_for:"},{"line_number":10,"context_line":"            timeout: 2"},{"line_number":11,"context_line":"            port: 8766"},{"line_number":12,"context_line":"            host: \u0027{{ registry_ip_address_branch[release] }}\u0027"},{"line_number":13,"context_line":"          register: waitfor"},{"line_number":14,"context_line":"          ignore_errors: true"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"02768e33_98e53ec1","line":12,"range":{"start_line":12,"start_character":49,"end_line":12,"end_character":56},"in_reply_to":"057d7cfa_e1e21442","updated":"2020-11-27 14:42:19.000000000","message":"thanks needs some thought... in fact we may just be able to directly use the passed \u0027provider_job_branch\u0027 zuul data https://github.com/openstack/tripleo-ci/blob/d5514028452f9d427949f5a8fac26b48bd0d7c03/playbooks/tripleo-ci/run-provider.yml#L74","commit_id":"8956815afeca165df55281076c523c31f46483ec"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"46794a5c9e20e1d7d4f318a01bfce760bb4d4c2a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"          wait_for:"},{"line_number":10,"context_line":"            timeout: 2"},{"line_number":11,"context_line":"            port: 8766"},{"line_number":12,"context_line":"            host: \u0027{{ registry_ip_address_branch[release] }}\u0027"},{"line_number":13,"context_line":"          register: waitfor"},{"line_number":14,"context_line":"          ignore_errors: true"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"057d7cfa_e1e21442","line":12,"range":{"start_line":12,"start_character":49,"end_line":12,"end_character":56},"in_reply_to":"53b8f661_ee490bd1","updated":"2020-11-27 11:50:25.000000000","message":"can use host: \u0027{{ registry_ip_address_branch[ci_branch] }}\u0027 and detect ci_branch like https://github.com/openstack/tripleo-ci/blob/d5514028452f9d427949f5a8fac26b48bd0d7c03/playbooks/tripleo-ci/run-provider.yml#L17-L33","commit_id":"8956815afeca165df55281076c523c31f46483ec"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e6f09a77e1be983d869a2089777814b95db92d4d","unresolved":true,"context_lines":[{"line_number":21,"context_line":"              set_fact:"},{"line_number":22,"context_line":"                install_built_repo_target_provider: \"{{ the_keys|max }}\""},{"line_number":23,"context_line":"              when: \"\u0027master\u0027 not in provider_branch_keys\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        - name: Check if we have a repo"},{"line_number":26,"context_line":"          wait_for:"},{"line_number":27,"context_line":"            timeout: 2"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"663b778f_397578d3","line":24,"updated":"2020-11-30 11:10:04.000000000","message":"needs more work updating","commit_id":"db86e50db70027fe2b3a354d540668147a841376"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"faeac06990d51ed8453f2331a4efa4c4a9ffe643","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- hosts: all"},{"line_number":3,"context_line":"  tasks:"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    - when: job.consumer_job|default(false)|bool"},{"line_number":6,"context_line":"      block:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"        - name: Determine the target content provider branch (newest wins)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fe52b22e_ec326573","line":5,"range":{"start_line":5,"start_character":12,"end_line":5,"end_character":48},"updated":"2020-11-30 16:14:33.000000000","message":"this is not working as a condition\n\n\neg. in this content provider job i don\u0027t expect the consumer_job to be set: https://abf74f6fb8c5c8b93a78-fb92f122ef2c9e1693ca4d1275ddc221.ssl.cf2.rackcdn.com/764359/3/check/tripleo-ci-centos-8-content-provider-ussuri/0cfaf03/job-output.txt\n\n\n2020-11-30 15:04:19.097754 | LOOP [Collect the content provider branch keys into a list]\n2020-11-30 15:04:19.153763 | primary | ERROR\n2020-11-30 15:04:19.154257 | primary | {\n2020-11-30 15:04:19.154339 | primary |   \"msg\": \"dict2items requires a dictionary, got \u003cclass \u0027ansible.template.AnsibleUndefined\u0027\u003e instead.\"\n2020-11-30 15:04:19.154412 | primary | }","commit_id":"1227e34d3ce04e283149d5535de648552ef1a77f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1785dd41907718880dc45fcd2a48ee23e6db9f8d","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- hosts: all"},{"line_number":3,"context_line":"  tasks:"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    - when: registry_ip_address_branch is defined"},{"line_number":6,"context_line":"      block:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"        - name: Determine the target content provider branch (newest wins)"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3e3e059c_016981f9","line":5,"range":{"start_line":5,"start_character":12,"end_line":5,"end_character":49},"updated":"2020-12-01 10:22:43.000000000","message":"not sure why this is still firing for the provider jobs... ?\n\n\n        * https://f21d76a1e10ee043e70e-a64a5535b18499bb41f0cb38f72ece97.ssl.cf5.rackcdn.com/764359/4/check/tripleo-ci-centos-8-content-provider-ussuri/2645679/job-output.txt\n        * 2020-11-30 16:57:19.876361 | LOOP [Collect the content provider branch keys into a list]\n2020-11-30 16:57:19.953650 | primary | ERROR\n2020-11-30 16:57:19.954504 | primary | {\n2020-11-30 16:57:19.954668 | primary |   \"msg\": \"dict2items requires a dictionary, got \u003cclass \u0027ansible.template.AnsibleUndefined\u0027\u003e instead.\"\n        * https://f21d76a1e10ee043e70e-a64a5535b18499bb41f0cb38f72ece97.ssl.cf5.rackcdn.com/764359/4/check/tripleo-ci-centos-8-content-provider-ussuri/2645679/zuul-info/inventory.yaml\n        *     provider_job: true\n\n\ngoing to add explicit consumer_job and not provider job into conditions","commit_id":"0b2434381cb505936709bcc8bae5301ef2f95164"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"04a77a9082f93ce035c12b583eb543a36559145c","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    - when:"},{"line_number":6,"context_line":"        - registry_ip_address_branch is defined"},{"line_number":7,"context_line":"        - job.consumer_job | default(false) | bool"},{"line_number":8,"context_line":"        - not job.provider_job | default(false) | bool"},{"line_number":9,"context_line":"      block:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"        - name: Collect the content provider branch keys into a list"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ee726a06_11d24d72","line":8,"updated":"2020-12-01 12:31:23.000000000","message":"wtf how is this still being executed ... ?\n\n\n        * https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_41c/764359/5/check/tripleo-ci-centos-8-content-provider-ussuri/41cf2e9/job-output.txt\n        * 2020-12-01 12:06:49.092562 | LOOP [Collect the content provider branch keys into a list]\n2020-12-01 12:06:49.337321 | primary | ERROR\n2020-12-01 12:06:49.337717 | primary | {\n2020-12-01 12:06:49.337817 | primary |   \"msg\": \"dict2items requires a dictionary, got \u003cclass \u0027ansible.template.AnsibleUndefined\u0027\u003e instead.\"\n\n\n\n        * https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_41c/764359/5/check/tripleo-ci-centos-8-content-provider-ussuri/41cf2e9/job-output.txt\n        * https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_41c/764359/5/check/tripleo-ci-centos-8-content-provider-ussuri/41cf2e9/zuul-info/inventory.yaml\n        *     provider_job: true","commit_id":"32bad2b1731a03331fe082ff5cdb455f137587b1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"04a77a9082f93ce035c12b583eb543a36559145c","unresolved":true,"context_lines":[{"line_number":11,"context_line":"        - name: Collect the content provider branch keys into a list"},{"line_number":12,"context_line":"          set_fact:"},{"line_number":13,"context_line":"            provider_branches: \"{{ provider_branches|default([]) + [item.key] }}\""},{"line_number":14,"context_line":"          loop: \"{{ registry_ip_address_branch|dict2items }}\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"        - name: Set target branch master if is it present"},{"line_number":17,"context_line":"          set_fact:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"86543390_75326ce5","line":14,"range":{"start_line":14,"start_character":20,"end_line":14,"end_character":46},"updated":"2020-12-01 12:31:23.000000000","message":"k lets also default stuff :/","commit_id":"32bad2b1731a03331fe082ff5cdb455f137587b1"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"3d68ca27e646c07a99b92b9b72dc5d9da0daebfe","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    - when:"},{"line_number":6,"context_line":"        - registry_ip_address_branch is defined"},{"line_number":7,"context_line":"        - registry_ip_address_branch"},{"line_number":8,"context_line":"        - job.consumer_job | default(false) | bool"},{"line_number":9,"context_line":"        - not job.provider_job | default(false) | bool"},{"line_number":10,"context_line":"      block:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"        - name: Collect the content provider branch keys into a list"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6e0e5b76_702dec38","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":54},"updated":"2020-12-02 12:43:52.000000000","message":"are these except registry_ip_address_branch really needed? also job.consumer_job or job.provider_job will not work, just consumer_job or provider_job should be enough.","commit_id":"3f1b4a8b519fb53545261cfc2d25cfd0243cebf5"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d1917981f1037dcfe2ccdfbd036cf1e3dc8d2b7c","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  tasks:"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    - when:"},{"line_number":6,"context_line":"        - registry_ip_address_branch is defined"},{"line_number":7,"context_line":"        - registry_ip_address_branch"},{"line_number":8,"context_line":"        - job.consumer_job | default(false) | bool"},{"line_number":9,"context_line":"        - not job.provider_job | default(false) | bool"},{"line_number":10,"context_line":"      block:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"        - name: Collect the content provider branch keys into a list"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7c7a17d3_f91e801d","line":9,"range":{"start_line":6,"start_character":21,"end_line":9,"end_character":23},"updated":"2020-12-02 12:12:21.000000000","message":"not working yet... \n\n\n        * https://a6fbb86efdf5860e1b02-ce677b1d4d068789ef14672b1b5d2453.ssl.cf5.rackcdn.com/764359/6/check/tripleo-ci-centos-8-content-provider-ussuri/fc28322/job-output.txt\n\t        * 2020-12-01 12:42:57.331798 | LOOP [Collect the content provider branch keys into a list]\n\t\t2020-12-01 12:42:57.493974 | \n\t\t2020-12-01 12:42:57.494252 | TASK [Set target branch master if is it present]\n\t\t2020-12-01 12:42:57.548672 | primary | skipping: Conditional result was False\n\t\t2020-12-01 12:42:57.585904 | \n\t\t2020-12-01 12:42:57.586157 | TASK [Set target branch as the latest alphabetically]\n\t\t2020-12-01 12:42:57.632659 | primary | skipping: Conditional result was False\n\t\t2020-12-01 12:42:57.671043 | \n\t\t2020-12-01 12:42:57.671318 | TASK [Debug the built_repo_target_branch fact]\n\t\t2020-12-01 12:42:57.724630 | primary | skipping: Conditional result was False\n\t\t2020-12-01 12:42:57.765525 | \n\t\t2020-12-01 12:42:57.765828 | TASK [Check if we have a repo]\n\t\t2020-12-01 12:42:57.817928 | primary | skipping: Conditional result was False\n\t\t2020-12-01 12:42:57.861844 | \n\t\t2020-12-01 12:42:57.862098 | TASK [Create a repo if got registry IP from Zuul]\n\t\t2020-12-01 12:42:57.922781 | primary | skipping: Conditional result was False\n\n        * https://38fc547d6dc8718028ea-253b0a19be2181811797fa6cbd0c2b8d.ssl.cf5.rackcdn.com/764359/6/check/tripleo-ci-centos-8-standalone/2cf2e41/job-output.txt\n\t        * 2020-12-01 13:33:57.541645 | LOOP [Collect the content provider branch keys into a list]\n\t\t2020-12-01 13:33:57.697475 | primary | skipping: Conditional result was False\n\t\t2020-12-01 13:33:57.816870 | \n\t\t2020-12-01 13:33:57.817211 | TASK [Set target branch master if is it present]\n\t\t2020-12-01 13:33:57.881324 | primary | skipping: Conditional result was False\n\n\n\n\t* https://9d8741f9b12c72356853-cbb980286bb4edf7e11c952127446228.ssl.cf2.rackcdn.com/764359/6/check/tripleo-ci-centos-8-standalone-upgrade/0ec1aa2/job-output.txt\n\t\t* 2020-12-01 13:56:59.178656 | LOOP [Collect the content provider branch keys into a list]\n\t\t2020-12-01 13:56:59.339652 | primary | skipping: Conditional result was False\n\t\t2020-12-01 13:56:59.345424 | primary | skipping: Conditional result was False\n\t\t2020-12-01 13:56:59.492327 | \n\t\t2020-12-01 13:56:59.492555 | TASK [Set target branch master if is it present]\n\t\t2020-12-01 13:56:59.565245 | primary | skipping: Conditional result was False\n\t\t2020-12-01 13:56:59.622305 | \n\t\t2020-12-01 13:56:59.622588 | TASK [Set target branch as the latest alphabetically]\n\t\t2020-12-01 13:56:59.690684 | primary | skipping: Conditional result was False\n\t\t2020-12-01 13:56:59.735820 | \n\t\t2020-12-01 13:56:59.736091 | TASK [Debug the built_repo_target_branch fact]\n\t\t2020-12-01 13:56:59.819624 | primary | skipping: Conditional result was False\n\t\t2020-12-01 13:56:59.877859 | \n\t\t2020-12-01 13:56:59.878113 | TASK [Check if we have a repo]\n\t\t2020-12-01 13:56:59.961618 | primary | skipping: Conditional result was False\n\t\t2020-12-01 13:57:00.011396 | \n\t\t2020-12-01 13:57:00.011662 | TASK [Create a repo if got registry IP from Zuul]\n\t\t2020-12-01 13:57:00.092527 | primary | skipping: Conditional result was False","commit_id":"3f1b4a8b519fb53545261cfc2d25cfd0243cebf5"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"24add3c089b57c5aac669ce10789ab3507d2f778","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    - when:"},{"line_number":6,"context_line":"        - registry_ip_address_branch is defined"},{"line_number":7,"context_line":"        - registry_ip_address_branch"},{"line_number":8,"context_line":"        - job.consumer_job | default(false) | bool"},{"line_number":9,"context_line":"        - not job.provider_job | default(false) | bool"},{"line_number":10,"context_line":"      block:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"        - name: Collect the content provider branch keys into a list"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6937ecc9_59ca1658","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":54},"in_reply_to":"6e0e5b76_702dec38","updated":"2020-12-02 13:15:59.000000000","message":"yeah on latest v7 i already changed back to how it was with registry_ip_address_branch\n\nif you see my comments on earlier versions, i think the conditionals were OK, but the loop on line 15 was being (pre?) processed regardless if the block was executed and it was causing failures.","commit_id":"3f1b4a8b519fb53545261cfc2d25cfd0243cebf5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"3d68ca27e646c07a99b92b9b72dc5d9da0daebfe","unresolved":true,"context_lines":[{"line_number":19,"context_line":"            built_repo_target_branch: \u0027master\u0027"},{"line_number":20,"context_line":"          when: \"\u0027master\u0027 in provider_branches\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"        - name: Set target branch as the latest alphabetically"},{"line_number":23,"context_line":"          set_fact:"},{"line_number":24,"context_line":"            built_repo_target_branch: \"{{ the_keys|max }}\""},{"line_number":25,"context_line":"          when: \"\u0027master\u0027 not in provider_branches\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba740d97_66f9ddb5","line":22,"range":{"start_line":22,"start_character":48,"end_line":22,"end_character":62},"updated":"2020-12-02 12:43:52.000000000","message":"/me not sure about this how this will work post Z name is used, currently wallaby. that\u0027s why i suggested earlier to detect based on zuul branch/override_branch like it\u0027s done in container build jobs or run-provider.yml.","commit_id":"3f1b4a8b519fb53545261cfc2d25cfd0243cebf5"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"24add3c089b57c5aac669ce10789ab3507d2f778","unresolved":true,"context_lines":[{"line_number":19,"context_line":"            built_repo_target_branch: \u0027master\u0027"},{"line_number":20,"context_line":"          when: \"\u0027master\u0027 in provider_branches\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"        - name: Set target branch as the latest alphabetically"},{"line_number":23,"context_line":"          set_fact:"},{"line_number":24,"context_line":"            built_repo_target_branch: \"{{ the_keys|max }}\""},{"line_number":25,"context_line":"          when: \"\u0027master\u0027 not in provider_branches\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5ebeafd6_b8065420","line":22,"range":{"start_line":22,"start_character":48,"end_line":22,"end_character":62},"in_reply_to":"ba740d97_66f9ddb5","updated":"2020-12-02 13:15:59.000000000","message":"yes this did occur to me but we don\u0027t know yet what post Z will be. I want to see if the conditionals are working as expected on this current run and i will rework that part on next pass thanks","commit_id":"3f1b4a8b519fb53545261cfc2d25cfd0243cebf5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"3d68ca27e646c07a99b92b9b72dc5d9da0daebfe","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"        - name: Set target branch as the latest alphabetically"},{"line_number":23,"context_line":"          set_fact:"},{"line_number":24,"context_line":"            built_repo_target_branch: \"{{ the_keys|max }}\""},{"line_number":25,"context_line":"          when: \"\u0027master\u0027 not in provider_branches\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        - name: Debug the built_repo_target_branch fact"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"453b7f0c_d9d5eb20","line":24,"range":{"start_line":24,"start_character":42,"end_line":24,"end_character":50},"updated":"2020-12-02 12:43:52.000000000","message":"where it\u0027s defined? don\u0027t you need to use provider_branches instead?","commit_id":"3f1b4a8b519fb53545261cfc2d25cfd0243cebf5"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"24add3c089b57c5aac669ce10789ab3507d2f778","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"        - name: Set target branch as the latest alphabetically"},{"line_number":23,"context_line":"          set_fact:"},{"line_number":24,"context_line":"            built_repo_target_branch: \"{{ the_keys|max }}\""},{"line_number":25,"context_line":"          when: \"\u0027master\u0027 not in provider_branches\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        - name: Debug the built_repo_target_branch fact"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"789fdeb7_8d3c5b93","line":24,"range":{"start_line":24,"start_character":42,"end_line":24,"end_character":50},"in_reply_to":"453b7f0c_d9d5eb20","updated":"2020-12-02 13:15:59.000000000","message":"yeah you commented as i was updating it, it was a nit from my debug and it is fixed in v7 thanks","commit_id":"3f1b4a8b519fb53545261cfc2d25cfd0243cebf5"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"77691e16d236159d8e7999a534880ca672d6a7f3","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        - name: Debug the built_repo_target_branch fact"},{"line_number":28,"context_line":"          debug:"},{"line_number":29,"context_line":"            msg: \"content-provider built_repo_target_branch is {{ built_repo_target_branch }} at {{ registry_ip_address_branch[built_repo_target_branch] }}\""},{"line_number":30,"context_line":"          when:"},{"line_number":31,"context_line":"            - built_repo_target_branch is defined"},{"line_number":32,"context_line":"            - built_repo_target_branch"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"57a8e725_e3df2218","line":29,"range":{"start_line":29,"start_character":12,"end_line":29,"end_character":156},"updated":"2020-12-02 11:43:53.000000000","message":"msg: \u003e-\n  content-provider built_repo_target_branch is {{ built_repo_target_branch }}\n  at {{ registry_ip_address_branch[built_repo_target_branch] }}","commit_id":"3f1b4a8b519fb53545261cfc2d25cfd0243cebf5"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d1917981f1037dcfe2ccdfbd036cf1e3dc8d2b7c","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        - name: Debug the built_repo_target_branch fact"},{"line_number":28,"context_line":"          debug:"},{"line_number":29,"context_line":"            msg: \"content-provider built_repo_target_branch is {{ built_repo_target_branch }} at {{ registry_ip_address_branch[built_repo_target_branch] }}\""},{"line_number":30,"context_line":"          when:"},{"line_number":31,"context_line":"            - built_repo_target_branch is defined"},{"line_number":32,"context_line":"            - built_repo_target_branch"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f1acf9e_0edf15c9","line":29,"range":{"start_line":29,"start_character":12,"end_line":29,"end_character":156},"in_reply_to":"57a8e725_e3df2218","updated":"2020-12-02 12:12:21.000000000","message":"thanks will do","commit_id":"3f1b4a8b519fb53545261cfc2d25cfd0243cebf5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"3d68ca27e646c07a99b92b9b72dc5d9da0daebfe","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        - name: Debug the built_repo_target_branch fact"},{"line_number":28,"context_line":"          debug:"},{"line_number":29,"context_line":"            msg: \"content-provider built_repo_target_branch is {{ built_repo_target_branch }} at {{ registry_ip_address_branch[built_repo_target_branch] }}\""},{"line_number":30,"context_line":"          when:"},{"line_number":31,"context_line":"            - built_repo_target_branch is defined"},{"line_number":32,"context_line":"            - built_repo_target_branch"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        - name: Check if we have a repo"},{"line_number":35,"context_line":"          wait_for:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e51734d9_f3f5dfc4","line":32,"range":{"start_line":30,"start_character":10,"end_line":32,"end_character":38},"updated":"2020-12-02 12:43:52.000000000","message":"these conditions should bt needed as it will be always defined, also it fails if used like this as built_repo_target_branch is a string.","commit_id":"3f1b4a8b519fb53545261cfc2d25cfd0243cebf5"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"28be6801a7fac6c5b28a02efc807c7c4bd03fcb4","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- hosts: all"},{"line_number":3,"context_line":"  tasks:"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    - when: registry_ip_address_branch is defined"},{"line_number":6,"context_line":"      block:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"        - name: Collect the content provider branch keys into a list"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"cab5a741_ee25ab8e","line":5,"range":{"start_line":5,"start_character":12,"end_line":5,"end_character":43},"updated":"2020-12-03 09:24:47.000000000","message":"ok conditionals seem to hold up OK this time (so it seems confirmed it was the loop that was being pre-processed, regardless if the loop was executed or not)\n\n\n\n        * https://review.opendev.org/c/openstack/tripleo-ci/+/764359\n        * https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_fd0/764359/7/check/tripleo-ci-centos-8-content-provider/fd01cd0/job-output.txt\n        * 2020-12-02 17:28:34.785709 | LOOP [Collect the content provider branch keys into a list]\n        * 2020-12-02 17:28:35.654313 | primary | ok: 0 changed: 0 unreachable: 0 failed: 0 skipped: 7 rescued: 0 ignored: 0\n        * 2020-12-02 17:28:35.538359 | primary | skipping: Conditional result was False\n\n        * https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_8a1/764359/7/check/tripleo-ci-centos-8-standalone-upgrade/8a1eca7/job-output.txt\n        * 2020-12-02 18:49:22.485443 | LOOP [Collect the content provider branch keys into a list]\n2020-12-02 18:49:22.730117 | primary | ok:\n2020-12-02 18:49:22.730428 | primary | {\n2020-12-02 18:49:22.730526 | primary |   \"key\": \"master\",\n2020-12-02 18:49:22.730619 | primary |   \"value\": \"172.99.69.223\"\n2020-12-02 18:49:22.730711 | primary | }\n2020-12-02 18:49:22.745519 | primary | ok:\n2020-12-02 18:49:22.745707 | primary | {\n2020-12-02 18:49:22.745858 | primary |   \"key\": \"victoria\",\n2020-12-02 18:49:22.745950 | primary |   \"value\": \"104.130.239.7\"\n2020-12-02 18:49:22.746040 | primary | }\n        * 2020-12-02 18:49:23.149869 | TASK [Debug the built_repo_target_branch fact]\n2020-12-02 18:49:23.235748 | content-provider built_repo_target_branch is master at 172.99.69.223\n\n\n\n\t* https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_5a2/764359/7/check/tripleo-ci-centos-8-containers-multinode/5a20e16/job-output.txt\n\t* 2020-12-02 18:33:51.899858 | TASK [Debug the built_repo_target_branch fact]\n\t2020-12-02 18:33:51.977608 | content-provider built_repo_target_branch is master at 172.99.69.223","commit_id":"b7879314c4a64b610c6993084529ea7780756c91"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"28be6801a7fac6c5b28a02efc807c7c4bd03fcb4","unresolved":true,"context_lines":[{"line_number":17,"context_line":"            - provider_branches is defined"},{"line_number":18,"context_line":"            - \"\u0027master\u0027 in provider_branches\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"        - name: Set target branch as the latest alphabetically"},{"line_number":21,"context_line":"          set_fact:"},{"line_number":22,"context_line":"            built_repo_target_branch: \"{{ provider_branches|max }}\""},{"line_number":23,"context_line":"          when:"},{"line_number":24,"context_line":"            - provider_branches is defined and provider_branches"},{"line_number":25,"context_line":"            - \"\u0027master\u0027 not in provider_branches\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        - name: Fail if we don\u0027t have built_repo_target_branch"},{"line_number":28,"context_line":"          fail:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"b9ec2baa_ba94a129","line":25,"range":{"start_line":20,"start_character":21,"end_line":25,"end_character":27},"updated":"2020-12-03 09:24:47.000000000","message":"i will rework this bit to try and re-use what we have in run-provider","commit_id":"b7879314c4a64b610c6993084529ea7780756c91"}]}