)]}'
{"roles/build-containers/tasks/package_setup.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"34fdf376c7912ee0796e494d090c024609f8b7d7","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    name:"},{"line_number":11,"context_line":"      - \"openstack-kolla\""},{"line_number":12,"context_line":"  when:"},{"line_number":13,"context_line":"    - ansible_distribution_major_version|int \u003c\u003d 7"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: set template override"},{"line_number":16,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"885c1a6d_f89300e4","line":13,"range":{"start_line":13,"start_character":40,"end_line":13,"end_character":48},"updated":"2020-12-01 08:18:54.000000000","message":"can you use \"is version(\u00277\u0027, \u0027\u003c\u003d\u0027)\" then we don\u0027t need to worry about casting to int or any potential type errors later","commit_id":"5432ad8c926294931da73b2e70cce90085bfaeb4"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"c73180948f4bef5447f8ca6b467f01b7b4183ee0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    name:"},{"line_number":11,"context_line":"      - \"openstack-kolla\""},{"line_number":12,"context_line":"  when:"},{"line_number":13,"context_line":"    - ansible_distribution_major_version|int \u003c\u003d 7"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: set template override"},{"line_number":16,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"affb2e9b_552cdb7c","line":13,"range":{"start_line":13,"start_character":40,"end_line":13,"end_character":48},"in_reply_to":"885c1a6d_f89300e4","updated":"2020-12-01 21:30:27.000000000","message":"Done","commit_id":"5432ad8c926294931da73b2e70cce90085bfaeb4"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2edb2e90c29b88a69212572cad27175ed3b7dd93","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- name: Include OS distro version specific variables"},{"line_number":2,"context_line":"  include_vars: \"{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- name: install tripleo dependencies from package"},{"line_number":5,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"0acb7c47_7ef1520b","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":14},"updated":"2020-12-02 08:29:29.000000000","message":"nice 😄","commit_id":"19a0eac70b57b1a5cad057d201bf6d338f753c3e"}],"roles/build-containers/tasks/venv_setup.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"34fdf376c7912ee0796e494d090c024609f8b7d7","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    virtualenv_python: \"{{ virtualenv_python[ansible_distribution_major_version|int] }}\""},{"line_number":31,"context_line":"  with_items: \"{{ upper_constraints_items }}\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: set_fact for requirements items"},{"line_number":34,"context_line":"  set_fact:"},{"line_number":35,"context_line":"    requirements_items:"},{"line_number":36,"context_line":"      - openstack-tripleo-common"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"158cf77d_ad9f5ef0","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":16},"updated":"2020-12-01 08:18:54.000000000","message":"why not add to the vars instead of setting a fact here? https://opendev.org/openstack/tripleo-ci/src/commit/c83900be5b2f7cd75ed2e144f6b5f9fc59373bdd/roles/build-containers/defaults/main.yaml","commit_id":"5432ad8c926294931da73b2e70cce90085bfaeb4"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"34fdf376c7912ee0796e494d090c024609f8b7d7","unresolved":true,"context_lines":[{"line_number":37,"context_line":"      - python-tripleoclient"},{"line_number":38,"context_line":"      - tripleo-ansible"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: set_fact for requirements items - kolla"},{"line_number":41,"context_line":"  set_fact:"},{"line_number":42,"context_line":"    requirements_items: \"{{ requirements_items + [ \u0027kolla\u0027 ] }}\""},{"line_number":43,"context_line":"  when: ansible_distribution_major_version|int \u003c\u003d 7"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3ab96276_04a24b8c","line":40,"range":{"start_line":40,"start_character":2,"end_line":40,"end_character":6},"updated":"2020-12-01 08:18:54.000000000","message":"this one could probably stay here. it could possibly also go to the defaults too though if you wanted to (e.g. with jinja conditionals instead of when:)","commit_id":"5432ad8c926294931da73b2e70cce90085bfaeb4"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"c73180948f4bef5447f8ca6b467f01b7b4183ee0","unresolved":true,"context_lines":[{"line_number":37,"context_line":"      - python-tripleoclient"},{"line_number":38,"context_line":"      - tripleo-ansible"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: set_fact for requirements items - kolla"},{"line_number":41,"context_line":"  set_fact:"},{"line_number":42,"context_line":"    requirements_items: \"{{ requirements_items + [ \u0027kolla\u0027 ] }}\""},{"line_number":43,"context_line":"  when: ansible_distribution_major_version|int \u003c\u003d 7"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"4cec337c_27004633","line":40,"range":{"start_line":40,"start_character":2,"end_line":40,"end_character":6},"in_reply_to":"3ab96276_04a24b8c","updated":"2020-12-01 21:30:27.000000000","message":"I thought about this ...\njinja conditions required either dup\u0027in the var as you can\u0027t have an empty additional item in the list","commit_id":"5432ad8c926294931da73b2e70cce90085bfaeb4"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"34fdf376c7912ee0796e494d090c024609f8b7d7","unresolved":true,"context_lines":[{"line_number":40,"context_line":"- name: set_fact for requirements items - kolla"},{"line_number":41,"context_line":"  set_fact:"},{"line_number":42,"context_line":"    requirements_items: \"{{ requirements_items + [ \u0027kolla\u0027 ] }}\""},{"line_number":43,"context_line":"  when: ansible_distribution_major_version|int \u003c\u003d 7"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- name: Install deps from requirements"},{"line_number":46,"context_line":"  when: zuul_internal is defined"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"aa73898f_b07a4224","line":43,"range":{"start_line":43,"start_character":42,"end_line":43,"end_character":46},"updated":"2020-12-01 08:18:54.000000000","message":"is version","commit_id":"5432ad8c926294931da73b2e70cce90085bfaeb4"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"c73180948f4bef5447f8ca6b467f01b7b4183ee0","unresolved":false,"context_lines":[{"line_number":40,"context_line":"- name: set_fact for requirements items - kolla"},{"line_number":41,"context_line":"  set_fact:"},{"line_number":42,"context_line":"    requirements_items: \"{{ requirements_items + [ \u0027kolla\u0027 ] }}\""},{"line_number":43,"context_line":"  when: ansible_distribution_major_version|int \u003c\u003d 7"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- name: Install deps from requirements"},{"line_number":46,"context_line":"  when: zuul_internal is defined"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9798b532_c4f22dbe","line":43,"range":{"start_line":43,"start_character":42,"end_line":43,"end_character":46},"in_reply_to":"aa73898f_b07a4224","updated":"2020-12-01 21:30:27.000000000","message":"Done","commit_id":"5432ad8c926294931da73b2e70cce90085bfaeb4"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"34fdf376c7912ee0796e494d090c024609f8b7d7","unresolved":true,"context_lines":[{"line_number":63,"context_line":"      - \"file://{{ openstack_git_root }}/{% if zuul_internal is defined %}openstack-{% endif %}tripleo-common\""},{"line_number":64,"context_line":"      - \"file://{{ openstack_git_root }}/python-tripleoclient\""},{"line_number":65,"context_line":"      - \"file://{{ openstack_git_root }}/tripleo-ansible\""},{"line_number":66,"context_line":"      - decorator"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"- name: Installation from source"},{"line_number":69,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"d15ea2c8_9984f362","line":66,"updated":"2020-12-01 08:18:54.000000000","message":"better if you add a when: ansible_distribution_major_version is version(\"7\", \"\u003e\") here then you  dont have to have a special fact name on line 55 ... i.e. you can just have source_items in both and only one of them will be executed because of the conditionals.","commit_id":"5432ad8c926294931da73b2e70cce90085bfaeb4"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"c73180948f4bef5447f8ca6b467f01b7b4183ee0","unresolved":false,"context_lines":[{"line_number":63,"context_line":"      - \"file://{{ openstack_git_root }}/{% if zuul_internal is defined %}openstack-{% endif %}tripleo-common\""},{"line_number":64,"context_line":"      - \"file://{{ openstack_git_root }}/python-tripleoclient\""},{"line_number":65,"context_line":"      - \"file://{{ openstack_git_root }}/tripleo-ansible\""},{"line_number":66,"context_line":"      - decorator"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"- name: Installation from source"},{"line_number":69,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"c0ef2423_ec47faf6","line":66,"in_reply_to":"d15ea2c8_9984f362","updated":"2020-12-01 21:30:27.000000000","message":"Done","commit_id":"5432ad8c926294931da73b2e70cce90085bfaeb4"}],"roles/build-containers/vars/centos-7.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c310bb6c64d933432536a568c82a9cd2ce9b582b","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"upper_constraints_items:"},{"line_number":7,"context_line":"  - tripleo-common"},{"line_number":8,"context_line":"  - python-tripleoclient"},{"line_number":9,"context_line":"  - tripleo-ansible"},{"line_number":10,"context_line":"  - kolla"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ac6b4ef1_b4bd5254","line":8,"updated":"2020-12-02 13:41:01.000000000","message":"so do they all have to be python* in this file then? i see 4 of them\n\nNO these are pip installs so has to be like that","commit_id":"9e1873b359b814cb59f5c4aa9e8061ccd17f91a2"}],"roles/build-containers/vars/centos-8.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2edb2e90c29b88a69212572cad27175ed3b7dd93","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"tripleo_deps_from_package:"},{"line_number":3,"context_line":"  - \"python*-tripleoclient\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"upper_constraints_items:"},{"line_number":6,"context_line":"  - tripleo-common"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"232db8ac_4933471d","line":3,"range":{"start_line":3,"start_character":11,"end_line":3,"end_character":12},"updated":"2020-12-02 08:29:29.000000000","message":"can we make this explicit now we have a file just for centos8?\ni.e. python3-tripleoclient ?\n\nit might let us know if something has gone wrong e.g. python-tripleoclient is available and installed instead","commit_id":"19a0eac70b57b1a5cad057d201bf6d338f753c3e"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"1af602cf7fe3b5af8608c79e9a921e3bd3928195","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"tripleo_deps_from_package:"},{"line_number":3,"context_line":"  - \"python*-tripleoclient\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"upper_constraints_items:"},{"line_number":6,"context_line":"  - tripleo-common"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"96192b5b_19457f47","line":3,"range":{"start_line":3,"start_character":11,"end_line":3,"end_character":12},"in_reply_to":"232db8ac_4933471d","updated":"2020-12-02 13:23:25.000000000","message":"I\u0027m on the fence about this one. Leaving the * makes it consistent with hrle9 one going forward that could have another version of python - and saves updates going forward.","commit_id":"19a0eac70b57b1a5cad057d201bf6d338f753c3e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9ce1e513c3c874af2211a4192a7c9dd5cf231092","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"tripleo_deps_from_package:"},{"line_number":3,"context_line":"  - \"python*-tripleoclient\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"upper_constraints_items:"},{"line_number":6,"context_line":"  - tripleo-common"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3f2a0d5d_1f2dfa20","line":3,"range":{"start_line":3,"start_character":11,"end_line":3,"end_character":12},"in_reply_to":"96192b5b_19457f47","updated":"2020-12-02 13:29:56.000000000","message":"I think it is better to be explicit, since we can be. We have a per release vars file with your latest update.\n\nLeaving it as * has the potential to mask problems. We _have_ a rhel9 vars file added here so if we need to update that to python4 python* we can do that later?","commit_id":"19a0eac70b57b1a5cad057d201bf6d338f753c3e"}]}