)]}'
{"roles/run-test/tasks/main.yaml":[{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"0fb0c7b1adff66948c2e681f46b63f1f335114c7","unresolved":true,"context_lines":[{"line_number":11,"context_line":"        - \u0027cirros_image\u0027"},{"line_number":12,"context_line":"        - \u0027dlrn_hash_tag\u0027"},{"line_number":13,"context_line":"        - \u0027dlrn_hash_tag_newest\u0027"},{"line_number":14,"context_line":"        - \u0027extra_args\u0027"},{"line_number":15,"context_line":"        - \u0027run_tempest\u0027"},{"line_number":16,"context_line":"        - \u0027standalone_container_cli\u0027"},{"line_number":17,"context_line":"        - \u0027standalone_environment_files\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bd20226c_584b931f","line":14,"updated":"2021-01-07 15:01:39.000000000","message":"this is a kind of generic variable name.\nI think it\u0027s the extra_args in deploy?\nmaybe a comment there would be helpful so people know it\u0027s not just random extra_rags to the playbooks","commit_id":"c927a4b34858963e8a3cebb72d724cb07537345d"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"9cbc6c0d5f0cbbee71521692f4356f3da9a1a491","unresolved":true,"context_lines":[{"line_number":11,"context_line":"        - \u0027cirros_image\u0027"},{"line_number":12,"context_line":"        - \u0027dlrn_hash_tag\u0027"},{"line_number":13,"context_line":"        - \u0027dlrn_hash_tag_newest\u0027"},{"line_number":14,"context_line":"        - \u0027extra_args\u0027"},{"line_number":15,"context_line":"        - \u0027run_tempest\u0027"},{"line_number":16,"context_line":"        - \u0027standalone_container_cli\u0027"},{"line_number":17,"context_line":"        - \u0027standalone_environment_files\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8eb8daa6_99b40812","line":14,"in_reply_to":"bd20226c_584b931f","updated":"2021-01-07 16:36:55.000000000","message":"Hi Ronelle,\n\nThanks for review.\n\n\u003e\u003e I think it\u0027s the extra_args in deploy?\n\nYes, extra_args is one of the different args[1] which overcloud-deploy role supports(tripleo-quickstart-extras) and which allows us to make final deployment command. \n\nApart from extra_args we have 26 more args but we don\u0027t have an explanation about them in overcloud-deploy role README.md file[2] or anywhere else. We use these different args all over in our featureset files[3] and good explanation in overcloud-deploy role will be beneficial.\n\nI agree with you that its a generic variable names and it would be helpful to have some explanations(comment). IMHO  overcloud-deploy role(tqe) README.md will be correct place to have this explanation. If its okay with you?\n\nI filed a documentation bug[4] to add information about these args. We can circle back on the doc bug[4] when time permits(hopefully we will be able to close this doc bug).\n\n[1] https://opendev.org/openstack/tripleo-quickstart-extras/src/branch/master/roles/overcloud-deploy/defaults/main.yml#L118-L145\n\n[2] https://opendev.org/openstack/tripleo-quickstart-extras/src/branch/master/roles/overcloud-deploy/README.md\n\n[3] https://codesearch.opendev.org/?q\u003d_args\u0026i\u003dnope\u0026files\u003dconfig%2Fgeneral_config\u0026excludeFiles\u003d\u0026repos\u003dopenstack/tripleo-quickstart\n\n[4] https://bugs.launchpad.net/tripleo/+bug/1910564","commit_id":"c927a4b34858963e8a3cebb72d724cb07537345d"}]}