)]}'
{"roles/run-test/templates/toci_gate_test.sh.j2":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"83c0d90d616b3f75fc90154b48fac148dfbfcb7e","unresolved":true,"context_lines":[{"line_number":47,"context_line":"    (curl -s \"https://bootstrap.pypa.io/get-pip.py\" -o \"get-pip.py\"; sudo $(python_cmd) get-pip.py)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"if [ \"$(python_cmd)\" \u003d\u003d \"python3\" ]; then"},{"line_number":50,"context_line":"    sudo $(python_cmd) -m pip install requests"},{"line_number":51,"context_line":"    sudo $(package_manager) install python3-setuptools python3-requests python3-urllib3 python3-PyYAML"},{"line_number":52,"context_line":"else"},{"line_number":53,"context_line":"    sudo $(package_manager) install python2-setuptools python2-requests python-requests python-urllib3 PyYAML"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ef262909_75220def","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":46},"updated":"2021-01-06 13:19:41.000000000","message":"so it worked fine, would be good to do this only for $(package_manager) \u003d\u003d  \"/usr/bin/yum\" as mixing pip with sudo and rpms is not good. and also can remove DNM and update commit message","commit_id":"774d8900cda53fc6d14179b2aaac40a8bb35b237"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"48a85326415bb70491382ecdff4edc0944941019","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"if [ \"$(python_cmd)\" \u003d\u003d \"python3\" ]; then"},{"line_number":50,"context_line":"    sudo $(python_cmd) -m pip install requests"},{"line_number":51,"context_line":"    sudo $(package_manager) install python3-setuptools python3-requests python3-urllib3 python3-PyYAML"},{"line_number":52,"context_line":"else"},{"line_number":53,"context_line":"    sudo $(package_manager) install python2-setuptools python2-requests python-requests python-urllib3 PyYAML"},{"line_number":54,"context_line":"fi"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"e1c3f1f9_2214f897","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":102},"updated":"2021-01-06 16:26:57.000000000","message":"I agree with yatin, we should not mix package installation with pip and rpm install.\n\nhttps://logserver.rdoproject.org/openstack-periodic-integration-stable4-5/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-7-multinode-1ctlr-featureset037-updates-stein/96a4566/job-output.txt\n~~~\n2021-01-03 13:53:21.701961 | primary | No package python3-requests available.\n2021-01-03 13:53:21.825667 | primary | No package python3-urllib3 available\n~~~\n\nBut if we considering installing using rpm, Is there a repo in Centos from where we can pull python3-requests ?\n\n@Yatin I didn\u0027t get your comment completely regarding doing this only for $(package_manager) \u003d\u003d  \"/usr/bin/yum\". Could you please elaborate.","commit_id":"774d8900cda53fc6d14179b2aaac40a8bb35b237"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"21c860d5a3175b6b0c106b485e8827d6dc408194","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"if [ \"$(python_cmd)\" \u003d\u003d \"python3\" ]; then"},{"line_number":50,"context_line":"    sudo $(python_cmd) -m pip install requests"},{"line_number":51,"context_line":"    sudo $(package_manager) install python3-setuptools python3-requests python3-urllib3 python3-PyYAML"},{"line_number":52,"context_line":"else"},{"line_number":53,"context_line":"    sudo $(package_manager) install python2-setuptools python2-requests python-requests python-urllib3 PyYAML"},{"line_number":54,"context_line":"fi"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ed156c61_a5a1baa0","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":102},"in_reply_to":"e1c3f1f9_2214f897","updated":"2021-01-07 06:30:20.000000000","message":"actually python3 requests rpm is not available in CentOS7 base repos, so with $(package_manager) \u003d\u003d  \"/usr/bin/yum\" condition we ensure that requests is installed from pip only on CentOS7 systems and not on CentOS8/rhel8 etc. we can install those from epel though but that would add an additional dep and we should avoid dep on epel. The chances of mix are more in EL8 distros as that\u0027s pure python3 while in C7 only limited set of python3 packages are available so we can live with this hack.","commit_id":"774d8900cda53fc6d14179b2aaac40a8bb35b237"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"db03e251856a8a7f9ccf1f55c86ce817e518cfdd","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    sudo $(package_manager) install python2-setuptools python2-requests python-requests python-urllib3 PyYAML"},{"line_number":53,"context_line":"fi"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"if [ \"$(package_manager)\" \u003d\u003d \"/usr/bin/yum\"]; then"},{"line_number":56,"context_line":"   sudo $(python_cmd) -m pip install requests"},{"line_number":57,"context_line":"fi"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ec8bf136_9dea2b04","line":55,"updated":"2021-01-07 07:12:30.000000000","message":"space needed before bracket close","commit_id":"8531bd893d26724f1011c4e77fbe7d58784b119d"}]}