)]}'
{"zuul.d/standalone-jobs.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a1c29ba94cc6175e231580ae644ae35ecc24523f","unresolved":true,"context_lines":[{"line_number":929,"context_line":"          - manila"},{"line_number":930,"context_line":"        tempest_tempest_conf_overrides:"},{"line_number":931,"context_line":"          \u0027share.multitenancy_enabled\u0027: \u0027False\u0027"},{"line_number":932,"context_line":"          \u0027share.enable_protocols\u0027: \u0027NFS\u0027"},{"line_number":933,"context_line":"          \u0027share.capability_snapshot_support\u0027: \u0027False\u0027"},{"line_number":934,"context_line":"          \u0027share.capability_create_share_from_snapshot_support\u0027: \u0027False\u0027"},{"line_number":935,"context_line":"        tempest_test_whitelist:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6ccf8a8f_49ba3bf5","line":932,"updated":"2021-01-14 08:03:00.000000000","message":"looks like the config is OK \"enable_protocols \u003d NFS\" @ https://7947741bdef63a16780e-a8f4a99bc353c122bd7e35753402ec62.ssl.cf2.rackcdn.com/770049/2/check/tripleo-ci-centos-8-scenario004-standalone/96b7d57/logs/undercloud/etc/tempest/tempest.conf\n\nbut do we need to enable a different tempest test to check that? I see the SharesCephFSTest is skipped at https://7947741bdef63a16780e-a8f4a99bc353c122bd7e35753402ec62.ssl.cf2.rackcdn.com/770049/2/check/tripleo-ci-centos-8-scenario004-standalone/96b7d57/logs/undercloud/var/log/tempest/stestr_results.html  (which makes sense if we don\u0027t have cephfs in enable_protocols) is there a different test for NFS?","commit_id":"b4d20b5285bed2bbd40984508eb092ea66fcbd04"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"4bfdb7a81a99c174bdef596928d6bdd758a1c165","unresolved":false,"context_lines":[{"line_number":929,"context_line":"          - manila"},{"line_number":930,"context_line":"        tempest_tempest_conf_overrides:"},{"line_number":931,"context_line":"          \u0027share.multitenancy_enabled\u0027: \u0027False\u0027"},{"line_number":932,"context_line":"          \u0027share.enable_protocols\u0027: \u0027NFS\u0027"},{"line_number":933,"context_line":"          \u0027share.capability_snapshot_support\u0027: \u0027False\u0027"},{"line_number":934,"context_line":"          \u0027share.capability_create_share_from_snapshot_support\u0027: \u0027False\u0027"},{"line_number":935,"context_line":"        tempest_test_whitelist:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"39be0570_a544d506","line":932,"in_reply_to":"6ccf8a8f_49ba3bf5","updated":"2021-01-14 18:47:56.000000000","message":"Good catch!  I will update the tempest_test_whitelist.","commit_id":"b4d20b5285bed2bbd40984508eb092ea66fcbd04"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5d9841646923d872812189430163bada36f8f4bb","unresolved":true,"context_lines":[{"line_number":751,"context_line":"          - manila"},{"line_number":752,"context_line":"        tempest_tempest_conf_overrides:"},{"line_number":753,"context_line":"          \u0027share.multitenancy_enabled\u0027: \u0027False\u0027"},{"line_number":754,"context_line":"          \u0027share.enable_protocols\u0027: \u0027cephfs\u0027"},{"line_number":755,"context_line":"          \u0027share.capability_snapshot_support\u0027: \u0027False\u0027"},{"line_number":756,"context_line":"          \u0027share.capability_create_share_from_snapshot_support\u0027: \u0027False\u0027"},{"line_number":757,"context_line":"        tempest_test_whitelist:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a2d76441_cefa2d16","line":754,"range":{"start_line":754,"start_character":37,"end_line":754,"end_character":43},"updated":"2021-01-15 07:58:31.000000000","message":"@Tom did you mean to change the c7 one too?","commit_id":"4e94dd806e1d1eb4474eafe12d23ec0d2dd054b2"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ad716263626acd4451a3a59cb1467bd7a0b23bdf","unresolved":false,"context_lines":[{"line_number":751,"context_line":"          - manila"},{"line_number":752,"context_line":"        tempest_tempest_conf_overrides:"},{"line_number":753,"context_line":"          \u0027share.multitenancy_enabled\u0027: \u0027False\u0027"},{"line_number":754,"context_line":"          \u0027share.enable_protocols\u0027: \u0027cephfs\u0027"},{"line_number":755,"context_line":"          \u0027share.capability_snapshot_support\u0027: \u0027False\u0027"},{"line_number":756,"context_line":"          \u0027share.capability_create_share_from_snapshot_support\u0027: \u0027False\u0027"},{"line_number":757,"context_line":"        tempest_test_whitelist:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a2830e86_ec7fdd84","line":754,"range":{"start_line":754,"start_character":37,"end_line":754,"end_character":43},"in_reply_to":"a2d76441_cefa2d16","updated":"2021-01-15 12:51:01.000000000","message":"No, I was aiming only for CentOS8 (for now at least).","commit_id":"4e94dd806e1d1eb4474eafe12d23ec0d2dd054b2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5d9841646923d872812189430163bada36f8f4bb","unresolved":true,"context_lines":[{"line_number":934,"context_line":"          \u0027share.capability_create_share_from_snapshot_support\u0027: \u0027False\u0027"},{"line_number":935,"context_line":"        tempest_test_whitelist:"},{"line_number":936,"context_line":"          - \u0027tempest.scenario.test_network_basic_ops.TestNetworkBasicOps.test_network_basic_ops\u0027"},{"line_number":937,"context_line":"          - \u0027manila_tempest_tests.tests.api.test_shares.SharesCephFSTest.test_create_get_delete_share\u0027"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":"- job:"},{"line_number":940,"context_line":"    name: tripleo-ci-centos-8-scenario007-standalone"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6bac398d_e26a7a6a","line":937,"range":{"start_line":937,"start_character":56,"end_line":937,"end_character":72},"updated":"2021-01-15 07:58:31.000000000","message":"I think this is the one you meant to update","commit_id":"4e94dd806e1d1eb4474eafe12d23ec0d2dd054b2"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ad716263626acd4451a3a59cb1467bd7a0b23bdf","unresolved":false,"context_lines":[{"line_number":934,"context_line":"          \u0027share.capability_create_share_from_snapshot_support\u0027: \u0027False\u0027"},{"line_number":935,"context_line":"        tempest_test_whitelist:"},{"line_number":936,"context_line":"          - \u0027tempest.scenario.test_network_basic_ops.TestNetworkBasicOps.test_network_basic_ops\u0027"},{"line_number":937,"context_line":"          - \u0027manila_tempest_tests.tests.api.test_shares.SharesCephFSTest.test_create_get_delete_share\u0027"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":"- job:"},{"line_number":940,"context_line":"    name: tripleo-ci-centos-8-scenario007-standalone"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b1151a4b_7af6eac8","line":937,"range":{"start_line":937,"start_character":56,"end_line":937,"end_character":72},"in_reply_to":"6bac398d_e26a7a6a","updated":"2021-01-15 12:51:01.000000000","message":"D\u0027oh.  Will fix!","commit_id":"4e94dd806e1d1eb4474eafe12d23ec0d2dd054b2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1ee88e68b5c58abc33d263e61ded2c6d52f40160","unresolved":true,"context_lines":[{"line_number":934,"context_line":"          \u0027share.capability_create_share_from_snapshot_support\u0027: \u0027False\u0027"},{"line_number":935,"context_line":"        tempest_test_whitelist:"},{"line_number":936,"context_line":"          - \u0027tempest.scenario.test_network_basic_ops.TestNetworkBasicOps.test_network_basic_ops\u0027"},{"line_number":937,"context_line":"          - \u0027manila_tempest_tests.tests.api.test_shares.SharesNFSTest.test_create_get_delete_share\u0027"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":"- job:"},{"line_number":940,"context_line":"    name: tripleo-ci-centos-8-scenario007-standalone"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fe0b669_5295ffd8","line":937,"range":{"start_line":937,"start_character":56,"end_line":937,"end_character":69},"updated":"2021-01-18 07:52:44.000000000","message":"thank you \n\nit looks like it still skips this test though. Perhaps you want to get this merged and investigate for a followup\n\n skip\n[x]\n\n        \npt1.1: setUpClass (manila_tempest_tests.tests.api.test_shares.SharesNFSTest)\n\n        \n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_d0b/770049/4/check/tripleo-ci-centos-8-scenario004-standalone/d0bf911/logs/undercloud/var/log/tempest/stestr_results.html","commit_id":"6bc779328d899455304be673ee1b6bfe1bbeb8b2"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"3953fc8e1191ceaa0edc884aa618450e66f99a8f","unresolved":false,"context_lines":[{"line_number":934,"context_line":"          \u0027share.capability_create_share_from_snapshot_support\u0027: \u0027False\u0027"},{"line_number":935,"context_line":"        tempest_test_whitelist:"},{"line_number":936,"context_line":"          - \u0027tempest.scenario.test_network_basic_ops.TestNetworkBasicOps.test_network_basic_ops\u0027"},{"line_number":937,"context_line":"          - \u0027manila_tempest_tests.tests.api.test_shares.SharesNFSTest.test_create_get_delete_share\u0027"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":"- job:"},{"line_number":940,"context_line":"    name: tripleo-ci-centos-8-scenario007-standalone"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ce0bd581_6d0ed906","line":937,"range":{"start_line":937,"start_character":56,"end_line":937,"end_character":69},"in_reply_to":"3fe0b669_5295ffd8","updated":"2021-01-18 15:37:38.000000000","message":"Wow, that\u0027s a very helpful skip message :)  As best I can tell tempest is expecting the enable_protocols to be lower case though.   Let me try that and if it doesn\u0027t work I may take you up on the kind followup patch offer.","commit_id":"6bc779328d899455304be673ee1b6bfe1bbeb8b2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fff0ee37daa5f8976235d4f582b818070cd6e9f2","unresolved":true,"context_lines":[{"line_number":934,"context_line":"          \u0027share.capability_create_share_from_snapshot_support\u0027: \u0027False\u0027"},{"line_number":935,"context_line":"        tempest_test_whitelist:"},{"line_number":936,"context_line":"          - \u0027tempest.scenario.test_network_basic_ops.TestNetworkBasicOps.test_network_basic_ops\u0027"},{"line_number":937,"context_line":"          - \u0027manila_tempest_tests.tests.api.test_shares.SharesNFSTest.test_create_get_delete_share\u0027"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":"- job:"},{"line_number":940,"context_line":"    name: tripleo-ci-centos-8-scenario007-standalone"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b85d35bf_29e8b35d","line":937,"updated":"2021-01-19 07:20:58.000000000","message":"so now it does run but it fails as it can\u0027t find \u0027NFS\u0027 as configured.\n\n\n        * https://b52e93f39937b9dff3e9-f9581a5a5cbf2c732684738263e0ea57.ssl.cf2.rackcdn.com/770049/5/check/tripleo-ci-centos-8-scenario004-standalone/dc98382/logs/undercloud/etc/tempest/tempest.conf\n        \t* enable_protocols \u003d nfs\n        \n        * https://b52e93f39937b9dff3e9-f9581a5a5cbf2c732684738263e0ea57.ssl.cf2.rackcdn.com/770049/5/check/tripleo-ci-centos-8-scenario004-standalone/dc98382/logs/undercloud/var/log/tempest/stestr_results.html\n        \t* tempest.lib.exceptions.BadRequest: Bad request\nDetails: {\u0027code\u0027: 400, \u0027message\u0027: \"Invalid input received: Invalid share protocol provided: NFS. It is either disabled or unsupported. Available protocols: [\u0027CEPHFS\u0027].\"}\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nSo if you configure \u0027NFS\u0027 it skips the test. If you configure \u0027nfs\u0027 it runs the test but fails as it wants \u0027NFS\u0027... :/\n\nsounds like it could be a bug in the tempest test?","commit_id":"21fad43190dd9059942cd3196e48127894c450a1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0940e093f7b6af8d44ff0a9f798174b29cbcae36","unresolved":true,"context_lines":[{"line_number":934,"context_line":"          \u0027share.capability_create_share_from_snapshot_support\u0027: \u0027False\u0027"},{"line_number":935,"context_line":"        tempest_test_whitelist:"},{"line_number":936,"context_line":"          - \u0027tempest.scenario.test_network_basic_ops.TestNetworkBasicOps.test_network_basic_ops\u0027"},{"line_number":937,"context_line":"          - \u0027manila_tempest_tests.tests.api.test_shares.SharesNFSTest.test_create_get_delete_share\u0027"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":"- job:"},{"line_number":940,"context_line":"    name: tripleo-ci-centos-8-scenario007-standalone"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b3233bb0_d775fd91","line":937,"in_reply_to":"b85d35bf_29e8b35d","updated":"2021-01-19 13:18:33.000000000","message":"I suspect that we also need the changes in https://review.opendev.org/c/openstack/tripleo-heat-templates/+/769937 for the tempest test case to work properly.  I\u0027ve already set up that change to depend on this one, since it needs to pass scenario004 to merge, so we may have a circular dependency.  To test this theory, I just rechecked 769937 so that it will pick up the tempest whitelist change from here (it last ran with the CephFS test case, and skipped it).\nIf that works, then I propose deferring the tempest whitelist change from CephFS to NFS from this patch and doing it as a third change depending on 769937.  If it doesn\u0027t work, then back to the drawing board.  This NFS test case works with other back ends in other jobs.","commit_id":"21fad43190dd9059942cd3196e48127894c450a1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"65c70b4e51df025d7cb66119677de847b5654d72","unresolved":true,"context_lines":[{"line_number":934,"context_line":"          \u0027share.capability_create_share_from_snapshot_support\u0027: \u0027False\u0027"},{"line_number":935,"context_line":"        tempest_test_whitelist:"},{"line_number":936,"context_line":"          - \u0027tempest.scenario.test_network_basic_ops.TestNetworkBasicOps.test_network_basic_ops\u0027"},{"line_number":937,"context_line":"          # Add the following back after"},{"line_number":938,"context_line":"          # https://review.opendev.org/c/openstack/tripleo-heat-templates/+/769937 merges"},{"line_number":939,"context_line":"          # - \u0027manila_tempest_tests.tests.api.test_shares.SharesNFSTest.test_create_get_delete_share\u0027"},{"line_number":940,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"130e7451_e28f95e8","line":937,"range":{"start_line":937,"start_character":10,"end_line":937,"end_character":15},"updated":"2021-01-21 08:12:32.000000000","message":"ack thanks for adding the note\nyou could even just go ahead and post another review ontop of this one right now with the depends-on and removing the comments here and then its less likely to be forgotten. It can merge once the depends-on does.","commit_id":"848dab54cb156fb3e63b07645b8941e364e8a83d"}]}