)]}'
{"playbooks/tripleo-ci/post.yaml":[{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"df96db8f3928fc69fdbffd3d03cdc80349e20f0e","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        path: \"{{ ansible_user_dir }}/workspace/log\""},{"line_number":50,"context_line":"        state: directory"},{"line_number":51,"context_line":"        recurse: yes"},{"line_number":52,"context_line":"      when: log_dir_exists.stat.exists"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    - name: Copy zuul_console_json log to workspace for reproducer"},{"line_number":55,"context_line":"      copy:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"39820ad9_537ed713","line":52,"updated":"2021-01-27 21:49:33.000000000","message":"when not log_dir_exists.stat.exists?\n\niiuc, only create when the dir does not exist","commit_id":"c897d24636d19ff39d29abfffaede470529ed042"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"82e7cba7181f03049ba01b1a3d1a725f2f607c1d","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        path: \"{{ ansible_user_dir }}/workspace/log\""},{"line_number":50,"context_line":"        state: directory"},{"line_number":51,"context_line":"        recurse: yes"},{"line_number":52,"context_line":"      when: log_dir_exists.stat.exists"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    - name: Copy zuul_console_json log to workspace for reproducer"},{"line_number":55,"context_line":"      copy:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"790f1b17_211a7e77","line":52,"in_reply_to":"39820ad9_537ed713","updated":"2021-01-28 08:14:47.000000000","message":"+1 and if you prefer you can use .stat.exists \u003d\u003d false","commit_id":"c897d24636d19ff39d29abfffaede470529ed042"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"5f6d29ed9c035f3350421ba641c30f7475a46f05","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        path: \"{{ ansible_user_dir }}/workspace/log\""},{"line_number":50,"context_line":"        state: directory"},{"line_number":51,"context_line":"        recurse: yes"},{"line_number":52,"context_line":"      when: log_dir_exists.stat.exists"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    - name: Copy zuul_console_json log to workspace for reproducer"},{"line_number":55,"context_line":"      copy:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d72d1bdf_77eb5ed9","line":52,"in_reply_to":"790f1b17_211a7e77","updated":"2021-01-29 09:18:35.000000000","message":"good catch.. thanks. I\u0027ll update it.","commit_id":"c897d24636d19ff39d29abfffaede470529ed042"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"cd29ef8c7562706c9de5a9a6406e0e5b70433144","unresolved":true,"context_lines":[{"line_number":39,"context_line":"      set_fact:"},{"line_number":40,"context_line":"        collect_timeout_sec: \"{{ zuul.post_timeout|default(3600) -  copy_logs_time|default(300) }}\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - name: \"Check if {{ ansible_user_dir }}/workspace/log exists\""},{"line_number":43,"context_line":"      stat:"},{"line_number":44,"context_line":"        path: \"{{ ansible_user_dir }}/workspace/log\""},{"line_number":45,"context_line":"      register: log_dir_exists"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d7e9148a_45e5a96b","line":42,"updated":"2021-01-30 19:27:27.000000000","message":"no need to check if it exists, ansible module is idempotent","commit_id":"e28d0b1360d341abd83d617be9da228c99d79abb"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"cd29ef8c7562706c9de5a9a6406e0e5b70433144","unresolved":true,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - name: \"Create log directory if not exists\""},{"line_number":48,"context_line":"      file:"},{"line_number":49,"context_line":"        path: \"{{ ansible_user_dir }}/workspace/log\""},{"line_number":50,"context_line":"        state: directory"},{"line_number":51,"context_line":"        recurse: yes"},{"line_number":52,"context_line":"      when: not log_dir_exists.stat.exists"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6b50fa1d_c0511e14","line":49,"range":{"start_line":49,"start_character":15,"end_line":49,"end_character":51},"updated":"2021-01-30 19:27:27.000000000","message":"1. afaiu it should \"logs\", not \"log\"\n2. it should be created in the beginning of the playbook not here","commit_id":"e28d0b1360d341abd83d617be9da228c99d79abb"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"decca95a2d9156a3caa4a610ee0402a58e9c0c16","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    - name: Check that the report.html exists"},{"line_number":20,"context_line":"      stat:"},{"line_number":21,"context_line":"        path: \"{{ ansible_user_dir }}/workspace/logs/report.html\""},{"line_number":22,"context_line":"      register: stat_report_result"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    - name: Return report.html artifact to Zuul"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"037a9a14_085687c3","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":65},"updated":"2021-02-02 08:53:16.000000000","message":"it\u0027s already used here, no point to create it later\nneed to ensure it exists before this task","commit_id":"57dadefcdb671607783dc0e1c8afd9fb9f230b2a"}]}