)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8e59f0969b215c1c60387fdbb7d2bd4a9dcf9329","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Container build status is not getting validated which"},{"line_number":10,"context_line":"leads to failure of container push and pull."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tripleo-common/+/774424"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1914061"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"31cf8e88_045304bd","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":7},"updated":"2021-02-18 08:12:22.000000000","message":"but that is DNM so if that isn\u0027t for merging we need to remove it from here before this patch can merge","commit_id":"67b457bb3383c15ee7d30d2ef632cc2ad84a15a5"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"e50655d5f8ba51117544aee0df6ccaf3cfe3d302","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Container build status is not getting validated which"},{"line_number":10,"context_line":"leads to failure of container push and pull."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tripleo-common/+/774424"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1914061"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"a86fcbc0_bfae77d2","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":7},"in_reply_to":"31cf8e88_045304bd","updated":"2021-02-18 09:27:39.000000000","message":"Yeah.. we are removing it.. I added it for testing purpose.","commit_id":"67b457bb3383c15ee7d30d2ef632cc2ad84a15a5"}],"roles/build-containers/tasks/main.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"847f8ed6e0c4b0bf14ea8e07b3ab89d0f7ab768f","unresolved":true,"context_lines":[{"line_number":233,"context_line":"- name: \"Run image build as root \u003e {{ workspace }}/logs/build.log\""},{"line_number":234,"context_line":"  args:"},{"line_number":235,"context_line":"    chdir: \u0027{{ workspace }}\u0027"},{"line_number":236,"context_line":"  shell: set -o pipefail \u0026\u0026 bash build_containers.sh 2\u003e\u00261 {{ timestamper_cmd }} \u003e {{ workspace }}/logs/build.log"},{"line_number":237,"context_line":"  when:"},{"line_number":238,"context_line":"    - ansible_distribution|lower \u003d\u003d \"redhat\""},{"line_number":239,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0811d622_47422036","line":236,"range":{"start_line":236,"start_character":33,"end_line":236,"end_character":49},"updated":"2021-02-11 07:55:17.000000000","message":"@Sagi, right, that\u0027s here it should fail instead","commit_id":"57e03a868bcd8ec44099eb3999372721f2bdc876"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"509fad91f8eca5de679090dbe57ba9ae3830653c","unresolved":true,"context_lines":[{"line_number":227,"context_line":"  args:"},{"line_number":228,"context_line":"    chdir: \u0027{{ workspace }}\u0027"},{"line_number":229,"context_line":"  shell: set -o pipefail \u0026\u0026 bash build_containers.sh 2\u003e\u00261 {{ timestamper_cmd }} \u003e {{ workspace }}/logs/build.log"},{"line_number":230,"context_line":"  register: exec_status"},{"line_number":231,"context_line":"  when:"},{"line_number":232,"context_line":"    - ansible_distribution|lower !\u003d \"redhat\""},{"line_number":233,"context_line":"  failed_when: exec_status.rc \u003d\u003d 1"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"88c3113d_6f6cc6c7","line":230,"range":{"start_line":230,"start_character":12,"end_line":230,"end_character":23},"updated":"2021-02-18 08:10:18.000000000","message":"please let\u0027s use descriptive names... e.g. \u0027build_status\u0027 or \u0027container_build_status\u0027","commit_id":"67b457bb3383c15ee7d30d2ef632cc2ad84a15a5"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"41088c784c52ed8a2eb1d877b584a65f22795996","unresolved":true,"context_lines":[{"line_number":230,"context_line":"  register: container_build_status"},{"line_number":231,"context_line":"  when:"},{"line_number":232,"context_line":"    - ansible_distribution|lower !\u003d \"redhat\""},{"line_number":233,"context_line":"  failed_when: container_build_status.rc \u003d\u003d 1"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"- name: \"Run image build as root \u003e {{ workspace }}/logs/build.log\""},{"line_number":236,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"b29b45b3_5d976466","line":233,"range":{"start_line":233,"start_character":14,"end_line":233,"end_character":45},"updated":"2021-02-18 11:25:27.000000000","message":"It\u0027s the default behavior to fail when rc is not 0. Why do we need to add it here? Seems pointless.","commit_id":"790a7e52ce58e80f9beb1770ee66093caca1046c"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"41088c784c52ed8a2eb1d877b584a65f22795996","unresolved":true,"context_lines":[{"line_number":240,"context_line":"  when:"},{"line_number":241,"context_line":"    - ansible_distribution|lower \u003d\u003d \"redhat\""},{"line_number":242,"context_line":"  become: true"},{"line_number":243,"context_line":"  failed_when: container_build_status.rc \u003d\u003d 1"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"- name: Retrieve built images"},{"line_number":246,"context_line":"  shell: \"{{ container_cli }} images | grep {{ container_name_prefix }} | awk \u0027{ print $1 }\u0027\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1a2c3b46_27e2b463","line":243,"range":{"start_line":243,"start_character":15,"end_line":243,"end_character":45},"updated":"2021-02-18 11:25:27.000000000","message":"ditto","commit_id":"790a7e52ce58e80f9beb1770ee66093caca1046c"}],"roles/build-containers/templates/kolla-build.sh.j2":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"41088c784c52ed8a2eb1d877b584a65f22795996","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    {% if build_timeout is defined %}"},{"line_number":25,"context_line":"        --build-timeout {{ build_timeout }} \\"},{"line_number":26,"context_line":"    {% endif %}"},{"line_number":27,"context_line":"    --kolla-config-file {{ workspace }}/kolla-build.conf"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RETCODE\u003d$?"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"40343cc7_2a5e8bc5","line":27,"updated":"2021-02-18 11:25:27.000000000","message":"This command (openstack overcloud container image build ...) should fail with status code !\u003d0 when it fails, and script should actually exit in this point (because there is bash -eux above). Then everything after it won\u0027t be executed.\nDoes this command exit with status !\u003d0 when fails or not?","commit_id":"790a7e52ce58e80f9beb1770ee66093caca1046c"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"68632f8fe4b5fc5917e6ddf41fee807c77c39b5f","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    {% endif %}"},{"line_number":27,"context_line":"    --kolla-config-file {{ workspace }}/kolla-build.conf"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RETCODE\u003d$?"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"### grep errors in all build logs"},{"line_number":32,"context_line":"sudo egrep \"^Error:|No match\" /tmp/kolla-*/docker -R \u003e containers-build-errors.log 2\u003e\u00261 || true"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"36f4bc62_d9abb2c9","line":29,"updated":"2021-02-18 09:55:32.000000000","message":"May be we can add in the commit msg stating retcode got removed in this patch https://review.opendev.org/c/openstack/tripleo-ci/+/755124/77/roles/build-containers/templates/build.sh.j2#116","commit_id":"790a7e52ce58e80f9beb1770ee66093caca1046c"}],"roles/build-containers/templates/tripleo-build.sh.j2":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"41088c784c52ed8a2eb1d877b584a65f22795996","unresolved":true,"context_lines":[{"line_number":78,"context_line":"{%   if build_timeout is defined %}"},{"line_number":79,"context_line":"     --build-timeout {{ build_timeout }} \\"},{"line_number":80,"context_line":"{%   endif %}"},{"line_number":81,"context_line":"     --debug"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"RETCODE\u003d$?"},{"line_number":84,"context_line":"if [ $RETCODE -eq 0 ]; then"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"849d6fdf_d4f95271","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":12},"updated":"2021-02-18 11:25:27.000000000","message":"same question as in previous file","commit_id":"790a7e52ce58e80f9beb1770ee66093caca1046c"}]}